117051 2013-05-30 15:34:28 -0700 It's easy to hit ASSERT_NOT_REACHED in WKDOMNodeClass 2013-05-30 19:05:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue sam simon.fraser oldest_to_newest 895697 0 thorton 2013-05-30 15:34:28 -0700 It doesn't make any sense; it's easy for clients to hit this assertion. For example: WebKit::WKDOMNodeClass(WebCore::Node*) + 218 (WKDOMInternals.mm:89) WebKit::initWithImpl(WebCore::Node*) + 21 (WKDOMInternals.mm:93) WKDOMNode* WebKit::toWKDOMType<WebCore::Node*, WKDOMNode*>(WebCore::Node*, WebKit::DOMCache<WebCore::Node*, WKDOMNode*>&) + 139 (WKDOMInternals.mm:162) WebKit::toWKDOMNode(WebCore::Node*) + 37 (WKDOMInternals.mm:103) -[WKDOMNode firstChild] + 54 (WKDOMNode.mm:91) Can easily get called with a comment node. 895702 1 203388 thorton 2013-05-30 15:37:49 -0700 Created attachment 203388 patch 895741 2 thorton 2013-05-30 17:08:49 -0700 http://trac.webkit.org/changeset/150989, but Sam thinks that we should return [WKDOMNode class]; instead, and that does seem reasonable. 895744 3 thorton 2013-05-30 17:18:03 -0700 <rdar://problem/14009163> 895745 4 203401 thorton 2013-05-30 17:18:53 -0700 Created attachment 203401 patch2 895762 5 203401 commit-queue 2013-05-30 19:05:42 -0700 Comment on attachment 203401 patch2 Clearing flags on attachment: 203401 Committed r151001: <http://trac.webkit.org/changeset/151001> 895763 6 commit-queue 2013-05-30 19:05:45 -0700 All reviewed patches have been landed. Closing bug. 203388 2013-05-30 15:37:49 -0700 2013-05-30 17:18:53 -0700 patch assert.diff text/plain 1190 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkOGViNGEyLi5jNmMwOWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDUtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIEFTU0VSVF9OT1RfUkVBQ0hFRCBmcm9tIFdLRE9NTm9kZUNsYXNzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcwNTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIGVhc3kg dG8gZmFpbCB0aGlzIGFzc2VydGlvbiBpbiBzZWVtaW5nbHktbGVnaXRpbWF0ZSBjYXNlcy4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS0RPTUludGVybmFs cy5tbToKKyAgICAgICAgKFdlYktpdDo6V0tET01Ob2RlQ2xhc3MpOgorCiAyMDEzLTA1LTI5ICBK ZWZmcmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gRW5hYmxlIGNh Y2hlIHBhcnRpdGlvbmluZyBhbmQgdGhlIHB1YmxpYyBzdWZmaXggbGlzdCBvbiAxMC44CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMv V0tET01JbnRlcm5hbHMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS9tYWMvV0tET01JbnRlcm5hbHMubW0KaW5kZXggNzAzNjlhZi4uYzFlNTQxYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFj L1dLRE9NSW50ZXJuYWxzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL21hYy9XS0RPTUludGVybmFscy5tbQpAQCAtODQsNyArODQsNiBAQCBzdGF0 aWMgQ2xhc3MgV0tET01Ob2RlQ2xhc3MoV2ViQ29yZTo6Tm9kZSogaW1wbCkKICAgICBjYXNlIFdl YkNvcmU6Ok5vZGU6OlhQQVRIX05BTUVTUEFDRV9OT0RFOgogICAgICAgICBicmVhazsKICAgICB9 Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgcmV0dXJuIG5pbDsKIH0KIAo= 203401 2013-05-30 17:18:53 -0700 2013-05-30 19:05:42 -0700 patch2 assert.diff text/plain 1401 thorton SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDk5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA1LTMwICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIEl0J3MgZWFzeSB0byBo aXQgQVNTRVJUX05PVF9SRUFDSEVEIGluIFdLRE9NTm9kZUNsYXNzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcwNTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZS1hZGQgdGhlIEFTU0VSVF9OT1RfUkVB Q0hFRCwgYW5kIHJldHVybiBbV0tET01Ob2RlIGNsYXNzXSBpbiB0aGUgY2FzZQorICAgICAgICB3 aGVyZSB3ZSBkb24ndCBoYXZlIGEgc3BlY2lmaWMgc3ViY2xhc3MuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tET01JbnRlcm5hbHMubW06CisgICAgICAg IChXZWJLaXQ6OldLRE9NTm9kZUNsYXNzKToKKworMjAxMy0wNS0zMCAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgQVNTRVJUX05PVF9SRUFD SEVEIGZyb20gV0tET01Ob2RlQ2xhc3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNzA1MQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tET01JbnRlcm5hbHMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLRE9NSW50 ZXJuYWxzLm1tCShyZXZpc2lvbiAxNTA5OTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tET01JbnRlcm5hbHMubW0JKHdvcmtpbmcgY29weSkK QEAgLTgyLDggKzgyLDkgQEAKICAgICBjYXNlIFdlYkNvcmU6Ok5vZGU6OkRPQ1VNRU5UX0ZSQUdN RU5UX05PREU6CiAgICAgY2FzZSBXZWJDb3JlOjpOb2RlOjpOT1RBVElPTl9OT0RFOgogICAgIGNh c2UgV2ViQ29yZTo6Tm9kZTo6WFBBVEhfTkFNRVNQQUNFX05PREU6Ci0gICAgICAgIGJyZWFrOwor ICAgICAgICByZXR1cm4gW1dLRE9NTm9kZSBjbGFzc107CiAgICAgfQorICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOwogICAgIHJldHVybiBuaWw7CiB9CiAK