117042 2013-05-30 12:59:55 -0700 REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility 2025-01-16 22:24:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 286124 1 andersca andersca commit-queue japhet oldest_to_newest 895652 0 andersca 2013-05-30 12:59:55 -0700 REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility 895655 1 203377 andersca 2013-05-30 13:03:26 -0700 Created attachment 203377 Patch 895659 2 203377 mrowe 2013-05-30 13:34:13 -0700 Comment on attachment 203377 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203377&action=review > Source/WebCore/loader/cache/CachedScript.cpp:116 > + // The installer in question tries to load .js file that doesn't exist,/ causing the server to There's a stray slash in this comment. > Source/WebCore/platform/RuntimeApplicationChecks.cpp:114 > + static bool isSolidStateNetworksDownloader = mainBundleIsEqualTo("com.solidstatenetworks.awkhost"); > + return isSolidStateNetworksDownloader; I'm not too keen on application specific hacks that never expire. With this hack in place they'd never notice the problem themselves and would have a hard time testing any fix on their end. 895663 3 203377 mrowe 2013-05-30 13:39:34 -0700 Comment on attachment 203377 Patch r=me anyway since I don't have any good ideas on how we could target the app specific hack more narrowly either. 895666 4 andersca 2013-05-30 13:49:48 -0700 Committed r150977: <http://trac.webkit.org/changeset/150977> 203377 2013-05-30 13:03:26 -0700 2013-05-30 13:39:34 -0700 Patch bug-117042-20130530130203.patch text/plain 4614 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwOTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWExOTY5MTZmMDUxZTE0 YWI3ODk0M2M0NGYwOTllY2NiZDdkZmFmNi4uYTkxZTYzNDEwYTZjZjQzZjgyMThmMzI4M2IzNTBl M2Y0YTQxNzEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA1LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjExOTc1OSk6IEFkb2JlIEZsYXNoIFBsYXllciAic21hbGxlciIgaW5zdGFsbGVyIHJlbGllcyBv biB0aGUgaW5jb3JyZWN0IGZpcmluZyBvZiBhIGxvYWQgZXZlbnQgYW5kIG5lZWRzIGFuIGFwcC1z cGVjaWZpYyBoYWNrIGZvciBjb21wYXRpYmlsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcwNDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEz OTE2MjkxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElnbm9yZSBIVFRQIGVycm9ycyBmb3Igc2NyaXB0cyByZXF1ZXN0ZWQgZnJvbSB3aXRoaW4gdGhl IGluc3RhbGxlci4gSW5zdGVhZCBvZiBqdXN0IGNoZWNraW5nIGZvciB0aGUKKyAgICAgICAgQWRv YmUgRmxhc2ggaW5zdGFsbGVyLCB3ZSB1c2UgdGhlICJjb20uc29saWRzdGF0ZW5ldHdvcmtzLmF3 a2hvc3QiIGJ1bmRsZSBpZGVudGlmaWVyIHRvIGRldGVybWluZQorICAgICAgICB3aGV0aGVyIHRv IGFwcGx5IHRoZSB3b3JrYXJvdW5kLiBUaGlzIGNvdWxkIGluIHRoZW9yeSBmaXggb3RoZXIgaW5z dGFsbGVycyB0aGF0IHVzZSB0aGUgc2FtZSBtZWNoYW5pc20uCisKKyAgICAgICAgKiBsb2FkZXIv Y2FjaGUvQ2FjaGVkU2NyaXB0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFNjcmlwdDo6 c2hvdWxkSWdub3JlSFRUUFN0YXR1c0NvZGVFcnJvcnMpOgorICAgICAgICAqIGxvYWRlci9jYWNo ZS9DYWNoZWRTY3JpcHQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25D aGVja3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YXBwbGljYXRpb25Jc1NvbGlkU3RhdGVOZXR3 b3Jrc0Rvd25sb2FkZXIpOgorICAgICAgICAqIHBsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrcy5oOgorCiAyMDEzLTA1LTI5ICBKZWZmcmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5jb20+CiAK ICAgICAgICAgW01hY10gRW5hYmxlIGNhY2hlIHBhcnRpdGlvbmluZyBhbmQgdGhlIHB1YmxpYyBz dWZmaXggbGlzdCBvbiAxMC44CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2Fj aGUvQ2FjaGVkU2NyaXB0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRT Y3JpcHQuY3BwCmluZGV4IGVhMjBjNmQ2OTBmZGM4YmVkMGI2MTJhMGNhMGZkODQwMmIzNWU3YWYu LmI4ZGRlZDQwMDUzNzYwZDdiNjk1YTVlMTExZjUxM2IwOWViNTk4MDkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTY3JpcHQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTY3JpcHQuY3BwCkBAIC0zMyw2ICszMyw3IEBACiAj aW5jbHVkZSAiTUlNRVR5cGVSZWdpc3RyeS5oIgogI2luY2x1ZGUgIk1lbW9yeUNhY2hlLmgiCiAj aW5jbHVkZSAiUmVzb3VyY2VCdWZmZXIuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25D aGVja3MuaCIKICNpbmNsdWRlICJUZXh0UmVzb3VyY2VEZWNvZGVyLmgiCiAjaW5jbHVkZSA8d3Rm L1ZlY3Rvci5oPgogCkBAIC0xMDcsNCArMTA4LDE4IEBAIGJvb2wgQ2FjaGVkU2NyaXB0OjptaW1l VHlwZUFsbG93ZWRCeU5vc25pZmYoKSBjb25zdAogfQogI2VuZGlmCiAKK2Jvb2wgQ2FjaGVkU2Ny aXB0OjpzaG91bGRJZ25vcmVIVFRQU3RhdHVzQ29kZUVycm9ycygpIGNvbnN0Cit7CisgICAgLy8g VGhpcyBpcyBhIHdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS8xMzkxNjI5MT4KKyAgICAv LyBSRUdSRVNTSU9OIChyMTE5NzU5KTogQWRvYmUgRmxhc2ggUGxheWVyICJzbWFsbGVyIiBpbnN0 YWxsZXIgcmVsaWVzIG9uIHRoZSBpbmNvcnJlY3QgZmlyaW5nCisgICAgLy8gb2YgYSBsb2FkIGV2 ZW50IGFuZCBuZWVkcyBhbiBhcHAtc3BlY2lmaWMgaGFjayBmb3IgY29tcGF0aWJpbGl0eS4KKyAg ICAvLyBUaGUgaW5zdGFsbGVyIGluIHF1ZXN0aW9uIHRyaWVzIHRvIGxvYWQgLmpzIGZpbGUgdGhh dCBkb2Vzbid0IGV4aXN0LC8gY2F1c2luZyB0aGUgc2VydmVyIHRvCisgICAgLy8gcmV0dXJuIGEg NDA0IHJlc3BvbnNlLiBOb3JtYWxseSwgdGhpcyB3b3VsZCB0cmlnZ2VyIGFuIGVycm9yIGV2ZW50 IHRvIGJlIGRpc3BhdGNoZWQsIGJ1dCB0aGUKKyAgICAvLyBpbnN0YWxsZXIgZXhwZWN0cyBhIGxv YWQgZXZlbnQgaW5zdGVhZCBzbyB3ZSB3b3JrIGFyb3VuZCBpdCBoZXJlLgorICAgIGlmIChhcHBs aWNhdGlvbklzU29saWRTdGF0ZU5ldHdvcmtzRG93bmxvYWRlcigpKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKworICAgIHJldHVybiBDYWNoZWRSZXNvdXJjZTo6c2hvdWxkSWdub3JlSFRUUFN0YXR1 c0NvZGVFcnJvcnMoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5oIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5oCmluZGV4IDVhMjM4MTZhMTgxMzJjYmNiZDQ5 NTY5OWZiZDY3MWYwZjUwMGVhZjcuLjVkOGIyN2VmZGM0NDBmZDAyZmZjOWI0NTJiNGU1OTVmMTM0 MDM0MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTY3Jp cHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2NyaXB0LmgKQEAg LTU0LDYgKzU0LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIFB1cmdl UHJpb3JpdHkgcHVyZ2VQcmlvcml0eSgpIGNvbnN0IHsgcmV0dXJuIFB1cmdlTGFzdDsgfQogICAg ICAgICB2aXJ0dWFsIGJvb2wgbWF5VHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgY29uc3QgT1ZFUlJJ REUgeyByZXR1cm4gdHJ1ZTsgfQogCisgICAgICAgIHZpcnR1YWwgYm9vbCBzaG91bGRJZ25vcmVI VFRQU3RhdHVzQ29kZUVycm9ycygpIGNvbnN0IE9WRVJSSURFOworCiAgICAgICAgIFN0cmluZyBt X3NjcmlwdDsKICAgICAgICAgUmVmUHRyPFRleHRSZXNvdXJjZURlY29kZXI+IG1fZGVjb2RlcjsK ICAgICB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxp Y2F0aW9uQ2hlY2tzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNh dGlvbkNoZWNrcy5jcHAKaW5kZXggOTBjODFkZjUzMWY0MDZjYjI5NmRiZTk1ZTZlM2I2ZjcyNGVi Yjg4NS4uMTc4OTQ5ZjQ1MjJiYWFjNzZlOWFjZjdlOTI3ZWExMTM0OGQyMmY1ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuY3Bw CkBAIC0xMDgsNCArMTA4LDEwIEBAIGJvb2wgYXBwbGljYXRpb25Jc1ZlcnNpb25zKCkKICAgICBy ZXR1cm4gaXNWZXJzaW9uczsKIH0KIAorYm9vbCBhcHBsaWNhdGlvbklzU29saWRTdGF0ZU5ldHdv cmtzRG93bmxvYWRlcigpCit7CisgICAgc3RhdGljIGJvb2wgaXNTb2xpZFN0YXRlTmV0d29ya3NE b3dubG9hZGVyID0gbWFpbkJ1bmRsZUlzRXF1YWxUbygiY29tLnNvbGlkc3RhdGVuZXR3b3Jrcy5h d2tob3N0Iik7CisgICAgcmV0dXJuIGlzU29saWRTdGF0ZU5ldHdvcmtzRG93bmxvYWRlcjsKK30K KwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAppbmRleCAwMzJhNTQ2NTI3NmViYjQ3ODkxMWJj MjVkYjdmZmNlOTM1Yzg0ODE3Li4yZmY0OWE3NjZiM2E1Yzk2ODE2MTNmNDIwOWY0ODRjMTUxOGRj MDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRp b25DaGVja3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRp b25DaGVja3MuaApAQCAtMzYsNiArMzYsNyBAQCBib29sIGFwcGxpY2F0aW9uSXNNaWNyb3NvZnRN ZXNzZW5nZXIoKTsKIGJvb2wgYXBwbGljYXRpb25Jc01pY3Jvc29mdE15RGF5KCk7CiBib29sIGFw cGxpY2F0aW9uSXNNaWNyb3NvZnRPdXRsb29rKCk7CiBib29sIGFwcGxpY2F0aW9uSXNTYWZhcmko KTsKK2Jvb2wgYXBwbGljYXRpb25Jc1NvbGlkU3RhdGVOZXR3b3Jrc0Rvd25sb2FkZXIoKTsKIGJv b2wgYXBwbGljYXRpb25Jc1ZlcnNpb25zKCk7CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK