117037 2013-05-30 11:45:17 -0700 fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2 2013-05-30 14:31:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned ap jer.noble oldest_to_newest 895608 0 thorton 2013-05-30 11:45:17 -0700 http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r150969%20(9349)/results.html I can reproduce locally as well. 895611 1 thorton 2013-05-30 11:53:12 -0700 Huh, I put logging in where we call notifydone (the third one), and it is getting called: CONSOLE MESSAGE: line 8: starting CONSOLE MESSAGE: line 49: closing CONSOLE MESSAGE: line 57: closed FAIL: Timed out waiting for notifyDone to be called 895657 2 thorton 2013-05-30 13:14:21 -0700 setTopLoadingFrame 0x7fbefaf3d9b0 setTopLoadingFrame 0x0 setTopLoadingFrame 0x7fbefad09040 TestRunner::notifyDone isTestRunning: 1, waitToDump: 1, topLoadingFrame: 0x7fbefad09040 (and then notifyDone bails because topLoadingFrame isn't 0) So I think this is failing because we're closing the subwindow before it's finished loading, leaving WKTR thinking that it still has a pending load. 895658 3 thorton 2013-05-30 13:22:08 -0700 (In reply to comment #2) > setTopLoadingFrame 0x7fbefaf3d9b0 > setTopLoadingFrame 0x0 > setTopLoadingFrame 0x7fbefad09040 > TestRunner::notifyDone isTestRunning: 1, waitToDump: 1, topLoadingFrame: 0x7fbefad09040 > > (and then notifyDone bails because topLoadingFrame isn't 0) > > So I think this is failing because we're closing the subwindow before it's finished loading, leaving WKTR thinking that it still has a pending load. The good case looks like this: setTopLoadingFrame 0x7fa8a3e2a8d0 setTopLoadingFrame 0x0 TestRunner::notifyDone isTestRunning: 1, waitToDump: 1, topLoadingFrame: 0x0 InjectedBundlePage::dump setTopLoadingFrame 0x0 So the subwindow never starts loading before we dump. 895669 4 thorton 2013-05-30 14:10:41 -0700 I'm going to add a 0-delay timeout to the test because I'm not sure how to fix the WKTR problem, and file another bug about the general issue. 895670 5 203381 thorton 2013-05-30 14:12:36 -0700 Created attachment 203381 patch 895672 6 thorton 2013-05-30 14:13:48 -0700 I filed https://bugs.webkit.org/show_bug.cgi?id=117044 about the more general fix. 895674 7 thorton 2013-05-30 14:31:34 -0700 http://trac.webkit.org/changeset/150987 203381 2013-05-30 14:12:36 -0700 2013-05-30 14:24:05 -0700 patch test.diff text/plain 1879 thorton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiMGU0MjU4Li44NTgzZmQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDUt MzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgZmFz dC9kb20vbG9jYXRpb24tbmV3LXdpbmRvdy1uby1jcmFzaC5odG1sIHRpbWVzIG91dCBmbGFraWx5 IG9uIG1hYy13azIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNzAzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENsb3NlIHRoZSB3aW5kb3cgb24gYSB6ZXJvLWRlbGF5IHRpbWVyLCB3b3JraW5nIGFyb3Vu ZCBhIGJ1ZyB3aGVyZSBXS1RSCisgICAgICAgIHdpbGwgaGFuZyBpZiBhIHdpbmRvdyBpcyBjbG9z ZWQgd2hpbGUgYSBsb2FkIGlzIGluIHByb2dyZXNzLgorCisgICAgICAgIERvZXNuJ3QgYWZmZWN0 IHRoZSB0ZXN0IGluIGFuIGltcG9ydGFudCB3YXkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9zY3Jp cHQtdGVzdHMvbG9jYXRpb24tbmV3LXdpbmRvdy1uby1jcmFzaC5qczoKKwogMjAxMy0wNS0zMCAg Wm9sdGFuIEFydmFpICA8emFydmFpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdIFVu cmV2aWV3ZWQgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2Ny aXB0LXRlc3RzL2xvY2F0aW9uLW5ldy13aW5kb3ctbm8tY3Jhc2guanMgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9zY3JpcHQtdGVzdHMvbG9jYXRpb24tbmV3LXdpbmRvdy1uby1jcmFzaC5qcwppbmRl eCBhMjFjMTc5Li5kMjZlZjk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3Jp cHQtdGVzdHMvbG9jYXRpb24tbmV3LXdpbmRvdy1uby1jcmFzaC5qcworKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMvbG9jYXRpb24tbmV3LXdpbmRvdy1uby1jcmFzaC5qcwpA QCAtNDQsMTYgKzQ0LDE4IEBAIHNob3VsZEJlKCJ0ZXN0V2luZG93LmxvY2F0aW9uLnBhdGhuYW1l IiwgIidibGFuayciKTsgLy8gRmlyZWZveCByZXR1cm5zIHRoZSBlbXB0CiBzaG91bGRCZSgidGVz dFdpbmRvdy5sb2NhdGlvbi5zZWFyY2giLCAiJyciKTsKIHNob3VsZEJlKCJ0ZXN0V2luZG93Lmxv Y2F0aW9uLmhhc2giLCAiJyciKTsKIAotdGVzdFdpbmRvdy5jbG9zZSgpOwotCi1pZiAod2luZG93 LnRlc3RSdW5uZXIpIHsKLSAgICBmdW5jdGlvbiBkb25lSGFuZGxlcigpCi0gICAgewotICAgICAg ICBpZiAodGVzdFdpbmRvdy5jbG9zZWQpIHsKLSAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5 RG9uZSgpOwotICAgICAgICAgICAgcmV0dXJuOworc2V0VGltZW91dChmdW5jdGlvbiAoKSB7Cisg ICAgdGVzdFdpbmRvdy5jbG9zZSgpOworCisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7Cisg ICAgICAgIGZ1bmN0aW9uIGRvbmVIYW5kbGVyKCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYg KHRlc3RXaW5kb3cuY2xvc2VkKSB7CisgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlE b25lKCk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorICAgICAgICAg ICAgc2V0VGltZW91dChkb25lSGFuZGxlciwgMCk7CiAgICAgICAgIH0KLSAgICAgICAgc2V0VGlt ZW91dChkb25lSGFuZGxlciwgMCk7CisgICAgICAgIGRvbmVIYW5kbGVyKCk7CiAgICAgfQotICAg IGRvbmVIYW5kbGVyKCk7Ci19Cit9LCAwKTsKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==