117031 2013-05-30 08:13:27 -0700 Fix double hash lookup in DocumentEventQueue::cancelEvent(). 2013-05-30 10:16:09 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue darin esprehn+autocc kling oldest_to_newest 895545 0 kling 2013-05-30 08:13:27 -0700 Fix double hash lookup in DocumentEventQueue::cancelEvent(). 895546 1 203358 kling 2013-05-30 08:15:00 -0700 Created attachment 203358 Patch 895550 2 203358 andersca 2013-05-30 08:39:38 -0700 Comment on attachment 203358 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203358&action=review > Source/WebCore/dom/DocumentEventQueue.cpp:103 > + m_queuedEvents.remove(it); You only want to remove it if it's found. 895551 3 kling 2013-05-30 08:40:46 -0700 (In reply to comment #2) > (From update of attachment 203358 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203358&action=review > > > Source/WebCore/dom/DocumentEventQueue.cpp:103 > > + m_queuedEvents.remove(it); > > You only want to remove it if it's found. THE SHAME :( 895580 4 kling 2013-05-30 10:09:08 -0700 Committed r150969: <http://trac.webkit.org/changeset/150969> 895583 5 darin 2013-05-30 10:16:09 -0700 I think we should add a bool return value to remove so we don’t have to use iterators in all the cases like this. 203358 2013-05-30 08:15:00 -0700 2013-05-30 08:39:37 -0700 Patch bug-117031.diff text/plain 1348 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNDhiY2FjLi40ZDFlMTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMDUtMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIEZpeCBkb3VibGUgaGFzaCBsb29rdXAgaW4gRG9jdW1lbnRFdmVudFF1ZXVlOjpjYW5jZWxF dmVudCgpLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMTcwMzE+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnRFdmVu dFF1ZXVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50RXZlbnRRdWV1ZTo6Y2FuY2Vs RXZlbnQpOgorCisyMDEzLTA1LTMwICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K KwogICAgICAgICBGaXggZG91YmxlIGhhc2ggbG9va3VwIGluIERvY3VtZW50TG9hZGVyOjpyZW1v dmVTdWJyZXNvdXJjZUxvYWRlcigpLgogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMTcw MzA+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudEV2ZW50UXVldWUu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RXZlbnRRdWV1ZS5jcHAKaW5kZXggNWY0 MGUzMy4uZmU3MmYxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RXZl bnRRdWV1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RXZlbnRRdWV1ZS5j cHAKQEAgLTk4LDggKzk4LDkgQEAgdm9pZCBEb2N1bWVudEV2ZW50UXVldWU6OmVucXVldWVPckRp c3BhdGNoU2Nyb2xsRXZlbnQoUGFzc1JlZlB0cjxOb2RlPiB0YXJnZXQsIFMKIAogYm9vbCBEb2N1 bWVudEV2ZW50UXVldWU6OmNhbmNlbEV2ZW50KEV2ZW50KiBldmVudCkKIHsKLSAgICBib29sIGZv dW5kID0gbV9xdWV1ZWRFdmVudHMuY29udGFpbnMoZXZlbnQpOwotICAgIG1fcXVldWVkRXZlbnRz LnJlbW92ZShldmVudCk7CisgICAgTGlzdEhhc2hTZXQ8UmVmUHRyPEV2ZW50PiwgMTY+OjppdGVy YXRvciBpdCA9IG1fcXVldWVkRXZlbnRzLmZpbmQoZXZlbnQpOworICAgIGJvb2wgZm91bmQgPSBp dCAhPSBtX3F1ZXVlZEV2ZW50cy5lbmQoKTsKKyAgICBtX3F1ZXVlZEV2ZW50cy5yZW1vdmUoaXQp OwogICAgIGlmIChtX3F1ZXVlZEV2ZW50cy5pc0VtcHR5KCkpCiAgICAgICAgIG1fcGVuZGluZ0V2 ZW50VGltZXItPnN0b3AoKTsKICAgICByZXR1cm4gZm91bmQ7Cg==