117021 2013-05-30 01:21:50 -0700 [GTK] Fix pass_by_value coverity warning in ChromeClientGtk 2013-05-30 13:39:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 0 eocanha webkit-unassigned cgarcia commit-queue csaavedra pnormand rego xan.lopez oldest_to_newest 895409 0 eocanha 2013-05-30 01:21:50 -0700 Coverity warned about this issue in ChromeClientGtk: pass_by_value: Passing parameter dirtyRegion of type WebCore::Region (size 448 bytes) by value. This was documented in https://docs.google.com/spreadsheet/ccc?key=0AvP3bJqGv0uXdExmcXU4anowQ3E2M0luWkltZXFuSEE#gid=0 (row 7033), linked from Bug #104114. 895414 1 203322 eocanha 2013-05-30 01:33:24 -0700 Created attachment 203322 Patch 895661 2 203322 commit-queue 2013-05-30 13:39:04 -0700 Comment on attachment 203322 Patch Clearing flags on attachment: 203322 Committed r150976: <http://trac.webkit.org/changeset/150976> 895662 3 commit-queue 2013-05-30 13:39:06 -0700 All reviewed patches have been landed. Closing bug. 203322 2013-05-30 01:33:24 -0700 2013-05-30 13:39:03 -0700 Patch bug-117021-20130530083200.patch text/plain 1524 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNjk1NWEzYzVm OGQxZGE2Yzk5YWZmMzZhZjMyNzc1NmUwN2VmY2NjZS4uMDdmNjYzNThjMDU3YTBkYzQyNzhhZGE2 YWUwYTYzMTliOGE1YzMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEz LTA1LTMwICBFbnJpcXVlIE9jYW5hIEdvbnphbGV6ICA8ZW9jYW5oYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIEZpeCBwYXNzX2J5X3ZhbHVlIGNvdmVyaXR5IHdhcm5pbmcgaW4gQ2hyb21l Q2xpZW50R3RrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTcwMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQYXNzIGRpcnR5UmVnaW9uIHBhcmFtZXRlciBpbiBwYWludFdlYlZpZXcoKSBieSByZWZlcmVu Y2UgdG8gYXZvaWQgb2JqZWN0IGNvcHlpbmcuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpwYWludFdlYlZpZXcpOgorCiAy MDEzLTA1LTI0ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4K IAogICAgICAgICBSZW1vdmUgY3VzdG9tIGNvZGUgZm9yIHdlYmtpdEF1ZGlvQ29udGV4dCBnbG9i YWwgY29uc3RydWN0b3IgZ2V0dGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAppbmRleCA5YjUzOGM0MmM2NTM2ZGQxODM5NWZj M2VmYzMwNzczMTg5ODlkOWQ5Li4yZTQyOTYwNmE1MzQ2MzlmYTliOWFmZDZhNzZhNmIzYjhiNDlm NmUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHAKQEAgLTUxNiw3ICs1MTYsNyBAQCBzdGF0aWMgdm9pZCBjb2FsZXNjZVJl Y3RzSWZQb3NzaWJsZShjb25zdCBJbnRSZWN0JiBjbGlwUmVjdCwgVmVjdG9yPEludFJlY3Q+JiBy ZQogICAgIHJlY3RzLmFwcGVuZChjbGlwUmVjdCk7CiB9CiAKLXN0YXRpYyB2b2lkIHBhaW50V2Vi VmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBGcmFtZSogZnJhbWUsIFJlZ2lvbiBkaXJ0eVJl Z2lvbikKK3N0YXRpYyB2b2lkIHBhaW50V2ViVmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBG cmFtZSogZnJhbWUsIGNvbnN0IFJlZ2lvbiYgZGlydHlSZWdpb24pCiB7CiAgICAgaWYgKCF3ZWJW aWV3LT5wcml2LT5iYWNraW5nU3RvcmUpCiAgICAgICAgIHJldHVybjsK