117014 2013-05-29 20:57:32 -0700 [EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu 2013-05-31 19:59:05 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez commit-queue lucas.de.marchi rakuco oldest_to_newest 895328 0 gyuyoung.kim 2013-05-29 20:57:32 -0700 m_viewImpl is able to be null. So, we need to protect this function against such case. EwkContextMenu::EwkContextMenu() : m_viewImpl(0) , m_contextMenuItems(0) { } EwkContextMenu::EwkContextMenu(Eina_List* items) : m_viewImpl(0) , m_contextMenuItems(0) { 895329 1 203306 gyuyoung.kim 2013-05-29 20:58:35 -0700 Created attachment 203306 Patch 895695 2 203306 mikhail.pozdnyakov 2013-05-30 15:22:01 -0700 Comment on attachment 203306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203306&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:77 > +bool EwkContextMenu::hide() I'd not change the function semantics: returned 'false' would implicitly mean that menu is not hidden which is not the case. 895749 3 203402 gyuyoung.kim 2013-05-30 17:40:58 -0700 Created attachment 203402 Patch 895750 4 gyuyoung.kim 2013-05-30 17:41:30 -0700 (In reply to comment #2) > (From update of attachment 203306 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203306&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:77 > > +bool EwkContextMenu::hide() > > I'd not change the function semantics: returned 'false' would implicitly mean that menu is not hidden which is not the case. Ok, I don't have big opinion about it. Changed. 895882 5 203402 mikhail.pozdnyakov 2013-05-31 07:00:48 -0700 Comment on attachment 203402 Patch LGTM 895892 6 203402 cdumez 2013-05-31 07:59:45 -0700 Comment on attachment 203402 Patch r=me 896047 7 203402 commit-queue 2013-05-31 19:59:02 -0700 Comment on attachment 203402 Patch Clearing flags on attachment: 203402 Committed r151062: <http://trac.webkit.org/changeset/151062> 896048 8 commit-queue 2013-05-31 19:59:05 -0700 All reviewed patches have been landed. Closing bug. 203306 2013-05-29 20:58:35 -0700 2013-05-30 17:40:51 -0700 Patch bug-117014-20130530125711.patch text/plain 2492 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWQ2NTIxZWU1ODkxYzYz NTlhN2NmZWU1ODQxMGFkZTgxNGJlZTE5MS4uZjU2OWZjM2U5ZDJhZjEyNDA2ZTljNzAwMWFjNmI5 MDc1MzUyOTM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTI5ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBBZGQgYSBudWxsIGNoZWNraW5nIGNvbmRpdGlvbiB0byBpbiBoaWRlKCkgb2YgRXdrQ29udGV4 dE1lbnUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NzAxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1f dmlld0ltcGwgaXMgYWJsZSB0byBiZSBudWxsLiBTbywgd2UgbmVlZCB0byBwcm90ZWN0IHRoaXMg ZnVuY3Rpb24gYWdhaW5zdCBzdWNoIGNhc2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfY29udGV4dF9tZW51LmNwcDoKKyAgICAgICAgKEV3a0NvbnRleHRNZW51OjpoaWRlKToK KyAgICAgICAgKGV3a19jb250ZXh0X21lbnVfaGlkZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX2NvbnRleHRfbWVudV9wcml2YXRlLmg6CisgICAgICAgIChFd2tDb250ZXh0TWVu dSk6CisKIDIwMTMtMDUtMjkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWJLaXQgc2hvdWxkIGV4cG9zZSBIU1RTIEFQSXMgdG8gZGV0ZXJtaW5lIHdo ZXRoZXIgYSBob3N0IGlzIGluIHRoZSBIU1RTIGNhY2hlIGFuZCB0byByZXNldCBIU1RTIHBvbGlj aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29u dGV4dF9tZW51LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0X21lbnUuY3BwCmluZGV4IGZhMjRmMDBiMmEzZThiYjg4M2JiNjUxMDUwMGRmNGM5N2Q3ZGQw MjEuLjMyMGY3ZjczMzk3NjcwMjg2ZWI3ZTI0Mjc0OWMwYjNlNTFlZWQ1MTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnUuY3Bw CkBAIC03NCw5ICs3NCwxNCBAQCBFd2tDb250ZXh0TWVudTo6fkV3a0NvbnRleHRNZW51KCkKICAg ICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PEV3a19Db250ZXh0X01lbnVfSXRlbSo+KGRhdGEpOwog fQogCi12b2lkIEV3a0NvbnRleHRNZW51OjpoaWRlKCkKK2Jvb2wgRXdrQ29udGV4dE1lbnU6Omhp ZGUoKQogeworICAgIGlmICghbV92aWV3SW1wbCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAg ICAgbV92aWV3SW1wbC0+aGlkZUNvbnRleHRNZW51KCk7CisKKyAgICByZXR1cm4gdHJ1ZTsKIH0K IAogdm9pZCBFd2tDb250ZXh0TWVudTo6YXBwZW5kSXRlbShFd2tDb250ZXh0TWVudUl0ZW0qIGl0 ZW0pCkBAIC0xMjYsOSArMTMxLDcgQEAgRWluYV9Cb29sIGV3a19jb250ZXh0X21lbnVfaGlkZShF d2tfQ29udGV4dF9NZW51KiBtZW51KQogewogICAgIEVXS19PQkpfR0VUX0lNUExfT1JfUkVUVVJO KEV3a0NvbnRleHRNZW51LCBtZW51LCBpbXBsLCBmYWxzZSk7CiAKLSAgICBpbXBsLT5oaWRlKCk7 Ci0KLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gaW1wbC0+aGlkZSgpOwogfQogCiBjb25z dCBFaW5hX0xpc3QqIGV3a19jb250ZXh0X21lbnVfaXRlbXNfZ2V0KGNvbnN0IEV3a19Db250ZXh0 X01lbnUqIG1lbnUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfY29udGV4dF9tZW51X3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a19jb250ZXh0X21lbnVfcHJpdmF0ZS5oCmluZGV4IDQ5YjVmOTdiNzM5NmMwMmZm ZmE0MGRlYTgwODhiYmI2N2VjZDEzNDMuLjczOTc5OGRjMzU5ZjE5ZjViYjM0NjRhMzgzZTExMmUy YTE4ZWQ2YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a19jb250ZXh0X21lbnVfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a19jb250ZXh0X21lbnVfcHJpdmF0ZS5oCkBAIC01NCw3ICs1NCw3IEBAIHB1Ymxp YzoKIAogICAgIH5Fd2tDb250ZXh0TWVudSgpOwogCi0gICAgdm9pZCBoaWRlKCk7CisgICAgYm9v bCBoaWRlKCk7CiAgICAgdm9pZCBhcHBlbmRJdGVtKEV3a0NvbnRleHRNZW51SXRlbSopOwogICAg IHZvaWQgcmVtb3ZlSXRlbShFd2tDb250ZXh0TWVudUl0ZW0qKTsKIAo= 203402 2013-05-30 17:40:58 -0700 2013-05-31 19:59:02 -0700 Patch bug-117014-20130531093933.patch text/plain 1480 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWQ2NTIxZWU1ODkxYzYz NTlhN2NmZWU1ODQxMGFkZTgxNGJlZTE5MS4uZjU2OWZjM2U5ZDJhZjEyNDA2ZTljNzAwMWFjNmI5 MDc1MzUyOTM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTI5ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBBZGQgYSBudWxsIGNoZWNraW5nIGNvbmRpdGlvbiB0byBpbiBoaWRlKCkgb2YgRXdrQ29udGV4 dE1lbnUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NzAxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1f dmlld0ltcGwgaXMgYWJsZSB0byBiZSBudWxsLiBTbywgd2UgbmVlZCB0byBwcm90ZWN0IHRoaXMg ZnVuY3Rpb24gYWdhaW5zdCBzdWNoIGNhc2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfY29udGV4dF9tZW51LmNwcDoKKyAgICAgICAgKEV3a0NvbnRleHRNZW51OjpoaWRlKToK KyAgICAgICAgKGV3a19jb250ZXh0X21lbnVfaGlkZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX2NvbnRleHRfbWVudV9wcml2YXRlLmg6CisgICAgICAgIChFd2tDb250ZXh0TWVu dSk6CisKIDIwMTMtMDUtMjkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWJLaXQgc2hvdWxkIGV4cG9zZSBIU1RTIEFQSXMgdG8gZGV0ZXJtaW5lIHdo ZXRoZXIgYSBob3N0IGlzIGluIHRoZSBIU1RTIGNhY2hlIGFuZCB0byByZXNldCBIU1RTIHBvbGlj aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29u dGV4dF9tZW51LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0X21lbnUuY3BwCmluZGV4IGZhMjRmMDBiMmEzZThiYjg4M2JiNjUxMDUwMGRmNGM5N2Q3ZGQw MjEuLmRmN2VkNWY4NTgxMmViNzYxMGM2MmYxMDQ5MjBmYjY5YmE5YTg4NjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnUuY3Bw CkBAIC03Niw2ICs3Niw5IEBAIEV3a0NvbnRleHRNZW51Ojp+RXdrQ29udGV4dE1lbnUoKQogCiB2 b2lkIEV3a0NvbnRleHRNZW51OjpoaWRlKCkKIHsKKyAgICBpZiAoIW1fdmlld0ltcGwpCisgICAg ICAgIHJldHVybjsKKwogICAgIG1fdmlld0ltcGwtPmhpZGVDb250ZXh0TWVudSgpOwogfQogCg==