117001 2013-05-29 14:39:26 -0700 WebKit's Enter Full Screen for <video> elements isn't working 2013-05-30 19:31:55 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 ruthiecftg webkit-unassigned commit-queue esprehn+autocc glenn jer.noble jonlee mitz ruthiecftg thorton webkit-bug-importer oldest_to_newest 895222 0 ruthiecftg 2013-05-29 14:39:26 -0700 When hooking into WK's context menu action for entering into full screen for <video> elements, nothing happens (as opposed to hooking into WK's other media context menu actions, such as mute). 895225 1 ruthiecftg 2013-05-29 14:41:58 -0700 <rdar://problem/14006095> 895618 2 203372 ruthiecftg 2013-05-30 12:05:25 -0700 Created attachment 203372 Patch 895639 3 203372 darin 2013-05-30 12:31:56 -0700 Comment on attachment 203372 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203372&action=review > Source/WebCore/ChangeLog:8 > + No new tests. Covered by existing tests for fullscreen. If this is covered by existing tests, why aren’t those tests failing? 895653 4 203372 jer.noble 2013-05-30 12:59:58 -0700 Comment on attachment 203372 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203372&action=review > Source/WebCore/dom/Document.cpp:4980 > + UserGestureIndicator indicator(DefinitelyProcessingNewUserGesture); > + By inserting this UserGestureIndicator, this patch would disable the security requirement that full screen requests must begin with an event handler. The appropriate place to put this line is in your context menu handler, immediately before calling element->webkitRequestFullScreen(), not inside requestFullScreenForElement() itself. 895734 5 203396 ruthiecftg 2013-05-30 16:45:27 -0700 Created attachment 203396 Patch 895738 6 203396 jer.noble 2013-05-30 16:55:11 -0700 Comment on attachment 203396 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203396&action=review > Source/WebCore/ChangeLog:11 > + No new tests. > + > + * rendering/HitTestResult.cpp: > + (WebCore::HitTestResult::enterFullscreenForVideo): Please describe the problem which this patch is trying to solve, and why the approach here fixes the problem. You should also explain why no new tests were added: i.e, there is an existing test, media/context-menu-actions.html, but it is disabled due to bug #116651. 895742 7 203400 ruthiecftg 2013-05-30 17:13:07 -0700 Created attachment 203400 Patch 895767 8 203400 commit-queue 2013-05-30 19:31:52 -0700 Comment on attachment 203400 Patch Clearing flags on attachment: 203400 Committed r151003: <http://trac.webkit.org/changeset/151003> 895768 9 commit-queue 2013-05-30 19:31:55 -0700 All reviewed patches have been landed. Closing bug. 203372 2013-05-30 12:05:25 -0700 2013-05-30 16:45:25 -0700 Patch bug-117001-20130530120402.patch text/plain 1300 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDk3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTMwICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdCdzIEVudGVyIEZ1bGwg U2NyZWVuIGZvciA8dmlkZW8+IGVsZW1lbnRzIGlzbid0IHdvcmtpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzAwMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQ292ZXJlZCBi eSBleGlzdGluZyB0ZXN0cyBmb3IgZnVsbHNjcmVlbi4KKworICAgICAgICAqIGRvbS9Eb2N1bWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6cmVxdWVzdEZ1bGxTY3JlZW5Gb3JF bGVtZW50KToKKwogMjAxMy0wNS0zMCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdh bGlhLmNvbT4KIAogICAgICAgICBBbGxvdyBubyBzcGFjZSBiZXR3ZWVuICJiYWNrZ3JvdW5kLXBv c2l0aW9uOiIgZGltZW5zaW9ucwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lv biAxNTA5NzMpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00OTc2LDYgKzQ5NzYsOCBAQCB2b2lkIERvY3VtZW50OjpyZXF1ZXN0RnVsbFNjcmVl bkZvckVsZW1lCiAgICAgLy8gZm9yIGZ1bGwgc2NyZWVuIG1vZGUsIGFuZCBkbyBub3QgaGF2ZSB0 aGUgY29uY2VwdCBvZiBhIGZ1bGwgc2NyZWVuIGVsZW1lbnQgc3RhY2suCiAgICAgYm9vbCBpbkxl Z2FjeU1vemlsbGFNb2RlID0gKGZsYWdzICYgRWxlbWVudDo6TEVHQUNZX01PWklMTEFfUkVRVUVT VCk7CiAKKyAgICBVc2VyR2VzdHVyZUluZGljYXRvciBpbmRpY2F0b3IoRGVmaW5pdGVseVByb2Nl c3NpbmdOZXdVc2VyR2VzdHVyZSk7CisgICAgCiAgICAgZG8gewogICAgICAgICBpZiAoIWVsZW1l bnQpCiAgICAgICAgICAgICBlbGVtZW50ID0gZG9jdW1lbnRFbGVtZW50KCk7Cg== 203396 2013-05-30 16:45:27 -0700 2013-05-30 17:13:03 -0700 Patch bug-117001-20130530164404.patch text/plain 1645 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDk5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTMwICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdCdzIEVudGVyIEZ1bGwg U2NyZWVuIGZvciA8dmlkZW8+IGVsZW1lbnRzIGlzbid0IHdvcmtpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzAwMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhpdFRl c3RSZXN1bHQ6OmVudGVyRnVsbHNjcmVlbkZvclZpZGVvKToKKwogMjAxMy0wNS0zMCAgUmFmYWVs IEJyYW5kYW8gIDxyYWZhZWwubG9ib0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEZpeCBkb3Vi bGUgaGFzaCBsb29rdXAgaW4gV2ViU29ja2V0Ojpjb25uZWN0IGxvb3AKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHAJKHJldmlzaW9uIDE1MDk5MCkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDEsNiArNDEsNyBAQAogI2luY2x1ZGUgIlJlbmRlckltYWdlLmgiCiAjaW5jbHVkZSAi UmVuZGVySW5saW5lLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyLmgiCisjaW5jbHVkZSAiVXNlckdl c3R1cmVJbmRpY2F0b3IuaCIKIAogI2lmIEVOQUJMRShTVkcpCiAjaW5jbHVkZSAiU1ZHTmFtZXMu aCIKQEAgLTQwNCw4ICs0MDUsMTAgQEAgdm9pZCBIaXRUZXN0UmVzdWx0OjplbnRlckZ1bGxzY3Jl ZW5Gb3JWaQogICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWx0KG1lZGlhRWxlbWVudCgpKTsK ICAgICBpZiAobWVkaWFFbHQgJiYgbWVkaWFFbHQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjp2aWRl b1RhZykpIHsKICAgICAgICAgSFRNTFZpZGVvRWxlbWVudCogdmlkZW9FbHQgPSBzdGF0aWNfY2Fz dDxIVE1MVmlkZW9FbGVtZW50Kj4obWVkaWFFbHQpOwotICAgICAgICBpZiAoIXZpZGVvRWx0LT5p c0Z1bGxzY3JlZW4oKSAmJiBtZWRpYUVsdC0+c3VwcG9ydHNGdWxsc2NyZWVuKCkpCisgICAgICAg IGlmICghdmlkZW9FbHQtPmlzRnVsbHNjcmVlbigpICYmIG1lZGlhRWx0LT5zdXBwb3J0c0Z1bGxz Y3JlZW4oKSkgeworICAgICAgICAgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgaW5kaWNhdG9yKERl ZmluaXRlbHlQcm9jZXNzaW5nTmV3VXNlckdlc3R1cmUpOwogICAgICAgICAgICAgdmlkZW9FbHQt PmVudGVyRnVsbHNjcmVlbigpOworICAgICAgICB9CiAgICAgfQogI2VuZGlmCiB9Cg== 203400 2013-05-30 17:13:07 -0700 2013-05-30 19:31:52 -0700 Patch bug-117001-20130530171143.patch text/plain 2041 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDk5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA1LTMwICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdCdzIEVudGVyIEZ1bGwg U2NyZWVuIGZvciA8dmlkZW8+IGVsZW1lbnRzIGlzbid0IHdvcmtpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzAwMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB3b3JrZmxvdyB0byBhbGxvdyBh IHZpZGVvIHRvIGVudGVyIGludG8gZnVsbCBzY3JlZW4KKyAgICAgICAgbW9kZSBmcm9tIGEga1dL Q29udGV4dE1lbnVJdGVtVGFnRW50ZXJWaWRlb0Z1bGxzY3JlZW4gCisgICAgICAgIGNvbnRleHQg bWVudSBpdGVtIGJ5IGRlbm90aW5nIHRoZSBlbnRlckZ1bGxzY3JlZW5Gb3JWaWRlbworICAgICAg ICBjYWxsIGFzIGEgdXNlciBnZXN0dXJlLCBzbyBEb2N1bWVudDo6cmVxdWVzdEZ1bGxTY3JlZW5G b3JFbGVtZW50CisgICAgICAgIHdpbGwgZXhlY3V0ZSBjb3JyZWN0bHkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IG1lZGlhL2NvbnRleHQtbWVudS1hY3Rpb25zLmh0bWwsCisg ICAgICAgIHdoaWNoIGlzIGRpc2FibGVkIGR1ZSB0byBidWcgIzExNjY1MS4KKworICAgICAgICAq IHJlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhpdFRlc3RS ZXN1bHQ6OmVudGVyRnVsbHNjcmVlbkZvclZpZGVvKToKKwogMjAxMy0wNS0zMCAgUmFmYWVsIEJy YW5kYW8gIDxyYWZhZWwubG9ib0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEZpeCBkb3VibGUg aGFzaCBsb29rdXAgaW4gV2ViU29ja2V0Ojpjb25uZWN0IGxvb3AKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHAJKHJldmlzaW9uIDE1MDk5MCkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDEsNiArNDEsNyBAQAogI2luY2x1ZGUgIlJlbmRlckltYWdlLmgiCiAjaW5jbHVkZSAiUmVu ZGVySW5saW5lLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyLmgiCisjaW5jbHVkZSAiVXNlckdlc3R1 cmVJbmRpY2F0b3IuaCIKIAogI2lmIEVOQUJMRShTVkcpCiAjaW5jbHVkZSAiU1ZHTmFtZXMuaCIK QEAgLTQwNCw4ICs0MDUsMTAgQEAgdm9pZCBIaXRUZXN0UmVzdWx0OjplbnRlckZ1bGxzY3JlZW5G b3JWaQogICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWx0KG1lZGlhRWxlbWVudCgpKTsKICAg ICBpZiAobWVkaWFFbHQgJiYgbWVkaWFFbHQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjp2aWRlb1Rh ZykpIHsKICAgICAgICAgSFRNTFZpZGVvRWxlbWVudCogdmlkZW9FbHQgPSBzdGF0aWNfY2FzdDxI VE1MVmlkZW9FbGVtZW50Kj4obWVkaWFFbHQpOwotICAgICAgICBpZiAoIXZpZGVvRWx0LT5pc0Z1 bGxzY3JlZW4oKSAmJiBtZWRpYUVsdC0+c3VwcG9ydHNGdWxsc2NyZWVuKCkpCisgICAgICAgIGlm ICghdmlkZW9FbHQtPmlzRnVsbHNjcmVlbigpICYmIG1lZGlhRWx0LT5zdXBwb3J0c0Z1bGxzY3Jl ZW4oKSkgeworICAgICAgICAgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgaW5kaWNhdG9yKERlZmlu aXRlbHlQcm9jZXNzaW5nTmV3VXNlckdlc3R1cmUpOwogICAgICAgICAgICAgdmlkZW9FbHQtPmVu dGVyRnVsbHNjcmVlbigpOworICAgICAgICB9CiAgICAgfQogI2VuZGlmCiB9Cg==