116998 2013-05-29 14:20:25 -0700 [Windows] Be consistent with allocation/deallocation behavior 2013-05-29 14:28:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 895210 0 bfulgham 2013-05-29 14:20:25 -0700 Running a Visual Studio 2010 build of DumpRenderTree can crash when using WebPreferences if a non-2010 runtime library is deallocating the memory. This patch adjusts the behavior of the WebPreferences implementation to use the library allocator rather than overriding to use the current CRT allocator so that future cleanup can be done by the same runtime library. 895212 1 203276 bfulgham 2013-05-29 14:22:26 -0700 Created attachment 203276 Patch 895214 2 webkit-bug-importer 2013-05-29 14:23:37 -0700 <rdar://problem/14016391> 895215 3 bfulgham 2013-05-29 14:28:16 -0700 Committed r150930: <http://trac.webkit.org/changeset/150930> 203276 2013-05-29 14:22:26 -0700 2013-05-29 14:26:32 -0700 Patch bug-116998-20130529142120.patch text/plain 1524 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDkyOCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTI5 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dz XSBCZSBjb25zaXN0ZW50IHdpdGggYWxsb2NhdGlvbi9kZWFsbG9jYXRpb24gYmVoYXZpb3IKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjk5OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJlZmVy ZW5jZXMuY3BwOgorICAgICAgICAoV2ViUHJlZmVyZW5jZXM6OnNldFN0cmluZ1ZhbHVlKTogU3dp dGNoIGZyb20gdXNpbmcgX3djc2R1cCBhbmQKKyAgICAgICAgQ0ZTdHJpbmdDcmVhdGVXaXRoQ2hh cmFjdGVyc05vQ29weSB0byBqdXN0IHVzZSB0aGUgc3RhbmRhcmQKKyAgICAgICAgQ0ZTdHJpbmdD cmVhdGVXaXRoQ2hhcmFjdGVycyBjYWxsLgorCiAyMDEzLTA1LTI4ICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBNYW55IGNzczIuMSB0ZXN0 cyBmYWlsIG9uIEFwcGxlJ3MgV2luZG93cyBwb3J0LgpJbmRleDogU291cmNlL1dlYktpdC93aW4v V2ViUHJlZmVyZW5jZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlBy ZWZlcmVuY2VzLmNwcAkocmV2aXNpb24gMTUwOTE5KQorKysgU291cmNlL1dlYktpdC93aW4vV2Vi UHJlZmVyZW5jZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTQsNyArMzU0LDcgQEAgdm9pZCBX ZWJQcmVmZXJlbmNlczo6c2V0U3RyaW5nVmFsdWUoQ0ZTdAogICAgIGlmICh2YWwgJiYgIXdjc2Nt cCh2YWwsIHZhbHVlKSkKICAgICAgICAgcmV0dXJuOwogICAgIAotICAgIFJldGFpblB0cjxDRlN0 cmluZ1JlZj4gdmFsdWVSZWYgPSBhZG9wdENGKENGU3RyaW5nQ3JlYXRlV2l0aENoYXJhY3RlcnNO b0NvcHkoMCwgKFVuaUNoYXIqKV93Y3NkdXAodmFsdWUpLCAoQ0ZJbmRleCl3Y3NsZW4odmFsdWUp LCBrQ0ZBbGxvY2F0b3JNYWxsb2MpKTsKKyAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHZhbHVl UmVmID0gYWRvcHRDRihDRlN0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKDAsIHJlaW50ZXJwcmV0 X2Nhc3Q8Y29uc3QgVW5pQ2hhcio+KHZhbHVlKSwgc3RhdGljX2Nhc3Q8Q0ZJbmRleD4od2NzbGVu KHZhbHVlKSkpKTsKICAgICBzZXRWYWx1ZUZvcktleShrZXksIHZhbHVlUmVmLmdldCgpKTsKIAog ICAgIHBvc3RQcmVmZXJlbmNlc0NoYW5nZXNOb3RpZmljYXRpb24oKTsK