116984 2013-05-29 12:14:32 -0700 Return earlier if there's no session storage namespace 2013-05-29 12:43:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 895124 0 andersca 2013-05-29 12:14:32 -0700 Return earlier if there's no session storage namespace 895125 1 203257 andersca 2013-05-29 12:17:29 -0700 Created attachment 203257 Patch 895128 2 commit-queue 2013-05-29 12:19:29 -0700 Attachment 203257 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp']" exit_code: 1 Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465: Missing spaces around >> [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 895154 3 203257 thorton 2013-05-29 12:40:34 -0700 Comment on attachment 203257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203257&action=review Seems ok. >> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465 >> + ASSERT((HashMap<uint64_t, RefPtr<SessionStorageNamespace>>::isValidKey(storageNamespaceID))); > > Missing spaces around >> [whitespace/operators] [3] We should file a bug about the stylebot. 895159 4 andersca 2013-05-29 12:43:15 -0700 Committed r150925: <http://trac.webkit.org/changeset/150925> 203257 2013-05-29 12:17:29 -0700 2013-05-29 12:40:34 -0700 Patch bug-116984-20130529121607.patch text/plain 2983 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwOTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjUzY2FmZTgzNzQyYjlh ODViNDRmY2E2ZGEwYjYzZTVlZWEzNmE3My4uYTIyYjRkOTA2NDAxN2Q0ZTBlMmU2NmEyNzJiYWQw MDM4ODdkNDJiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTI5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV0dXJuIGVhcmxp ZXIgaWYgdGhlcmUncyBubyBzZXNzaW9uIHN0b3JhZ2UgbmFtZXNwYWNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY5ODQKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEzOTc2NzgxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIHdlIGNhbid0IGZpbmQgYSBzZXNzaW9uIHN0b3JhZ2UgbmFtZXNwYWNl LCByZXR1cm4gYmVmb3JlIGNyZWF0aW5nIGFuIGVudHJ5IGluIHRoZSBtX3N0b3JhZ2VBcmVhc0J5 Q29ubmVjdGlvbgorICAgICAgICBoYXNoIG1hcCBzaW5jZSB0aGVuIHdlJ2xsIGNyYXNoIHRyeWlu ZyB0byByZW1vdmUgaXQgbGF0ZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvU3RvcmFnZS9TdG9y YWdlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlN0b3JhZ2VNYW5hZ2VyOjpjcmVhdGVT ZXNzaW9uU3RvcmFnZU1hcCk6CisKIDIwMTMtMDUtMjkgIE1hcmNlbG8gTGlyYSAgPG1hcmNlbG8u bGlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtXSzJdW0Nvb3JkaW5hdGVkR3JhcGhpY3Nd W0VGTF0gV0tWaWV3VXNlclZpZXdwb3J0VG9Db250ZW50cygpIGZ1bmN0aW9uIGRvZXNuJ3QgZG8g d2hhdCBpdCBzYXlzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFn ZS9TdG9yYWdlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9T dG9yYWdlTWFuYWdlci5jcHAKaW5kZXggMmY3N2MzMDQ5NDAyODg5Mzk3NzZjYzg0ZThhY2JjZTVi MjE0ZThlOC4uNTM1MGRkZTA1ZThlNDNlNjE4ODE2NjFmNDI3YjM3YmQ0NDk2NzQ0NyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNw cApAQCAtNDYxLDYgKzQ2MSwxNSBAQCB2b2lkIFN0b3JhZ2VNYW5hZ2VyOjpjcmVhdGVMb2NhbFN0 b3JhZ2VNYXAoQ29yZUlQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbiwgdWludAogCiB2b2lkIFN0 b3JhZ2VNYW5hZ2VyOjpjcmVhdGVTZXNzaW9uU3RvcmFnZU1hcChDb3JlSVBDOjpDb25uZWN0aW9u KiBjb25uZWN0aW9uLCB1aW50NjRfdCBzdG9yYWdlTWFwSUQsIHVpbnQ2NF90IHN0b3JhZ2VOYW1l c3BhY2VJRCwgY29uc3QgU2VjdXJpdHlPcmlnaW5EYXRhJiBzZWN1cml0eU9yaWdpbkRhdGEpCiB7 CisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGJlIGEgbWVzc2FnZSBjaGVjay4KKyAgICBBU1NF UlQoKEhhc2hNYXA8dWludDY0X3QsIFJlZlB0cjxTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZT4+Ojpp c1ZhbGlkS2V5KHN0b3JhZ2VOYW1lc3BhY2VJRCkpKTsKKyAgICBTZXNzaW9uU3RvcmFnZU5hbWVz cGFjZSogc2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UgPSBtX3Nlc3Npb25TdG9yYWdlTmFtZXNwYWNl cy5nZXQoc3RvcmFnZU5hbWVzcGFjZUlEKTsKKyAgICBpZiAoIXNlc3Npb25TdG9yYWdlTmFtZXNw YWNlKSB7CisgICAgICAgIC8vIFdlJ3JlIGdldHRpbmcgYW4gaW5jb21pbmcgbWVzc2FnZSBmcm9t IHRoZSB3ZWIgcHJvY2VzcyB0aGF0J3MgZm9yIHNlc3Npb24gc3RvcmFnZSBmb3IgYSB3ZWIgcGFn ZQorICAgICAgICAvLyB0aGF0IGhhcyBhbHJlYWR5IGJlZW4gY2xvc2VkLCBqdXN0IGlnbm9yZSBp dC4KKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIHN0ZDo6cGFpcjxSZWZQdHI8Q29yZUlQ Qzo6Q29ubmVjdGlvbj4sIHVpbnQ2NF90PiBjb25uZWN0aW9uQW5kU3RvcmFnZU1hcElEUGFpcihj b25uZWN0aW9uLCBzdG9yYWdlTWFwSUQpOwogCiAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGJl IGEgbWVzc2FnZSBjaGVjay4KQEAgLTQ3MSwxNCArNDgwLDYgQEAgdm9pZCBTdG9yYWdlTWFuYWdl cjo6Y3JlYXRlU2Vzc2lvblN0b3JhZ2VNYXAoQ29yZUlQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlv biwgdWkKICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgYSBtZXNzYWdlIGNoZWNrLgogICAg IEFTU0VSVChyZXN1bHQuaXNOZXdFbnRyeSk7CiAKLSAgICBBU1NFUlQoKEhhc2hNYXA8dWludDY0 X3QsIFJlZlB0cjxTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZT4+Ojppc1ZhbGlkS2V5KHN0b3JhZ2VO YW1lc3BhY2VJRCkpKTsKLSAgICBTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSogc2Vzc2lvblN0b3Jh Z2VOYW1lc3BhY2UgPSBtX3Nlc3Npb25TdG9yYWdlTmFtZXNwYWNlcy5nZXQoc3RvcmFnZU5hbWVz cGFjZUlEKTsKLSAgICBpZiAoIXNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKSB7Ci0gICAgICAgIC8v IFdlJ3JlIGdldHRpbmcgYW4gaW5jb21pbmcgbWVzc2FnZSBmcm9tIHRoZSB3ZWIgcHJvY2VzcyB0 aGF0J3MgZm9yIHNlc3Npb24gc3RvcmFnZSBmb3IgYSB3ZWIgcGFnZQotICAgICAgICAvLyB0aGF0 IGhhcyBhbHJlYWR5IGJlZW4gY2xvc2VkLCBqdXN0IGlnbm9yZSBpdC4KLSAgICAgICAgcmV0dXJu OwotICAgIH0KLQogICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBhIG1lc3NhZ2UgY2hlY2su CiAgICAgQVNTRVJUKGNvbm5lY3Rpb24gPT0gc2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UtPmFsbG93 ZWRDb25uZWN0aW9uKCkpOwogCg==