116979 2013-05-29 11:04:30 -0700 ASSERTION FAILED: !m_adoptionIsRequired in void WebCore::TreeShared<NodeType>::ref() 2013-08-15 12:51:52 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116980 1 rhodovan.u-szeged rwlbuis ap commit-queue darin esprehn+autocc kling koivisto loislo rwlbuis oldest_to_newest 895026 0 203218 rhodovan.u-szeged 2013-05-29 11:04:30 -0700 Created attachment 203218 Test case The attached tests crashes in debug mode. Crashlog & backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff575275d in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:339 339 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff575275d in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:339 #1 0x00007ffff3bfd4d1 in WebCore::TreeShared<WebCore::Node>::ref (this=0x8d0ae0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/TreeShared.h:65 #2 0x00007ffff42cc5c2 in WebCore::Node::refEventTarget (this=0x8d0ad0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Node.cpp:792 #3 0x00007ffff3fc7039 in WebCore::EventTarget::ref (this=0x8d0ad0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/EventTarget.h:106 #4 0x00007ffff3fc7e9f in WTF::refIfNotNull<WebCore::EventTarget> (ptr=0x8d0ad0) at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/PassRefPtr.h:46 #5 0x00007ffff4246327 in WTF::PassRefPtr<WebCore::EventTarget>::PassRefPtr (this=0x7fffffffbde0, ptr=0x8d0ad0) at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/PassRefPtr.h:60 #6 0x00007ffff42994f8 in WebCore::EventDispatcher::dispatchScopedEvent (node=0x8d0ad0, mediator=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/EventDispatcher.cpp:73 #7 0x00007ffff42d0f3c in WebCore::Node::dispatchScopedEventDispatchMediator (this=0x8d0ad0, eventDispatchMediator=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Node.cpp:2274 #8 0x00007ffff42d0eeb in WebCore::Node::dispatchScopedEvent (this=0x8d0ad0, event=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Node.cpp:2269 #9 0x00007ffff42d11e0 in WebCore::Node::dispatchSubtreeModifiedEvent (this=0x8d0ad0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Node.cpp:2298 #10 0x00007ffff428f71d in WebCore::Element::didAddAttribute (this=0x8d0ad0, name=..., value=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Element.cpp:2952 917388 1 208781 rwlbuis 2013-08-14 19:21:58 -0700 Created attachment 208781 Patch 917494 2 208781 koivisto 2013-08-15 06:40:29 -0700 Comment on attachment 208781 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208781&action=review > Source/WebCore/html/HTMLProgressElement.cpp:159 > RefPtr<ProgressInnerElement> inner = ProgressInnerElement::create(document()); > + inner->setPseudo(AtomicString("-webkit-progress-inner-element", AtomicString::ConstructFromLiteral)); It would be nicer to make these setPseudo calls in ::create() so it is not possible to construct ProgressInnerElement and pals without the right pseudo type. 917512 3 rwlbuis 2013-08-15 08:02:24 -0700 (In reply to comment #2) > (From update of attachment 208781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208781&action=review > > > Source/WebCore/html/HTMLProgressElement.cpp:159 > > RefPtr<ProgressInnerElement> inner = ProgressInnerElement::create(document()); > > + inner->setPseudo(AtomicString("-webkit-progress-inner-element", AtomicString::ConstructFromLiteral)); > > It would be nicer to make these setPseudo calls in ::create() so it is not possible to construct ProgressInnerElement and pals without the right pseudo type. Great idea, I fixed it before landing. A shame that we are not always consistent here. 917513 4 rwlbuis 2013-08-15 08:03:42 -0700 Committed r154099: <http://trac.webkit.org/changeset/154099> 917567 5 208781 darin 2013-08-15 10:41:25 -0700 Comment on attachment 208781 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208781&action=review > Source/WebCore/html/shadow/ProgressShadowElement.h:69 > + ProgressBarElement(Document*); Shouldn’t this constructor be private, if it’s only supposed to be called by the create function? > Source/WebCore/html/shadow/ProgressShadowElement.h:81 > + ProgressValueElement(Document*); Same question. 917571 6 rwlbuis 2013-08-15 10:46:40 -0700 (In reply to comment #5) > (From update of attachment 208781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208781&action=review > > > Source/WebCore/html/shadow/ProgressShadowElement.h:69 > > + ProgressBarElement(Document*); > > Shouldn’t this constructor be private, if it’s only supposed to be called by the create function? > > > Source/WebCore/html/shadow/ProgressShadowElement.h:81 > > + ProgressValueElement(Document*); > > Same question. Good point, I'll try to make a follow-up patch. 917590 7 rwlbuis 2013-08-15 11:41:08 -0700 Reopening to attach new patch. 917591 8 208827 rwlbuis 2013-08-15 11:41:13 -0700 Created attachment 208827 Patch 917649 9 208827 commit-queue 2013-08-15 12:51:49 -0700 Comment on attachment 208827 Patch Clearing flags on attachment: 208827 Committed r154121: <http://trac.webkit.org/changeset/154121> 917650 10 commit-queue 2013-08-15 12:51:52 -0700 All reviewed patches have been landed. Closing bug. 203218 2013-05-29 11:04:30 -0700 2013-05-29 11:04:30 -0700 Test case current_AppleWebKit_537_44.html text/html 133 rhodovan.u-szeged PGh0bWw+Cgk8YSBpZD0iQiI+Cgk8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3ho dG1sIj4KCQk8dHJlZiB4bGluazpocmVmPSIjQiI+PC90cmVmPgoJPC9zdmc+Cgk8cHJvZ3Jlc3M+ PC9wcm9ncmVzcz4KPC9odG1sPg== 208781 2013-08-14 19:21:58 -0700 2013-08-15 11:41:02 -0700 Patch bug-116979-20130814222143.patch text/plain 7418 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAwYzJhNDMxNzQ3NjE0 NDYwYmNjZWQ1MWE5YTJkYWIyYmNjZGRlYi4uMzk2Zjg1ZDc1NGYyZmU1MjBkZjVlY2NlZTA1YmQy ZDk3YTNhYzc1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTA4LTE0ICBSb2Ig QnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KIAorICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAh bV9hZG9wdGlvbklzUmVxdWlyZWQgaW4gdm9pZCBXZWJDb3JlOjpUcmVlU2hhcmVkPE5vZGVUeXBl Pjo6cmVmKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2Ugc3VyZSBhZG9wdFJlZiBpcyBjYWxsZWQgYmVmb3JlIGNhbGxpbmcgc2V0UHNldWRvLCBm b3IgYWxsIHByb2dyZXNzIHNoYWRvdyBlbGVtZW50cy4KKworICAgICAgICBUZXN0OiBzdmcvY3Vz dG9tL3RyZWYtd2l0aC1wcm9ncmVzcy10YWctc2V0cHNldWRvLWFzc2VydC5odG1sCisKKyAgICAg ICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TFByb2dyZXNzRWxlbWVudDo6ZGlkQWRkVXNlckFnZW50U2hhZG93Um9vdCk6CisgICAgICAgICog aHRtbC9zaGFkb3cvUHJvZ3Jlc3NTaGFkb3dFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlByb2dyZXNzSW5uZXJFbGVtZW50OjpQcm9ncmVzc0lubmVyRWxlbWVudCk6CisgICAgICAgIChX ZWJDb3JlOjpQcm9ncmVzc0JhckVsZW1lbnQ6OlByb2dyZXNzQmFyRWxlbWVudCk6CisgICAgICAg IChXZWJDb3JlOjpQcm9ncmVzc1ZhbHVlRWxlbWVudDo6UHJvZ3Jlc3NWYWx1ZUVsZW1lbnQpOgor ICAgICAgICAqIGh0bWwvc2hhZG93L1Byb2dyZXNzU2hhZG93RWxlbWVudC5oOgorICAgICAgICAo V2ViQ29yZTo6UHJvZ3Jlc3NJbm5lckVsZW1lbnQ6OmNyZWF0ZSk6CisKKzIwMTMtMDgtMTQgIFJv YiBCdWlzICA8cndsYnVpc0B3ZWJraXQub3JnPgorCiAgICAgICAgIEFzc2VydGlvbiBmYWlsdXJl IGluIFJlbmRlck9iamVjdDo6ZHJhd0xpbmVGb3JCb3hTaWRlCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgxODcKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHAKaW5kZXggM2Q3OTFjNDdlMWUyNTEwZTJhMzliMjg1 ZDUzNjU2MTc4NjQwMTZmMy4uYTE4ZWQ5M2Y5Mzg3MmNlODQ5OTZmYmY5ZWE2OTg2YjVmYTVkMDMy MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwCkBAIC0x NTYsMTEgKzE1NiwxNCBAQCB2b2lkIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OmRpZEFkZFVzZXJBZ2Vu dFNoYWRvd1Jvb3QoU2hhZG93Um9vdCogcm9vdCkKICAgICBBU1NFUlQoIW1fdmFsdWUpOwogCiAg ICAgUmVmUHRyPFByb2dyZXNzSW5uZXJFbGVtZW50PiBpbm5lciA9IFByb2dyZXNzSW5uZXJFbGVt ZW50OjpjcmVhdGUoZG9jdW1lbnQoKSk7CisgICAgaW5uZXItPnNldFBzZXVkbyhBdG9taWNTdHJp bmcoIi13ZWJraXQtcHJvZ3Jlc3MtaW5uZXItZWxlbWVudCIsIEF0b21pY1N0cmluZzo6Q29uc3Ry dWN0RnJvbUxpdGVyYWwpKTsKICAgICByb290LT5hcHBlbmRDaGlsZChpbm5lcik7CiAKICAgICBS ZWZQdHI8UHJvZ3Jlc3NCYXJFbGVtZW50PiBiYXIgPSBQcm9ncmVzc0JhckVsZW1lbnQ6OmNyZWF0 ZShkb2N1bWVudCgpKTsKKyAgICBiYXItPnNldFBzZXVkbyhBdG9taWNTdHJpbmcoIi13ZWJraXQt cHJvZ3Jlc3MtYmFyIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwogICAg IFJlZlB0cjxQcm9ncmVzc1ZhbHVlRWxlbWVudD4gdmFsdWUgPSBQcm9ncmVzc1ZhbHVlRWxlbWVu dDo6Y3JlYXRlKGRvY3VtZW50KCkpOwogICAgIG1fdmFsdWUgPSB2YWx1ZS5nZXQoKTsKKyAgICBt X3ZhbHVlLT5zZXRQc2V1ZG8oQXRvbWljU3RyaW5nKCItd2Via2l0LXByb2dyZXNzLXZhbHVlIiwg QXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwogICAgIG1fdmFsdWUtPnNldFdp ZHRoUGVyY2VudGFnZShIVE1MUHJvZ3Jlc3NFbGVtZW50OjpJbmRldGVybWluYXRlUG9zaXRpb24g KiAxMDApOwogICAgIGJhci0+YXBwZW5kQ2hpbGQobV92YWx1ZSwgQVNTRVJUX05PX0VYQ0VQVElP Tik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1Byb2dyZXNzU2hh ZG93RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Qcm9ncmVzc1NoYWRv d0VsZW1lbnQuY3BwCmluZGV4IGNiN2FjYTliYWVkOGY0NDM3ZmI2ZWYzNzgxZmYxMWQyYjYyMTE5 YWIuLjNkMmYxZTY0MTY2NDdlZWM3ZTRkMjg2MTIwOWVmYTQwYzJiZjdmMTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1Byb2dyZXNzU2hhZG93RWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvUHJvZ3Jlc3NTaGFkb3dFbGVtZW50LmNwcApA QCAtNTksMTMgKzU5LDYgQEAgYm9vbCBQcm9ncmVzc1NoYWRvd0VsZW1lbnQ6OnJlbmRlcmVySXNO ZWVkZWQoY29uc3QgTm9kZVJlbmRlcmluZ0NvbnRleHQmIGNvbnRleHQKIFByb2dyZXNzSW5uZXJF bGVtZW50OjpQcm9ncmVzc0lubmVyRWxlbWVudChEb2N1bWVudCogZG9jdW1lbnQpCiAgICAgOiBQ cm9ncmVzc1NoYWRvd0VsZW1lbnQoZG9jdW1lbnQpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NB TChBdG9taWNTdHJpbmcsIHBzZXVkb0lkLCAoIi13ZWJraXQtcHJvZ3Jlc3MtaW5uZXItZWxlbWVu dCIsIEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpKTsKLSAgICBzZXRQc2V1ZG8o cHNldWRvSWQpOwotfQotCi1QYXNzUmVmUHRyPFByb2dyZXNzSW5uZXJFbGVtZW50PiBQcm9ncmVz c0lubmVyRWxlbWVudDo6Y3JlYXRlKERvY3VtZW50KiBkb2N1bWVudCkKLXsKLSAgICByZXR1cm4g YWRvcHRSZWYobmV3IFByb2dyZXNzSW5uZXJFbGVtZW50KGRvY3VtZW50KSk7CiB9CiAKIFJlbmRl ck9iamVjdCogUHJvZ3Jlc3NJbm5lckVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5h KiBhcmVuYSwgUmVuZGVyU3R5bGUqKQpAQCAtODIsNiArNzUsMTYgQEAgYm9vbCBQcm9ncmVzc0lu bmVyRWxlbWVudDo6cmVuZGVyZXJJc05lZWRlZChjb25zdCBOb2RlUmVuZGVyaW5nQ29udGV4dCYg Y29udGV4dCkKICAgICByZXR1cm4gcHJvZ3Jlc3NSZW5kZXJlciAmJiAhcHJvZ3Jlc3NSZW5kZXJl ci0+c3R5bGUoKS0+aGFzQXBwZWFyYW5jZSgpICYmIEhUTUxEaXZFbGVtZW50OjpyZW5kZXJlcklz TmVlZGVkKGNvbnRleHQpOyAgICAKIH0KIAorUHJvZ3Jlc3NCYXJFbGVtZW50OjpQcm9ncmVzc0Jh ckVsZW1lbnQoRG9jdW1lbnQqIGRvY3VtZW50KQorICAgIDogUHJvZ3Jlc3NTaGFkb3dFbGVtZW50 KGRvY3VtZW50KQoreworfQorCitQcm9ncmVzc1ZhbHVlRWxlbWVudDo6UHJvZ3Jlc3NWYWx1ZUVs ZW1lbnQoRG9jdW1lbnQqIGRvY3VtZW50KQorICAgIDogUHJvZ3Jlc3NTaGFkb3dFbGVtZW50KGRv Y3VtZW50KQoreworfQorCiB2b2lkIFByb2dyZXNzVmFsdWVFbGVtZW50OjpzZXRXaWR0aFBlcmNl bnRhZ2UoZG91YmxlIHdpZHRoKQogewogICAgIHNldElubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJv cGVydHlXaWR0aCwgd2lkdGgsIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUEVSQ0VOVEFHRSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Qcm9ncmVzc1NoYWRvd0VsZW1l bnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1Byb2dyZXNzU2hhZG93RWxlbWVudC5o CmluZGV4IDFiNzEyNDc1OGE1NGZhZGEyZDg5ZDMxMTM3OGVlNjVkNWE5YWQ4YzUuLmUwMDVlOGVk NTQ4MDhlOWJjNmZmOTBhNDE4N2IwYmIyZWUzY2UwYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L1Byb2dyZXNzU2hhZG93RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L1Byb2dyZXNzU2hhZG93RWxlbWVudC5oCkBAIC01OSwxNCArNTksMTQg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChjb25zdCBOb2Rl UmVuZGVyaW5nQ29udGV4dCYpOwogfTsKIAoraW5saW5lIFBhc3NSZWZQdHI8UHJvZ3Jlc3NJbm5l ckVsZW1lbnQ+IFByb2dyZXNzSW5uZXJFbGVtZW50OjpjcmVhdGUoRG9jdW1lbnQqIGRvY3VtZW50 KQoreworICAgIHJldHVybiBhZG9wdFJlZihuZXcgUHJvZ3Jlc3NJbm5lckVsZW1lbnQoZG9jdW1l bnQpKTsKK30KKwogY2xhc3MgUHJvZ3Jlc3NCYXJFbGVtZW50IEZJTkFMIDogcHVibGljIFByb2dy ZXNzU2hhZG93RWxlbWVudCB7CiBwdWJsaWM6Ci0gICAgUHJvZ3Jlc3NCYXJFbGVtZW50KERvY3Vt ZW50KiBkb2N1bWVudCkgCi0gICAgICAgIDogUHJvZ3Jlc3NTaGFkb3dFbGVtZW50KGRvY3VtZW50 KQotICAgIHsKLSAgICAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChBdG9taWNTdHJpbmcsIHBzZXVk b0lkLCAoIi13ZWJraXQtcHJvZ3Jlc3MtYmFyIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9t TGl0ZXJhbCkpOwotICAgICAgICBzZXRQc2V1ZG8ocHNldWRvSWQpOwotICAgIH0KKyAgICBQcm9n cmVzc0JhckVsZW1lbnQoRG9jdW1lbnQqKTsKIAogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFByb2dy ZXNzQmFyRWxlbWVudD4gY3JlYXRlKERvY3VtZW50Kik7CiB9OwpAQCAtNzgsMTIgKzc4LDcgQEAg aW5saW5lIFBhc3NSZWZQdHI8UHJvZ3Jlc3NCYXJFbGVtZW50PiBQcm9ncmVzc0JhckVsZW1lbnQ6 OmNyZWF0ZShEb2N1bWVudCogZG9jdW0KIAogY2xhc3MgUHJvZ3Jlc3NWYWx1ZUVsZW1lbnQgRklO QUwgOiBwdWJsaWMgUHJvZ3Jlc3NTaGFkb3dFbGVtZW50IHsKIHB1YmxpYzoKLSAgICBQcm9ncmVz c1ZhbHVlRWxlbWVudChEb2N1bWVudCogZG9jdW1lbnQpIAotICAgICAgICA6IFByb2dyZXNzU2hh ZG93RWxlbWVudChkb2N1bWVudCkKLSAgICB7Ci0gICAgICAgIERFRklORV9TVEFUSUNfTE9DQUwo QXRvbWljU3RyaW5nLCBwc2V1ZG9JZCwgKCItd2Via2l0LXByb2dyZXNzLXZhbHVlIiwgQXRvbWlj U3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwotICAgICAgICBzZXRQc2V1ZG8ocHNldWRv SWQpOwotICAgIH0KKyAgICBQcm9ncmVzc1ZhbHVlRWxlbWVudChEb2N1bWVudCopOwogCiAgICAg c3RhdGljIFBhc3NSZWZQdHI8UHJvZ3Jlc3NWYWx1ZUVsZW1lbnQ+IGNyZWF0ZShEb2N1bWVudCop OwogICAgIHZvaWQgc2V0V2lkdGhQZXJjZW50YWdlKGRvdWJsZSk7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGQ5NDg0YWVi NzZkYjk5YTEyMGZlZmViZTMwNjYzYmQ5OWRlZmU2Ni4uZGJlMDZmMDY1YjFmODEzNDJmMmNhM2Nl YThlYWM4MDhlMTFlZmZiOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA4LTE0ICBSb2Ig QnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KIAorICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAh bV9hZG9wdGlvbklzUmVxdWlyZWQgaW4gdm9pZCBXZWJDb3JlOjpUcmVlU2hhcmVkPE5vZGVUeXBl Pjo6cmVmKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCB0ZXN0Y2FzZSBmcm9tIGJ1ZyB3aXRoIHNtYWxsIGFkanVzdG1lbnRzLgorCisgICAgICAg ICogc3ZnL2N1c3RvbS90cmVmLXdpdGgtcHJvZ3Jlc3MtdGFnLXNldHBzZXVkby1hc3NlcnQtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdmcvY3VzdG9tL3RyZWYtd2l0aC1wcm9ncmVz cy10YWctc2V0cHNldWRvLWFzc2VydC5odG1sOiBBZGRlZC4KKworMjAxMy0wOC0xNCAgUm9iIEJ1 aXMgIDxyd2xidWlzQHdlYmtpdC5vcmc+CisKICAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4g UmVuZGVyT2JqZWN0OjpkcmF3TGluZUZvckJveFNpZGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODE4NwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9zdmcvY3VzdG9tL3RyZWYtd2l0aC1wcm9ncmVzcy10YWctc2V0cHNldWRvLWFzc2VydC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3RyZWYtd2l0aC1wcm9ncmVzcy10YWct c2V0cHNldWRvLWFzc2VydC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTg0YWI4MDQwOTk0ZjA3 NTQ1MmY1ZTQ5ODMzYWE2MWMwM2IzM2I5MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L3N2Zy9jdXN0b20vdHJlZi13aXRoLXByb2dyZXNzLXRhZy1zZXRwc2V1ZG8tYXNzZXJ0LWV4cGVj dGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3Zn L2N1c3RvbS90cmVmLXdpdGgtcHJvZ3Jlc3MtdGFnLXNldHBzZXVkby1hc3NlcnQuaHRtbCBiL0xh eW91dFRlc3RzL3N2Zy9jdXN0b20vdHJlZi13aXRoLXByb2dyZXNzLXRhZy1zZXRwc2V1ZG8tYXNz ZXJ0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNmJlMjIwM2Y3NTRhY2QwMDQwM2ZlNmYwMDdjN2FjOTNmMWYz Yzc2YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vdHJlZi13aXRo LXByb2dyZXNzLXRhZy1zZXRwc2V1ZG8tYXNzZXJ0Lmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPGh0 bWw+CisgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgdGVzdFJ1 bm5lci5kdW1wQXNUZXh0KCk7CisgIDwvc2NyaXB0PgorICA8YSBpZD0iQiI+UEFTUzwvYT4KKyAg PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CisgICAgPHRyZWYgeGxp bms6aHJlZj0iI0IiPjwvdHJlZj4KKyAgPC9zdmc+CisgIDxwcm9ncmVzcz48L3Byb2dyZXNzPgor PC9odG1sPgo= 208827 2013-08-15 11:41:13 -0700 2013-08-15 12:51:49 -0700 Patch bug-116979-20130815144100.patch text/plain 4620 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDJiZGNlODg1Y2I1OTc5 YmM4Y2Q2ZjFlMDU3ZGY0NTljNWE5YTAxMS4uNjA3ZjcwYjdhMGY2YjY3NzFmN2NhODE2MGZlYWZj MDdkZDM5ZDBmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMyw2ICszLDE4IEBACiAgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6ICFtX2Fkb3B0aW9uSXNSZXF1aXJlZCBpbiB2b2lkIFdlYkNvcmU6OlRyZWVTaGFy ZWQ8Tm9kZVR5cGU+OjpyZWYoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE2OTc5CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBjb25zdHJ1Y3RvcnMgcHJpdmF0ZSBzaW5jZSBvbmx5IDo6Y3JlYXRl IHNob3VsZCB1c2UgdGhlbS4KKworICAgICAgICAqIGh0bWwvc2hhZG93L01ldGVyU2hhZG93RWxl bWVudC5oOgorICAgICAgICAqIGh0bWwvc2hhZG93L1Byb2dyZXNzU2hhZG93RWxlbWVudC5oOgor CisyMDEzLTA4LTE1ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KKworICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiAhbV9hZG9wdGlvbklzUmVxdWlyZWQgaW4gdm9pZCBXZWJDb3JlOjpU cmVlU2hhcmVkPE5vZGVUeXBlPjo6cmVmKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNjk3OQorCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtv aXZpc3RvLgogCiAgICAgICAgIE1ha2Ugc3VyZSBhZG9wdFJlZiBpcyBjYWxsZWQgYmVmb3JlIGNh bGxpbmcgc2V0UHNldWRvLCBmb3IgYWxsIHByb2dyZXNzIHNoYWRvdyBlbGVtZW50cy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01ldGVyU2hhZG93RWxlbWVudC5oIGIv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWV0ZXJTaGFkb3dFbGVtZW50LmgKaW5kZXggODJi ODlhYjYzNmE1YzA0OWY5ZjU2ZDc0MGEzMjI4MzZiNGE1ZTY1YS4uZDRhOGM3NDA5NTliYzAxNGIz Y2NlZGYyMzM0ZjdmNDZlMDUxNjIxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9z aGFkb3cvTWV0ZXJTaGFkb3dFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFk b3cvTWV0ZXJTaGFkb3dFbGVtZW50LmgKQEAgLTUxLDEwICs1MSwxMSBAQCBwcml2YXRlOgogCiBj bGFzcyBNZXRlcklubmVyRWxlbWVudCBGSU5BTCA6IHB1YmxpYyBNZXRlclNoYWRvd0VsZW1lbnQg ewogcHVibGljOgotICAgIE1ldGVySW5uZXJFbGVtZW50KERvY3VtZW50Kik7CiAgICAgc3RhdGlj IFBhc3NSZWZQdHI8TWV0ZXJJbm5lckVsZW1lbnQ+IGNyZWF0ZShEb2N1bWVudCopOwogCiBwcml2 YXRlOgorICAgIE1ldGVySW5uZXJFbGVtZW50KERvY3VtZW50Kik7CisKICAgICB2aXJ0dWFsIGJv b2wgcmVuZGVyZXJJc05lZWRlZChjb25zdCBOb2RlUmVuZGVyaW5nQ29udGV4dCYpIE9WRVJSSURF OwogICAgIHZpcnR1YWwgUmVuZGVyT2JqZWN0KiBjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSos IFJlbmRlclN0eWxlKikgT1ZFUlJJREU7CiB9OwpAQCAtNjYsMTQgKzY3LDE1IEBAIGlubGluZSBQ YXNzUmVmUHRyPE1ldGVySW5uZXJFbGVtZW50PiBNZXRlcklubmVyRWxlbWVudDo6Y3JlYXRlKERv Y3VtZW50KiBkb2N1bWVuCiAKIGNsYXNzIE1ldGVyQmFyRWxlbWVudCBGSU5BTCA6IHB1YmxpYyBN ZXRlclNoYWRvd0VsZW1lbnQgewogcHVibGljOgorICAgIHN0YXRpYyBQYXNzUmVmUHRyPE1ldGVy QmFyRWxlbWVudD4gY3JlYXRlKERvY3VtZW50Kik7CisKK3ByaXZhdGU6CiAgICAgTWV0ZXJCYXJF bGVtZW50KERvY3VtZW50KiBkb2N1bWVudCkgCiAgICAgICAgIDogTWV0ZXJTaGFkb3dFbGVtZW50 KGRvY3VtZW50KQogICAgIHsKICAgICAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChBdG9taWNTdHJp bmcsIHBzZXVkb0lkLCAoIi13ZWJraXQtbWV0ZXItYmFyIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1 Y3RGcm9tTGl0ZXJhbCkpOwogICAgICAgICBzZXRQc2V1ZG8ocHNldWRvSWQpOwogICAgIH0KLQot ICAgIHN0YXRpYyBQYXNzUmVmUHRyPE1ldGVyQmFyRWxlbWVudD4gY3JlYXRlKERvY3VtZW50Kik7 CiB9OwogCiBpbmxpbmUgUGFzc1JlZlB0cjxNZXRlckJhckVsZW1lbnQ+IE1ldGVyQmFyRWxlbWVu dDo6Y3JlYXRlKERvY3VtZW50KiBkb2N1bWVudCkKQEAgLTgzLDE3ICs4NSwxNyBAQCBpbmxpbmUg UGFzc1JlZlB0cjxNZXRlckJhckVsZW1lbnQ+IE1ldGVyQmFyRWxlbWVudDo6Y3JlYXRlKERvY3Vt ZW50KiBkb2N1bWVudCkKIAogY2xhc3MgTWV0ZXJWYWx1ZUVsZW1lbnQgRklOQUwgOiBwdWJsaWMg TWV0ZXJTaGFkb3dFbGVtZW50IHsKIHB1YmxpYzoKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxNZXRl clZhbHVlRWxlbWVudD4gY3JlYXRlKERvY3VtZW50Kik7CisgICAgdm9pZCBzZXRXaWR0aFBlcmNl bnRhZ2UoZG91YmxlKTsKKyAgICB2b2lkIHVwZGF0ZVBzZXVkbygpIHsgc2V0UHNldWRvKHZhbHVl UHNldWRvSWQoKSk7IH0KKworcHJpdmF0ZToKICAgICBNZXRlclZhbHVlRWxlbWVudChEb2N1bWVu dCogZG9jdW1lbnQpIAogICAgICAgICA6IE1ldGVyU2hhZG93RWxlbWVudChkb2N1bWVudCkKICAg ICB7CiAgICAgICAgIHVwZGF0ZVBzZXVkbygpOwogICAgIH0KIAotICAgIHN0YXRpYyBQYXNzUmVm UHRyPE1ldGVyVmFsdWVFbGVtZW50PiBjcmVhdGUoRG9jdW1lbnQqKTsKLSAgICB2b2lkIHNldFdp ZHRoUGVyY2VudGFnZShkb3VibGUpOwotICAgIHZvaWQgdXBkYXRlUHNldWRvKCkgeyBzZXRQc2V1 ZG8odmFsdWVQc2V1ZG9JZCgpKTsgfQotCi1wcml2YXRlOgogICAgIGNvbnN0IEF0b21pY1N0cmlu ZyYgdmFsdWVQc2V1ZG9JZCgpIGNvbnN0OwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvUHJvZ3Jlc3NTaGFkb3dFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9Qcm9ncmVzc1NoYWRvd0VsZW1lbnQuaAppbmRleCA3MTdiOGRkMzI1Y2Y4NTUy NTNkMzZlYTI0ZTRjYjczMGZkNmFjYTM1Li5jN2VjZGI1NjA1MmFlOGZlMDNhZmQxODNhODNmZGE5 YjdiYjQxYjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Qcm9ncmVz c1NoYWRvd0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Qcm9ncmVz c1NoYWRvd0VsZW1lbnQuaApAQCAtNTEsMTAgKzUxLDExIEBAIHByb3RlY3RlZDoKIAogY2xhc3Mg UHJvZ3Jlc3NJbm5lckVsZW1lbnQgRklOQUwgOiBwdWJsaWMgUHJvZ3Jlc3NTaGFkb3dFbGVtZW50 IHsKIHB1YmxpYzoKLSAgICBQcm9ncmVzc0lubmVyRWxlbWVudChEb2N1bWVudCopOwotCiAgICAg c3RhdGljIFBhc3NSZWZQdHI8UHJvZ3Jlc3NJbm5lckVsZW1lbnQ+IGNyZWF0ZShEb2N1bWVudCop OworCiBwcml2YXRlOgorICAgIFByb2dyZXNzSW5uZXJFbGVtZW50KERvY3VtZW50Kik7CisKICAg ICB2aXJ0dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqLCBSZW5k ZXJTdHlsZSopIE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCByZW5kZXJlcklzTmVlZGVkKGNv bnN0IE5vZGVSZW5kZXJpbmdDb250ZXh0Jik7CiB9OwpAQCAtNjgsOSArNjksMTAgQEAgaW5saW5l IFBhc3NSZWZQdHI8UHJvZ3Jlc3NJbm5lckVsZW1lbnQ+IFByb2dyZXNzSW5uZXJFbGVtZW50Ojpj cmVhdGUoRG9jdW1lbnQqIGQKIAogY2xhc3MgUHJvZ3Jlc3NCYXJFbGVtZW50IEZJTkFMIDogcHVi bGljIFByb2dyZXNzU2hhZG93RWxlbWVudCB7CiBwdWJsaWM6Ci0gICAgUHJvZ3Jlc3NCYXJFbGVt ZW50KERvY3VtZW50Kik7Ci0KICAgICBzdGF0aWMgUGFzc1JlZlB0cjxQcm9ncmVzc0JhckVsZW1l bnQ+IGNyZWF0ZShEb2N1bWVudCopOworCitwcml2YXRlOgorICAgIFByb2dyZXNzQmFyRWxlbWVu dChEb2N1bWVudCopOwogfTsKIAogaW5saW5lIFBhc3NSZWZQdHI8UHJvZ3Jlc3NCYXJFbGVtZW50 PiBQcm9ncmVzc0JhckVsZW1lbnQ6OmNyZWF0ZShEb2N1bWVudCogZG9jdW1lbnQpCkBAIC04Miwx MCArODQsMTEgQEAgaW5saW5lIFBhc3NSZWZQdHI8UHJvZ3Jlc3NCYXJFbGVtZW50PiBQcm9ncmVz c0JhckVsZW1lbnQ6OmNyZWF0ZShEb2N1bWVudCogZG9jdW0KIAogY2xhc3MgUHJvZ3Jlc3NWYWx1 ZUVsZW1lbnQgRklOQUwgOiBwdWJsaWMgUHJvZ3Jlc3NTaGFkb3dFbGVtZW50IHsKIHB1YmxpYzoK LSAgICBQcm9ncmVzc1ZhbHVlRWxlbWVudChEb2N1bWVudCopOwotCiAgICAgc3RhdGljIFBhc3NS ZWZQdHI8UHJvZ3Jlc3NWYWx1ZUVsZW1lbnQ+IGNyZWF0ZShEb2N1bWVudCopOwogICAgIHZvaWQg c2V0V2lkdGhQZXJjZW50YWdlKGRvdWJsZSk7CisKK3ByaXZhdGU6CisgICAgUHJvZ3Jlc3NWYWx1 ZUVsZW1lbnQoRG9jdW1lbnQqKTsKIH07CiAKIGlubGluZSBQYXNzUmVmUHRyPFByb2dyZXNzVmFs dWVFbGVtZW50PiBQcm9ncmVzc1ZhbHVlRWxlbWVudDo6Y3JlYXRlKERvY3VtZW50KiBkb2N1bWVu dCkK