116909 2013-05-28 23:21:18 -0700 User is not removed by setUser() in KURL 2013-06-10 23:14:52 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 meeyoung.kim webkit-unassigned ap darin meeyoung.kim oldest_to_newest 894680 0 meeyoung.kim 2013-05-28 23:21:18 -0700 "Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials(). In these case, the aim of setUser() and setPass() is that removing the user and passward from m_string. But the user is not removed from m_string. Because user is empty. 894681 1 203123 meeyoung.kim 2013-05-28 23:25:07 -0700 Created attachment 203123 Improve performance of removing user and password from URLs By making the new remove function. To improve performance of removing user and password from URLs, the new function is used in strippedForUseAsReferrer() and removeCredentials(), instead of setUser() and setPass(). 895133 2 203123 commit-queue 2013-05-29 12:22:50 -0700 Comment on attachment 203123 Improve performance of removing user and password from URLs By making the new remove function. Rejecting attachment 203123 from review queue. meeyoung.kim@lge.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 895135 3 203123 darin 2013-05-29 12:23:19 -0700 Comment on attachment 203123 Improve performance of removing user and password from URLs By making the new remove function. Patches need to include change log. Patches that are supposed to be performance optimizations need to have performance data. Patches that are supposed to fix bugs need to come with regression tests showing the bug is fixed. 895341 4 meeyoung.kim 2013-05-29 21:49:09 -0700 I will check it, again. Thank you. 899046 5 meeyoung.kim 2013-06-10 23:14:52 -0700 Invalid description(not a bug). I change the status of this bug. 203123 2013-05-28 23:25:07 -0700 2013-05-29 12:23:19 -0700 Improve performance of removing user and password from URLs By making the new remove function. kurl_removeuserpass.patch text/plain 4245 meeyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQpp bmRleCA5ZmQ3MjY5Li41ZDEzODAyCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCkBAIC03NTksMjQgKzc1 OSwyMSBAQCB2b2lkIEtVUkw6OnNldFVzZXIoY29uc3QgU3RyaW5nJiB1c2VyKQogCiAgICAgLy8g RklYTUU6IE5vbi1BU0NJSSBjaGFyYWN0ZXJzIG11c3QgYmUgZW5jb2RlZCBhbmQgZXNjYXBlZCB0 byBtYXRjaCBwYXJzZSgpIGV4cGVjdGF0aW9ucywKICAgICAvLyBhbmQgdG8gYXZvaWQgY2hhbmdp bmcgbW9yZSB0aGFuIGp1c3QgdGhlIHVzZXIgbG9naW4uCi0KKyAgICBTdHJpbmcgdTsKICAgICBp bnQgZW5kID0gbV91c2VyRW5kOwogICAgIGlmICghdXNlci5pc0VtcHR5KCkpIHsKLSAgICAgICAg U3RyaW5nIHUgPSB1c2VyOworICAgICAgICB1ID0gdXNlcjsKICAgICAgICAgaWYgKG1fdXNlclN0 YXJ0ID09IG1fc2NoZW1lRW5kICsgMSkKICAgICAgICAgICAgIHUgPSAiLy8iICsgdTsKICAgICAg ICAgLy8gQWRkICdAJyBpZiB3ZSBkaWRuJ3QgaGF2ZSBvbmUgYmVmb3JlLgogICAgICAgICBpZiAo ZW5kID09IG1faG9zdEVuZCB8fCAoZW5kID09IG1fcGFzc3dvcmRFbmQgJiYgbV9zdHJpbmdbZW5k XSAhPSAnQCcpKQogICAgICAgICAgICAgdS5hcHBlbmQoJ0AnKTsKLSAgICAgICAgcGFyc2UobV9z dHJpbmcubGVmdChtX3VzZXJTdGFydCkgKyB1ICsgbV9zdHJpbmcuc3Vic3RyaW5nKGVuZCkpOwog ICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIFJlbW92ZSAnQCcgaWYgd2Ugbm93IGhhdmUgbmVpdGhl ciB1c2VyIG5vciBwYXNzd29yZC4KICAgICAgICAgaWYgKG1fdXNlckVuZCA9PSBtX3Bhc3N3b3Jk RW5kICYmIGVuZCAhPSBtX2hvc3RFbmQgJiYgbV9zdHJpbmdbZW5kXSA9PSAnQCcpCiAgICAgICAg ICAgICBlbmQgKz0gMTsKLSAgICAgICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBwYXJzZSBpbiB0aGUg ZXh0cmVtZWx5IGNvbW1vbiBjYXNlIHdoZXJlIHdlIGFyZSBub3QgZ29pbmcgdG8gbWFrZSBhIGNo YW5nZS4KLSAgICAgICAgaWYgKG1fdXNlclN0YXJ0ICE9IGVuZCkKLSAgICAgICAgICAgIHBhcnNl KG1fc3RyaW5nLmxlZnQobV91c2VyU3RhcnQpICsgbV9zdHJpbmcuc3Vic3RyaW5nKGVuZCkpOwog ICAgIH0KKyAgICBwYXJzZShtX3N0cmluZy5sZWZ0KG1fdXNlclN0YXJ0KSArIHUgKyBtX3N0cmlu Zy5zdWJzdHJpbmcoZW5kKSk7CiB9CiAKIHZvaWQgS1VSTDo6c2V0UGFzcyhjb25zdCBTdHJpbmcm IHBhc3N3b3JkKQpAQCAtNzg2LDI2ICs3ODMsMzMgQEAgdm9pZCBLVVJMOjpzZXRQYXNzKGNvbnN0 IFN0cmluZyYgcGFzc3dvcmQpCiAKICAgICAvLyBGSVhNRTogTm9uLUFTQ0lJIGNoYXJhY3RlcnMg bXVzdCBiZSBlbmNvZGVkIGFuZCBlc2NhcGVkIHRvIG1hdGNoIHBhcnNlKCkgZXhwZWN0YXRpb25z LAogICAgIC8vIGFuZCB0byBhdm9pZCBjaGFuZ2luZyBtb3JlIHRoYW4ganVzdCB0aGUgdXNlciBw YXNzd29yZC4KLQorICAgIFN0cmluZyBwOwogICAgIGludCBlbmQgPSBtX3Bhc3N3b3JkRW5kOwog ICAgIGlmICghcGFzc3dvcmQuaXNFbXB0eSgpKSB7Ci0gICAgICAgIFN0cmluZyBwID0gIjoiICsg cGFzc3dvcmQgKyAiQCI7CisgICAgICAgIHAgPSAiOiIgKyBwYXNzd29yZCArICJAIjsKICAgICAg ICAgaWYgKG1fdXNlckVuZCA9PSBtX3NjaGVtZUVuZCArIDEpCiAgICAgICAgICAgICBwID0gIi8v IiArIHA7CiAgICAgICAgIC8vIEVhdCB0aGUgZXhpc3RpbmcgJ0AnIHNpbmNlIHdlIGFyZSBnb2lu ZyB0byBhZGQgb3VyIG93bi4KICAgICAgICAgaWYgKGVuZCAhPSBtX2hvc3RFbmQgJiYgbV9zdHJp bmdbZW5kXSA9PSAnQCcpCiAgICAgICAgICAgICBlbmQgKz0gMTsKLSAgICAgICAgcGFyc2UobV9z dHJpbmcubGVmdChtX3VzZXJFbmQpICsgcCArIG1fc3RyaW5nLnN1YnN0cmluZyhlbmQpKTsKICAg ICB9IGVsc2UgewogICAgICAgICAvLyBSZW1vdmUgJ0AnIGlmIHdlIG5vdyBoYXZlIG5laXRoZXIg dXNlciBub3IgcGFzc3dvcmQuCiAgICAgICAgIGlmIChtX3VzZXJTdGFydCA9PSBtX3VzZXJFbmQg JiYgZW5kICE9IG1faG9zdEVuZCAmJiBtX3N0cmluZ1tlbmRdID09ICdAJykKICAgICAgICAgICAg IGVuZCArPSAxOwotICAgICAgICAvLyBXZSBkb24ndCB3YW50IHRvIHBhcnNlIGluIHRoZSBleHRy ZW1lbHkgY29tbW9uIGNhc2Ugd2hlcmUgd2UgYXJlIG5vdCBnb2luZyB0byBtYWtlIGEgY2hhbmdl LgotICAgICAgICBpZiAobV91c2VyRW5kICE9IGVuZCkKLSAgICAgICAgICAgIHBhcnNlKG1fc3Ry aW5nLmxlZnQobV91c2VyRW5kKSArIG1fc3RyaW5nLnN1YnN0cmluZyhlbmQpKTsKICAgICB9Cisg ICAgcGFyc2UobV9zdHJpbmcubGVmdChtX3VzZXJFbmQpICsgcCArIG1fc3RyaW5nLnN1YnN0cmlu ZyhlbmQpKTsKIH0KK3ZvaWQgS1VSTDo6cmVtb3ZlVXNlclBhc3MoKQoreworICAgIGlmICghbV9p c1ZhbGlkKQorICAgICAgICByZXR1cm47CisgICAgaW50IGVuZCA9IG1fcGFzc3dvcmRFbmQ7CiAK KyAgICAvLyBSZW1vdmUgJ0AnIGlmIHdlIG5vdyBoYXZlIG5laXRoZXIgdXNlciBub3IgcGFzc3dv cmQuCisgICAgaWYgKG1fdXNlclN0YXJ0ICE9IG1fcGFzc3dvcmRFbmQgJiYgZW5kICE9IG1faG9z dEVuZCAmJiBtX3N0cmluZ1tlbmRdID09ICdAJykKKyAgICAgICAgZW5kICs9IDE7CisgICAgcGFy c2UobV9zdHJpbmcubGVmdChtX3VzZXJTdGFydCkgKyBtX3N0cmluZy5zdWJzdHJpbmcoZW5kKSk7 IAorfQogdm9pZCBLVVJMOjpzZXRGcmFnbWVudElkZW50aWZpZXIoY29uc3QgU3RyaW5nJiBzKQog ewogICAgIGlmICghbV9pc1ZhbGlkKQpAQCAtMTc0MCw4ICsxNzQ0LDcgQEAgdm9pZCBLVVJMOjpw cmludCgpIGNvbnN0CiBTdHJpbmcgS1VSTDo6c3RyaXBwZWRGb3JVc2VBc1JlZmVycmVyKCkgY29u c3QKIHsKICAgICBLVVJMIHJlZmVycmVyKCp0aGlzKTsKLSAgICByZWZlcnJlci5zZXRVc2VyKFN0 cmluZygpKTsKLSAgICByZWZlcnJlci5zZXRQYXNzKFN0cmluZygpKTsKKyAgICByZWZlcnJlci5y ZW1vdmVVc2VyUGFzcygpOwogICAgIHJlZmVycmVyLnJlbW92ZUZyYWdtZW50SWRlbnRpZmllcigp OwogICAgIHJldHVybiByZWZlcnJlci5zdHJpbmcoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL0tVUkwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaApv bGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IDhhNTU5ZGIuLjE0MzAxZjgKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0tVUkwuaApAQCAtMTQwLDYgKzE0MCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0 VXNlcihjb25zdCBTdHJpbmcmKTsKICAgICB2b2lkIHNldFBhc3MoY29uc3QgU3RyaW5nJik7Cisg ICAgdm9pZCByZW1vdmVVc2VyUGFzcygpOwogCiAgICAgLy8gSWYgeW91IHBhc3MgYW4gZW1wdHkg cGF0aCBmb3IgSFRUUCBvciBIVFRQUyBVUkxzLCB0aGUgcmVzdWx0aW5nIHBhdGgKICAgICAvLyB3 aWxsIGJlICIvIi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv UmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUK aW5kZXggMTk1ZjRhZS4uOWYyMTgwMAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAKQEAgLTEzNiw5ICsxMzYsNyBAQCB2b2lk IFJlc291cmNlUmVxdWVzdEJhc2U6OnJlbW92ZUNyZWRlbnRpYWxzKCkKICAgICBpZiAobV91cmwu dXNlcigpLmlzRW1wdHkoKSAmJiBtX3VybC5wYXNzKCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1 cm47CiAKLSAgICBtX3VybC5zZXRVc2VyKFN0cmluZygpKTsKLSAgICBtX3VybC5zZXRQYXNzKFN0 cmluZygpKTsKLQorICAgIG1fdXJsLnJlbW92ZVVzZXJQYXNzKCk7CiAgICAgbV9wbGF0Zm9ybVJl cXVlc3RVcGRhdGVkID0gZmFsc2U7CiB9CiAK