116906 2013-05-28 21:16:27 -0700 REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript 2013-05-29 16:08:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 113626 117007 1 aestes aestes commit-queue japhet webkit-bug-importer oldest_to_newest 894653 0 aestes 2013-05-28 21:16:27 -0700 REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript 894654 1 aestes 2013-05-28 21:18:17 -0700 <rdar://problem/13991927> 894655 2 203118 aestes 2013-05-28 21:27:12 -0700 Created attachment 203118 Patch 894658 3 203118 kling 2013-05-28 21:51:29 -0700 Comment on attachment 203118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203118&action=review r=me. > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=116906 It's nice to have the rdar:// link here too. Your future bisecting self will thank you. :) 894660 4 aestes 2013-05-28 21:55:58 -0700 Committed r150863: <http://trac.webkit.org/changeset/150863> 895127 5 203118 darin 2013-05-29 12:18:23 -0700 Comment on attachment 203118 Patch I’m not sure this can be the last word on the subject. Caching local files indefinitely even after the files change on disk does not seem like good behavior for us to keep forever. And for unknown custom schemes it could also be unacceptable. Seems like we need to rethink this to get it right long term. 895248 6 aestes 2013-05-29 16:07:30 -0700 (In reply to comment #5) > (From update of attachment 203118 [details]) > I’m not sure this can be the last word on the subject. Caching local files indefinitely even after the files change on disk does not seem like good behavior for us to keep forever. And for unknown custom schemes it could also be unacceptable. Seems like we need to rethink this to get it right long term. I agree with you. I wrote up my thoughts on how to improve this situation here: https://bugs.webkit.org/show_bug.cgi?id=117007 203118 2013-05-28 21:27:12 -0700 2013-05-29 12:18:23 -0700 Patch bug-116906-20130528212551.patch text/plain 2821 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI0N2JkYTQzMTEzMjdi ZGJhNGIwNTVlY2Q5NzRhYzJhYTA5ODlmZS4uMWI4NDExOWJjZmJkMjI1MzdlZjVhMjc5OWZmMDE1 MWU4YmRhNDIxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTA1LTI4ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTUwMTY5 KTogSW1hZ2VzIGZyb20gZmlsZTogVVJMcyBkaXNwbGF5IGFmdGVyIGEgZGVsYXkgZXZlbiB0aG91 Z2ggdGhleSB3ZXJlIHByZWxvYWRlZCBieSBKYXZhU2NyaXB0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY5MDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXcml0aW5nIGEgdGVzdCBmb3IgdGhpcyBpcyBi bG9ja2VkIG9uIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzExNjE5OS4KKworICAgICAgICBTb21lIFdl YktpdCBjbGllbnRzIHVzZSBKYXZhU2NyaXB0IHRvIHByZWxvYWQgaW1hZ2VzIGZyb20gZGlzayBz byB0aGF0CisgICAgICAgIHN1YnNlcXVlbnQgbG9hZHMgd2lsbCBkaXNwbGF5IGltbWVkaWF0ZWx5 IGZyb20gdGhlIG1lbW9yeSBjYWNoZS4gQnkgbm90CisgICAgICAgIGNhY2hpbmcgbm9uLUhUVFAg c3ViLXJlc291cmNlcyBpbiBtZW1vcnksIHdlIGJyZWFrIHRoaXMgY29tbW9uIHBhdHRlcm4uCisg ICAgICAgIFRoaXMgY2hhbmdlIHJlc3RyaWN0cyByMTUwMTY5IHRvIG9ubHkgYXBwbHkgdG8gY2Fj aGVkIG1haW4gcmVzb3VyY2VzLgorICAgICAgICBTdWItcmVzb3VyY2VzIHdpbGwgYWdhaW4gYmUg Y2FjaGVkIGluZGVmaW5pdGVseSBhcyB0aGV5IHdlcmUgcHJpb3IgdG8KKyAgICAgICAgcjE1MDE2 OS4KKworICAgICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZTo6ZnJlc2huZXNzTGlmZXRpbWUpOiBJZiB0aGlzIGlz IGEgbm9uLUhUVFAKKyAgICAgICAgbWFpbiByZXNvdXJjZSBmcm9tIGEgc2NoZW1lIHRoYXQgc2hv dWxkIG5vdCBiZSBjYWNoZWQgaW5kZWZpbml0ZWx5LAorICAgICAgICByZXR1cm4gMCBmb3IgdGhl IGZyZXNobmVzcyBsaWZldGltZS4gRm9yIG90aGVyIG5vbi1IVFRQIGNhY2hlZAorICAgICAgICBy ZXNvdXJjZXMsIHJldHVybiBhbiBpbmRlZmluaXRlIGZyZXNobmVzcyBsaWZldGltZS4KKwogMjAx My0wNS0yOCAgQWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIEdyYXBoaWNzQ29udGV4dDogYWRkIG1pc3NpbmcgZGVmaW5pdGlvbnMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAppbmRleCAy MmMyNjVjMWE1MTkwYmQ4MGFmZTI4YmYwNzhiZGM4NWQzYTI1OGNiLi4zYjJmNzEzN2RlNGI1NTMw YzU3YjcxZjBjOGZkMTgzMDZiODMyMTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKQEAgLTQxNSwxMiArNDE1LDE1IEBAIGRvdWJsZSBDYWNo ZWRSZXNvdXJjZTo6Y3VycmVudEFnZSgpIGNvbnN0CiAKIGRvdWJsZSBDYWNoZWRSZXNvdXJjZTo6 ZnJlc2huZXNzTGlmZXRpbWUoKSBjb25zdAogewotICAgIGlmIChTY2hlbWVSZWdpc3RyeTo6c2hv dWxkQ2FjaGVSZXNwb25zZXNGcm9tVVJMU2NoZW1lSW5kZWZpbml0ZWx5KG1fcmVzcG9uc2UudXJs KCkucHJvdG9jb2woKSkpCi0gICAgICAgIHJldHVybiBzdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJs ZT46Om1heCgpOworICAgIGlmICghbV9yZXNwb25zZS51cmwoKS5wcm90b2NvbElzSW5IVFRQRmFt aWx5KCkpIHsKKyAgICAgICAgLy8gRG9uJ3QgY2FjaGUgbm9uLUhUVFAgbWFpbiByZXNvdXJjZXMg c2luY2Ugd2UgY2FuJ3QgY2hlY2sgZm9yIGZyZXNobmVzcy4KKyAgICAgICAgLy8gRklYTUU6IFdl IHNob3VsZCBub3QgY2FjaGUgc3VicmVzb3VyY2VzIGVpdGhlciwgYnV0IHdoZW4gd2UgdHJpZWQg dGhpcworICAgICAgICAvLyBpdCBjYXVzZWQgcGVyZm9ybWFuY2UgYW5kIGZsYWtpbmVzcyBpc3N1 ZXMgaW4gb3VyIHRlc3QgaW5mcmFzdHJ1Y3R1cmUuCisgICAgICAgIGlmIChtX3R5cGUgPT0gTWFp blJlc291cmNlICYmICFTY2hlbWVSZWdpc3RyeTo6c2hvdWxkQ2FjaGVSZXNwb25zZXNGcm9tVVJM U2NoZW1lSW5kZWZpbml0ZWx5KG1fcmVzcG9uc2UudXJsKCkucHJvdG9jb2woKSkpCisgICAgICAg ICAgICByZXR1cm4gMDsKIAotICAgIC8vIERvbid0IGNhY2hlIG90aGVyIG5vbi1IVFRQIHJlc291 cmNlcyBzaW5jZSB3ZSBjYW4ndCBjaGVjayBmb3IgZnJlc2huZXNzLgotICAgIGlmICghbV9yZXNw b25zZS51cmwoKS5wcm90b2NvbElzSW5IVFRQRmFtaWx5KCkpCi0gICAgICAgIHJldHVybiAwOwor ICAgICAgICByZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+OjptYXgoKTsKKyAgICB9 CiAKICAgICAvLyBSRkMyNjE2IDEzLjIuNAogICAgIGRvdWJsZSBtYXhBZ2VWYWx1ZSA9IG1fcmVz cG9uc2UuY2FjaGVDb250cm9sTWF4QWdlKCk7Cg==