116900 2013-05-28 16:36:04 -0700 Animations do not restart after exiting page cache 2013-05-28 20:22:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino commit-queue dstockwell simon.fraser oldest_to_newest 894599 0 dino 2013-05-28 16:36:04 -0700 We suspend animations going into the page cache and do not resume them coming out. <rdar://problem/14006844> 894638 1 203115 dino 2013-05-28 20:05:44 -0700 Created attachment 203115 Patch 894639 2 203115 thorton 2013-05-28 20:10:01 -0700 Comment on attachment 203115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203115&action=review > Source/WebCore/ChangeLog:11 > + was an error in r149576 which was checking a global suspended > + on the AnimationController and not trying to resume anything a global suspended *what*. > Source/WebCore/page/animation/AnimationController.cpp:-315 > - if (!isSuspended()) > - return; How sure are we that there are no cases where this will accidentally get called twice/is there any potential downside to that? 894640 3 dino 2013-05-28 20:11:47 -0700 (In reply to comment #2) > (From update of attachment 203115 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203115&action=review > > > Source/WebCore/ChangeLog:11 > > + was an error in r149576 which was checking a global suspended > > + on the AnimationController and not trying to resume anything > > a global suspended *what*. :) > > > Source/WebCore/page/animation/AnimationController.cpp:-315 > > - if (!isSuspended()) > > - return; > > How sure are we that there are no cases where this will accidentally get called twice/is there any potential downside to that? There is no downside. In fact, the code was originally like this for years, before I added the flag. I just got a bit overzealous when trying to return early. 894641 4 dino 2013-05-28 20:14:32 -0700 Committed r150862: <http://trac.webkit.org/changeset/150862> 894642 5 simon.fraser 2013-05-28 20:22:29 -0700 <rdar://problem/14006844> 203115 2013-05-28 20:05:44 -0700 2013-05-28 20:10:01 -0700 Patch bug-116900-20130529130422.patch text/plain 5824 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFjOTliZjMyY2M3NzMy MzllMjk1N2Q3NzIyODkwNTY1ZjYxNjVjZS4uMzM3Y2U2OWJmYWRjYjQ2NTM4YTYwNGFiYTkzZGI0 Y2Q1ZTczNTY1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA1LTI4ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBbmltYXRpb25zIGRvIG5vdCBy ZXN0YXJ0IGFmdGVyIGV4aXRpbmcgcGFnZSBjYWNoZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2OTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQW5pbWF0aW9ucyBhcmUgc3VzcGVuZGVkIGFzIHRoZXkg ZW50ZXIgdGhlIHBhZ2UgY2FjaGUsIGJ1dAorICAgICAgICB3ZXJlIG5vdCBnZXR0aW5nIGNvcnJl Y3RseSByZXN1bWVkIHdoZW4gZXhpdGluZy4gVGhlIGNhdXNlCisgICAgICAgIHdhcyBhbiBlcnJv ciBpbiByMTQ5NTc2IHdoaWNoIHdhcyBjaGVja2luZyBhIGdsb2JhbCBzdXNwZW5kZWQKKyAgICAg ICAgb24gdGhlIEFuaW1hdGlvbkNvbnRyb2xsZXIgYW5kIG5vdCB0cnlpbmcgdG8gcmVzdW1lIGFu eXRoaW5nCisgICAgICAgIGlmIGl0IGRpZG4ndCB0aGluayBpdCB3YXMgc3VzcGVuZGVkLgorCisg ICAgICAgIFRlc3Q6IGFuaW1hdGlvbnMvcmVzdW1lLWFmdGVyLXBhZ2UtY2FjaGUuaHRtbAorCisg ICAgICAgICogcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6c3VzcGVuZEFuaW1hdGlvbnNG b3JEb2N1bWVudCk6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25Db250cm9sbGVyUHJpdmF0 ZTo6cmVzdW1lQW5pbWF0aW9uc0ZvckRvY3VtZW50KToKKwogMjAxMy0wNS0yNiAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUGx1Z2lucyB3aXRoIG5vIHNyYyBidXQg dmFsaWQgdHlwZSBzaG91bGQgbm90IHNuYXBzaG90CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25Db250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCmluZGV4IDM0YmFhMmFhMzYz NjdjODdiYmEwNDI4ZDJkMWRhM2FhZjIwMzIwYjAuLjc3ZjJjNDE5NjliYmQ3ZDQ1YjczNGMyYzQ0 YTQ3OWE5ZTk2NDY4MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9u L0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0 aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCkBAIC0yOTIsOSArMjkyLDYgQEAgdm9pZCBBbmlt YXRpb25Db250cm9sbGVyUHJpdmF0ZTo6cmVzdW1lQW5pbWF0aW9ucygpCiAKIHZvaWQgQW5pbWF0 aW9uQ29udHJvbGxlclByaXZhdGU6OnN1c3BlbmRBbmltYXRpb25zRm9yRG9jdW1lbnQoRG9jdW1l bnQqIGRvY3VtZW50KQogewotICAgIGlmIChpc1N1c3BlbmRlZCgpKQotICAgICAgICByZXR1cm47 Ci0KICAgICBzZXRCZWdpbkFuaW1hdGlvblVwZGF0ZVRpbWUoY0JlZ2luQW5pbWF0aW9uVXBkYXRl VGltZU5vdFNldCk7CiAKICAgICBSZW5kZXJPYmplY3RBbmltYXRpb25NYXA6OmNvbnN0X2l0ZXJh dG9yIGFuaW1hdGlvbnNFbmQgPSBtX2NvbXBvc2l0ZUFuaW1hdGlvbnMuZW5kKCk7CkBAIC0zMTEs OSArMzA4LDYgQEAgdm9pZCBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6c3VzcGVuZEFuaW1h dGlvbnNGb3JEb2N1bWVudChEb2N1bWVudCogZG9jdW1lbnQKIAogdm9pZCBBbmltYXRpb25Db250 cm9sbGVyUHJpdmF0ZTo6cmVzdW1lQW5pbWF0aW9uc0ZvckRvY3VtZW50KERvY3VtZW50KiBkb2N1 bWVudCkKIHsKLSAgICBpZiAoIWlzU3VzcGVuZGVkKCkpCi0gICAgICAgIHJldHVybjsKLQogICAg IHNldEJlZ2luQW5pbWF0aW9uVXBkYXRlVGltZShjQmVnaW5BbmltYXRpb25VcGRhdGVUaW1lTm90 U2V0KTsKIAogICAgIFJlbmRlck9iamVjdEFuaW1hdGlvbk1hcDo6Y29uc3RfaXRlcmF0b3IgYW5p bWF0aW9uc0VuZCA9IG1fY29tcG9zaXRlQW5pbWF0aW9ucy5lbmQoKTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjZjU2NmRm NjNiY2ZlYjkwYjJlYzZiOTUxNGZlZjM4OWIzMGEyZGQxLi43OTVkZjNlYmE2NWVlZjljZWI0OTkx MWMzOGM3OTFhNThmNDVkYTk1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDUtMjggIERl YW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEFuaW1hdGlvbnMgZG8gbm90 IHJlc3RhcnQgYWZ0ZXIgZXhpdGluZyBwYWdlIGNhY2hlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY5MDAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZXcgdGVzdCB0byBtYWtlIHN1cmUgYW4gYW5pbWF0 aW9uIHdpbGwgcmVzdW1lIGlmIGl0CisgICAgICAgIGVudGVycyBhbmQgbGVhdmVzIHRoZSBwYWdl IGNhY2hlLgorCisgICAgICAgICogYW5pbWF0aW9ucy9yZXNvdXJjZXMvcGFnZS1jYWNoZS1oZWxw ZXIuaHRtbDogQWRkZWQuCisgICAgICAgICogYW5pbWF0aW9ucy9yZXN1bWUtYWZ0ZXItcGFnZS1j YWNoZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFuaW1hdGlvbnMvcmVzdW1lLWFm dGVyLXBhZ2UtY2FjaGUuaHRtbDogQWRkZWQuCisKIDIwMTMtMDUtMjUgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgVW5wcmVmaXggUGFnZSBWaXNpYmls aXR5IEFQSQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9yZXNvdXJjZXMvcGFn ZS1jYWNoZS1oZWxwZXIuaHRtbCBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvcmVzb3VyY2VzL3Bh Z2UtY2FjaGUtaGVscGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTliNmMyMjhlODAxMTcwY2RlNDNiYTk2 OTMxNTU2YzQ2MzYwNDY0YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FuaW1hdGlv bnMvcmVzb3VyY2VzL3BhZ2UtY2FjaGUtaGVscGVyLmh0bWwKQEAgLTAsMCArMSw4IEBACitUaGlz IHBhZ2Ugc2hvdWxkIGdvIGJhY2suCis8c2NyaXB0Pgord2luZG93LmFkZEV2ZW50TGlzdGVuZXIo ImxvYWQiLCBmdW5jdGlvbigpIHsKKyAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAg ICBoaXN0b3J5LmJhY2soKTsKKyAgICB9LCAwKTsKK30sIGZhbHNlKTsKKzwvc2NyaXB0PgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9yZXN1bWUtYWZ0ZXItcGFnZS1jYWNoZS1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3Jlc3VtZS1hZnRlci1wYWdlLWNh Y2hlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yZmZhNzMxNjg1ODRkZmQxMTc3MDkwMjg0ZDg5 ZjJhNzkxYWIwNzdkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9y ZXN1bWUtYWZ0ZXItcGFnZS1jYWNoZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitUaGlz IHRlc3RzIHRoYXQgYW5pbWF0aW9ucyBjb250aW51ZSB3aGVuIHJlc3RvcmVkIGZyb20gdGhlIHBh Z2UgY2FjaGUuCisKK1BBU1M6IFNhdyBpdGVyYXRpb24gYWZ0ZXIgbmF2aWdhdGlvbgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9yZXN1bWUtYWZ0ZXItcGFnZS1jYWNoZS5odG1s IGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9yZXN1bWUtYWZ0ZXItcGFnZS1jYWNoZS5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmFmMWRlMDNjMjBhYWRkOWM4OTBlZDBhMzViZWYwNWExNWYzNGNlZWQKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3Jlc3VtZS1hZnRlci1wYWdlLWNh Y2hlLmh0bWwKQEAgLTAsMCArMSw1NSBAQAorPHN0eWxlPgorQC13ZWJraXQta2V5ZnJhbWVzIGJv dW5jZSB7CisgICAgZnJvbSB7CisgICAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGUz ZCgwLDAsMCk7CisgICAgfQorICAgIHRvIHsKKyAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRy YW5zbGF0ZTNkKDIwMHB4LDAsMCk7CisgICAgfQorfQorCisjYW5pbWF0b3IgeworICAgIHBvc2l0 aW9uOiByZWxhdGl2ZTsKKyAgICB0b3A6IDBweDsKKyAgICB3aWR0aDogMTAwcHg7CisgICAgaGVp Z2h0OiAxMDBweDsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworICAgIC13ZWJraXQtYW5p bWF0aW9uLW5hbWU6IGJvdW5jZTsKKyAgICAtd2Via2l0LWFuaW1hdGlvbi1kdXJhdGlvbjogODBt czsKKyAgICAtd2Via2l0LWFuaW1hdGlvbi1pdGVyYXRpb24tY291bnQ6IGluZmluaXRlOworfQor PC9zdHlsZT4KKzxzY3JpcHQ+Cit2YXIgaGFzTmF2aWdhdGVkID0gZmFsc2U7CisKK2Z1bmN0aW9u IHNhd0l0ZXJhdGlvbihldmVudCkgeworICAgIGlmIChoYXNOYXZpZ2F0ZWQpIHsKKyAgICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdHMiKS5pbm5lclRleHQgPSAiUEFTUzogU2F3 IGl0ZXJhdGlvbiBhZnRlciBuYXZpZ2F0aW9uIjsKKyAgICAgICAgd2luZG93LnRlc3RSdW5uZXIu b3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRVc2VzUGFnZUNhY2hlUHJlZmVyZW5jZUtleSIsIDAp OworICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9u IHN0YXJ0VGVzdCgpIHsKKyAgICB2YXIgYW5pbWF0b3IgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiYW5pbWF0b3IiKTsKKyAgICBhbmltYXRvci5hZGRFdmVudExpc3RlbmVyKCJ3ZWJraXRBbmlt YXRpb25JdGVyYXRpb24iLCBzYXdJdGVyYXRpb24sIGZhbHNlKTsKKyAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgeworICAgICAgICBoYXNOYXZpZ2F0ZWQgPSB0cnVlOworICAgICAgICB3aW5kb3cu bG9jYXRpb24uaHJlZiA9ICJyZXNvdXJjZXMvcGFnZS1jYWNoZS1oZWxwZXIuaHRtbCI7CisgICAg fSwgMjAwKTsKK30KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgd2luZG93LnRlc3RS dW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHdpbmRvdy50ZXN0UnVubmVyLndhaXRVbnRpbERvbmUo KTsKKyAgICB3aW5kb3cudGVzdFJ1bm5lci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdFVzZXNQ YWdlQ2FjaGVQcmVmZXJlbmNlS2V5IiwgMSk7Cit9CisKK3dpbmRvdy5hZGRFdmVudExpc3RlbmVy KCJsb2FkIiwgc3RhcnRUZXN0LCBmYWxzZSk7Cis8L3NjcmlwdD4KKzxwPgorICAgIFRoaXMgdGVz dHMgdGhhdCBhbmltYXRpb25zIGNvbnRpbnVlIHdoZW4gcmVzdG9yZWQgZnJvbSB0aGUgcGFnZSBj YWNoZS4KKzwvcD4KKworPGRpdiBpZD0iYW5pbWF0b3IiPjwvZGl2PgorPGRpdiBpZD0icmVzdWx0 cyI+PC9kaXY+Cg==