116895 2013-05-28 15:21:37 -0700 fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833 2013-05-30 18:52:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 1 thorton barraclough barraclough jer.noble thorton oldest_to_newest 894565 0 thorton 2013-05-28 15:21:37 -0700 http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r150833%20(10397)/fast/js/date-DST-time-cusps-pretty-diff.html - PASS Passed all tests (or skipped all tests if your timezone isn't PST/PDT) + FAIL 2/4 tests were failed: (new Date(1982, 2, 14, 2, 10)).getHours() should be 1. Was 3., (new Date(1982, 2, 14, 2)).getHours() should be 1. Was 3. 894577 1 thorton 2013-05-28 15:40:09 -0700 Marked failing in http://trac.webkit.org/changeset/150848. Please fix by the morning or I'll roll out the offending patch. 894646 2 barraclough 2013-05-28 20:40:51 -0700 This is actually a progression! Per the description in the test case: "For times that shouldn't happen we currently go back an hour, but in reality we would like to go forward an hour. This has been filed as a radar: 4777813" Now it does! I'll update the expected results. 894648 3 203116 barraclough 2013-05-28 21:01:40 -0700 Created attachment 203116 Update results 895349 4 203116 ap 2013-05-29 22:23:05 -0700 Comment on attachment 203116 Update results View in context: https://bugs.webkit.org/attachment.cgi?id=203116&action=review Looks convincing. > LayoutTests/ChangeLog:5 > + <rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist Also <https://bugs.webkit.org/show_bug.cgi?id=11157>, I guess. > LayoutTests/ChangeLog:14 > + - Preffer the latter option for non-existant time (due to clock rolling forwards). Typo: Preffer. Mistake: existant. Looks suspicious to me: forwards. > LayoutTests/fast/js/script-tests/date-DST-time-cusps.js:6 > "For times that happen twice the behavior of all major browsers seems to be to pick the second occurance, i.e. Standard Time not Daylight Time" Mistake: occurrance. 895761 5 barraclough 2013-05-30 18:52:44 -0700 Fixed in r151000 203116 2013-05-28 21:01:40 -0700 2013-05-29 22:23:04 -0700 Update results 116895.patch text/plain 2729 barraclough SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1MDg2MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTI4ICBHYXZpbiBCYXJyYWNsb3Vn aCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBmYXN0L2pzL2RhdGUtRFNULXRp bWUtY3VzcHMuaHRtbCBmYWlscyBhZnRlciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNl dC8xNTA4MzMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjg5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc3NzgxMz4gU2FmYXJpIGluY29ycmVj dGx5IGhhbmRsZXMgdGltZXMgdGhhdCBzaG91bGRuJ3QgZXhpc3QKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NpZGVudGFsIHByb2dyZXNzaW9uLCB1 cGRhdGluZyByZXN1bHRzIHRvIGV4cGVjdCBzdWNjZXNzLgorCisgICAgICAgICogVGVzdEV4cGVj dGF0aW9uczoKKyAgICAgICAgICAgIC0gUmVtb3ZlIGV4cGVjdGF0aW9ucyBvZiBmYWlsdXJlLgor ICAgICAgICAqIGZhc3QvanMvc2NyaXB0LXRlc3RzL2RhdGUtRFNULXRpbWUtY3VzcHMuanM6Cisg ICAgICAgICAgICAtIFByZWZmZXIgdGhlIGxhdHRlciBvcHRpb24gZm9yIG5vbi1leGlzdGFudCB0 aW1lIChkdWUgdG8gY2xvY2sgcm9sbGluZyBmb3J3YXJkcykuCisKIDIwMTMtMDUtMjggIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFuaW1hdGlvbnMgZG8gbm90IHJl c3RhcnQgYWZ0ZXIgZXhpdGluZyBwYWdlIGNhY2hlCkluZGV4OiBMYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMJKHJl dmlzaW9uIDE1MDg1OCkKKysrIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcg Y29weSkKQEAgLTE1LDYgKzE1LDMgQEAgd2Via2l0Lm9yZy9iLzExNjQ3MyBlZGl0aW5nL3NlbGVj dGlvbi91cwogCiAjIG1lZGlhL1czQy92aWRlby9uZXR3b3JrU3RhdGUvbmV0d29ya1N0YXRlX2R1 cmluZ19wcm9ncmVzcy5odG1sIGlzIGZsYWt5CiB3ZWJraXQub3JnL2IvNzYyODAgbWVkaWEvVzND L3ZpZGVvL25ldHdvcmtTdGF0ZS9uZXR3b3JrU3RhdGVfZHVyaW5nX3Byb2dyZXNzLmh0bWwgWyBQ YXNzIEZhaWx1cmUgXQotCi0jIGZhc3QvanMvZGF0ZS1EU1QtdGltZS1jdXNwcy5odG1sIGZhaWxz IGFmdGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE1MDgzMwotd2Via2l0Lm9y Zy9iLzExNjg5NSBmYXN0L2pzL2RhdGUtRFNULXRpbWUtY3VzcHMuaHRtbCBbIEZhaWx1cmUgXQpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1EU1QtdGltZS1jdXNw cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9kYXRl LURTVC10aW1lLWN1c3BzLmpzCShyZXZpc2lvbiAxNTA4NTgpCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2pzL3NjcmlwdC10ZXN0cy9kYXRlLURTVC10aW1lLWN1c3BzLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0zLDE3ICszLDEzIEBAIGRlc2NyaXB0aW9uKAogKTsKIAogZGVzY3JpcHRpb24oCi0iRm9yIHRp bWVzIHRoYXQgc2hvdWxkbid0IGhhcHBlbiB3ZSBjdXJyZW50bHkgZ28gYmFjayBhbiBob3VyLCBi dXQgaW4gcmVhbGl0eSB3ZSB3b3VsZCBsaWtlIHRvIGdvIGZvcndhcmQgYW4gaG91ci4gIFRoaXMg aGFzIGJlZW4gZmlsZWQgYXMgYSByYWRhcjogNDc3NzgxMyIKLSk7Ci0KLWRlc2NyaXB0aW9uKAog IkZvciB0aW1lcyB0aGF0IGhhcHBlbiB0d2ljZSB0aGUgYmVoYXZpb3Igb2YgYWxsIG1ham9yIGJy b3dzZXJzIHNlZW1zIHRvIGJlIHRvIHBpY2sgdGhlIHNlY29uZCBvY2N1cmFuY2UsIGkuZS4gU3Rh bmRhcmQgVGltZSBub3QgRGF5bGlnaHQgVGltZSIKICk7CiAKIHZhciB0ZXN0Q2FzZXMgPSBbXTsK IGlmICgobmV3IERhdGUoMjAwOSwgOSwgMSkpLnRvU3RyaW5nKCkubWF0Y2goIlBEVCIpKSB7Ci0g ICAgdGVzdENhc2VzLnB1c2goWyIobmV3IERhdGUoMTk4MiwgMiwgMTQsIDIsIDEwKSkuZ2V0SG91 cnMoKSIsICIxIl0pOwotICAgIHRlc3RDYXNlcy5wdXNoKFsiKG5ldyBEYXRlKDE5ODIsIDIsIDE0 LCAyKSkuZ2V0SG91cnMoKSIsICIxIl0pOworICAgIHRlc3RDYXNlcy5wdXNoKFsiKG5ldyBEYXRl KDE5ODIsIDIsIDE0LCAyLCAxMCkpLmdldEhvdXJzKCkiLCAiMyJdKTsKKyAgICB0ZXN0Q2FzZXMu cHVzaChbIihuZXcgRGF0ZSgxOTgyLCAyLCAxNCwgMikpLmdldEhvdXJzKCkiLCAiMyJdKTsKICAg ICB0ZXN0Q2FzZXMucHVzaChbIihuZXcgRGF0ZSgxOTgyLCAxMSwgNywgMSwgMTApKS5nZXRUaW1l em9uZU9mZnNldCgpIiwgIjQ4MCJdKTsKICAgICB0ZXN0Q2FzZXMucHVzaChbIihuZXcgRGF0ZSgx OTgyLCAxMSwgNywgMSkpLmdldFRpbWV6b25lT2Zmc2V0KCkiLCAiNDgwIl0pOwogfQo=