116881 2013-05-28 12:41:06 -0700 [BlackBerry] Radio Button UX updates. 2013-05-29 10:47:14 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tijiang webkit-unassigned commit-queue oldest_to_newest 894463 0 tijiang 2013-05-28 12:41:06 -0700 Update Radio Button UX. 894473 1 203082 tijiang 2013-05-28 13:12:52 -0700 Created attachment 203082 Patch 895008 2 203082 rwlbuis 2013-05-29 10:26:19 -0700 Comment on attachment 203082 Patch LGTM. 895020 3 203082 commit-queue 2013-05-29 10:47:13 -0700 Comment on attachment 203082 Patch Clearing flags on attachment: 203082 Committed r150909: <http://trac.webkit.org/changeset/150909> 895021 4 commit-queue 2013-05-29 10:47:14 -0700 All reviewed patches have been landed. Closing bug. 203082 2013-05-28 13:12:52 -0700 2013-05-29 10:47:13 -0700 Patch bug-116881-20130528161116.patch text/plain 4334 tijiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI0N2JkYTQzMTEzMjdi ZGJhNGIwNTVlY2Q5NzRhYzJhYTA5ODlmZS4uMjFmNGZkNDljNjc2YzdkMGVjYjE3ZDgzYmVhMjk4 YTEyZjZlN2FjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTI4ICBUaWFu Y2hlbmcgSmlhbmcgIDx0aWppYW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFJh ZGlvIEJ1dHRvbiBVWCB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE2ODgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQmxhY2tCZXJyeSBQUiAzNDIzMjIuCisgICAgICAgIEludGVybmFsbHkg UmV2aWV3ZWQgYnkgSmVmZiBSb2dlcnMuCisgICAgICAgIENoYW5nZSBpbWFnZXMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUJsYWNrQmVycnk6OnBhaW50UmFkaW8pOgorCiAyMDEz LTA1LTI4ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb QmxhY2tCZXJyeV0gR3JhcGhpY3NDb250ZXh0OiBhZGQgbWlzc2luZyBkZWZpbml0aW9ucy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVC bGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVy VGhlbWVCbGFja0JlcnJ5LmNwcAppbmRleCBlM2RiZmVhZjc4YzkzYTMwNzRmNjNhYTJjZTUxMjUw MDQ0YmYxYjU1Li42NDgxODQ3YmUxZmMxZjZhZTNjNTk3ZDhkOWY1Y2I2YjZiOTZmODNlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxh Y2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5k ZXJUaGVtZUJsYWNrQmVycnkuY3BwCkBAIC00OTYsNDUgKzQ5Niw0MiBAQCBib29sIFJlbmRlclRo ZW1lQmxhY2tCZXJyeTo6cGFpbnRSYWRpbyhSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUGFp bnRJbmZvJiBpbgogICAgIEFTU0VSVChpbmZvLmNvbnRleHQpOwogICAgIEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCA9IGluZm8uY29udGV4dDsKIAotICAgIHN0YXRpYyBSZWZQdHI8SW1hZ2U+IGRp c2FibGVkLCBkaXNhYmxlZEFjdGl2ZSwgaW5hY3RpdmUsIHByZXNzZWQsIGFjdGl2ZSwgYWN0aXZl TWFyazsKKyAgICBzdGF0aWMgUmVmUHRyPEltYWdlPiBkaXNhYmxlZCwgZGlzYWJsZWREb3QsIGlu YWN0aXZlLCBwcmVzc2VkLCBhY3RpdmUsIGFjdGl2ZURvdCwgcHJlc3NlZERvdDsKICAgICBpZiAo IWRpc2FibGVkKSB7CiAgICAgICAgIGRpc2FibGVkID0gbG9hZEltYWdlKCJjb3JlX3JhZGlvYnV0 dG9uX2Rpc2FibGVkIik7Ci0gICAgICAgIGRpc2FibGVkQWN0aXZlID0gbG9hZEltYWdlKCJjb3Jl X3JhZGlvYnV0dG9uX2Rpc2FibGVkX2FjdGl2ZSIpOworICAgICAgICBkaXNhYmxlZERvdCA9IGxv YWRJbWFnZSgiY29yZV9yYWRpb2J1dHRvbl9kb3RfZGlzYWJsZWQiKTsKICAgICAgICAgaW5hY3Rp dmUgPSBsb2FkSW1hZ2UoImNvcmVfcmFkaW9idXR0b25faW5hY3RpdmUiKTsKICAgICAgICAgcHJl c3NlZCA9IGxvYWRJbWFnZSgiY29yZV9yYWRpb2J1dHRvbl9wcmVzc2VkIik7CiAgICAgICAgIGFj dGl2ZSA9IGxvYWRJbWFnZSgiY29yZV9yYWRpb2J1dHRvbl9hY3RpdmUiKTsKLSAgICAgICAgYWN0 aXZlTWFyayA9IGxvYWRJbWFnZSgiY29yZV9yYWRpb2J1dHRvbl9hY3RpdmVfbWFyayIpOworICAg ICAgICBhY3RpdmVEb3QgPSBsb2FkSW1hZ2UoImNvcmVfcmFkaW9idXR0b25fZG90X3NlbGVjdGVk Iik7CisgICAgICAgIHByZXNzZWREb3QgPSBsb2FkSW1hZ2UoImNvcmVfcmFkaW9idXR0b25fZG90 X3ByZXNzZWQiKTsKICAgICB9CiAKICAgICAvLyBDYWN1bGF0ZSB3aGVyZSB0byBwdXQgY2VudGVy IGNpcmNsZS4KICAgICBGbG9hdFJlY3QgdG1wUmVjdChyZWN0KTsKIAotICAgIGZsb2F0IGNlbnRl clggPSAoKGZsb2F0KGluYWN0aXZlLT53aWR0aCgpKSAtIGZsb2F0KGFjdGl2ZU1hcmstPndpZHRo KCkpKSAvIGZsb2F0KGluYWN0aXZlLT53aWR0aCgpKSAqIHRtcFJlY3Qud2lkdGgoKSAvIDIpKyB0 bXBSZWN0LngoKTsKLSAgICBmbG9hdCBjZW50ZXJZID0gKChmbG9hdChpbmFjdGl2ZS0+aGVpZ2h0 KCkpIC0gZmxvYXQoYWN0aXZlTWFyay0+aGVpZ2h0KCkpKSAvIGZsb2F0KGluYWN0aXZlLT5oZWln aHQoKSkgKiB0bXBSZWN0LmhlaWdodCgpIC8gMikgKyB0bXBSZWN0LnkoKTsKLSAgICBmbG9hdCB3 aWR0aCA9IGZsb2F0KGFjdGl2ZU1hcmstPndpZHRoKCkpIC8gZmxvYXQoaW5hY3RpdmUtPndpZHRo KCkpICogdG1wUmVjdC53aWR0aCgpOwotICAgIGZsb2F0IGhlaWdodCA9IGZsb2F0KGFjdGl2ZU1h cmstPmhlaWdodCgpKSAvIGZsb2F0KGluYWN0aXZlLT5oZWlnaHQoKSkgKiB0bXBSZWN0LmhlaWdo dCgpOworICAgIGZsb2F0IGNlbnRlclggPSAoKGZsb2F0KGluYWN0aXZlLT53aWR0aCgpKSAtIGZs b2F0KGFjdGl2ZURvdC0+d2lkdGgoKSkpIC8gZmxvYXQoaW5hY3RpdmUtPndpZHRoKCkpICogdG1w UmVjdC53aWR0aCgpIC8gMikrIHRtcFJlY3QueCgpOworICAgIGZsb2F0IGNlbnRlclkgPSAoKGZs b2F0KGluYWN0aXZlLT5oZWlnaHQoKSkgLSBmbG9hdChhY3RpdmVEb3QtPmhlaWdodCgpKSkgLyBm bG9hdChpbmFjdGl2ZS0+aGVpZ2h0KCkpICogdG1wUmVjdC5oZWlnaHQoKSAvIDIpICsgdG1wUmVj dC55KCk7CisgICAgZmxvYXQgd2lkdGggPSBmbG9hdChhY3RpdmVEb3QtPndpZHRoKCkpIC8gZmxv YXQoaW5hY3RpdmUtPndpZHRoKCkpICogdG1wUmVjdC53aWR0aCgpOworICAgIGZsb2F0IGhlaWdo dCA9IGZsb2F0KGFjdGl2ZURvdC0+aGVpZ2h0KCkpIC8gZmxvYXQoaW5hY3RpdmUtPmhlaWdodCgp KSAqIHRtcFJlY3QuaGVpZ2h0KCk7CiAgICAgRmxvYXRSZWN0IGNlbnRlclJlY3QoY2VudGVyWCwg Y2VudGVyWSwgd2lkdGgsIGhlaWdodCk7CiAKICAgICBpZiAoaXNFbmFibGVkKG9iamVjdCkpIHsK ICAgICAgICAgaWYgKGlzUHJlc3NlZChvYmplY3QpKSB7CiAgICAgICAgICAgICBkcmF3Q29udHJv bChjb250ZXh0LCByZWN0LCBwcmVzc2VkLmdldCgpKTsKLSAgICAgICAgICAgIGlmIChpc0NoZWNr ZWQob2JqZWN0KSkgewotICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBuZWVkIG9wYWNpdHkgMzAl IG9uIGFjdGl2ZU1hcmsKLSAgICAgICAgICAgICAgICBkcmF3Q29udHJvbChjb250ZXh0LCBjZW50 ZXJSZWN0LCBhY3RpdmVNYXJrLmdldCgpKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlm IChpc0NoZWNrZWQob2JqZWN0KSkKKyAgICAgICAgICAgICAgICBkcmF3Q29udHJvbChjb250ZXh0 LCBjZW50ZXJSZWN0LCBwcmVzc2VkRG90LmdldCgpKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgIGRyYXdDb250cm9sKGNvbnRleHQsIHJlY3QsIGluYWN0aXZlLmdldCgpKTsKICAgICAg ICAgICAgIGlmIChpc0NoZWNrZWQob2JqZWN0KSkgewogICAgICAgICAgICAgICAgIGRyYXdDb250 cm9sKGNvbnRleHQsIHJlY3QsIGFjdGl2ZS5nZXQoKSk7Ci0gICAgICAgICAgICAgICAgZHJhd0Nv bnRyb2woY29udGV4dCwgY2VudGVyUmVjdCwgYWN0aXZlTWFyay5nZXQoKSk7CisgICAgICAgICAg ICAgICAgZHJhd0NvbnRyb2woY29udGV4dCwgY2VudGVyUmVjdCwgYWN0aXZlRG90LmdldCgpKTsK ICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0gZWxzZSB7Ci0gICAgICAgIGRyYXdDb250 cm9sKGNvbnRleHQsIHJlY3QsIGluYWN0aXZlLmdldCgpKTsKKyAgICAgICAgZHJhd0NvbnRyb2wo Y29udGV4dCwgcmVjdCwgZGlzYWJsZWQuZ2V0KCkpOwogICAgICAgICBpZiAoaXNDaGVja2VkKG9i amVjdCkpCi0gICAgICAgICAgICBkcmF3Q29udHJvbChjb250ZXh0LCByZWN0LCBkaXNhYmxlZEFj dGl2ZS5nZXQoKSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGRyYXdDb250cm9sKGNvbnRl eHQsIHJlY3QsIGRpc2FibGVkLmdldCgpKTsKKyAgICAgICAgICAgIGRyYXdDb250cm9sKGNvbnRl eHQsIHJlY3QsIGRpc2FibGVkRG90LmdldCgpKTsKICAgICB9CiAgICAgcmV0dXJuIGZhbHNlOwog fQo=