116843 2013-05-27 14:04:29 -0700 [BlackBerry] Notify client of selection deletion 2013-05-29 11:39:16 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nghanavatian nghanavatian commit-queue rwlbuis xan.lopez oldest_to_newest 894155 0 nghanavatian 2013-05-27 14:04:29 -0700 Our change guard was preventing caret change notification to be sent to IMF. This put us out of state when a selection was deleted because it is not a simple single character deletion. Ensure that selection deletions always send a caret update 894366 1 203056 nghanavatian 2013-05-28 08:10:02 -0700 Created attachment 203056 Patch 894981 2 203056 rwlbuis 2013-05-29 09:34:20 -0700 Comment on attachment 203056 Patch Okay. 895100 3 203056 commit-queue 2013-05-29 11:39:15 -0700 Comment on attachment 203056 Patch Clearing flags on attachment: 203056 Committed r150914: <http://trac.webkit.org/changeset/150914> 895101 4 commit-queue 2013-05-29 11:39:16 -0700 All reviewed patches have been landed. Closing bug. 203056 2013-05-28 08:10:02 -0700 2013-05-29 11:39:14 -0700 Patch bug-116843-20130528110804.patch text/plain 4221 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0Y2MzOWEzZDA4ZWM1MzdmMmY2YTg4OTllMDVjODBiZTE4NjA5OTc0Li43YjU1OTZhOTgx ZWIyOGQ3YzIzZjU4N2RiMWVkNGU1YjIyNDlhYTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wNS0yMyAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkBibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gTm90aWZ5 IGNsaWVudCBvZiBzZWxlY3Rpb24gZGVsZXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjg0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50b24u CisKKyAgICAgICAgUFIzNDIxMDYKKyAgICAgICAgT3VyIGNoYW5nZSBndWFyZCB3YXMgcHJldmVu dGluZyBjYXJldCBjaGFuZ2Ugbm90aWZpY2F0aW9uIHRvIGJlIHNlbnQgdG8gSU1GLgorICAgICAg ICBUaGlzIHB1dCB1cyBvdXQgb2Ygc3RhdGUgd2hlbiBhIHNlbGVjdGlvbiB3YXMgZGVsZXRlZCBi ZWNhdXNlIGl0IGlzIG5vdCBhIHNpbXBsZQorICAgICAgICBzaW5nbGUgY2hhcmFjdGVyIGRlbGV0 aW9uLiBFbnN1cmUgdGhhdCBzZWxlY3Rpb24gZGVsZXRpb25zIGFsd2F5cyBzZW5kIGEgY2FyZXQK KyAgICAgICAgdXBkYXRlLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIu Y3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OmRlbGV0ZVNl bGVjdGlvbik6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6ZGVs ZXRlVGV4dFJlbGF0aXZlVG9DdXJzb3IpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJ bnB1dEhhbmRsZXI6OmRlbGV0ZVRleHQpOgorCiAyMDEzLTA1LTI3ICBOaW1hIEdoYW5hdmF0aWFu ICA8bmdoYW5hdmF0aWFuQGJsYWNrYmVycnkuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBD bGVhciBzdXByZXNzaW9uIGZsYWcgd2hlbiBjYXJldCBjaGFuZ2VzIGFyZW4ndCBwcm9wb2dhdGVk IHRocm91Z2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDY1NzQ3YTYyY2Q1Yzc3MTc3ZjJjMWQ4ZDkzMzZj MzUwOTZkZTk5MWYuLjg5YTQ3MmE1ZTAwOGE4NTFiOTE1MDBhZmQxNGU3MmExYzE0NWQ5ZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFu ZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5w dXRIYW5kbGVyLmNwcApAQCAtMTkwNiw3ICsxOTA2LDExIEBAIGJvb2wgSW5wdXRIYW5kbGVyOjpk ZWxldGVTZWxlY3Rpb24oKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBBU1NFUlQoZnJh bWUtPmVkaXRvcigpKTsKLSAgICByZXR1cm4gaGFuZGxlS2V5Ym9hcmRJbnB1dChQbGF0Zm9ybTo6 S2V5Ym9hcmRFdmVudChLRVlDT0RFX0JBQ0tTUEFDRSwgUGxhdGZvcm06OktleWJvYXJkRXZlbnQ6 OktleURvd24sIDApLCBmYWxzZSAvKiBjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uICovKTsKKyAg ICBpZiAoIWhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZlbnQoS0VZQ09E RV9CQUNLU1BBQ0UsIFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50OjpLZXlEb3duLCAwKSwgZmFsc2Ug LyogY2hhbmdlSXNQYXJ0T2ZDb21wb3NpdGlvbiAqLykpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIHNlbGVjdGlvbkNoYW5nZWQoKTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogdm9pZCBJ bnB1dEhhbmRsZXI6Omluc2VydFRleHQoY29uc3QgV1RGOjpTdHJpbmcmIHN0cmluZykKQEAgLTIy MDgsOCArMjIxMiw2IEBAIGJvb2wgSW5wdXRIYW5kbGVyOjpkZWxldGVUZXh0UmVsYXRpdmVUb0N1 cnNvcihpbnQgbGVmdE9mZnNldCwgaW50IHJpZ2h0T2Zmc2V0KQogICAgIGlmICghaXNBY3RpdmVU ZXh0RWRpdCgpIHx8IGNvbXBvc2l0aW9uQWN0aXZlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAotICAgIFByb2Nlc3NpbmdDaGFuZ2VHdWFyZCBndWFyZCh0aGlzKTsKLQogICAgIElucHV0TG9n KFBsYXRmb3JtOjpMb2dMZXZlbEluZm8sCiAgICAgICAgICJJbnB1dEhhbmRsZXI6OmRlbGV0ZVRl eHRSZWxhdGl2ZVRvQ3Vyc29yIGxlZnQgJWQgcmlnaHQgJWQiLAogICAgICAgICBsZWZ0T2Zmc2V0 LCByaWdodE9mZnNldCk7CkBAIC0yMjIwLDExICsyMjIyLDE2IEBAIGJvb2wgSW5wdXRIYW5kbGVy OjpkZWxldGVUZXh0UmVsYXRpdmVUb0N1cnNvcihpbnQgbGVmdE9mZnNldCwgaW50IHJpZ2h0T2Zm c2V0KQogCiAgICAgLy8gSWYgd2UgaGF2ZSBiYWNrc3BhY2UgaW4gYSBzaW5nbGUgY2hhcmFjdGVy LCBzZW5kIHRoaXMgdG8gd2Via2l0IGFzIGEgS2V5Ym9hcmRFdmVudC4gT3RoZXJ3aXNlLCBjYWxs IGRlbGV0ZVRleHQuCiAgICAgaWYgKGxlZnRPZmZzZXQgPT0gMSAmJiAhcmlnaHRPZmZzZXQpIHsK KyAgICAgICAgaWYgKHNlbGVjdGlvbkFjdGl2ZSgpKQorICAgICAgICAgICAgcmV0dXJuIGRlbGV0 ZVNlbGVjdGlvbigpOworCiAgICAgICAgIGlmICghaGFuZGxlS2V5Ym9hcmRJbnB1dChQbGF0Zm9y bTo6S2V5Ym9hcmRFdmVudChLRVlDT0RFX0JBQ0tTUEFDRSwgUGxhdGZvcm06OktleWJvYXJkRXZl bnQ6OktleURvd24sIDApLCB0cnVlIC8qIGNoYW5nZUlzUGFydE9mQ29tcG9zaXRpb24gKi8pKQog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0gZWxzZSBpZiAoIWRlbGV0ZVRleHQoc3Rh cnQsIGVuZCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIFByb2Nlc3NpbmdDaGFuZ2VH dWFyZCBndWFyZCh0aGlzKTsKKwogICAgIC8vIFNjcm9sbCB0aGUgZmllbGQgaWYgbmVjZXNzYXJ5 LiBUaGUgYXV0b21hdGljIHVwZGF0ZSBpcyBzdXBwcmVzc2VkCiAgICAgLy8gYnkgdGhlIHByb2Nl c3NpbmcgY2hhbmdlIGd1YXJkLgogICAgIGVuc3VyZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxlKEVk Z2VJZk5lZWRlZCk7CkBAIC0yMjM3LDEzICsyMjQ0LDE1IEBAIGJvb2wgSW5wdXRIYW5kbGVyOjpk ZWxldGVUZXh0KGludCBzdGFydCwgaW50IGVuZCkKICAgICBpZiAoIWlzQWN0aXZlVGV4dEVkaXQo KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgUHJvY2Vzc2luZ0NoYW5nZUd1YXJkIGd1 YXJkKHRoaXMpOworICAgIHsKKyAgICAgICAgUHJvY2Vzc2luZ0NoYW5nZUd1YXJkIGd1YXJkKHRo aXMpOwogCi0gICAgaWYgKGVuZCAtIHN0YXJ0ID09IDEpCi0gICAgICAgIHJldHVybiBoYW5kbGVL ZXlib2FyZElucHV0KFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50KEtFWUNPREVfQkFDS1NQQUNFLCBQ bGF0Zm9ybTo6S2V5Ym9hcmRFdmVudDo6S2V5RG93biwgMCksIHRydWUgLyogY2hhbmdlSXNQYXJ0 T2ZDb21wb3NpdGlvbiAqLyk7CisgICAgICAgIGlmIChlbmQgLSBzdGFydCA9PSAxKQorICAgICAg ICAgICAgcmV0dXJuIGhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZlbnQo S0VZQ09ERV9CQUNLU1BBQ0UsIFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50OjpLZXlEb3duLCAwKSwg dHJ1ZSAvKiBjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uICovKTsKIAotICAgIGlmICghc2V0U2Vs ZWN0aW9uKHN0YXJ0LCBlbmQsIHRydWUgLypjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uKi8pKQot ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGlmICghc2V0U2VsZWN0aW9uKHN0YXJ0LCBl bmQsIHRydWUgLypjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uKi8pKQorICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KIAogICAgIElucHV0TG9nKFBsYXRmb3JtOjpMb2dMZXZlbEluZm8s ICJJbnB1dEhhbmRsZXI6OmRlbGV0ZVRleHQgc3RhcnQgJWQgZW5kICVkIiwgc3RhcnQsIGVuZCk7 CiAK