116837 2013-05-27 11:00:01 -0700 [BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches 2013-05-27 12:26:53 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned commit-queue oldest_to_newest 894089 0 andchen 2013-05-27 11:00:01 -0700 Find-on-page should be able to convert the active match to selection when clearing all matches. 894106 1 202996 andchen 2013-05-27 11:44:02 -0700 Created attachment 202996 Patch 894109 2 202996 rwlbuis 2013-05-27 11:59:39 -0700 Comment on attachment 202996 Patch LGTM. 894117 3 202996 commit-queue 2013-05-27 12:26:50 -0700 Comment on attachment 202996 Patch Clearing flags on attachment: 202996 Committed r150770: <http://trac.webkit.org/changeset/150770> 894118 4 commit-queue 2013-05-27 12:26:53 -0700 All reviewed patches have been landed. Closing bug. 202996 2013-05-27 11:44:02 -0700 2013-05-27 12:26:50 -0700 Patch bug-116837-20130527144242.patch text/plain 7239 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzZDEyMWZkOGZiOTAxOTQxMTZhNjNhNDZhNTZhN2QxMmFlMTc4NWNiLi40NTYyODJhNzU2 MDcxZWRlMGNiNDEzMGYwNTFhZTAwNmRlYzUxZjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMy0wNS0yNyAgQW5keSBDaGVuICA8YW5kY2hlbkBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRmluZC1vbi1wYWdlIHNob3Vs ZCBiZSBhYmxlIHRvIGNvbnZlcnQgdGhlIGFjdGl2ZSBtYXRjaCB0byBzZWxlY3Rpb24gd2hlbiBj bGVhcmluZyBhbGwgbWF0Y2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE2ODM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUFIgMjkxOTAzCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlr ZSBGZW50b24uCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OmZpbmROZXh0U3RyaW5nKToKKyAgICAgICAgKiBBcGkvV2Vi UGFnZS5oOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHA6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkluUGFnZVNlYXJjaE1hbmFnZXI6OmZpbmRO ZXh0U3RyaW5nKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5QYWdlU2VhcmNoTWFu YWdlcjo6Y2xlYXJUZXh0TWF0Y2hlcyk6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JblBhZ2VT ZWFyY2hNYW5hZ2VyLmg6CisgICAgICAgIChJblBhZ2VTZWFyY2hNYW5hZ2VyKToKKwogMjAxMy0w NS0yNyAgRWxpIEZpZGxlciAgPGVmaWRsZXJAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gRml4IHN1YmZyYW1lIHRhcmdldCBhZGRlZCB0byBuZXcgcmVxdWVzdHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDhhMzEyODBlYTI3YjQ4NDJjMzBmM2Zi NTM0YmNkMDgzMmRkMjYwMjQuLjQ1MGI0ZDliNjkzYzE3NjcwMjVlNDQyY2EyZDdmZGJmMDI1ZDU2 MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNDcwOCw3 ICs0NzA4LDcgQEAgdm9pZCBXZWJQYWdlOjpzZXRGb2N1c2VkKGJvb2wgZm9jdXNlZCkKICAgICBm b2N1c0NvbnRyb2xsZXItPnNldEZvY3VzZWQoZm9jdXNlZCk7CiB9CiAKLWJvb2wgV2ViUGFnZTo6 ZmluZE5leHRTdHJpbmcoY29uc3QgY2hhciogdGV4dCwgYm9vbCBmb3J3YXJkLCBib29sIGNhc2VT ZW5zaXRpdmUsIGJvb2wgd3JhcCwgYm9vbCBoaWdobGlnaHRBbGxNYXRjaGVzKQorYm9vbCBXZWJQ YWdlOjpmaW5kTmV4dFN0cmluZyhjb25zdCBjaGFyKiB0ZXh0LCBib29sIGZvcndhcmQsIGJvb2wg Y2FzZVNlbnNpdGl2ZSwgYm9vbCB3cmFwLCBib29sIGhpZ2hsaWdodEFsbE1hdGNoZXMsIGJvb2wg c2VsZWN0QWN0aXZlTWF0Y2hPbkNsZWFyKQogewogICAgIFdlYkNvcmU6OkZpbmRPcHRpb25zIGZp bmRPcHRpb25zID0gV2ViQ29yZTo6U3RhcnRJblNlbGVjdGlvbjsKICAgICBpZiAoIWZvcndhcmQp CkBAIC00NzE5LDcgKzQ3MTksNyBAQCBib29sIFdlYlBhZ2U6OmZpbmROZXh0U3RyaW5nKGNvbnN0 IGNoYXIqIHRleHQsIGJvb2wgZm9yd2FyZCwgYm9vbCBjYXNlU2Vuc2l0aXZlLAogICAgIC8vIFRo ZSBXZWJDb3JlOjpGaW5kT3B0aW9uczo6V3JhcEFyb3VuZCBib29sZWFuIGFjdHVhbGx5IHdyYXBz IHRoZSBzZWFyY2gKICAgICAvLyB3aXRoaW4gdGhlIGN1cnJlbnQgZnJhbWUgYXMgb3Bwb3NlZCB0 byB0aGUgZW50aXJlIERvY3VtZW50LCBzbyB3ZSBoYXZlIHRvCiAgICAgLy8gcHJvdmlkZSBvdXIg b3duIHdyYXBwaW5nIGNvZGUgdG8gd3JhcCBhdCB0aGUgd2hvbGUgRG9jdW1lbnQgbGV2ZWwuCi0g ICAgcmV0dXJuIGQtPm1faW5QYWdlU2VhcmNoTWFuYWdlci0+ZmluZE5leHRTdHJpbmcoU3RyaW5n Ojpmcm9tVVRGOCh0ZXh0KSwgZmluZE9wdGlvbnMsIHdyYXAsIGhpZ2hsaWdodEFsbE1hdGNoZXMp OworICAgIHJldHVybiBkLT5tX2luUGFnZVNlYXJjaE1hbmFnZXItPmZpbmROZXh0U3RyaW5nKFN0 cmluZzo6ZnJvbVVURjgodGV4dCksIGZpbmRPcHRpb25zLCB3cmFwLCBoaWdobGlnaHRBbGxNYXRj aGVzLCBzZWxlY3RBY3RpdmVNYXRjaE9uQ2xlYXIpOwogfQogCiB2b2lkIFdlYlBhZ2U6OnJ1bkxh eW91dFRlc3RzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXggZTY5 ZTA2M2JmOGNjNWFlNjIzZTBjYTJkMDNiN2JkMmQ5MDgwMWJjYy4uMWZiMjcwZDBlMzU2ZjZmMGFl NWJiYzRlMzc4NWQ0Nzk0Nzk1OTk4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmgKQEAgLTIzMCw3ICsyMzAsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBGaW5kIHRoZSBuZXh0 IHV0Zjggc3RyaW5nIGluIHRoZSBnaXZlbiBkaXJlY3Rpb24uCiAgICAgLy8gQ2FzZSBzZW5zaXRp dml0eSwgd3JhcHBpbmcsIGFuZCBoaWdobGlnaHRpbmcgYWxsIG1hdGNoZXMgYXJlIGFsc28gdG9n Z2xlYWJsZS4KLSAgICBib29sIGZpbmROZXh0U3RyaW5nKGNvbnN0IGNoYXIqLCBib29sIGZvcndh cmQsIGJvb2wgY2FzZVNlbnNpdGl2ZSwgYm9vbCB3cmFwLCBib29sIGhpZ2hsaWdodEFsbE1hdGNo ZXMpOworICAgIGJvb2wgZmluZE5leHRTdHJpbmcoY29uc3QgY2hhciosIGJvb2wgZm9yd2FyZCwg Ym9vbCBjYXNlU2Vuc2l0aXZlLCBib29sIHdyYXAsIGJvb2wgaGlnaGxpZ2h0QWxsTWF0Y2hlcywg Ym9vbCBzZWxlY3RBY3RpdmVNYXRjaE9uQ2xlYXIpOwogCiAgICAgSlNHbG9iYWxDb250ZXh0UmVm IGdsb2JhbENvbnRleHQoKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcAppbmRl eCA0MDkxZGFlNmZjNjkyYWQwMDM0MzRiMzAyM2M1MDdkMDU3MTMzZDY2Li5lZDcwZmFjMDliZGI3 Yjc5YzYzNGQ4ZTM0MjU0MDE0MTczMTE4YmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNw cApAQCAtODQsMTMgKzg0LDEzIEBAIEluUGFnZVNlYXJjaE1hbmFnZXI6On5JblBhZ2VTZWFyY2hN YW5hZ2VyKCkKICAgICBjYW5jZWxQZW5kaW5nU2NvcGluZ0VmZm9ydCgpOwogfQogCi1ib29sIElu UGFnZVNlYXJjaE1hbmFnZXI6OmZpbmROZXh0U3RyaW5nKGNvbnN0IFN0cmluZyYgdGV4dCwgRmlu ZE9wdGlvbnMgZmluZE9wdGlvbnMsIGJvb2wgd3JhcCwgYm9vbCBoaWdobGlnaHRBbGxNYXRjaGVz KQorYm9vbCBJblBhZ2VTZWFyY2hNYW5hZ2VyOjpmaW5kTmV4dFN0cmluZyhjb25zdCBTdHJpbmcm IHRleHQsIEZpbmRPcHRpb25zIGZpbmRPcHRpb25zLCBib29sIHdyYXAsIGJvb2wgaGlnaGxpZ2h0 QWxsTWF0Y2hlcywgYm9vbCBzZWxlY3RBY3RpdmVNYXRjaE9uQ2xlYXIpCiB7CiAgICAgYm9vbCBo aWdobGlnaHRBbGxNYXRjaGVzU3RhdGVDaGFuZ2VkID0gbV9oaWdobGlnaHRBbGxNYXRjaGVzICE9 IGhpZ2hsaWdodEFsbE1hdGNoZXM7CiAgICAgbV9oaWdobGlnaHRBbGxNYXRjaGVzID0gaGlnaGxp Z2h0QWxsTWF0Y2hlczsKIAogICAgIGlmICghdGV4dC5sZW5ndGgoKSkgewotICAgICAgICBjbGVh clRleHRNYXRjaGVzKCk7CisgICAgICAgIGNsZWFyVGV4dE1hdGNoZXMoc2VsZWN0QWN0aXZlTWF0 Y2hPbkNsZWFyKTsKICAgICAgICAgY2FuY2VsUGVuZGluZ1Njb3BpbmdFZmZvcnQoKTsKICAgICAg ICAgbV9hY3RpdmVTZWFyY2hTdHJpbmcgPSBTdHJpbmcoKTsKICAgICAgICAgbV93ZWJQYWdlLT5t X2NsaWVudC0+dXBkYXRlRmluZFN0cmluZ1Jlc3VsdChtX2FjdGl2ZU1hdGNoQ291bnQsIG1fYWN0 aXZlTWF0Y2hJbmRleCk7CkBAIC0yMzEsOCArMjMxLDEyIEBAIGJvb2wgSW5QYWdlU2VhcmNoTWFu YWdlcjo6ZmluZEFuZE1hcmtUZXh0KGNvbnN0IFN0cmluZyYgdGV4dCwgUmFuZ2UqIHJhbmdlLCBG cmFtCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIEluUGFnZVNlYXJjaE1hbmFnZXI6OmNs ZWFyVGV4dE1hdGNoZXMoKQordm9pZCBJblBhZ2VTZWFyY2hNYW5hZ2VyOjpjbGVhclRleHRNYXRj aGVzKGJvb2wgc2VsZWN0QWN0aXZlTWF0Y2hPbkNsZWFyKQogeworICAgIGlmIChzZWxlY3RBY3Rp dmVNYXRjaE9uQ2xlYXIgJiYgbV9hY3RpdmVNYXRjaC5nZXQoKSkgeworICAgICAgICBWaXNpYmxl U2VsZWN0aW9uIHNlbGVjdGlvbihtX2FjdGl2ZU1hdGNoLmdldCgpKTsKKyAgICAgICAgbV9hY3Rp dmVNYXRjaC0+b3duZXJEb2N1bWVudCgpLT5mcmFtZSgpLT5zZWxlY3Rpb24oKS0+c2V0U2VsZWN0 aW9uKHNlbGVjdGlvbik7CisgICAgfQogICAgIG1fd2ViUGFnZS0+bV9wYWdlLT51bm1hcmtBbGxU ZXh0TWF0Y2hlcygpOwogICAgIG1fYWN0aXZlTWF0Y2ggPSAwOwogICAgIG1fYWN0aXZlTWF0Y2hD b3VudCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmgKaW5kZXggNDIxZGQyYzJhNTBmMWFjNjRk NjNjNDA0NDAyNjVkMTBiOTQ1OTBkOC4uNjQ0NjU5M2IzYzFkMWU0Yzc3YzFlODI0OTcxNjU1ZWQ2 MmFkODZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvSW5QYWdlU2VhcmNoTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L0luUGFnZVNlYXJjaE1hbmFnZXIuaApAQCAtMzksMTQgKzM5LDE0IEBAIHB1 YmxpYzoKICAgICBJblBhZ2VTZWFyY2hNYW5hZ2VyKFdlYlBhZ2VQcml2YXRlKik7CiAgICAgfklu UGFnZVNlYXJjaE1hbmFnZXIoKTsKIAotICAgIGJvb2wgZmluZE5leHRTdHJpbmcoY29uc3QgU3Ry aW5nJiwgV2ViQ29yZTo6RmluZE9wdGlvbnMsIGJvb2wgd3JhcCwgYm9vbCBoaWdobGlnaHRBbGxN YXRjaGVzKTsKKyAgICBib29sIGZpbmROZXh0U3RyaW5nKGNvbnN0IFN0cmluZyYsIFdlYkNvcmU6 OkZpbmRPcHRpb25zLCBib29sIHdyYXAsIGJvb2wgaGlnaGxpZ2h0QWxsTWF0Y2hlcywgYm9vbCBz ZWxlY3RBY3RpdmVNYXRjaE9uQ2xlYXIpOwogICAgIHZvaWQgZnJhbWVVbmxvYWRlZChjb25zdCBX ZWJDb3JlOjpGcmFtZSopOwogCiBwcml2YXRlOgogICAgIGNsYXNzIERlZmVycmVkU2NvcGVTdHJp bmdNYXRjaGVzOwogICAgIGZyaWVuZCBjbGFzcyBEZWZlcnJlZFNjb3BlU3RyaW5nTWF0Y2hlczsK IAotICAgIHZvaWQgY2xlYXJUZXh0TWF0Y2hlcygpOworICAgIHZvaWQgY2xlYXJUZXh0TWF0Y2hl cyhib29sIHNlbGVjdEFjdGl2ZU1hdGNoT25DbGVhciA9IGZhbHNlKTsKICAgICB2b2lkIHNldEFj dGl2ZU1hdGNoQW5kTWFya2VyKFBhc3NSZWZQdHI8V2ViQ29yZTo6UmFuZ2U+KTsKICAgICBib29s IGZpbmRBbmRNYXJrVGV4dChjb25zdCBTdHJpbmcmLCBXZWJDb3JlOjpSYW5nZSosIFdlYkNvcmU6 OkZyYW1lKiwgY29uc3QgV2ViQ29yZTo6RmluZE9wdGlvbnMmLCBib29sIC8qIGlzTmV3U2VhcmNo ICovLCBib29sIC8qIHN0YXJ0RnJvbVNlbGVjdGlvbiAqLyk7CiAgICAgYm9vbCBzaG91bGRTZWFy Y2hGb3JUZXh0KGNvbnN0IFN0cmluZyYpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvYmxhY2tiZXJyeS9UZXN0UnVubmVyQmxhY2tCZXJyeS5jcHAgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9ibGFja2JlcnJ5L1Rlc3RSdW5uZXJCbGFja0JlcnJ5LmNwcAppbmRleCA4NmViNWEyNDFm ZjkzZWVmNDRjN2JjMWUyZGUzZDVkNzlmMzg5MmViLi4wNGEyMTVlNzVmZGFjODYzYzEwNjU5YzZm YjQ3YTU4NmNlZjY5NTg5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2Jl cnJ5L1Rlc3RSdW5uZXJCbGFja0JlcnJ5LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9i bGFja2JlcnJ5L1Rlc3RSdW5uZXJCbGFja0JlcnJ5LmNwcApAQCAtNjE3LDcgKzYxNyw3IEBAIGJv b2wgVGVzdFJ1bm5lcjo6ZmluZFN0cmluZyhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNTdHJpbmdS ZWYgdGFyZ2V0LCBKU09iamVjdFJlCiAKICAgICAvLyBPdXIgbGF5b3V0IHRlc3RzIGFzc3VtZSBm aW5kIHdpbGwgd3JhcCBhbmQgaGlnaGxpZ2h0IGFsbCBtYXRjaGVzLgogICAgIEJsYWNrQmVycnk6 OldlYktpdDo6RHVtcFJlbmRlclRyZWU6OmN1cnJlbnRJbnN0YW5jZSgpLT5wYWdlKCktPmZpbmRO ZXh0U3RyaW5nKG5hbWVTdHIudXRmOCgpLmRhdGEoKSwKLSAgICAgICAgIShvcHRpb25zICYgV2Vi Q29yZTo6QmFja3dhcmRzKSwgIShvcHRpb25zICYgV2ViQ29yZTo6Q2FzZUluc2Vuc2l0aXZlKSwg dHJ1ZSAvKiB3cmFwICovLCB0cnVlIC8qIGhpZ2hsaWdodEFsbE1hdGNoZXMgKi8pOworICAgICAg ICAhKG9wdGlvbnMgJiBXZWJDb3JlOjpCYWNrd2FyZHMpLCAhKG9wdGlvbnMgJiBXZWJDb3JlOjpD YXNlSW5zZW5zaXRpdmUpLCB0cnVlIC8qIHdyYXAgKi8sIHRydWUgLyogaGlnaGxpZ2h0QWxsTWF0 Y2hlcyAqLywgZmFsc2UgLyogc2VsZWN0QWN0aXZlTWF0Y2hPbkNsZWFyICovKTsKIAogICAgIHJl dHVybiBtYWluRnJhbWUtPnBhZ2UoKS0+ZmluZFN0cmluZyhuYW1lU3RyLCBvcHRpb25zKTsKIH0K