116805 2013-05-26 23:30:33 -0700 Remove redundant CachedRawResource::loader() 2013-05-27 01:20:07 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei abarth commit-queue japhet rwlbuis staikos oldest_to_newest 893895 0 charles.wei 2013-05-26 23:30:33 -0700 CachedRawResource has a member function: CachedRawResource::loader(), which is introduced by the patch for: https://bugs.webkit.org/show_bug.cgi?id=99864. The base class of CachedRawResource, CachedResource, has the same member function an they return the same loader hosted by CachedResource. So the CachedRawResource::loader() is redundant and should be removed. 893896 1 202953 charles.wei 2013-05-26 23:38:33 -0700 Created attachment 202953 Patch 893899 2 202953 kling 2013-05-26 23:58:42 -0700 Comment on attachment 202953 Patch r=me 893910 3 202953 commit-queue 2013-05-27 01:20:04 -0700 Comment on attachment 202953 Patch Clearing flags on attachment: 202953 Committed r150738: <http://trac.webkit.org/changeset/150738> 893911 4 commit-queue 2013-05-27 01:20:07 -0700 All reviewed patches have been landed. Closing bug. 202953 2013-05-26 23:38:33 -0700 2013-05-27 01:20:04 -0700 Patch bug-116805-20130527143713.patch text/plain 1993 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDg0MjJlNGZjOGZmMzUz YTBmYWI4NmM5MzUwZDRhZDNkNzAwMmMxNC4uZmVmN2QwYjQ4YzEzNTQzYzA1ZDY5MzhkY2Y1OTMw ZmJkNzhjZjJjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTI2ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBSZW1v dmUgcmVkdW5kYW50IENhY2hlZFJhd1Jlc291cmNlOjpsb2FkZXIoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2ODA1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCByZW1vdmUgcmVkdW5kYW50IGNv ZGUsIG5vIHRlc3QgY2FzZSBuZWVkZWQuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVk UmF3UmVzb3VyY2UuY3BwOgorICAgICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJj ZS5oOgorCiAyMDEzLTA1LTI2ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4K IAogICAgICAgICBSZW1vdmUgYSBsZWZ0b3ZlciBDQUxFTkRBUl9QSUNLRVIgZnJvbSBMb2NhbGVO b25lLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJh d1Jlc291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNv dXJjZS5jcHAKaW5kZXggY2FmNDVjY2M1NGRmMjFjOTBhZjIyODUxNTc5YjJiYjU3MGFiODgzZC4u MDAxNmRlMjhiYTAxN2YxNDNlZDY5Zjc5MTIyYWZhNDA1YWEwOTVjYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2UuY3BwCkBAIC0yMjQsMTEg KzIyNCw2IEBAIGJvb2wgQ2FjaGVkUmF3UmVzb3VyY2U6OmNhblJldXNlKGNvbnN0IFJlc291cmNl UmVxdWVzdCYgbmV3UmVxdWVzdCkgY29uc3QKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotU3VicmVz b3VyY2VMb2FkZXIqIENhY2hlZFJhd1Jlc291cmNlOjpsb2FkZXIoKSBjb25zdAotewotICAgIHJl dHVybiBtX2xvYWRlci5nZXQoKTsKLX0KLQogdm9pZCBDYWNoZWRSYXdSZXNvdXJjZTo6Y2xlYXIo KQogewogICAgIG1fZGF0YS5jbGVhcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2Fj aGUvQ2FjaGVkUmF3UmVzb3VyY2UuaAppbmRleCBhZTA1MzRmZDZjOTE4ZDE0MzU3Yzc0NWNmN2U5 YzYwMGZmYTA4ODZmLi42MDEzOWFhMTMzZmVlNjZlOGEzODRkNjY4ZGE3OTliMTY0OWZhYzMwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2Uu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2UuaApA QCAtNDQsNyArNDQsNiBAQCBwdWJsaWM6CiAgICAgLy8gRklYTUU6IFRoaXMgaXMgZXhwb3NlZCBm b3IgdGhlIElucHNlY3Rvckluc3RydW1lbnRhdGlvbiBmb3IgcHJlZmxpZ2h0cyBpbiBEb2N1bWVu dFRocmVhZGFibGVMb2FkZXIuIEl0J3MgYWxzbyByZWFsbHkgbGFtZS4KICAgICB1bnNpZ25lZCBs b25nIGlkZW50aWZpZXIoKSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXI7IH0KIAotICAgIFN1 YnJlc291cmNlTG9hZGVyKiBsb2FkZXIoKSBjb25zdDsKICAgICB2b2lkIGNsZWFyKCk7CiAKICAg ICB2aXJ0dWFsIGJvb2wgY2FuUmV1c2UoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JikgY29uc3Q7Cg==