116799 2013-05-26 16:11:49 -0700 Plugins with no src but valid type should not snapshot 2013-05-26 18:46:03 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue esprehn+autocc jonlee thorton oldest_to_newest 893822 0 dino 2013-05-26 16:11:49 -0700 There are a few plugins in the wild that don't take any src attribute - they simply load the plugin from the mime type. Google Hangouts is an example. 893823 1 202933 dino 2013-05-26 16:15:27 -0700 Created attachment 202933 Patch 893826 2 dino 2013-05-26 16:19:32 -0700 <rdar://problem/13695911> 893850 3 202933 darin 2013-05-26 18:02:58 -0700 Comment on attachment 202933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202933&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:649 > + if ((m_loadedUrl.isNull() || m_loadedUrl.isEmpty()) && !loadedMimeType().isEmpty()) { No need to write (m_loadedUrl.isNull() || m_loadedUrl.isEmpty()); that’s the same as m_loadedUrl.isEmpty(). 893872 4 dino 2013-05-26 18:46:03 -0700 Committed r150731: <http://trac.webkit.org/changeset/150731> 202933 2013-05-26 16:15:27 -0700 2013-05-26 18:02:58 -0700 Patch bug-116799-20130527091408.patch text/plain 3167 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRhOGVlMTllOWM0ZTc2 Y2ZlOTA0ZmEyMTg4NmZlOTQ1MzE2NjUwOS4uYjRkZTZkMWJmMTEzODVlODI5ZTMzODYxYjZkZDc5 NDExYjliZmIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTI2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBQbHVnaW5zIHdpdGggbm8gc3Jj IGJ1dCB2YWxpZCB0eXBlIHNob3VsZCBub3Qgc25hcHNob3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjc5OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBhIGZldyBwbHVnLWlucyBhcm91 bmQgdGhhdCBkb24ndCB0YWtlIGFueSBzb3VyY2UgY29udGVudAorICAgICAgICB2aWEgdGhlIHNy YyBhdHRyaWJ1dGUsIGJ1dCByYXRoZXIganVzdCBsb2FkIHRoZSBiaW5hcnkgYmFzZWQgb24gdGhl CisgICAgICAgIG1pbWUtdHlwZS4gSW4gdGhvc2UgY2FzZXMgd2Ugc2hvdWxkbid0IHNuYXBzaG90 IHVudGlsIHdlIGhhdmUgYQorICAgICAgICBtZWNoYW5pc20gdG8gZG8gc28uCisKKyAgICAgICAg KiBodG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TFBsdWdJbkltYWdlRWxlbWVudDo6c3ViZnJhbWVMb2FkZXJXaWxsQ3JlYXRlUGx1Z0luKToKKyAg ICAgICAgICAgIEFkZCBNSU1FVHlwZSBsb2dnaW5nLCBhbmQgZGV0ZWN0IHRoZSBjYXNlIG9mIG5v IHNyYyBidXQgdmFsaWQgdHlwZS4KKyAgICAgICAgKiBodG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1l bnQuaDogQWRkIGFub3RoZXIgU25hcHNob3RSZWFzb24gZW51bSBmb3IKKyAgICAgICAgICAgIHRo aXMgc3BlY2lhbCBjYXNlLgorCiAyMDEzLTA1LTI2ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRm9udEZhbWlseS5oLy5jcHAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCmluZGV4IDQ5MjkwMjViNDlj ZTAzNzQ0YWNmZWFlMmJkZDYxM2M2ZDNmMmFjOGUuLjc2NjE3MmZlMGVkOWQ0YjgxN2ZmNTAyOGFj NTI4ODExOTM2Y2Y0ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJ bkltYWdlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1h Z2VFbGVtZW50LmNwcApAQCAtNTc3LDcgKzU3Nyw4IEBAIHZvaWQgSFRNTFBsdWdJbkltYWdlRWxl bWVudDo6Y2hlY2tTaXplQ2hhbmdlRm9yU25hcHNob3R0aW5nKCkKIHZvaWQgSFRNTFBsdWdJbklt YWdlRWxlbWVudDo6c3ViZnJhbWVMb2FkZXJXaWxsQ3JlYXRlUGx1Z0luKGNvbnN0IEtVUkwmIHVy bCkKIHsKICAgICBMT0coUGx1Z2lucywgIiVwIFBsdWctaW4gVVJMOiAlcyIsIHRoaXMsIG1fdXJs LnV0ZjgoKS5kYXRhKCkpOwotICAgIExPRyhQbHVnaW5zLCAiICAgTG9hZGVkIFVSTDogJXMiLCB1 cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisgICAgTE9HKFBsdWdpbnMsICIgICBBY3R1YWwg VVJMOiAlcyIsIHVybC5zdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBMT0coUGx1Z2lucywg IiAgIE1JTUUgdHlwZTogJXMiLCBsb2FkZWRNaW1lVHlwZSgpLnV0ZjgoKS5kYXRhKCkpOwogCiAg ICAgbV9sb2FkZWRVcmwgPSB1cmw7CiAgICAgbV9wbHVnSW5XYXNDcmVhdGVkID0gZmFsc2U7CkBA IC02NDUsNiArNjQ2LDEyIEBAIHZvaWQgSFRNTFBsdWdJbkltYWdlRWxlbWVudDo6c3ViZnJhbWVM b2FkZXJXaWxsQ3JlYXRlUGx1Z0luKGNvbnN0IEtVUkwmIHVybCkKICAgICAgICAgcmV0dXJuOwog ICAgIH0KIAorICAgIGlmICgobV9sb2FkZWRVcmwuaXNOdWxsKCkgfHwgbV9sb2FkZWRVcmwuaXNF bXB0eSgpKSAmJiAhbG9hZGVkTWltZVR5cGUoKS5pc0VtcHR5KCkpIHsKKyAgICAgICAgTE9HKFBs dWdpbnMsICIlcCBQbHVnLWluIGhhcyBubyBzcmMgVVJMIGJ1dCBkb2VzIGhhdmUgYSB2YWxpZCBt aW1lIHR5cGUgJXMsIHNldCB0byBwbGF5IiwgdGhpcywgbG9hZGVkTWltZVR5cGUoKS51dGY4KCku ZGF0YSgpKTsKKyAgICAgICAgbV9zbmFwc2hvdERlY2lzaW9uID0gTWF5U25hcHNob3RXaGVuQ29u dGVudElzU2V0OworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgUmVuZGVyQm94KiByZW5k ZXJFbWJlZGRlZE9iamVjdCA9IHRvUmVuZGVyQm94KHJlbmRlcmVyKCkpOwogICAgIExlbmd0aCBz dHlsZVdpZHRoID0gcmVuZGVyRW1iZWRkZWRPYmplY3QtPnN0eWxlKCktPndpZHRoKCk7CiAgICAg TGVuZ3RoIHN0eWxlSGVpZ2h0ID0gcmVuZGVyRW1iZWRkZWRPYmplY3QtPnN0eWxlKCktPmhlaWdo dCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVt ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuaAppbmRl eCA0ZjlhZTViYjFhN2U3NmVjMzg1NTAzNjkzNzBjYzIzYzdlMzJiN2ExLi4yYWU2NzM0MDg2YzEy OTUzMWRiNmYwZmNjNDQxYmZkN2YxZGE3YmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxQbHVnSW5JbWFnZUVsZW1lbnQuaApAQCAtOTQsNyArOTQsOCBAQCBwdWJsaWM6CiAgICAgICAg IFNuYXBzaG90Tm90WWV0RGVjaWRlZCwKICAgICAgICAgTmV2ZXJTbmFwc2hvdCwKICAgICAgICAg U25hcHNob3R0ZWQsCi0gICAgICAgIE1heVNuYXBzaG90V2hlblJlc2l6ZWQKKyAgICAgICAgTWF5 U25hcHNob3RXaGVuUmVzaXplZCwKKyAgICAgICAgTWF5U25hcHNob3RXaGVuQ29udGVudElzU2V0 CiAgICAgfTsKICAgICBTbmFwc2hvdERlY2lzaW9uIHNuYXBzaG90RGVjaXNpb24oKSBjb25zdCB7 IHJldHVybiBtX3NuYXBzaG90RGVjaXNpb247IH0KIAo=