116765 2013-05-25 12:29:42 -0700 Path: clean up addPathForRoundedRect() 2013-05-25 17:50:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned commit-queue xan.lopez oldest_to_newest 893631 0 berto 2013-05-25 12:29:42 -0700 The current implementation of Path::addPathForRoundedRect() is a bit confusing and redundant if (preferBezier) { bezier(); return; } #if CG || BLACKBERRY native(); #else bezier(); #fi I would suggest something like #if CG || BLACKBERRY if (preferNative) { native(); return; } #endif bezier(); 893632 1 202891 berto 2013-05-25 12:35:17 -0700 Created attachment 202891 Patch Here's the patch. The only reason why I put the #ifdef inside the if() block is to avoid a "unused parameter: strategy" warning. 893665 2 202891 commit-queue 2013-05-25 17:50:44 -0700 Comment on attachment 202891 Patch Clearing flags on attachment: 202891 Committed r150696: <http://trac.webkit.org/changeset/150696> 893666 3 commit-queue 2013-05-25 17:50:46 -0700 All reviewed patches have been landed. Closing bug. 202891 2013-05-25 12:35:17 -0700 2013-05-25 17:50:44 -0700 Patch 116765.diff text/plain 1971 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNWZmMmZlLi4yNmVjMmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDUtMjUgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFBhdGg6IGNsZWFuIHVwIGFkZFBhdGhGb3JSb3VuZGVkUmVjdCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY3NjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW9yZ2FuaXplIGNvZGUgdGhh dCBpcyBhIGJpdCByZWR1bmRhbnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlv ciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBhdGg6OmFkZFBhdGhGb3JSb3VuZGVkUmVjdCk6CisKIDIwMTMtMDUtMjUg IEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgTm9kZTo6 aXNLZXlib2FyZEZvY3VzYWJsZSgpIHRvIEVsZW1lbnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1BhdGguY3BwCmluZGV4IDgwMzI5MmIuLmQ2NmFkNTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwCkBAIC0xNDUsMTYgKzE0NSwxNCBAQCB2b2lk IFBhdGg6OmFkZFJvdW5kZWRSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCwgY29uc3QgRmxvYXRT aXplJiB0b3BMZWZ0UmFkaXVzLAogCiB2b2lkIFBhdGg6OmFkZFBhdGhGb3JSb3VuZGVkUmVjdChj b25zdCBGbG9hdFJlY3QmIHJlY3QsIGNvbnN0IEZsb2F0U2l6ZSYgdG9wTGVmdFJhZGl1cywgY29u c3QgRmxvYXRTaXplJiB0b3BSaWdodFJhZGl1cywgY29uc3QgRmxvYXRTaXplJiBib3R0b21MZWZ0 UmFkaXVzLCBjb25zdCBGbG9hdFNpemUmIGJvdHRvbVJpZ2h0UmFkaXVzLCBSb3VuZGVkUmVjdFN0 cmF0ZWd5IHN0cmF0ZWd5KQogewotICAgIGlmIChzdHJhdGVneSA9PSBQcmVmZXJCZXppZXJSb3Vu ZGVkUmVjdCkgewotICAgICAgICBhZGRCZXppZXJzRm9yUm91bmRlZFJlY3QocmVjdCwgdG9wTGVm dFJhZGl1cywgdG9wUmlnaHRSYWRpdXMsIGJvdHRvbUxlZnRSYWRpdXMsIGJvdHRvbVJpZ2h0UmFk aXVzKTsKKyAgICBpZiAoc3RyYXRlZ3kgPT0gUHJlZmVyTmF0aXZlUm91bmRlZFJlY3QpIHsKKyNp ZiBVU0UoQ0cpIHx8IFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgICAgIHBsYXRmb3JtQWRkUGF0 aEZvclJvdW5kZWRSZWN0KHJlY3QsIHRvcExlZnRSYWRpdXMsIHRvcFJpZ2h0UmFkaXVzLCBib3R0 b21MZWZ0UmFkaXVzLCBib3R0b21SaWdodFJhZGl1cyk7CiAgICAgICAgIHJldHVybjsKKyNlbmRp ZgogICAgIH0KIAotI2lmIFVTRShDRykgfHwgUExBVEZPUk0oQkxBQ0tCRVJSWSkKLSAgICBwbGF0 Zm9ybUFkZFBhdGhGb3JSb3VuZGVkUmVjdChyZWN0LCB0b3BMZWZ0UmFkaXVzLCB0b3BSaWdodFJh ZGl1cywgYm90dG9tTGVmdFJhZGl1cywgYm90dG9tUmlnaHRSYWRpdXMpOwotI2Vsc2UKICAgICBh ZGRCZXppZXJzRm9yUm91bmRlZFJlY3QocmVjdCwgdG9wTGVmdFJhZGl1cywgdG9wUmlnaHRSYWRp dXMsIGJvdHRvbUxlZnRSYWRpdXMsIGJvdHRvbVJpZ2h0UmFkaXVzKTsKLSNlbmRpZgogfQogCiAv LyBBcHByb3hpbWF0aW9uIG9mIGNvbnRyb2wgcG9pbnQgcG9zaXRpb25zIG9uIGEgYmV6aWVyIHRv IHNpbXVsYXRlIGEgcXVhcnRlciBvZiBhIGNpcmNsZS4K