116756 2013-05-24 22:40:06 -0700 AX: WKView is unable to set AXFocused to YES and does not handle keyboard events as expected 2013-05-28 14:47:57 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jdiggs mario thorton oldest_to_newest 893565 0 cfleizach 2013-05-24 22:40:06 -0700 It appears that if AXFocused is set to YES on a web view that accepts text editing, the WebView does not become the first responder 893566 1 202875 cfleizach 2013-05-24 22:45:37 -0700 Created attachment 202875 patch 893567 2 cfleizach 2013-05-24 22:46:37 -0700 rdar://13925131 894502 3 202875 thorton 2013-05-28 14:10:07 -0700 Comment on attachment 202875 patch View in context: https://bugs.webkit.org/attachment.cgi?id=202875&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3051 > + bool focus = [number intValue] != 0; NSNumber has boolValue... > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3058 > + page->chrome().client()->focus(); Could grab the chrome client in a local and reuse it on these three lines. 894533 4 cfleizach 2013-05-28 14:47:57 -0700 http://trac.webkit.org/changeset/150836 202875 2013-05-24 22:45:37 -0700 2013-05-28 14:10:07 -0700 patch patch text/plain 2678 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDY4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTI0ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdLVmlldyBpcyB1 bmFibGUgdG8gc2V0IEFYRm9jdXNlZCB0byBZRVMgYW5kIGRvZXMgbm90IGhhbmRsZSBrZXlib2Fy ZCBldmVudHMgYXMgZXhwZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNjc1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIEFYRm9jdXNlZCBpcyBzZXQgdG8gdHJ1ZSwgYnV0IHRoZSBXZWJWaWV3 IGlzIG5vdCB0aGUgZmlyc3QgcmVzcG9uZGVyLCB0aGVuIHRoZSBjYWxsIHdpbGwKKyAgICAgICAg bm90IGRvIGFueXRoaW5nLiBUaGlzIGNoYW5nZSBhc2tzIHRoZSBDaHJvbWUgdG8gbWFrZSB0aGUg V2ViVmlldyB0aGUgZmlyc3QgcmVzcG9uZGVyIGJlZm9yZQorICAgICAgICB0cnlpbmcgdG8gc2V0 IGZvY3VzIHdpdGhpbiB0aGUgcGFnZS4KKworICAgICAgICBXYXMgbm90IGFibGUgdG8gbWFrZSBh IHRlc3QsIGl0IHJlcXVpcmVzIG9uIGludGVycGxheSBiZXR3ZWVuIGFyZWFzIG91dHNpZGUgdGhl IHdlYiB2aWV3LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIGFjY2Vzc2liaWxpdHlTZXRWYWx1ZTpmb3JBdHRyaWJ1dGU6XSk6CisKIDIwMTMtMDUt MjQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4 IGFmdGVyIHIxNTA2NjQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1h Yy5tbQkocmV2aXNpb24gMTUwNjcwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9t YWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAg LTMwNDcsNyArMzA0NywyMyBAQAogICAgICAgICBtX29iamVjdC0+c2V0U2VsZWN0ZWRWaXNpYmxl UG9zaXRpb25SYW5nZShbc2VsZiB2aXNpYmxlUG9zaXRpb25SYW5nZUZvclRleHRNYXJrZXJSYW5n ZTp0ZXh0TWFya2VyUmFuZ2VdKTsKICAgICB9IGVsc2UgaWYgKFthdHRyaWJ1dGVOYW1lIGlzRXF1 YWxUb1N0cmluZzogTlNBY2Nlc3NpYmlsaXR5Rm9jdXNlZEF0dHJpYnV0ZV0pIHsKICAgICAgICAg QVNTRVJUKG51bWJlcik7Ci0gICAgICAgIG1fb2JqZWN0LT5zZXRGb2N1c2VkKFtudW1iZXIgaW50 VmFsdWVdICE9IDApOworICAgICAgICAKKyAgICAgICAgYm9vbCBmb2N1cyA9IFtudW1iZXIgaW50 VmFsdWVdICE9IDA7CisgICAgICAgIAorICAgICAgICAvLyBJZiBmb2N1cyBpcyBqdXN0IHNldCB3 aXRob3V0IG1ha2luZyB0aGUgdmlldyB0aGUgZmlyc3QgcmVzcG9uZGVyLCB0aGVuIGtleWJvYXJk IGZvY3VzIHdvbid0IG1vdmUgdG8gdGhlIHJpZ2h0IHBsYWNlLgorICAgICAgICBpZiAoZm9jdXMg JiYgbV9vYmplY3QtPmlzV2ViQXJlYSgpICYmICFtX29iamVjdC0+ZG9jdW1lbnQoKS0+ZnJhbWUo KS0+c2VsZWN0aW9uKCktPmlzRm9jdXNlZEFuZEFjdGl2ZSgpKSB7CisgICAgICAgICAgICBGcmFt ZVZpZXcqIGZyYW1lVmlldyA9IG1fb2JqZWN0LT5kb2N1bWVudEZyYW1lVmlldygpOworICAgICAg ICAgICAgUGFnZSogcGFnZSA9IG1fb2JqZWN0LT5wYWdlKCk7CisgICAgICAgICAgICBpZiAocGFn ZSAmJiBmcmFtZVZpZXcpIHsKKyAgICAgICAgICAgICAgICBwYWdlLT5jaHJvbWUoKS5jbGllbnQo KS0+Zm9jdXMoKTsKKyAgICAgICAgICAgICAgICBpZiAoZnJhbWVWaWV3LT5wbGF0Zm9ybVdpZGdl dCgpKQorICAgICAgICAgICAgICAgICAgICBwYWdlLT5jaHJvbWUoKS5jbGllbnQoKS0+bWFrZUZp cnN0UmVzcG9uZGVyKGZyYW1lVmlldy0+cGxhdGZvcm1XaWRnZXQoKSk7CisgICAgICAgICAgICAg ICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBwYWdlLT5jaHJvbWUoKS5jbGllbnQoKS0+bWFr ZUZpcnN0UmVzcG9uZGVyKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgCisg ICAgICAgIG1fb2JqZWN0LT5zZXRGb2N1c2VkKGZvY3VzKTsKICAgICB9IGVsc2UgaWYgKFthdHRy aWJ1dGVOYW1lIGlzRXF1YWxUb1N0cmluZzogTlNBY2Nlc3NpYmlsaXR5VmFsdWVBdHRyaWJ1dGVd KSB7CiAgICAgICAgIGlmIChudW1iZXIgJiYgbV9vYmplY3QtPmNhblNldE51bWVyaWNWYWx1ZSgp KQogICAgICAgICAgICAgbV9vYmplY3QtPnNldFZhbHVlKFtudW1iZXIgZmxvYXRWYWx1ZV0pOwo=