116755 2013-05-24 21:01:53 -0700 CSSParser::parseImageResolution doesn't need a parameter. 2013-05-26 19:32:55 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned commit-queue esprehn+autocc glenn koivisto macpherson menard oldest_to_newest 893558 0 ljaehun.lim 2013-05-24 21:01:53 -0700 parseImageResolution() can get CSSPraserValueList from m_valueList directly. 893563 1 202874 ljaehun.lim 2013-05-24 21:36:41 -0700 Created attachment 202874 Patch 893842 2 202874 darin 2013-05-26 17:44:49 -0700 Comment on attachment 202874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review > Source/WebCore/css/CSSParser.cpp:2983 > m_valueList->next(); This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing. 893855 3 202874 ljaehun.lim 2013-05-26 18:09:05 -0700 Comment on attachment 202874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review >> Source/WebCore/css/CSSParser.cpp:2983 >> m_valueList->next(); > > This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing. Yes. I think "if (!parsedValue) / return false;" are redundant, too. parsedValue will be checked after switch case statement. I'll remove these two lines. 893859 4 202941 ljaehun.lim 2013-05-26 18:11:32 -0700 Created attachment 202941 Patch 893881 5 202941 commit-queue 2013-05-26 19:32:52 -0700 Comment on attachment 202941 Patch Clearing flags on attachment: 202941 Committed r150734: <http://trac.webkit.org/changeset/150734> 893882 6 commit-queue 2013-05-26 19:32:55 -0700 All reviewed patches have been landed. Closing bug. 202874 2013-05-24 21:36:41 -0700 2013-05-26 18:11:24 -0700 Patch bug-116755-20130525133523.patch text/plain 2685 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg2MzgwYmIyNWIyNmNm Mjc3YTk4YWMwOWNiZjc1YjhhZTNiNjI1NC4uYjAzMDMzN2I1ZTVkOTZmZWUyNGQzYzlkMTEwNjhm NDY0YmRjYmJkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTI0ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ1NTUGFyc2VyOjpw YXJzZUltYWdlUmVzb2x1dGlvbiBkb2Vzbid0IG5lZWQgYSBwYXJhbWV0ZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY3NTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwYXJzZUltYWdlUmVzb2x1dGlv bigpIGNhbiBnZXQgQ1NTUHJhc2VyVmFsdWVMaXN0IGZyb20gbV92YWx1ZUxpc3QgZGlyZWN0bHku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VJ bWFnZVJlc29sdXRpb24pOgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKwogMjAxMy0wNS0y NCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXgg YWZ0ZXIgcjE1MDY2NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMWYzOGE0YzQ0NGEx MzljNzg4NTVjYWI3N2YzZGZhOTUyY2Y1ODYzNS4uZDMzNDQyMDNhMzQ1ZjAxMTI5YmU2MTRmYmI5 ZjA1NzZmMTNkMGZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTI5NzcsNyArMjk3 Nyw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKENTU1Byb3BlcnR5SUQgcHJvcElkLCBi b29sIGltcG9ydGFudCkKICNlbmRpZgogI2lmIEVOQUJMRShDU1NfSU1BR0VfUkVTT0xVVElPTikK ICAgICBjYXNlIENTU1Byb3BlcnR5SW1hZ2VSZXNvbHV0aW9uOgotICAgICAgICBwYXJzZWRWYWx1 ZSA9IHBhcnNlSW1hZ2VSZXNvbHV0aW9uKG1fdmFsdWVMaXN0LmdldCgpKTsKKyAgICAgICAgcGFy c2VkVmFsdWUgPSBwYXJzZUltYWdlUmVzb2x1dGlvbigpOwogICAgICAgICBpZiAoIXBhcnNlZFZh bHVlKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBtX3ZhbHVlTGlzdC0+bmV4 dCgpOwpAQCAtNzkzNSwxNCArNzkzNSwxNCBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VDYW52YXMo Q1NTUGFyc2VyVmFsdWVMaXN0KiB2YWx1ZUxpc3QsIFJlZlB0cjxDU1NWYWx1ZT4mIGNhbgogfQog CiAjaWYgRU5BQkxFKENTU19JTUFHRV9SRVNPTFVUSU9OKQotUGFzc1JlZlB0cjxDU1NWYWx1ZT4g Q1NTUGFyc2VyOjpwYXJzZUltYWdlUmVzb2x1dGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVl TGlzdCkKK1Bhc3NSZWZQdHI8Q1NTVmFsdWU+IENTU1BhcnNlcjo6cGFyc2VJbWFnZVJlc29sdXRp b24oKQogewogICAgIFJlZlB0cjxDU1NWYWx1ZUxpc3Q+IGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNy ZWF0ZVNwYWNlU2VwYXJhdGVkKCk7CiAgICAgYm9vbCBoYXZlUmVzb2x1dGlvbiA9IGZhbHNlOwog ICAgIGJvb2wgaGF2ZUZyb21JbWFnZSA9IGZhbHNlOwogICAgIGJvb2wgaGF2ZVNuYXAgPSBmYWxz ZTsKIAotICAgIENTU1BhcnNlclZhbHVlKiB2YWx1ZSA9IHZhbHVlTGlzdC0+Y3VycmVudCgpOwor ICAgIENTU1BhcnNlclZhbHVlKiB2YWx1ZSA9IG1fdmFsdWVMaXN0LT5jdXJyZW50KCk7CiAgICAg d2hpbGUgKHZhbHVlKSB7CiAgICAgICAgIGlmICghaGF2ZUZyb21JbWFnZSAmJiB2YWx1ZS0+aWQg PT0gQ1NTVmFsdWVGcm9tSW1hZ2UpIHsKICAgICAgICAgICAgIGxpc3QtPmFwcGVuZChjc3NWYWx1 ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUodmFsdWUtPmlkKSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmgKaW5kZXggOWEyMjJhOWRkNDRhMTUzODIwODAwMzY1MzhlMzM0YmQxNDg4NDRiOS4uYjJm MmQyYjBkMDU2Mzc3MmRiYjM0NzJkMmI0NmFiZTNlMDhkNDE2MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuaApAQCAtMjM1LDcgKzIzNSw3IEBAIHB1YmxpYzoKICAgICBib29sIHBhcnNlQ3Jvc3NmYWRl KENTU1BhcnNlclZhbHVlTGlzdCosIFJlZlB0cjxDU1NWYWx1ZT4mKTsKIAogI2lmIEVOQUJMRShD U1NfSU1BR0VfUkVTT0xVVElPTikKLSAgICBQYXNzUmVmUHRyPENTU1ZhbHVlPiBwYXJzZUltYWdl UmVzb2x1dGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqKTsKKyAgICBQYXNzUmVmUHRyPENTU1ZhbHVl PiBwYXJzZUltYWdlUmVzb2x1dGlvbigpOwogI2VuZGlmCiAKICNpZiBFTkFCTEUoQ1NTX0lNQUdF X1NFVCkK 202941 2013-05-26 18:11:32 -0700 2013-05-26 19:32:52 -0700 Patch bug-116755-20130527101013.patch text/plain 2783 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDg0MjJlNGZjOGZmMzUz YTBmYWI4NmM5MzUwZDRhZDNkNzAwMmMxNC4uNzIzYjdjMjUyNGZjYzRjNjk1MWY4YmM0MjcwMDI0 NGVmZjJhOGJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTI2ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ1NTUGFyc2VyOjpw YXJzZUltYWdlUmVzb2x1dGlvbiBkb2Vzbid0IG5lZWQgYSBwYXJhbWV0ZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY3NTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwYXJzZUltYWdlUmVzb2x1dGlv bigpIGNhbiBnZXQgQ1NTUHJhc2VyVmFsdWVMaXN0IGZyb20gbV92YWx1ZUxpc3QgZGlyZWN0bHku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VJ bWFnZVJlc29sdXRpb24pOgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKwogMjAxMy0wNS0y NiAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmVtb3Zl IGEgbGVmdG92ZXIgQ0FMRU5EQVJfUElDS0VSIGZyb20gTG9jYWxlTm9uZS5jcHAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKaW5kZXggMWYzOGE0YzQ0NGExMzljNzg4NTVjYWI3N2YzZGZhOTUyY2Y1 ODYzNS4uZTE3NTA4ODRmZmJmNTk4OWIxMzY2ZGM3M2MzNjc2YmJmZGE3M2RjOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1BhcnNlci5jcHAKQEAgLTI5NzcsMTAgKzI5NzcsNyBAQCBib29sIENTU1BhcnNlcjo6 cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCBpbXBvcnRhbnQpCiAjZW5kaWYK ICNpZiBFTkFCTEUoQ1NTX0lNQUdFX1JFU09MVVRJT04pCiAgICAgY2FzZSBDU1NQcm9wZXJ0eUlt YWdlUmVzb2x1dGlvbjoKLSAgICAgICAgcGFyc2VkVmFsdWUgPSBwYXJzZUltYWdlUmVzb2x1dGlv bihtX3ZhbHVlTGlzdC5nZXQoKSk7Ci0gICAgICAgIGlmICghcGFyc2VkVmFsdWUpCi0gICAgICAg ICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7CisgICAgICAg IHBhcnNlZFZhbHVlID0gcGFyc2VJbWFnZVJlc29sdXRpb24oKTsKICAgICAgICAgYnJlYWs7CiAj ZW5kaWYKICAgICBjYXNlIENTU1Byb3BlcnR5Qm9yZGVyQm90dG9tU3R5bGU6CkBAIC03OTM1LDE0 ICs3OTMyLDE0IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUNhbnZhcyhDU1NQYXJzZXJWYWx1ZUxp c3QqIHZhbHVlTGlzdCwgUmVmUHRyPENTU1ZhbHVlPiYgY2FuCiB9CiAKICNpZiBFTkFCTEUoQ1NT X0lNQUdFX1JFU09MVVRJT04pCi1QYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NQYXJzZXI6OnBhcnNl SW1hZ2VSZXNvbHV0aW9uKENTU1BhcnNlclZhbHVlTGlzdCogdmFsdWVMaXN0KQorUGFzc1JlZlB0 cjxDU1NWYWx1ZT4gQ1NTUGFyc2VyOjpwYXJzZUltYWdlUmVzb2x1dGlvbigpCiB7CiAgICAgUmVm UHRyPENTU1ZhbHVlTGlzdD4gbGlzdCA9IENTU1ZhbHVlTGlzdDo6Y3JlYXRlU3BhY2VTZXBhcmF0 ZWQoKTsKICAgICBib29sIGhhdmVSZXNvbHV0aW9uID0gZmFsc2U7CiAgICAgYm9vbCBoYXZlRnJv bUltYWdlID0gZmFsc2U7CiAgICAgYm9vbCBoYXZlU25hcCA9IGZhbHNlOwogCi0gICAgQ1NTUGFy c2VyVmFsdWUqIHZhbHVlID0gdmFsdWVMaXN0LT5jdXJyZW50KCk7CisgICAgQ1NTUGFyc2VyVmFs dWUqIHZhbHVlID0gbV92YWx1ZUxpc3QtPmN1cnJlbnQoKTsKICAgICB3aGlsZSAodmFsdWUpIHsK ICAgICAgICAgaWYgKCFoYXZlRnJvbUltYWdlICYmIHZhbHVlLT5pZCA9PSBDU1NWYWx1ZUZyb21J bWFnZSkgewogICAgICAgICAgICAgbGlzdC0+YXBwZW5kKGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlk ZW50aWZpZXJWYWx1ZSh2YWx1ZS0+aWQpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAppbmRleCA5YTIy MmE5ZGQ0NGExNTM4MjA4MDAzNjUzOGUzMzRiZDE0ODg0NGI5Li5iMmYyZDJiMGQwNTYzNzcyZGJi MzQ3MmQyYjQ2YWJlM2UwOGQ0MTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCkBAIC0yMzUsNyAr MjM1LDcgQEAgcHVibGljOgogICAgIGJvb2wgcGFyc2VDcm9zc2ZhZGUoQ1NTUGFyc2VyVmFsdWVM aXN0KiwgUmVmUHRyPENTU1ZhbHVlPiYpOwogCiAjaWYgRU5BQkxFKENTU19JTUFHRV9SRVNPTFVU SU9OKQotICAgIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IHBhcnNlSW1hZ2VSZXNvbHV0aW9uKENTU1Bh cnNlclZhbHVlTGlzdCopOworICAgIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IHBhcnNlSW1hZ2VSZXNv bHV0aW9uKCk7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShDU1NfSU1BR0VfU0VUKQo=