116754 2013-05-24 20:32:57 -0700 Add guard around paintForFixedRootBackground 2013-05-27 14:11:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned commit-queue esprehn+autocc glenn simon.fraser oldest_to_newest 893552 0 seokju 2013-05-24 20:32:57 -0700 This function(paintForFixedRootBackground) is used when ACCELERATED_COMPOSITING is enabled. 893553 1 202872 seokju 2013-05-24 20:35:36 -0700 Created attachment 202872 Patch 893635 2 202872 simon.fraser 2013-05-25 14:05:04 -0700 Comment on attachment 202872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202872&action=review > Source/WebCore/ChangeLog:8 > + paintForFixedRootBackground is used when ACCELERATED_COMPOSITING is enabled. is _only_ used when 893827 3 202935 seokju 2013-05-26 16:22:15 -0700 Created attachment 202935 Patch 893828 4 seokju 2013-05-26 16:23:23 -0700 @Simon Fraser I have fixed it. Can you cq+ for this now? 894158 5 202935 commit-queue 2013-05-27 14:11:49 -0700 Comment on attachment 202935 Patch Clearing flags on attachment: 202935 Committed r150778: <http://trac.webkit.org/changeset/150778> 894159 6 commit-queue 2013-05-27 14:11:51 -0700 All reviewed patches have been landed. Closing bug. 202872 2013-05-24 20:35:36 -0700 2013-05-26 16:22:09 -0700 Patch bug-116754-20130525123419.patch text/plain 1541 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg2MzgwYmIyNWIyNmNm Mjc3YTk4YWMwOWNiZjc1YjhhZTNiNjI1NC4uNjM3N2FkZWFhNmJlNDEyNjU3MmNlNDYyNjM1ODA5 YTcxODE2NDcwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTI0ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBBZGQgZ3VhcmQgYXJv dW5kIHBhaW50Rm9yRml4ZWRSb290QmFja2dyb3VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcGFpbnRGb3JGaXhlZFJvb3RCYWNrZ3JvdW5kIGlzIHVz ZWQgd2hlbiBBQ0NFTEVSQVRFRF9DT01QT1NJVElORyBpcyBlbmFibGVkLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEzLTA1LTI0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeCBhZnRlciByMTUw NjY0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMWNkYjVl MmI5OWVhNzVhODM3NGM2ZGEyNGFmZjI0NWQwOTE3NWFlZS4uNmUyOWJiZGEwOWVkNzRkMDJhMDM3 MTAxNzRiZWQ2MDRhNzkxYWQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwCkBAIC0zNTk2LDEwICszNTk2LDEyIEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRT dXBwcmVzc1BhaW50aW5nTGF5ZXIoUmVuZGVyTGF5ZXIqIGxheWVyKQogICAgIHJldHVybiBmYWxz ZTsKIH0KIAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIHN0YXRpYyBib29sIHBh aW50Rm9yRml4ZWRSb290QmFja2dyb3VuZChjb25zdCBSZW5kZXJMYXllciogbGF5ZXIsIFJlbmRl ckxheWVyOjpQYWludExheWVyRmxhZ3MgcGFpbnRGbGFncykKIHsKICAgICByZXR1cm4gbGF5ZXIt PnJlbmRlcmVyKCktPmlzUm9vdCgpICYmIChwYWludEZsYWdzICYgUmVuZGVyTGF5ZXI6OlBhaW50 TGF5ZXJQYWludGluZ1Jvb3RCYWNrZ3JvdW5kT25seSk7CiB9CisjZW5kaWYKIAogdm9pZCBSZW5k ZXJMYXllcjo6cGFpbnRMYXllcihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IExheWVy UGFpbnRpbmdJbmZvJiBwYWludGluZ0luZm8sIFBhaW50TGF5ZXJGbGFncyBwYWludEZsYWdzKQog ewo= 202935 2013-05-26 16:22:15 -0700 2013-05-27 14:11:49 -0700 Patch bug-116754-20130527082056.patch text/plain 1550 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmIyMDU2Nzg3ZjQ1YWI0 MDU1NzdiMzAzZmU0MTUzYTA1N2I0MjRiMi4uNDg0M2MyODg1MDU5MDk5MWM1MDFjZWU4OTU1NWZi YmZlZjRlMDJlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTI2ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBBZGQgZ3VhcmQgYXJv dW5kIHBhaW50Rm9yRml4ZWRSb290QmFja2dyb3VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2lt b24gRnJhc2VyLgorCisgICAgICAgIHBhaW50Rm9yRml4ZWRSb290QmFja2dyb3VuZCBpcyBvbmx5 IHVzZWQgd2hlbiBBQ0NFTEVSQVRFRF9DT01QT1NJVElORyBpcyBlbmFibGVkLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEzLTA1LTI2ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFX0NB TEVOREFSX1BJQ0tFUgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5k ZXggMWNkYjVlMmI5OWVhNzVhODM3NGM2ZGEyNGFmZjI0NWQwOTE3NWFlZS4uNmUyOWJiZGEwOWVk NzRkMDJhMDM3MTAxNzRiZWQ2MDRhNzkxYWQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCkBAIC0zNTk2LDEwICszNTk2LDEyIEBAIHN0YXRpYyBpbmxpbmUgYm9v bCBzaG91bGRTdXBwcmVzc1BhaW50aW5nTGF5ZXIoUmVuZGVyTGF5ZXIqIGxheWVyKQogICAgIHJl dHVybiBmYWxzZTsKIH0KIAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIHN0YXRp YyBib29sIHBhaW50Rm9yRml4ZWRSb290QmFja2dyb3VuZChjb25zdCBSZW5kZXJMYXllciogbGF5 ZXIsIFJlbmRlckxheWVyOjpQYWludExheWVyRmxhZ3MgcGFpbnRGbGFncykKIHsKICAgICByZXR1 cm4gbGF5ZXItPnJlbmRlcmVyKCktPmlzUm9vdCgpICYmIChwYWludEZsYWdzICYgUmVuZGVyTGF5 ZXI6OlBhaW50TGF5ZXJQYWludGluZ1Jvb3RCYWNrZ3JvdW5kT25seSk7CiB9CisjZW5kaWYKIAog dm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMYXllcihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNv bnN0IExheWVyUGFpbnRpbmdJbmZvJiBwYWludGluZ0luZm8sIFBhaW50TGF5ZXJGbGFncyBwYWlu dEZsYWdzKQogewo=