116724 2013-05-24 08:56:44 -0700 [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms 2013-05-27 08:51:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned anilsson anlo commit-queue rwlbuis tabbott oldest_to_newest 893320 0 cgarcia 2013-05-24 08:56:44 -0700 It seems that the animations are triggered too often after r150071 in some cases. 893325 1 202828 cgarcia 2013-05-24 09:08:53 -0700 Created attachment 202828 Patch 893344 2 202828 anilsson 2013-05-24 10:02:05 -0700 Comment on attachment 202828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202828&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:6343 > + m_monotonicAnimationStartTime = monotonicallyIncreasingTime(); currentTime and monotonicallyIncreasingTime() ärr two incompatible time coordinate systems... > Source/WebKit/blackberry/Api/WebPage.cpp:6382 > + m_mainFrame->view()->serviceScriptedAnimations(monotonicAnimationStartTime); ...so which time coordinate system does serviceScriptedAnimations expect anyway? I noticed you used currentTime() in the previous patch... 893354 3 cgarcia 2013-05-24 10:15:45 -0700 (In reply to comment #2) > (From update of attachment 202828 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202828&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:6343 > > + m_monotonicAnimationStartTime = monotonicallyIncreasingTime(); > > currentTime and monotonicallyIncreasingTime() ärr two incompatible time coordinate systems... This is what display refresh monitor does, that's why I changed it. 893363 4 anilsson 2013-05-24 10:27:47 -0700 Alright, monotonic it is then! LGTM. 894050 5 202828 rwlbuis 2013-05-27 08:38:58 -0700 Comment on attachment 202828 Patch Looks good. 894061 6 202828 commit-queue 2013-05-27 08:50:59 -0700 Comment on attachment 202828 Patch Clearing flags on attachment: 202828 Committed r150760: <http://trac.webkit.org/changeset/150760> 894062 7 commit-queue 2013-05-27 08:51:01 -0700 All reviewed patches have been landed. Closing bug. 202828 2013-05-24 09:08:53 -0700 2013-05-27 08:50:59 -0700 Patch bb-animations.diff text/plain 4448 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDVjMTU2YzEuLjRkNDY5ZTUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA1LTI0ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gUkVHUkVTU0lPTihyMTUwMDcxKTogQW5pbWF0aW9uIHBlcmZvcm1hbmNlIGlzc3Vl cyBpbiBzb21lIHdlYnNpdGVzIHdpdGggQ1NTIHRyYW5zZm9ybXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjcyNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbm90aGVyIGJvb2wgdmFyaWFibGUg bV9wcmV2aW91c0ZyYW1lRG9uZSB0byBtYWtlIHN1cmUgd2UKKyAgICAgICAgZG9uJ3Qgc3RhcnQg YSBuZXcgZnJhbWUgdW50aWwgdGhlIHByZXZpb3VzIG9uZSBoYXMgYmVlbiBkb25lLiBBbHNvCisg ICAgICAgIG1ha2Ugc3VyZSB3ZSBwYXNzIHRoZSBhbmltYXRpb24gc3RhcnQgdGltZSB0bworICAg ICAgICBzZXJ2aWNlU2NyaXB0ZWRBbmltYXRpb25zKCkuCisKKyAgICAgICAgKiBBcGkvV2ViUGFn ZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpXZWJQ YWdlUHJpdmF0ZSk6IEluaXRpYWxpemUKKyAgICAgICAgbV9wcmV2aW91c0ZyYW1lRG9uZSBhbmQg bV9tb25vdG9uaWNBbmltYXRpb25TdGFydFRpbWUuCisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OldlYlBhZ2VQcml2YXRlOjphbmltYXRpb25GcmFtZUNoYW5nZWQpOgorICAgICAgICBSZXR1 cm4gZWFybHkgaWYgcHJldmlvdXMgZnJhbWUgaXMgbm90IGRvbmUuIE90aGVyd2lzZSBzZXQKKyAg ICAgICAgbV9wcmV2aW91c0ZyYW1lRG9uZSB0byBmYWxzZSBhbmQgc2F2ZSB0aGUgYW5pbWF0aW9u IHN0YXJ0IHRpbWUuCisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRl OjpzZXJ2aWNlQW5pbWF0aW9ucyk6IENhbGwKKyAgICAgICAgc2VydmljZVNjcmlwdGVkQW5pbWF0 aW9ucygpIHBhc3NpbmcgdGhlIHNhdmVkIGFuaW1hdGlvbiBzdGFydCB0aW1lCisgICAgICAgIGFu ZCByZXNldCBtX2FuaW1hdGlvblNjaGVkdWxlZCBhbmQgbV9wcmV2aW91c0ZyYW1lRG9uZS4KKyAg ICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmhhbmRsZVNlcnZpY2VT Y3JpcHRlZEFuaW1hdGlvbnNPbk1haW5UaHJlYWQpOgorICAgICAgICBDYWxsIFdlYlBhZ2VQcml2 YXRlOjpzZXJ2aWNlQW5pbWF0aW9ucygpLgorICAgICAgICAqIEFwaS9XZWJQYWdlX3AuaDoKKyAg ICAgICAgKFdlYlBhZ2VQcml2YXRlKToKKwogMjAxMy0wNS0yNCAgSmVmZiBSb2dlcnMgIDxqcm9n ZXJzQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSBTS0lBIGxlZnRvdmVy cyBmcm9tIFdlYlBhZ2UuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNw cAppbmRleCA4NzgzNmE0Li40ZGUwOGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAKQEAgLTQyOCw2ICs0MjgsOCBAQCBXZWJQYWdlUHJpdmF0ZTo6V2ViUGFnZVBy aXZhdGUoV2ViUGFnZSogd2ViUGFnZSwgV2ViUGFnZUNsaWVudCogY2xpZW50LCBjb25zdCBJbgog I2lmIEVOQUJMRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRSkgJiYgIVVTRShSRVFVRVNUX0FOSU1B VElPTl9GUkFNRV9USU1FUikKICAgICAsIG1faXNSdW5uaW5nUmVmcmVzaEFuaW1hdGlvbkNsaWVu dChmYWxzZSkKICAgICAsIG1fYW5pbWF0aW9uU2NoZWR1bGVkKGZhbHNlKQorICAgICwgbV9wcmV2 aW91c0ZyYW1lRG9uZSh0cnVlKQorICAgICwgbV9tb25vdG9uaWNBbmltYXRpb25TdGFydFRpbWUo MCkKICNlbmRpZgogewogICAgIHN0YXRpYyBib29sIGlzSW5pdGlhbGl6ZWQgPSBmYWxzZTsKQEAg LTYzMjUsMTMgKzYzMjcsMjAgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6YW5pbWF0aW9uRnJhbWVD aGFuZ2VkKCkKICAgICBpZiAoIW1fYW5pbWF0aW9uTXV0ZXgudHJ5TG9jaygpKQogICAgICAgICBy ZXR1cm47CiAKKyAgICBpZiAoIW1fcHJldmlvdXNGcmFtZURvbmUpIHsKKyAgICAgICAgbV9hbmlt YXRpb25NdXRleC51bmxvY2soKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGlmICgh bV9hbmltYXRpb25TY2hlZHVsZWQpIHsKICAgICAgICAgc3RvcFJlZnJlc2hBbmltYXRpb25DbGll bnQoKTsKICAgICAgICAgbV9hbmltYXRpb25NdXRleC51bmxvY2soKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KIAotICAgIG1fYW5pbWF0aW9uU2NoZWR1bGVkID0gZmFsc2U7CisgICAgbV9wcmV2 aW91c0ZyYW1lRG9uZSA9IGZhbHNlOworCisgICAgbV9tb25vdG9uaWNBbmltYXRpb25TdGFydFRp bWUgPSBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsKICAgICBjYWxsT25NYWluVGhyZWFk KGhhbmRsZVNlcnZpY2VTY3JpcHRlZEFuaW1hdGlvbnNPbk1haW5UaHJlYWQsIHRoaXMpOwogICAg IG1fYW5pbWF0aW9uTXV0ZXgudW5sb2NrKCk7CiB9CkBAIC02MzYxLDEwICs2MzcwLDI2IEBAIHZv aWQgV2ViUGFnZVByaXZhdGU6OnN0b3BSZWZyZXNoQW5pbWF0aW9uQ2xpZW50KCkKICAgICBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6QW5pbWF0aW9uRnJhbWVSYXRlQ29udHJvbGxlcjo6aW5zdGFuY2Uo KS0+cmVtb3ZlQ2xpZW50KHRoaXMpOwogfQogCit2b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXJ2aWNl QW5pbWF0aW9ucygpCit7CisgICAgZG91YmxlIG1vbm90b25pY0FuaW1hdGlvblN0YXJ0VGltZTsK KyAgICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2sobV9hbmltYXRpb25NdXRleCk7CisgICAg ICAgIG1fYW5pbWF0aW9uU2NoZWR1bGVkID0gZmFsc2U7CisgICAgICAgIG1vbm90b25pY0FuaW1h dGlvblN0YXJ0VGltZSA9IG1fbW9ub3RvbmljQW5pbWF0aW9uU3RhcnRUaW1lOworICAgIH0KKwor ICAgIG1fbWFpbkZyYW1lLT52aWV3KCktPnNlcnZpY2VTY3JpcHRlZEFuaW1hdGlvbnMobW9ub3Rv bmljQW5pbWF0aW9uU3RhcnRUaW1lKTsKKworICAgIHsKKyAgICAgICAgTXV0ZXhMb2NrZXIgbG9j ayhtX2FuaW1hdGlvbk11dGV4KTsKKyAgICAgICAgbV9wcmV2aW91c0ZyYW1lRG9uZSA9IHRydWU7 CisgICAgfQorfQorCiB2b2lkIFdlYlBhZ2VQcml2YXRlOjpoYW5kbGVTZXJ2aWNlU2NyaXB0ZWRB bmltYXRpb25zT25NYWluVGhyZWFkKHZvaWQqIGRhdGEpCiB7Ci0gICAgV2ViUGFnZVByaXZhdGUq IHdlYlBhZ2VQcml2YXRlID0gc3RhdGljX2Nhc3Q8V2ViUGFnZVByaXZhdGUqPihkYXRhKTsKLSAg ICB3ZWJQYWdlUHJpdmF0ZS0+bV9tYWluRnJhbWUtPnZpZXcoKS0+c2VydmljZVNjcmlwdGVkQW5p bWF0aW9ucyhjdXJyZW50VGltZSgpKTsKKyAgICBzdGF0aWNfY2FzdDxXZWJQYWdlUHJpdmF0ZSo+ KGRhdGEpLT5zZXJ2aWNlQW5pbWF0aW9ucygpOwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oCmluZGV4IGVlOWMxMzAuLjM2MDAzNjggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKKysrIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaApAQCAtNDY2LDYgKzQ2Niw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIHNjaGVkdWxlQW5pbWF0aW9uKCk7CiAgICAgdm9pZCBzdGFydFJlZnJl c2hBbmltYXRpb25DbGllbnQoKTsKICAgICB2b2lkIHN0b3BSZWZyZXNoQW5pbWF0aW9uQ2xpZW50 KCk7CisgICAgdm9pZCBzZXJ2aWNlQW5pbWF0aW9ucygpOwogICAgIHN0YXRpYyB2b2lkIGhhbmRs ZVNlcnZpY2VTY3JpcHRlZEFuaW1hdGlvbnNPbk1haW5UaHJlYWQodm9pZCopOwogI2VuZGlmCiAK QEAgLTY2Miw2ICs2NjMsOCBAQCBwdWJsaWM6CiAgICAgTXV0ZXggbV9hbmltYXRpb25NdXRleDsK ICAgICBib29sIG1faXNSdW5uaW5nUmVmcmVzaEFuaW1hdGlvbkNsaWVudDsKICAgICBib29sIG1f YW5pbWF0aW9uU2NoZWR1bGVkOworICAgIGJvb2wgbV9wcmV2aW91c0ZyYW1lRG9uZTsKKyAgICBk b3VibGUgbV9tb25vdG9uaWNBbmltYXRpb25TdGFydFRpbWU7CiAjZW5kaWYKIAogcHJvdGVjdGVk Ogo=