116712 2013-05-24 02:03:03 -0700 [AC] Needs to be guarded by USE(ACCELERATED_COMPOSITING) 2013-05-24 13:25:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned commit-queue oldest_to_newest 893229 0 seokju 2013-05-24 02:03:03 -0700 renderView variable in FrameView::setFrameRect It is used when ACCELERATED_COMPOSITING is enabled. So, this patch allows it to be guarded by USE(ACCELERATED_COMPOSITING). 893232 1 202790 seokju 2013-05-24 02:10:12 -0700 Created attachment 202790 Patch 893235 2 202790 seokju 2013-05-24 02:18:12 -0700 Comment on attachment 202790 Patch If ACCELERATED_COMPOSITING is disabled /WebKit/Source/WebCore/page/FrameView.cpp: In member function ‘virtual void WebCore::FrameView::setFrameRect(const WebCore::IntRect&)’: /WebKit/Source/WebCore/page/FrameView.cpp:472:17: error: unused variable ‘renderView’ [-Werror=unused-variable] 893422 3 202790 commit-queue 2013-05-24 13:25:39 -0700 Comment on attachment 202790 Patch Clearing flags on attachment: 202790 Committed r150656: <http://trac.webkit.org/changeset/150656> 893423 4 commit-queue 2013-05-24 13:25:41 -0700 All reviewed patches have been landed. Closing bug. 202790 2013-05-24 02:10:12 -0700 2013-05-24 13:25:39 -0700 Patch bug-116712-20130524180856.patch text/plain 1530 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZkOGNlM2NmMzcwZGQ5 NGJlYTU0YjQxMDE4NTcwMmM2ZDI4YzNjOC4uNGM1MmZmYTdhYzE4YTBkMDE0NWNhYzhjMDk1NDNi Yzg4MWZkMTViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTI0ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbQUNdIE5lZWRzIHRv IGJlIGd1YXJkZWQgYnkgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NzEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmVuZGVyVmlldyBpcyB1c2VkIHdo ZW4gQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgaXMgZW5hYmxlZC4KKyAgICAgICAgU28sIHRoaXMg cGF0Y2ggYWxsb3dzIGl0IHRvIGJlIGd1YXJkZWQgYnkgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lU SU5HKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAg ICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6 c2V0RnJhbWVSZWN0KToKKwogMjAxMy0wNS0yMyAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIE1vZGlmeSBXZWJDb3JlIGZvciBBcHBsZVdp biAyMDEwIHByb2R1Y3Rpb24gYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXgg YWExNWIyNjNjMDA5YjU3OGE1MDZhNGM0MTU3ZDUxZjAyNjMxMzg0OC4uNjE2M2NkOGNiOTU2ZTQ1 ZDNjNDMyMTRlNzgwMDVhZGE0MzQxZDQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApA QCAtNDY5LDEwICs0NjksOCBAQCB2b2lkIEZyYW1lVmlldzo6c2V0RnJhbWVSZWN0KGNvbnN0IElu dFJlY3QmIG5ld1JlY3QpCiAKICAgICB1cGRhdGVTY3JvbGxhYmxlQXJlYVNldCgpOwogCi0gICAg UmVuZGVyVmlldyogcmVuZGVyVmlldyA9IHRoaXMtPnJlbmRlclZpZXcoKTsKLQogI2lmIFVTRShB Q0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBpZiAocmVuZGVyVmlldykgeworICAgIGlmIChS ZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gdGhpcy0+cmVuZGVyVmlldygpKSB7CiAgICAgICAgIGlm IChyZW5kZXJWaWV3LT51c2VzQ29tcG9zaXRpbmcoKSkKICAgICAgICAgICAgIHJlbmRlclZpZXct PmNvbXBvc2l0b3IoKS0+ZnJhbWVWaWV3RGlkQ2hhbmdlU2l6ZSgpOwogICAgIH0K