116707 2013-05-24 00:31:10 -0700 [EFL][WK2] Remove unneeded WebCore namespace use in ewk 2013-05-27 23:48:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez commit-queue lucas.de.marchi rakuco oldest_to_newest 893196 0 gyuyoung.kim 2013-05-24 00:31:10 -0700 SSIA 893197 1 202778 gyuyoung.kim 2013-05-24 00:32:19 -0700 Created attachment 202778 Patch 893202 2 202778 cdumez 2013-05-24 00:36:44 -0700 Comment on attachment 202778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > #include <WebCore/SecurityOrigin.h> Could we remove this header include as well? 893203 3 202779 gyuyoung.kim 2013-05-24 00:40:35 -0700 Created attachment 202779 Patch 893204 4 gyuyoung.kim 2013-05-24 00:40:56 -0700 (In reply to comment #2) > (From update of attachment 202778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > > #include <WebCore/SecurityOrigin.h> > > Could we remove this header include as well? Sure ! 893205 5 gyuyoung.kim 2013-05-24 00:43:26 -0700 (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 202778 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > > > > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > > > #include <WebCore/SecurityOrigin.h> > > > > Could we remove this header include as well? > > Sure ! Oops. EFL WK2 EWS is pending now. There was no problem when I remove it on my local source. 893206 6 202779 cdumez 2013-05-24 00:52:18 -0700 Comment on attachment 202779 Patch Looks fine, r=me. Please make sure it builds locally before landing as the ews is sluggish today. 894229 7 202779 gyuyoung.kim 2013-05-27 23:48:13 -0700 Comment on attachment 202779 Patch Clearing flags on attachment: 202779 Committed r150787: <http://trac.webkit.org/changeset/150787> 894230 8 gyuyoung.kim 2013-05-27 23:48:20 -0700 All reviewed patches have been landed. Closing bug. 202778 2013-05-24 00:32:19 -0700 2013-05-24 00:40:29 -0700 Patch bug-116707-20130524163103.patch text/plain 1858 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjAxNGQwMzNhMjM4NTY4 MzgwMDZjNThmYWNhNzQ1YTQ1NDM2MjE3NC4uZjg0YjJmNzZkNDA1YTBkZTk4MTRlOGJjMDVjOWFj NmYwYTVlOWQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTI0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBSZW1vdmUgdW5uZWVkZWQgV2ViQ29yZSBuYW1lc3BhY2UgdXNlIGluIGV3aworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NzA3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcDogUmVtb3ZlICJ1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZSIuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHA6IGRp dHRvLgorCiAyMDEzLTA1LTIzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbV0syXVtFRkxdW1FUXSBCdWlsZCBicmVhayBhZnRlciByMTUwNjEwCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2VjdXJpdHlfb3Jp Z2luLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwCmluZGV4IDE4NGFkMmY0NjkwMzMyM2JkMzJhOGMyNzEwNjg5NGE2NWI0NDM2YjYu LjA2MDMwYmFjNTcwMDBjNWFjZDQ4N2NlYjcwZmQ4MTA0MjM4MjJmYzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW4uY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW4u Y3BwCkBAIC0zMiw3ICszMiw2IEBACiAjaW5jbHVkZSAiZXdrX3NlY3VyaXR5X29yaWdpbl9wcml2 YXRlLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgogCi11c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKIEV3a1NlY3VyaXR5T3Jp Z2luOjpFd2tTZWN1cml0eU9yaWdpbihXS1NlY3VyaXR5T3JpZ2luUmVmIG9yaWdpblJlZikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2NoZWNr ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tl ci5jcHAKaW5kZXggODlhMzgyZjYyNmIyY2Q1Y2JiMjViMjA1MjA0ZDk5NmNlOTYzN2QyOC4uOGY0 OTk0YjBmYWE3YWIzNTZiZWJiOGMwNWM5YjBmNjc4NTlkZGNkNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAKQEAgLTMw LDcgKzMwLDYgQEAKICNpZiBFTkFCTEUoU1BFTExDSEVDSykKICNpbmNsdWRlICJUZXh0Q2hlY2tl ckNsaWVudEVmbC5oIgogCi11c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFj ZSBXZWJLaXQ7CiAKIHN0YXRpYyBFaW5hX0xpc3QqIGNvbnZlcnRMYW5ndWFnZXNUb0VpbmFMaXN0 KGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBsYW5ndWFnZXMpCg== 202779 2013-05-24 00:40:35 -0700 2013-05-27 23:48:13 -0700 Patch bug-116707-20130524163919.patch text/plain 1912 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjAxNGQwMzNhMjM4NTY4 MzgwMDZjNThmYWNhNzQ1YTQ1NDM2MjE3NC4uZjg0YjJmNzZkNDA1YTBkZTk4MTRlOGJjMDVjOWFj NmYwYTVlOWQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTI0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBSZW1vdmUgdW5uZWVkZWQgV2ViQ29yZSBuYW1lc3BhY2UgdXNlIGluIGV3aworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NzA3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcDogUmVtb3ZlICJ1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZSIuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHA6IGRp dHRvLgorCiAyMDEzLTA1LTIzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbV0syXVtFRkxdW1FUXSBCdWlsZCBicmVhayBhZnRlciByMTUwNjEwCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2VjdXJpdHlfb3Jp Z2luLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwCmluZGV4IDE4NGFkMmY0NjkwMzMyM2JkMzJhOGMyNzEwNjg5NGE2NWI0NDM2YjYu LmI0NzZmNDQ0NDU2YTI1NDE2MjkxNjM1ZDZjMWVhMjA2YmI1ZDhiZGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW4uY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW4u Y3BwCkBAIC0zMCw5ICszMCw3IEBACiAjaW5jbHVkZSAiV0tTZWN1cml0eU9yaWdpbi5oIgogI2lu Y2x1ZGUgIldLU3RyaW5nLmgiCiAjaW5jbHVkZSAiZXdrX3NlY3VyaXR5X29yaWdpbl9wcml2YXRl LmgiCi0jaW5jbHVkZSA8V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgogCi11c2luZyBuYW1lc3Bh Y2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKIEV3a1NlY3VyaXR5T3JpZ2lu OjpFd2tTZWN1cml0eU9yaWdpbihXS1NlY3VyaXR5T3JpZ2luUmVmIG9yaWdpblJlZikKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2NoZWNrZXIu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5j cHAKaW5kZXggODlhMzgyZjYyNmIyY2Q1Y2JiMjViMjA1MjA0ZDk5NmNlOTYzN2QyOC4uOGY0OTk0 YjBmYWE3YWIzNTZiZWJiOGMwNWM5YjBmNjc4NTlkZGNkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAKQEAgLTMwLDcg KzMwLDYgQEAKICNpZiBFTkFCTEUoU1BFTExDSEVDSykKICNpbmNsdWRlICJUZXh0Q2hlY2tlckNs aWVudEVmbC5oIgogCi11c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBX ZWJLaXQ7CiAKIHN0YXRpYyBFaW5hX0xpc3QqIGNvbnZlcnRMYW5ndWFnZXNUb0VpbmFMaXN0KGNv bnN0IFZlY3RvcjxTdHJpbmc+JiBsYW5ndWFnZXMpCg==