116699 2013-05-23 20:43:26 -0700 [WK2][EFL][QT] Build break after r150610 2013-05-23 22:14:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116690 1 ryuan.choi ryuan.choi ossy oldest_to_newest 893109 0 ryuan.choi 2013-05-23 20:43:26 -0700 EFL and QT using -Werror=maybe-uninitialized got below error. /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/UIProcess/WebPageProxy.cpp: In member function ‘void WebKit::WebPageProxy::findPlugin(const WTF::String&, uint32_t, const WTF::String&, const WTF::String&, const WTF::String&, bool, uint64_t&, WTF::String&, uint32_t&)’: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/UIProcess/WebPageProxy.cpp:1440:155: error: ‘pluginProcessSandboxPolicy’ may be used uninitialized in this function [-Werror=maybe-uninitialized] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o] Error 1 893110 1 202758 ryuan.choi 2013-05-23 20:45:38 -0700 Created attachment 202758 Patch 893119 2 202758 andersca 2013-05-23 21:20:08 -0700 Comment on attachment 202758 Patch This fix (while OK) has the downside of making the compiler not warn if we ever add more cases. I think a better fix is to just initialize the variable. 893120 3 202762 ryuan.choi 2013-05-23 21:25:24 -0700 Created attachment 202762 Patch 893123 4 ryuan.choi 2013-05-23 21:29:16 -0700 (In reply to comment #2) > (From update of attachment 202758 [details]) > This fix (while OK) has the downside of making the compiler not warn if we ever add more cases. I think a better fix is to just initialize the variable. OK. I initialized the variable. 893131 5 202762 ossy 2013-05-23 22:11:38 -0700 Comment on attachment 202762 Patch LGTM, I think it's safe if we use stricter policy if the variable is uninitialized. I'm not an owner, but I don't think if we should wait for an owner to get up for this trivial buildfix. So r=me. And feel free to find a better fix after you get up. 893133 6 202762 ossy 2013-05-23 22:14:36 -0700 Comment on attachment 202762 Patch Clearing flags on attachment: 202762 Committed r150624: <http://trac.webkit.org/changeset/150624> 893134 7 ossy 2013-05-23 22:14:42 -0700 All reviewed patches have been landed. Closing bug. 202758 2013-05-23 20:45:38 -0700 2013-05-23 21:25:20 -0700 Patch bug-116699-20130524124422.patch text/plain 1189 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTA5NTdiYmVlNjA0YmRm OTU0MWI4ZTVlYzBjOTk2N2E2YzVmM2JjOS4uMDYwOTkxMTlmNzJjZDVjOGRiODY4NWI4YzUwMTc4 ODE0M2I0MWJhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTIzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdW1FU XSBCdWlsZCBicmVhayBhZnRlciByMTUwNjEwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2OTkKKworICAgICAgICBVbnJldmlld2VkIGJ5IGJ1aWxk IGZpeC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OmZpbmRQbHVnaW4pOgorCiAyMDEzLTA1LTIzICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgU2hpbSBGbGFzaCBwbHVn LWluIHRvIGFsbG93IGl0cyB1cGRhdGVyIHRvIHJ1bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAppbmRleCAwMGQ2Mjc0MjdmY2Y2ZDc4Yjc5NjBiNzE0N2NkMjQ1MDk3 ZjFkNDE5Li41YWFlMjdjMDc0YTcwYjk0ODE2YWUwNzNkN2ZlOTJjMmRlNGRlNTE3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMTQzMyw2ICsxNDMzLDcg QEAgdm9pZCBXZWJQYWdlUHJveHk6OmZpbmRQbHVnaW4oY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwg dWludDMyX3QgcHJvY2Vzc1R5cGUsIGNvbnMKIAogICAgIGNhc2UgUGx1Z2luTW9kdWxlQmxvY2tl ZDoKICAgICBjYXNlIFBsdWdpbk1vZHVsZUluYWN0aXZlOgorICAgIGRlZmF1bHQ6CiAgICAgICAg IHBsdWdpblByb2Nlc3NUb2tlbiA9IDA7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg== 202762 2013-05-23 21:25:24 -0700 2013-05-23 22:14:36 -0700 Patch bug-116699-20130524132408.patch text/plain 1436 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTA5NTdiYmVlNjA0YmRm OTU0MWI4ZTVlYzBjOTk2N2E2YzVmM2JjOS4uYjlmYjQ3MWQ1NTZjZGYzZTRhZmZiYjAwZDI4ZjJk ZmE2YzVmYmE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTIzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdW1FU XSBCdWlsZCBicmVhayBhZnRlciByMTUwNjEwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmZpbmRQbHVnaW4pOiBJbml0aWFsaXplZCBwbHVnaW5Q cm9jZXNzU2FuZGJveFBvbGljeS4KKwogMjAxMy0wNS0yMyAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFNoaW0gRmxhc2ggcGx1Zy1pbiB0byBhbGxvdyBp dHMgdXBkYXRlciB0byBydW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKaW5kZXggMDBkNjI3NDI3ZmNmNmQ3OGI3OTYwYjcxNDdjZDI0NTA5N2YxZDQxOS4uZTIxNDg3 ZTNlMTE2Y2I4NTY0M2ViNDMyMThjNGVkYWM2ZTk5ZmRjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTE0MjIsNyArMTQyMiw3IEBAIHZvaWQgV2ViUGFn ZVByb3h5OjpmaW5kUGx1Z2luKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIHVpbnQzMl90IHByb2Nl c3NUeXBlLCBjb25zCiAgICAgVU5VU0VEX1BBUkFNKHBhZ2VVUkxTdHJpbmcpOwogI2VuZGlmCiAK LSAgICBQbHVnaW5Qcm9jZXNzU2FuZGJveFBvbGljeSBwbHVnaW5Qcm9jZXNzU2FuZGJveFBvbGlj eTsKKyAgICBQbHVnaW5Qcm9jZXNzU2FuZGJveFBvbGljeSBwbHVnaW5Qcm9jZXNzU2FuZGJveFBv bGljeSA9IFBsdWdpblByb2Nlc3NTYW5kYm94UG9saWN5Tm9ybWFsOwogICAgIHN3aXRjaCAocGx1 Z2luTG9hZFBvbGljeSkgewogICAgIGNhc2UgUGx1Z2luTW9kdWxlTG9hZE5vcm1hbGx5OgogICAg ICAgICBwbHVnaW5Qcm9jZXNzU2FuZGJveFBvbGljeSA9IFBsdWdpblByb2Nlc3NTYW5kYm94UG9s aWN5Tm9ybWFsOwo=