116682 2013-05-23 10:52:39 -0700 Move posix_spawn onto a zero delay timer 2013-05-23 15:01:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 892957 0 barraclough 2013-05-23 10:52:39 -0700 <rdar://problem/13973468> 892960 1 202728 barraclough 2013-05-23 10:56:43 -0700 Created attachment 202728 Fix 892961 2 barraclough 2013-05-23 11:02:46 -0700 Fixed in r150595 892970 3 202728 ggaren 2013-05-23 11:27:24 -0700 Comment on attachment 202728 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=202728&action=review > Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:119 > + CFRunLoopTimerContext context = { 0, info, NULL, NULL, NULL }; > + CFRunLoopTimerRef timer = CFRunLoopTimerCreate(NULL, CFAbsoluteTimeGetCurrent(), 0, 0, 0, reexecCallBack, &context); > + CFRunLoopAddTimer(CFRunLoopGetCurrent(), timer, kCFRunLoopCommonModes); Aren't you leaking this timer? 892973 4 202728 darin 2013-05-23 11:31:46 -0700 Comment on attachment 202728 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=202728&action=review > Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:79 > + posix_spawnattr_destroy(&attr); I don’t understand our approach on memory allocation. We are deallocating this, but not info, info->environment, the strings in info->environment, or timer. Why deallocate anything? Why not deallocate everything? 893054 5 barraclough 2013-05-23 15:01:51 -0700 This code was already leaky – it always immediately calls posix_spawn with flags to perform an execv – so the process is going to be be completely replaced (or will exit). 202728 2013-05-23 10:56:43 -0700 2013-05-23 11:31:46 -0700 Fix 116682.patch text/plain 6561 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDU5NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA1LTIzICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIHBvc2l4 X3NwYXduIG9udG8gYSB6ZXJvIGRlbGF5IHRpbWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTM5NzM0Njg+CisKKyAgICAg ICAgKiBTaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9tYWMvWFBDU2VydmljZS9YUENTZXJ2aWNl TWFpbi5EZXZlbG9wbWVudC5tbToKKyAgICAgICAgKFJlZXhlY0luZm8pOgorICAgICAgICAgICAg LSBzdHJ1Y3QgdG8gaG9sZCBpbmZvIGZyb20gdGhlIFhQQyBtZXNzYWdlLgorICAgICAgICAoV2Vi S2l0OjpyZWV4ZWMpOgorICAgICAgICAgICAgLSBtb3ZlZCBjYWxsIHRvIHBvc2l4X3NwYXduIG91 dCB0byB0aGlzIGhlbHBlci4KKyAgICAgICAgKFdlYktpdDo6cmVleGVjQ2FsbEJhY2spOgorICAg ICAgICAgICAgLSBjYWxscyByZWV4ZWMuCisgICAgICAgIChXZWJLaXQ6OlhQQ1NlcnZpY2VFdmVu dEhhbmRsZXIpOgorICAgICAgICAgICAgLSByZW1vdmVkIGNhbGwgdG8gcG9zaXhfc3Bhd247IHNj aGVkdWxlIGEgY2FsbCB0byByZWV4ZWNDYWxsQmFjay4KKwogMjAxMy0wNS0yMyAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtjbWFrZV0gRml4IGdlbmVy YXRpbmctZm9yd2FyZGluZy1oZWFkZXJzIHJ1bGUgYWZ0ZXIgcjE1MDQ2MApJbmRleDogU291cmNl L1dlYktpdDIvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvbWFjL1hQQ1NlcnZpY2UvWFBDU2Vy dmljZU1haW4uRGV2ZWxvcG1lbnQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hh cmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvbWFjL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1haW4uRGV2 ZWxvcG1lbnQubW0JKHJldmlzaW9uIDE1MDMxNCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9F bnRyeVBvaW50VXRpbGl0aWVzL21hYy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VNYWluLkRldmVsb3Bt ZW50Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw2MCBAQAogCiBuYW1lc3BhY2UgV2Vi S2l0IHsKIAorc3RydWN0IFJlZXhlY0luZm8geworICAgIGJvb2wgZXhlY3V0YWJsZUhlYXA7Cisg ICAgY2hhcioqIGVudmlyb25tZW50OworICAgIGNwdV90eXBlX3QgY3B1VHlwZTsKK307CisKK3N0 YXRpYyBOT19SRVRVUk4gdm9pZCByZWV4ZWMoUmVleGVjSW5mbyAqaW5mbykKK3sKKyAgICBwb3Np eF9zcGF3bmF0dHJfdCBhdHRyOworICAgIHBvc2l4X3NwYXduYXR0cl9pbml0KCZhdHRyKTsKKwor ICAgIHNob3J0IGZsYWdzID0gMDsKKworICAgIC8vIFdlIGp1c3Qgd2FudCB0byBzZXQgdGhlIHBy b2Nlc3Mgc3RhdGUsIG5vdCBhY3R1YWxseSBsYXVuY2ggYSBuZXcgcHJvY2VzcywKKyAgICAvLyBz byB3ZSBhcmUgZ29pbmcgdG8gdXNlIHRoZSBkYXJ3aW4gZXh0ZW5zaW9uIHRvIHBvc2l4X3NwYXdu IFBPU0lYX1NQQVdOX1NFVEVYRUMKKyAgICAvLyB0byBhY3QgbGlrZSBhIG1vcmUgZnVsbCBmZWF0 dXJlZCBleGVjLgorICAgIGZsYWdzIHw9IFBPU0lYX1NQQVdOX1NFVEVYRUM7CisKKyAgICBzaWdz ZXRfdCBzaWduYWxNYXNrU2V0OworICAgIHNpZ2VtcHR5c2V0KCZzaWduYWxNYXNrU2V0KTsKKyAg ICBwb3NpeF9zcGF3bmF0dHJfc2V0c2lnbWFzaygmYXR0ciwgJnNpZ25hbE1hc2tTZXQpOworICAg IGZsYWdzIHw9IFBPU0lYX1NQQVdOX1NFVFNJR01BU0s7CisKKyAgICBzdGF0aWMgY29uc3QgaW50 IGFsbG93RXhlY3V0YWJsZUhlYXBGbGFnID0gMHgyMDAwOworICAgIGlmIChpbmZvLT5leGVjdXRh YmxlSGVhcCkKKyAgICAgICAgZmxhZ3MgfD0gYWxsb3dFeGVjdXRhYmxlSGVhcEZsYWc7CisKKyAg ICBwb3NpeF9zcGF3bmF0dHJfc2V0ZmxhZ3MoJmF0dHIsIGZsYWdzKTsKKworICAgIHNpemVfdCBv dXRDb3VudCA9IDA7CisgICAgcG9zaXhfc3Bhd25hdHRyX3NldGJpbnByZWZfbnAoJmF0dHIsIDEs ICZpbmZvLT5jcHVUeXBlLCAmb3V0Q291bnQpOworCisgICAgY2hhciBwYXRoWzQgKiBQQVRIX01B WF07CisgICAgdWludDMyX3QgcGF0aExlbmd0aCA9IHNpemVvZihwYXRoKTsKKyAgICBfTlNHZXRF eGVjdXRhYmxlUGF0aChwYXRoLCAmcGF0aExlbmd0aCk7CisKKyAgICBjaGFyKiogYXJndiA9ICpf TlNHZXRBcmd2KCk7CisgICAgY29uc3QgY2hhciogcHJvZ3JhbU5hbWUgPSBhcmd2WzBdOworICAg IGNvbnN0IGNoYXIqIGFyZ3NbXSA9IHsgcHJvZ3JhbU5hbWUsIDAgfTsKKworICAgIHBpZF90IHBy b2Nlc3NJZGVudGlmaWVyID0gMDsKKyAgICBwb3NpeF9zcGF3bigmcHJvY2Vzc0lkZW50aWZpZXIs IHBhdGgsIDAsICZhdHRyLCBjb25zdF9jYXN0PGNoYXIqKj4oYXJncyksIGluZm8tPmVudmlyb25t ZW50KTsKKworICAgIHBvc2l4X3NwYXduYXR0cl9kZXN0cm95KCZhdHRyKTsKKworICAgIE5TTG9n KEAiVW5hYmxlIHRvIHJlLWV4ZWMgZm9yIHBhdGg6ICVzIiwgcGF0aCk7CisgICAgZXhpdChFWElU X0ZBSUxVUkUpOworfQorCitzdGF0aWMgTk9fUkVUVVJOIHZvaWQgcmVleGVjQ2FsbEJhY2soQ0ZS dW5Mb29wVGltZXJSZWYgdGltZXIsIHZvaWQgKmluZm8pCit7CisgICAgcmVleGVjKHN0YXRpY19j YXN0PFJlZXhlY0luZm8gKj4oaW5mbykpOworfQorCiBzdGF0aWMgdm9pZCBYUENTZXJ2aWNlRXZl bnRIYW5kbGVyKHhwY19jb25uZWN0aW9uX3QgcGVlcikKIHsKICAgICB4cGNfY29ubmVjdGlvbl9z ZXRfdGFyZ2V0X3F1ZXVlKHBlZXIsIGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCkpOwpAQCAtNDcs NTQgKzEwMSwyMiBAQCBzdGF0aWMgdm9pZCBYUENTZXJ2aWNlRXZlbnRIYW5kbGVyKHhwY19jCiAg ICAgICAgICAgICBhc3NlcnQodHlwZSA9PSBYUENfVFlQRV9ESUNUSU9OQVJZKTsKIAogICAgICAg ICAgICAgaWYgKCFzdHJjbXAoeHBjX2RpY3Rpb25hcnlfZ2V0X3N0cmluZyhldmVudCwgIm1lc3Nh Z2UtbmFtZSIpLCAicmUtZXhlYyIpKSB7Ci0gICAgICAgICAgICAgICAgcG9zaXhfc3Bhd25hdHRy X3QgYXR0cjsKLSAgICAgICAgICAgICAgICBwb3NpeF9zcGF3bmF0dHJfaW5pdCgmYXR0cik7Cisg ICAgICAgICAgICAgICAgUmVleGVjSW5mbyAqaW5mbyA9IHN0YXRpY19jYXN0PFJlZXhlY0luZm8g Kj4obWFsbG9jKHNpemVvZihSZWV4ZWNJbmZvKSkpOwogCi0gICAgICAgICAgICAgICAgc2hvcnQg ZmxhZ3MgPSAwOwotCi0gICAgICAgICAgICAgICAgLy8gV2UganVzdCB3YW50IHRvIHNldCB0aGUg cHJvY2VzcyBzdGF0ZSwgbm90IGFjdHVhbGx5IGxhdW5jaCBhIG5ldyBwcm9jZXNzLAotICAgICAg ICAgICAgICAgIC8vIHNvIHdlIGFyZSBnb2luZyB0byB1c2UgdGhlIGRhcndpbiBleHRlbnNpb24g dG8gcG9zaXhfc3Bhd24gUE9TSVhfU1BBV05fU0VURVhFQwotICAgICAgICAgICAgICAgIC8vIHRv IGFjdCBsaWtlIGEgbW9yZSBmdWxsIGZlYXR1cmVkIGV4ZWMuCi0gICAgICAgICAgICAgICAgZmxh Z3MgfD0gUE9TSVhfU1BBV05fU0VURVhFQzsKLQotICAgICAgICAgICAgICAgIHNpZ3NldF90IHNp Z25hbE1hc2tTZXQ7Ci0gICAgICAgICAgICAgICAgc2lnZW1wdHlzZXQoJnNpZ25hbE1hc2tTZXQp OwotICAgICAgICAgICAgICAgIHBvc2l4X3NwYXduYXR0cl9zZXRzaWdtYXNrKCZhdHRyLCAmc2ln bmFsTWFza1NldCk7Ci0gICAgICAgICAgICAgICAgZmxhZ3MgfD0gUE9TSVhfU1BBV05fU0VUU0lH TUFTSzsKLQotICAgICAgICAgICAgICAgIHN0YXRpYyBjb25zdCBpbnQgYWxsb3dFeGVjdXRhYmxl SGVhcEZsYWcgPSAweDIwMDA7Ci0gICAgICAgICAgICAgICAgaWYgKHhwY19kaWN0aW9uYXJ5X2dl dF9ib29sKGV2ZW50LCAiZXhlY3V0YWJsZS1oZWFwIikpCi0gICAgICAgICAgICAgICAgICAgIGZs YWdzIHw9IGFsbG93RXhlY3V0YWJsZUhlYXBGbGFnOwotCi0gICAgICAgICAgICAgICAgcG9zaXhf c3Bhd25hdHRyX3NldGZsYWdzKCZhdHRyLCBmbGFncyk7Ci0KLSAgICAgICAgICAgICAgICBjcHVf dHlwZV90IGNwdVR5cGVzW10gPSB7IChjcHVfdHlwZV90KXhwY19kaWN0aW9uYXJ5X2dldF91aW50 NjQoZXZlbnQsICJhcmNoaXRlY3R1cmUiKSB9OwotICAgICAgICAgICAgICAgIHNpemVfdCBvdXRD b3VudCA9IDA7Ci0gICAgICAgICAgICAgICAgcG9zaXhfc3Bhd25hdHRyX3NldGJpbnByZWZfbnAo JmF0dHIsIDEsIGNwdVR5cGVzLCAmb3V0Q291bnQpOwotCi0gICAgICAgICAgICAgICAgY2hhciBw YXRoWzQgKiBQQVRIX01BWF07Ci0gICAgICAgICAgICAgICAgdWludDMyX3QgcGF0aExlbmd0aCA9 IHNpemVvZihwYXRoKTsKLSAgICAgICAgICAgICAgICBfTlNHZXRFeGVjdXRhYmxlUGF0aChwYXRo LCAmcGF0aExlbmd0aCk7Ci0KLSAgICAgICAgICAgICAgICBjaGFyKiogYXJndiA9ICpfTlNHZXRB cmd2KCk7Ci0gICAgICAgICAgICAgICAgY29uc3QgY2hhciogcHJvZ3JhbU5hbWUgPSBhcmd2WzBd OwotICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIqIGFyZ3NbXSA9IHsgcHJvZ3JhbU5hbWUsIDAg fTsKKyAgICAgICAgICAgICAgICBpbmZvLT5leGVjdXRhYmxlSGVhcCA9IHhwY19kaWN0aW9uYXJ5 X2dldF9ib29sKGV2ZW50LCAiZXhlY3V0YWJsZS1oZWFwIik7CisgICAgICAgICAgICAgICAgaW5m by0+Y3B1VHlwZSA9IChjcHVfdHlwZV90KXhwY19kaWN0aW9uYXJ5X2dldF91aW50NjQoZXZlbnQs ICJhcmNoaXRlY3R1cmUiKTsKIAogICAgICAgICAgICAgICAgIHhwY19vYmplY3RfdCBlbnZpcm9u bWVudEFycmF5ID0geHBjX2RpY3Rpb25hcnlfZ2V0X3ZhbHVlKGV2ZW50LCAiZW52aXJvbm1lbnQi KTsKICAgICAgICAgICAgICAgICBzaXplX3QgbnVtYmVyT2ZFbnZpcm9ubWVudFZhcmlhYmxlcyA9 IHhwY19hcnJheV9nZXRfY291bnQoZW52aXJvbm1lbnRBcnJheSk7Ci0KLSAgICAgICAgICAgICAg ICBjb25zdCBjaGFyKiogZW52aXJvbm1lbnQgPSAoY29uc3QgY2hhcioqKW1hbGxvYyhudW1iZXJP ZkVudmlyb25tZW50VmFyaWFibGVzICogc2l6ZW9mKGNoYXIqKSArIDEpOworICAgICAgICAgICAg ICAgIGNoYXIqKiBlbnZpcm9ubWVudCA9IHN0YXRpY19jYXN0PGNoYXIgKio+KG1hbGxvYyhudW1i ZXJPZkVudmlyb25tZW50VmFyaWFibGVzICogc2l6ZW9mKGNoYXIqKSArIDEpKTsKICAgICAgICAg ICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG51bWJlck9mRW52aXJvbm1lbnRWYXJpYWJs ZXM7ICsraSkKLSAgICAgICAgICAgICAgICAgICAgZW52aXJvbm1lbnRbaV0gPSB4cGNfYXJyYXlf Z2V0X3N0cmluZyhlbnZpcm9ubWVudEFycmF5LCBpKTsKKyAgICAgICAgICAgICAgICAgICAgZW52 aXJvbm1lbnRbaV0gPSBzdHJkdXAoeHBjX2FycmF5X2dldF9zdHJpbmcoZW52aXJvbm1lbnRBcnJh eSwgaSkpOwogICAgICAgICAgICAgICAgIGVudmlyb25tZW50W251bWJlck9mRW52aXJvbm1lbnRW YXJpYWJsZXNdID0gMDsKKyAgICAgICAgICAgICAgICBpbmZvLT5lbnZpcm9ubWVudCA9IGVudmly b25tZW50OwogCi0gICAgICAgICAgICAgICAgcGlkX3QgcHJvY2Vzc0lkZW50aWZpZXIgPSAwOwot ICAgICAgICAgICAgICAgIHBvc2l4X3NwYXduKCZwcm9jZXNzSWRlbnRpZmllciwgcGF0aCwgMCwg JmF0dHIsIGNvbnN0X2Nhc3Q8Y2hhcioqPihhcmdzKSwgY29uc3RfY2FzdDxjaGFyKio+KGVudmly b25tZW50KSk7Ci0KLSAgICAgICAgICAgICAgICBwb3NpeF9zcGF3bmF0dHJfZGVzdHJveSgmYXR0 cik7Ci0KLSAgICAgICAgICAgICAgICBOU0xvZyhAIlVuYWJsZSB0byByZS1leGVjIGZvciBwYXRo OiAlcyIsIHBhdGgpOwotICAgICAgICAgICAgICAgIGV4aXQoRVhJVF9GQUlMVVJFKTsKKyAgICAg ICAgICAgICAgICBDRlJ1bkxvb3BUaW1lckNvbnRleHQgY29udGV4dCA9IHsgMCwgaW5mbywgTlVM TCwgTlVMTCwgTlVMTCB9OworICAgICAgICAgICAgICAgIENGUnVuTG9vcFRpbWVyUmVmIHRpbWVy ID0gQ0ZSdW5Mb29wVGltZXJDcmVhdGUoTlVMTCwgQ0ZBYnNvbHV0ZVRpbWVHZXRDdXJyZW50KCks IDAsIDAsIDAsIHJlZXhlY0NhbGxCYWNrLCAmY29udGV4dCk7CisgICAgICAgICAgICAgICAgQ0ZS dW5Mb29wQWRkVGltZXIoQ0ZSdW5Mb29wR2V0Q3VycmVudCgpLCB0aW1lciwga0NGUnVuTG9vcENv bW1vbk1vZGVzKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKCFzdHJjbXAoeHBj X2RpY3Rpb25hcnlfZ2V0X3N0cmluZyhldmVudCwgIm1lc3NhZ2UtbmFtZSIpLCAiYm9vdHN0cmFw IikpIHsK