116679 2013-05-23 09:00:39 -0700 Refactoring CSS grammar 2013-05-28 07:37:32 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 115709 116071 1 svillar svillar benjamin csaavedra darin glenn kling svillar syoichi oldest_to_newest 892911 0 svillar 2013-05-23 09:00:39 -0700 We should probably merge https://chromium.googlesource.com/chromium/blink/+/959863e444241eb36cff89d2c956676cd468bddf Nonfunctional change. Introduced closing_parenthesis and error_recovery to reduce code duplication. Extracted from https://codereview.chromium.org/14969002/ 892924 1 svillar 2013-05-23 09:40:21 -0700 Which seems to depend on https://codereview.chromium.org/14083017. 894287 2 203036 svillar 2013-05-28 03:36:52 -0700 Created attachment 203036 Patch 894357 3 203036 svillar 2013-05-28 07:37:25 -0700 Comment on attachment 203036 Patch Clearing flags on attachment: 203036 Committed r150804: <http://trac.webkit.org/changeset/150804> 894358 4 svillar 2013-05-28 07:37:32 -0700 All reviewed patches have been landed. Closing bug. 203036 2013-05-28 03:36:52 -0700 2013-05-28 07:37:25 -0700 Patch bug-116679-20130528123531.patch text/plain 4020 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTJiYjcyNzg3ZjFmMzdj ODQzNzgwNDVmZmNlNzQyNWI0YTRjMDhiYS4uNTlhMWY3OTQ4MjNlN2Y2NWZlM2UzYjBmN2ZhMTUz ODZlMTliMjdhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA1LTI4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJlZmFjdG9y aW5nIENTUyBncmFtbWFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTY2NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGcm9tIEJsaW5rIHIxNDk5NDggYnkgPHNlcnlhQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBZGRlZCAiY2xvc2luZ19wYXJlbnRoZXNpczoiIGFuZCAiZXJyb3JfcmVjb3Zlcnk6IiB0 byBhdm9pZCBjb2RlCisgICAgICAgIGR1cGxpY2F0aW9uIGluIGEgY291cGxlIG9mIGVycm9yIHJl Y292ZXJ5IHJ1bGVzLiBTb21lIG90aGVyIHJ1bGVzCisgICAgICAgIHdlcmUgYWxzbyByZWZhY3Rv cmVkIHdoaWNoIGFsbG93cyB0byByZWR1Y2UgdGhlIHRoZSBudW1iZXIgb2YKKyAgICAgICAgc2hp ZnQvcmVkdWNlIGNvbmZsaWN0cyBieSAyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJl ZCBhcyB0aGlzIGlzIGp1c3QgYSByZWZhY3RvcmluZywgbm8gbmV3CisgICAgICAgIGZ1bmN0aW9u YWxpdHkgYWRkZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55LmluOgorCiAyMDEzLTA1 LTI3ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IEludmFsaWQgYmxvY2sgZG9lc24ndCBtYWtlIGRlY2xhcmF0aW9uIGludmFsaWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4gYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTR3JhbW1hci55LmluCmluZGV4IDBmMDc5MDE4NDg0YzIzMzI4YmNlNWMzMjlkZjE4NTZh NTNkZmQwYzIuLjRjYWNmZmJkNDUxNmU0ZTVkNTlkNThlYzRhYmI1NjlkNTdjODAwMzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4KKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgpAQCAtODgsOSArODgsOSBAQCBzdGF0aWMgaW5saW5l IGJvb2wgaXNDU1NUb2tlbkFTdHJpbmcoaW50IHl5dHlwZSkKICV9CiAKICNpZiBFTkFCTEVfU0hB RE9XX0RPTQotJWV4cGVjdCA2NQorJWV4cGVjdCA2MwogI2Vsc2UKLSVleHBlY3QgNjQKKyVleHBl Y3QgNjIKICNlbmRpZgogCiAlbm9uYXNzb2MgTE9XRVNUX1BSRUMKQEAgLTQyOCw2ICs0MjgsMTEg QEAgY2xvc2luZ19icmFjZToKICAgfCAlcHJlYyBMT1dFU1RfUFJFQyBUT0tFTl9FT0YKICAgOwog CitjbG9zaW5nX3BhcmVudGhlc2lzOgorICAgICcpJworICB8ICVwcmVjIExPV0VTVF9QUkVDIFRP S0VOX0VPRgorICA7CisKIGNoYXJzZXQ6CiAgIENIQVJTRVRfU1lNIG1heWJlX3NwYWNlIFNUUklO RyBtYXliZV9zcGFjZSAnOycgewogICAgICBpZiAocGFyc2VyLT5tX3N0eWxlU2hlZXQpCkBAIC0x NTYxLDExICsxNTY2LDkgQEAgZGVjbF9saXN0OgogICAgIDsKIAogZGVjbF9saXN0X3JlY292ZXJ5 OgotICAgIGVycm9yIGVycm9yX2xvY2F0aW9uIHsKKyAgICBlcnJvciBlcnJvcl9sb2NhdGlvbiBl cnJvcl9yZWNvdmVyeSB7CiAgICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDIsIENTU1BhcnNl cjo6UHJvcGVydHlEZWNsYXJhdGlvbkVycm9yKTsKICAgICB9Ci0gICAgfCBkZWNsX2xpc3RfcmVj b3ZlcnkgaW52YWxpZF9ibG9jawotICAgIHwgZGVjbF9saXN0X3JlY292ZXJ5IGVycm9yCiAgICAg OwogCiBkZWNsYXJhdGlvbjoKQEAgLTE2MTgsMTEgKzE2MjEsOSBAQCBkZWNsYXJhdGlvbjoKICAg OwogCiBkZWNsYXJhdGlvbl9yZWNvdmVyeToKLSAgICBlcnJvciBlcnJvcl9sb2NhdGlvbiB7Cisg ICAgZXJyb3IgZXJyb3JfbG9jYXRpb24gZXJyb3JfcmVjb3ZlcnkgewogICAgICAgICBwYXJzZXIt PnN5bnRheEVycm9yKCQyKTsKICAgICB9Ci0gICAgfCBkZWNsYXJhdGlvbl9yZWNvdmVyeSBpbnZh bGlkX2Jsb2NrCi0gICAgfCBkZWNsYXJhdGlvbl9yZWNvdmVyeSBlcnJvcgogICA7CiAKIHByb3Bl cnR5OgpAQCAtMTY1NCwxNyArMTY1NSwxNSBAQCBleHByOgogICAgICAgICAgICAgJCQtPmFkZFZh bHVlKHBhcnNlci0+c2lua0Zsb2F0aW5nVmFsdWUoJDMpKTsKICAgICAgICAgfQogICAgIH0KLSAg ICB8IGV4cHIgaW52YWxpZF9ibG9ja19saXN0IHsKLSAgICAgICAgJCQgPSAwOwotICAgIH0KLSAg ICB8IGV4cHIgaW52YWxpZF9ibG9ja19saXN0IGVycm9yIHsKLSAgICAgICAgJCQgPSAwOwotICAg IH0KLSAgICB8IGV4cHIgZXJyb3IgeworICAgIHwgZXhwciBleHByX3JlY292ZXJ5IHsKICAgICAg ICAgJCQgPSAwOwogICAgIH0KICAgOwogCitleHByX3JlY292ZXJ5OgorICAgIGVycm9yIGVycm9y X2xvY2F0aW9uIGVycm9yX3JlY292ZXJ5CisgIDsKKwogb3BlcmF0b3I6CiAgICAgJy8nIG1heWJl X3NwYWNlIHsKICAgICAgICAgJCQgPSAnLyc7CkBAIC0xNzU0LDE1ICsxNzUzLDcgQEAgdW5hcnlf dGVybToKICAgOwogCiBmdW5jdGlvbjoKLSAgICBGVU5DVElPTiBtYXliZV9zcGFjZSBleHByICcp JyBtYXliZV9zcGFjZSB7Ci0gICAgICAgIENTU1BhcnNlckZ1bmN0aW9uKiBmID0gcGFyc2VyLT5j cmVhdGVGbG9hdGluZ0Z1bmN0aW9uKCk7Ci0gICAgICAgIGYtPm5hbWUgPSAkMTsKLSAgICAgICAg Zi0+YXJncyA9IHBhcnNlci0+c2lua0Zsb2F0aW5nVmFsdWVMaXN0KCQzKTsKLSAgICAgICAgJCQu aWQgPSAwOwotICAgICAgICAkJC51bml0ID0gQ1NTUGFyc2VyVmFsdWU6OkZ1bmN0aW9uOwotICAg ICAgICAkJC5mdW5jdGlvbiA9IGY7Ci0gICAgfSB8Ci0gICAgRlVOQ1RJT04gbWF5YmVfc3BhY2Ug ZXhwciBUT0tFTl9FT0YgeworICAgIEZVTkNUSU9OIG1heWJlX3NwYWNlIGV4cHIgY2xvc2luZ19w YXJlbnRoZXNpcyBtYXliZV9zcGFjZSB7CiAgICAgICAgIENTU1BhcnNlckZ1bmN0aW9uKiBmID0g cGFyc2VyLT5jcmVhdGVGbG9hdGluZ0Z1bmN0aW9uKCk7CiAgICAgICAgIGYtPm5hbWUgPSAkMTsK ICAgICAgICAgZi0+YXJncyA9IHBhcnNlci0+c2lua0Zsb2F0aW5nVmFsdWVMaXN0KCQzKTsKQEAg LTE3NzAsNyArMTc2MSw3IEBAIGZ1bmN0aW9uOgogICAgICAgICAkJC51bml0ID0gQ1NTUGFyc2Vy VmFsdWU6OkZ1bmN0aW9uOwogICAgICAgICAkJC5mdW5jdGlvbiA9IGY7CiAgICAgfSB8Ci0gICAg RlVOQ1RJT04gbWF5YmVfc3BhY2UgJyknIG1heWJlX3NwYWNlIHsKKyAgICBGVU5DVElPTiBtYXli ZV9zcGFjZSBjbG9zaW5nX3BhcmVudGhlc2lzIG1heWJlX3NwYWNlIHsKICAgICAgICAgQ1NTUGFy c2VyRnVuY3Rpb24qIGYgPSBwYXJzZXItPmNyZWF0ZUZsb2F0aW5nRnVuY3Rpb24oKTsKICAgICAg ICAgZi0+bmFtZSA9ICQxOwogICAgICAgICBDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlzdCA9 IHBhcnNlci0+Y3JlYXRlRmxvYXRpbmdWYWx1ZUxpc3QoKTsKQEAgLTE3ODgsNyArMTc3OSw3IEBA IGZ1bmN0aW9uOgogICAgICAgICAkJC5mdW5jdGlvbiA9IGY7CiAgIH0KICAgOwotIAorCiBjYWxj X2Z1bmNfdGVybToKICAgdW5hcnlfdGVybSB7ICQkID0gJDE7IH0KICAgfCBWQVJGVU5DVElPTiBt YXliZV9zcGFjZSBJREVOVCAnKScgbWF5YmVfc3BhY2UgewpAQCAtMTk4MCw1ICsxOTcxLDExIEBA IGVycm9yX2xvY2F0aW9uOiB7CiAgICAgfQogICAgIDsKIAorZXJyb3JfcmVjb3Zlcnk6CisgICAg LyogZW1wdHkgKi8KKyAgfCBlcnJvcl9yZWNvdmVyeSBpbnZhbGlkX2Jsb2NrCisgIHwgZXJyb3Jf cmVjb3ZlcnkgZXJyb3IKKyAgICA7CisKICUlCiAK