<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>116678</bug_id>
          
          <creation_ts>2013-05-23 08:38:57 -0700</creation_ts>
          <short_desc>CSS Variables tokenisation not checking CSS identifier length</short_desc>
          <delta_ts>2013-06-12 09:38:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>116071</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sergio Villar Senin">svillar</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alancutter</cc>
    
    <cc>glenn</cc>
    
    <cc>svillar</cc>
    
    <cc>syoichi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>892902</commentid>
    <comment_count>0</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2013-05-23 08:38:57 -0700</bug_when>
    <thetext>We should consider merging this change https://codereview.chromium.org/15317009 and the test case which is not currently in WebKit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>899579</commentid>
    <comment_count>1</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2013-06-12 09:38:41 -0700</bug_when>
    <thetext>There is no need to merge this fix. The ASSERT() was triggered because the code was using isEqualToCSSIdentifier() which had some restrictions not applicable to the CSS variables case. Actually the ASSERT() mentioned in the Chromium bug can no longer happen since r150776, as we perform a case sensitive check in a different inline method which does not have those assertions.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>