116674 2013-05-23 07:26:13 -0700 [BlackBerry] Validate form data before doing direct submission. 2013-05-23 08:54:58 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton commit-queue oldest_to_newest 892863 0 mifenton 2013-05-23 07:26:13 -0700 Two fixes: 1) Improve the submission trigger to validate the form. 2) Respect TabIndex when calculating next/prev elements. 892870 1 202711 mifenton 2013-05-23 07:30:37 -0700 Created attachment 202711 Validation patch. 892871 2 202712 mifenton 2013-05-23 07:31:21 -0700 Created attachment 202712 tabIndex patch 892884 3 202712 mifenton 2013-05-23 08:04:32 -0700 Comment on attachment 202712 tabIndex patch Clearing flags, moved to new bug 116676. 892885 4 202711 xan.lopez 2013-05-23 08:06:27 -0700 Comment on attachment 202711 Validation patch. View in context: https://bugs.webkit.org/attachment.cgi?id=202711&action=review > Source/WebKit/blackberry/ChangeLog:3 > + [BlackBerry] Improve input form control handling. We should do one patch per bug. I suggest we rename this to something related to form validation, and move the other patch elsewhere. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1022 > + formElement->submit(); Makes sense to me otherwise, seems it just moves code around to check validity before doing submit(). So please rename the title to land it! 892886 5 202716 mifenton 2013-05-23 08:10:07 -0700 Created attachment 202716 Updated Patch 892887 6 202716 xan.lopez 2013-05-23 08:12:21 -0700 Comment on attachment 202716 Updated Patch r=me 892909 7 202716 commit-queue 2013-05-23 08:54:56 -0700 Comment on attachment 202716 Updated Patch Clearing flags on attachment: 202716 Committed r150587: <http://trac.webkit.org/changeset/150587> 892910 8 commit-queue 2013-05-23 08:54:58 -0700 All reviewed patches have been landed. Closing bug. 202711 2013-05-23 07:30:37 -0700 2013-05-23 08:10:07 -0700 Validation patch. 0001-2013-05-21-Mike-Fenton-mifenton-rim.com.patch text/plain 2755 mifenton RnJvbSA5NzE5MmM4YTc4NzM1NTIxNWI3ZTNlNzIyNmZmMDZjYTRjYzMxNTBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VHVlLCAyMSBNYXkgMjAxMyAxMzo1MTo0MiAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSAyMDEz LTA1LTIxICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CgogICAgICAgIFBSIDMxNDIw Mi4KCiAgICAgICAgQ2hlY2sgdmFsaWRhdGlvbiBvZiB0aGUgaW5wdXQgZm9ybSBiZWZvcmUgdHJp Z2dlcmluZyBkaXJlY3Qgc3VibWlzc2lvbi4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgogICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6c3VibWl0Rm9ybSk6Ci0tLQogU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgICAx NiArKysrKysrKysrKysrKysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9J bnB1dEhhbmRsZXIuY3BwICAgfCAgIDE1ICsrKysrKysrKy0tLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAyNSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCmluZGV4IGZiMzRmOWIuLjExOGFlMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTIzICBNaWtlIEZlbnRvbiAgPG1pZmVudG9u QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEltcHJvdmUgaW5wdXQgZm9ybSBjb250 cm9sIGhhbmRsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE2Njc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUFIgMzE0MjAyLgorCisgICAgICAgIENoZWNrIHZhbGlkYXRpb24gb2YgdGhlIGlucHV0 IGZvcm0gYmVmb3JlIHRyaWdnZXJpbmcgZGlyZWN0IHN1Ym1pc3Npb24uCisKKyAgICAgICAgSW50 ZXJuYWxseSBSZXZpZXdlZCBieSBOaW1hIEdoYW5hdmF0aWFuLgorCisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJ bnB1dEhhbmRsZXI6OnN1Ym1pdEZvcm0pOgorCiAyMDEzLTA1LTIxICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gTWFrZSBQ YWdlUG9wdXAgaW1wbGVtZW50YXRpb24gaW5kZXBlbmRlbnQgZnJvbSBXZWJDb3JlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIu Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVy LmNwcAppbmRleCA0M2I2OTEwLi40YmYxMWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTEwMDgsMTUg KzEwMDgsMTggQEAgdm9pZCBJbnB1dEhhbmRsZXI6OnN1Ym1pdEZvcm0oKQogICAgICAgICByZXR1 cm47CiAKICAgICBJbnB1dExvZyhQbGF0Zm9ybTo6TG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVy OjpzdWJtaXRGb3JtIHRyaWdnZXJlZCIpOwotICAgIGlmIChlbGVtZW50VHlwZShtX2N1cnJlbnRG b2N1c0VsZW1lbnQuZ2V0KCkpID09IElucHV0VHlwZVRleHRBcmVhKQotICAgICAgICBmb3JtRWxl bWVudC0+c3VibWl0KCk7Ci0gICAgZWxzZSB7CisKKyAgICBpZiAoZWxlbWVudFR5cGUobV9jdXJy ZW50Rm9jdXNFbGVtZW50LmdldCgpKSAhPSBJbnB1dFR5cGVUZXh0QXJlYSkgewogICAgICAgICBo YW5kbGVLZXlib2FyZElucHV0KFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50KEtFWUNPREVfUkVUVVJO LCBQbGF0Zm9ybTo6S2V5Ym9hcmRFdmVudDo6S2V5Q2hhciwgMCksIGZhbHNlIC8qIGNoYW5nZUlz UGFydE9mQ29tcG9zaXRpb24gKi8pOwogCi0gICAgICAgIC8vIENvbmZpcm0gdGhhdCBpbXBsaWNp dCBzdWJtaXNzaW9uIHdhcyBhY2NlcHRlZC4KLSAgICAgICAgaWYgKGlzQWN0aXZlVGV4dEVkaXQo KSkKLSAgICAgICAgICAgIGZvcm1FbGVtZW50LT5zdWJtaXQoKTsKKyAgICAgICAgLy8gRGlkIHRo aXMgY2xlYXIgdGhlIGZvY3VzPyBJZiBzbywgZm9ybSB3YXMgc3VibWl0dGVkIG9yIGludmFsaWQu CisgICAgICAgIGlmICghaXNBY3RpdmVUZXh0RWRpdCgpKQorICAgICAgICAgICAgcmV0dXJuOwog ICAgIH0KKworICAgIC8vIFZhbGlkYXRlIGZvcm0gZGF0YSBhbmQgaWYgdmFsaWQsIHN1Ym1pdC4K KyAgICBpZiAoZm9ybUVsZW1lbnQtPmNoZWNrVmFsaWRpdHkoKSkKKyAgICAgICAgZm9ybUVsZW1l bnQtPnN1Ym1pdCgpOwogfQogCiBzdGF0aWMgdm9pZCBhZGRJbnB1dFN0eWxlTWFza0ZvcktleWJv YXJkVHlwZShpbnQ2NF90JiBpbnB1dE1hc2ssIFZpcnR1YWxLZXlib2FyZFR5cGUga2V5Ym9hcmRU eXBlKQotLSAKMS43LjEwLjQKCg== 202712 2013-05-23 07:31:21 -0700 2013-05-23 08:04:32 -0700 tabIndex patch 0002-2013-05-22-Mike-Fenton-mifenton-rim.com.patch text/plain 9817 mifenton RnJvbSAxNjViMWVlYmM1M2MzODc2MjE4MTdmYWYwNDkxZTAzZGYyZGIxNzVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog V2VkLCAyMiBNYXkgMjAxMyAxNDoxOTo1MyAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSAyMDEz LTA1LTIyICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CgogICAgICAgIFBSIDMzNzQx OS4KCiAgICAgICAgVXBkYXRlIGZvcm0gY29udHJvbCBuYXZpZ2F0aW9uIHRyYWNraW5nIHRvIHRh a2UgdGFiaW5kZXgKICAgICAgICBvcmRlciBpbnRvIGFjY291bnQgd2hlbiBjYWxjdWxhdGluZyBu ZXh0IGFuZCBwcmV2aW91cyBub2Rlcy4KCiAgICAgICAgVGhlIG9yZGVyIHRvIGZvbGxvdyBpcyB0 YWIgaW5kZXggMSAtIE4sIGZvbGxvd2VkIGJ5IGFsbCBpdGVtcwogICAgICAgIHdpdGhvdXQgYSB0 YWIgaW5kZXggb3IgdGFiIGluZGV4IDAgaW4gcmVuZGVyaW5nIG9yZGVyIHRvIG1hdGNoCiAgICAg ICAgd2l0aCBzdGFuZGFyZCBkZXNrdG9wIGJlaGF2aW9yLgoKICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6 CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjp1cGRhdGVGb3JtU3Rh dGUpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgICAyMSArKysrCiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxl ci5jcHAgICAgICB8ICAxMDEgKysrKysrKysrKysrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTAzIGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCmluZGV4IDExOGFlMWQuLmYxYTNlNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZwpAQCAtNSw2ICs1LDI3IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCiAKKyAgICAgICAgUFIgMzM3NDE5LgorCisgICAgICAgIFVwZGF0ZSBmb3JtIGNvbnRyb2wg bmF2aWdhdGlvbiB0cmFja2luZyB0byB0YWtlIHRhYmluZGV4CisgICAgICAgIG9yZGVyIGludG8g YWNjb3VudCB3aGVuIGNhbGN1bGF0aW5nIG5leHQgYW5kIHByZXZpb3VzIG5vZGVzLgorCisgICAg ICAgIFRoZSBvcmRlciB0byBmb2xsb3cgaXMgdGFiIGluZGV4IDEgLSBOLCBmb2xsb3dlZCBieSBh bGwgaXRlbXMKKyAgICAgICAgd2l0aG91dCBhIHRhYiBpbmRleCBvciB0YWIgaW5kZXggMCBpbiBy ZW5kZXJpbmcgb3JkZXIgdG8gbWF0Y2gKKyAgICAgICAgd2l0aCBzdGFuZGFyZCBkZXNrdG9wIGJl aGF2aW9yLgorCisgICAgICAgIEludGVybmFsbHkgUmV2aWV3ZWQgYnkgR2VuZXZpZXZlIE1hayBh bmQgTmltYSBHaGFuYXZhdGlhbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5k bGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjp1cGRh dGVGb3JtU3RhdGUpOgorCisyMDEzLTA1LTIzICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5j b20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEltcHJvdmUgaW5wdXQgZm9ybSBjb250cm9sIGhh bmRsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE2Njc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAg UFIgMzE0MjAyLgogCiAgICAgICAgIENoZWNrIHZhbGlkYXRpb24gb2YgdGhlIGlucHV0IGZvcm0g YmVmb3JlIHRyaWdnZXJpbmcgZGlyZWN0IHN1Ym1pc3Npb24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA0 YmYxMWQwLi4zZjM0MWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTk0NywzNSArOTQ3LDk4IEBAIHZv aWQgSW5wdXRIYW5kbGVyOjp1cGRhdGVGb3JtU3RhdGUoKQogICAgIGlmIChmb3JtRWxlbWVudENv dW50IDwgMikKICAgICAgICAgcmV0dXJuOwogCi0gICAgSW5wdXRMb2coUGxhdGZvcm06OkxvZ0xl dmVsSW5mbywgIklucHV0SGFuZGxlcjo6dXBkYXRlRm9ybVN0YXRlIGZvcm0gaGFzICVkIGZpZWxk cyIsIGZvcm1FbGVtZW50Q291bnQpOwogCiAgICAgbV9oYXNTdWJtaXRCdXR0b24gPSB0cnVlOwot ICAgIGZvciAoaW50IGZvY3VzRWxlbWVudElkID0gMDsgZm9jdXNFbGVtZW50SWQgPCBmb3JtRWxl bWVudENvdW50OyBmb2N1c0VsZW1lbnRJZCsrKSB7Ci0gICAgICAgIGlmICh0b0hUTUxFbGVtZW50 KGZvcm1FbGVtZW50TGlzdFtmb2N1c0VsZW1lbnRJZF0pICE9IG1fY3VycmVudEZvY3VzRWxlbWVu dCkKLSAgICAgICAgICAgIGNvbnRpbnVlOwogCi0gICAgICAgIC8vIEZvdW5kIHRoZSBmb2N1c2Vk IGVsZW1lbnQsIGdldCB0aGUgbmV4dCBhbmQgcHJldmlvdXMgZWxlbWVudHMgaWYgdGhleSBleGlz dC4KKyAgICAvLyBXYWxrIGFsbCBlbGVtZW50cyBpbiB0aGUgZm9ybSB0byBkZXRlcm1pbmUgbmV4 dC9wcmV2IGVsZW1lbnRzLgorICAgIGludCBmb2N1c1RhYkluZGV4ID0gc3RhdGljX2Nhc3Q8Tm9k ZSo+KG1fY3VycmVudEZvY3VzRWxlbWVudC5nZXQoKSktPnRhYkluZGV4KCk7CisgICAgaW50IHBy ZXZUYWJJbmRleCA9IC0xOworICAgIGludCBuZXh0VGFiSW5kZXggPSBzdGQ6Om51bWVyaWNfbGlt aXRzPHNob3J0Pjo6bWF4KCkgKyAxOworICAgIElucHV0TG9nKFBsYXRmb3JtOjpMb2dMZXZlbElu Zm8sICJJbnB1dEhhbmRsZXI6OnVwZGF0ZUZvcm1TdGF0ZSBmb3JtIGhhcyAlZCBmaWVsZHMgYW5k IHRhYkluZGV4ICVkIiwgZm9ybUVsZW1lbnRDb3VudCwgZm9jdXNUYWJJbmRleCk7CiAKLSAgICAg ICAgLy8gUHJldmlvdXMKLSAgICAgICAgZm9yIChpbnQgcHJldmlvdXNFbGVtZW50SWQgPSBmb2N1 c0VsZW1lbnRJZCAtIDE7IHByZXZpb3VzRWxlbWVudElkID49IDA7IHByZXZpb3VzRWxlbWVudElk LS0pIHsKLSAgICAgICAgICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBjb25zdF9jYXN0PEhUTUxFbGVt ZW50Kj4odG9IVE1MRWxlbWVudChmb3JtRWxlbWVudExpc3RbcHJldmlvdXNFbGVtZW50SWRdKSk7 Ci0gICAgICAgICAgICBpZiAoRE9NU3VwcG9ydDo6aXNUZXh0QmFzZWRDb250ZW50RWRpdGFibGVF bGVtZW50KGVsZW1lbnQpICYmICFET01TdXBwb3J0Ojppc0VsZW1lbnRSZWFkT25seShlbGVtZW50 KSkgewotICAgICAgICAgICAgICAgIG1fcHJldmlvdXNGb2N1c2FibGVUZXh0RWxlbWVudCA9IGVs ZW1lbnQ7Ci0gICAgICAgICAgICAgICAgSW5wdXRMb2coUGxhdGZvcm06OkxvZ0xldmVsSW5mbywg IklucHV0SGFuZGxlcjo6dXBkYXRlRm9ybVN0YXRlIGZvdW5kIHByZXZpb3VzIGVsZW1lbnQiKTsK LSAgICAgICAgICAgICAgICBicmVhazsKKyAgICBFbGVtZW50KiBmaXJzdEluRmllbGRXaXRob3V0 VGFiSW5kZXggPSAwOworICAgIEVsZW1lbnQqIGhpZ2hlc3RUYWJJbmRleEVsZW1lbnQgPSAwOwor ICAgIGZvciAoaW50IGZvY3VzRWxlbWVudElkID0gMDsgZm9jdXNFbGVtZW50SWQgPCBmb3JtRWxl bWVudENvdW50OyBmb2N1c0VsZW1lbnRJZCsrKSB7CisgICAgICAgIC8vIENoZWNrIGZvciB0aGUg Zm9jdXNlZCBlbGVtZW50LCBhbmQgaWYgd2UgZG9uJ3QgaGF2ZSBhbnkgdGFyZ2V0IG5vZGVzLCB1 c2UgdGhlIGZvcm0gb3JkZXIgbmV4dAorICAgICAgICAvLyBhbmQgcHJldmlvdXMgYXMgcGxhY2Vo b2xkZXJzLiBJbiBhIGZvcm0gd2l0aG91dCBwcm92aWRlZCB0YWIgaW5kaWNlcywgdGhpcyB3aWxs IGRldGVybWluZSB0aGUKKyAgICAgICAgLy8gY29udHJvbCBmaWVsZHMuCisgICAgICAgIEVsZW1l bnQqIGVsZW1lbnQgPSBjb25zdF9jYXN0PEhUTUxFbGVtZW50Kj4odG9IVE1MRWxlbWVudChmb3Jt RWxlbWVudExpc3RbZm9jdXNFbGVtZW50SWRdKSk7CisgICAgICAgIGlmIChlbGVtZW50ID09IG1f Y3VycmVudEZvY3VzRWxlbWVudCkgeworICAgICAgICAgICAgSW5wdXRMb2coUGxhdGZvcm06Okxv Z0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6dXBkYXRlRm9ybVN0YXRlIGZvdW5kIGZvY3VzZWQg ZWxlbWVudC4iKTsKKworICAgICAgICAgICAgLy8gSWYgdGhlIGZvY3VzIHRhYiBpbmRleCBpcyBz ZXQgZm9yIHRoZSBub2RlLCBkb24ndCB1c2UgdGhlIGxvZ2ljYWwgb3JkZXJpbmcuCisgICAgICAg ICAgICAvLyBKdW1wIGZyb20gbGFzdCB0YWIgaW5kZXggdG8gdW4tb3JkZXJlZCBpcyBkb25lIHNl cGFyYXRlbHkuCisgICAgICAgICAgICBpZiAoZm9jdXNUYWJJbmRleCkKKyAgICAgICAgICAgICAg ICBjb250aW51ZTsKKworICAgICAgICAgICAgLy8gR2V0IHRoZSBuZXh0L3ByZXYgZWxlbWVudCBp ZiB3ZSBkb24ndCBhbHJlYWR5IGhhdmUgYSB0YWIgaW5kZXggYmFzZWQgaXRlbS4KKyAgICAgICAg ICAgIC8vIFByZXZpb3VzCisgICAgICAgICAgICBpZiAoIW1fcHJldmlvdXNGb2N1c2FibGVUZXh0 RWxlbWVudCkgeworICAgICAgICAgICAgICAgIGZvciAoaW50IHByZXZpb3VzRWxlbWVudElkID0g Zm9jdXNFbGVtZW50SWQgLSAxOyBwcmV2aW91c0VsZW1lbnRJZCA+PSAwOyBwcmV2aW91c0VsZW1l bnRJZC0tKSB7CisgICAgICAgICAgICAgICAgICAgIEVsZW1lbnQqIHByZXZFbGVtZW50ID0gY29u c3RfY2FzdDxIVE1MRWxlbWVudCo+KHRvSFRNTEVsZW1lbnQoZm9ybUVsZW1lbnRMaXN0W3ByZXZp b3VzRWxlbWVudElkXSkpOworICAgICAgICAgICAgICAgICAgICBpZiAoRE9NU3VwcG9ydDo6aXNU ZXh0QmFzZWRDb250ZW50RWRpdGFibGVFbGVtZW50KHByZXZFbGVtZW50KSAmJiAhRE9NU3VwcG9y dDo6aXNFbGVtZW50UmVhZE9ubHkocHJldkVsZW1lbnQpICYmICFzdGF0aWNfY2FzdDxOb2RlKj4o cHJldkVsZW1lbnQpLT50YWJJbmRleCgpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBtX3By ZXZpb3VzRm9jdXNhYmxlVGV4dEVsZW1lbnQgPSBwcmV2RWxlbWVudDsKKyAgICAgICAgICAgICAg ICAgICAgICAgIElucHV0TG9nKFBsYXRmb3JtOjpMb2dMZXZlbEluZm8sICJJbnB1dEhhbmRsZXI6 OnVwZGF0ZUZvcm1TdGF0ZSBmb3VuZCBwcmV2aW91cyBlbGVtZW50Iik7CisgICAgICAgICAgICAg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAgICAgICAvLyBOZXh0Ci0gICAgICAgIGZv ciAoaW50IG5leHRFbGVtZW50SWQgPSBmb2N1c0VsZW1lbnRJZCArIDE7IG5leHRFbGVtZW50SWQg PCBmb3JtRWxlbWVudENvdW50OyBuZXh0RWxlbWVudElkKyspIHsKLSAgICAgICAgICAgIEVsZW1l bnQqIGVsZW1lbnQgPSBjb25zdF9jYXN0PEhUTUxFbGVtZW50Kj4odG9IVE1MRWxlbWVudChmb3Jt RWxlbWVudExpc3RbbmV4dEVsZW1lbnRJZF0pKTsKKworICAgICAgICAgICAgLy8gTmV4dAorICAg ICAgICAgICAgaWYgKCFtX25leHRGb2N1c2FibGVUZXh0RWxlbWVudCkgeworICAgICAgICAgICAg ICAgIGZvciAoaW50IG5leHRFbGVtZW50SWQgPSBmb2N1c0VsZW1lbnRJZCArIDE7IG5leHRFbGVt ZW50SWQgPCBmb3JtRWxlbWVudENvdW50OyBuZXh0RWxlbWVudElkKyspIHsKKyAgICAgICAgICAg ICAgICAgICAgRWxlbWVudCogbmV4dEVsZW1lbnQgPSBjb25zdF9jYXN0PEhUTUxFbGVtZW50Kj4o dG9IVE1MRWxlbWVudChmb3JtRWxlbWVudExpc3RbbmV4dEVsZW1lbnRJZF0pKTsKKyAgICAgICAg ICAgICAgICAgICAgaWYgKERPTVN1cHBvcnQ6OmlzVGV4dEJhc2VkQ29udGVudEVkaXRhYmxlRWxl bWVudChuZXh0RWxlbWVudCkgJiYgIURPTVN1cHBvcnQ6OmlzRWxlbWVudFJlYWRPbmx5KG5leHRF bGVtZW50KSAmJiAhc3RhdGljX2Nhc3Q8Tm9kZSo+KG5leHRFbGVtZW50KS0+dGFiSW5kZXgoKSkg eworICAgICAgICAgICAgICAgICAgICAgICAgbV9uZXh0Rm9jdXNhYmxlVGV4dEVsZW1lbnQgPSBu ZXh0RWxlbWVudDsKKyAgICAgICAgICAgICAgICAgICAgICAgIElucHV0TG9nKFBsYXRmb3JtOjpM b2dMZXZlbEluZm8sICJJbnB1dEhhbmRsZXI6OnVwZGF0ZUZvcm1TdGF0ZSBmb3VuZCBuZXh0IGVs ZW1lbnQiKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9IGVsc2Ug aWYgKGZvY3VzVGFiSW5kZXgpIHsKKyAgICAgICAgICAgIElucHV0TG9nKFBsYXRmb3JtOjpMb2dM ZXZlbEluZm8sICJJbnB1dEhhbmRsZXI6OnVwZGF0ZUZvcm1TdGF0ZSBwcm9jZXNzaW5nIGVsZW1l bnQiKTsKICAgICAgICAgICAgIGlmIChET01TdXBwb3J0Ojppc1RleHRCYXNlZENvbnRlbnRFZGl0 YWJsZUVsZW1lbnQoZWxlbWVudCkgJiYgIURPTVN1cHBvcnQ6OmlzRWxlbWVudFJlYWRPbmx5KGVs ZW1lbnQpKSB7Ci0gICAgICAgICAgICAgICAgbV9uZXh0Rm9jdXNhYmxlVGV4dEVsZW1lbnQgPSBl bGVtZW50OwotICAgICAgICAgICAgICAgIElucHV0TG9nKFBsYXRmb3JtOjpMb2dMZXZlbEluZm8s ICJJbnB1dEhhbmRsZXI6OnVwZGF0ZUZvcm1TdGF0ZSBmb3VuZCBuZXh0IGVsZW1lbnQiKTsKLSAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICBJbnB1dExvZyhQbGF0Zm9ybTo6 TG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjp1cGRhdGVGb3JtU3RhdGUgcHJvY2Vzc2luZyBl bGVtZW50IHZhbGlkIik7CisgICAgICAgICAgICAgICAgaWYgKGludCB0YWJJbmRleCA9IHN0YXRp Y19jYXN0PE5vZGUqPihlbGVtZW50KS0+dGFiSW5kZXgoKSkgeworICAgICAgICAgICAgICAgICAg ICBJbnB1dExvZyhQbGF0Zm9ybTo6TG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjp1cGRhdGVG b3JtU3RhdGUgcHJvY2Vzc2luZyBlbGVtZW50IHdpdGggdGFiIGluZGV4ICVkIiwgdGFiSW5kZXgp OworICAgICAgICAgICAgICAgICAgICAvLyBDb21wYXJlIGZvciB0aGUgYmVmb3JlIGFuZCBhZnRl ciBmb3JtIHBvc2l0aW9ucyBiYXNlZCBvbiB0aGUgdGFiIGluZGV4LCBhbmQvb3IgZm9ybSBwb3Np dGlvbgorICAgICAgICAgICAgICAgICAgICAvLyBpZiB0YWIgaW5kZXhlcyBhcmUgZXF1YWwgZm9y bSBwb3NpdGlvbiBzaG91bGQgYmUgdXNlZC4KKyAgICAgICAgICAgICAgICAgICAgaWYgKHRhYklu ZGV4ICYmIHRhYkluZGV4IDwgZm9jdXNUYWJJbmRleCAmJiB0YWJJbmRleCA+IHByZXZUYWJJbmRl eCkgeworICAgICAgICAgICAgICAgICAgICAgICAgbV9wcmV2aW91c0ZvY3VzYWJsZVRleHRFbGVt ZW50ID0gZWxlbWVudDsKKyAgICAgICAgICAgICAgICAgICAgICAgIHByZXZUYWJJbmRleCA9IHRh YkluZGV4OworICAgICAgICAgICAgICAgICAgICAgICAgSW5wdXRMb2coUGxhdGZvcm06OkxvZ0xl dmVsSW5mbywgIklucHV0SGFuZGxlcjo6dXBkYXRlRm9ybVN0YXRlIGZvdW5kIHByZXZpb3VzIGVs ZW1lbnQgd2l0aCB0YWJJbmRleCAlZCIsIHRhYkluZGV4KTsKKyAgICAgICAgICAgICAgICAgICAg fSBlbHNlIGlmICh0YWJJbmRleCA+IGZvY3VzVGFiSW5kZXggJiYgdGFiSW5kZXggPCBuZXh0VGFi SW5kZXgpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fbmV4dEZvY3VzYWJsZVRleHRFbGVt ZW50ID0gZWxlbWVudDsKKyAgICAgICAgICAgICAgICAgICAgICAgIG5leHRUYWJJbmRleCA9IHRh YkluZGV4OworICAgICAgICAgICAgICAgICAgICAgICAgSW5wdXRMb2coUGxhdGZvcm06OkxvZ0xl dmVsSW5mbywgIklucHV0SGFuZGxlcjo6dXBkYXRlRm9ybVN0YXRlIGZvdW5kIG5leHQgZWxlbWVu dCB3aXRoIHRhYkluZGV4ICVkIiwgdGFiSW5kZXgpOworICAgICAgICAgICAgICAgICAgICB9Cisg ICAgICAgICAgICAgICAgfSBlbHNlIGlmICghZmlyc3RJbkZpZWxkV2l0aG91dFRhYkluZGV4KSB7 CisgICAgICAgICAgICAgICAgICAgIC8vIFN0b3JlIHRoZSBmaXJzdCBmaWVsZCBpbiB0aGUgZm9y bSB3aXRob3V0IGEgdGFiIGluZGV4IGlmIHdlIGhhdmUgYSBmb3JtIHdpdGggc29tZSB0YWIgaW5k ZXhlcyB0aGUgIm5leHQiIG9uZSBmcm9tCisgICAgICAgICAgICAgICAgICAgIC8vIHRoZSBoaWdo ZXN0IHRhYiBpbmRleCBpcyB0aGUgZmlyc3QgZmllbGQgd2l0aG91dCBhIHRhYiBpbmRleC4KKyAg ICAgICAgICAgICAgICAgICAgZmlyc3RJbkZpZWxkV2l0aG91dFRhYkluZGV4ID0gZWxlbWVudDsK KyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSB7CisgICAg ICAgICAgICAvLyBUaGUgZmllbGQgaGFzIG5vIHRhYiBpbmRleCwgaWYgaXQncyB0aGUgZmlyc3Qg bm9kZSB3ZSdsbCBuZWVkIHRoZSBoaWdoZXN0IHRhYiBpbmRleCBmaWVsZAorICAgICAgICAgICAg Ly8gd2hlbiBuYXZpZ2F0aW5nIGJhY2t3YXJkcy4KKyAgICAgICAgICAgIGlmIChpbnQgdGFiSW5k ZXggPSBzdGF0aWNfY2FzdDxOb2RlKj4oZWxlbWVudCktPnRhYkluZGV4KCkpIHsKKyAgICAgICAg ICAgICAgICBpZiAoIWhpZ2hlc3RUYWJJbmRleEVsZW1lbnQgfHwgKHRhYkluZGV4ID4gc3RhdGlj X2Nhc3Q8Tm9kZSo+KGhpZ2hlc3RUYWJJbmRleEVsZW1lbnQpLT50YWJJbmRleCgpKSkKKyAgICAg ICAgICAgICAgICAgICAgaGlnaGVzdFRhYkluZGV4RWxlbWVudCA9IGVsZW1lbnQ7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAoIW1fbmV4dEZvY3VzYWJsZVRleHRF bGVtZW50ICYmIGZpcnN0SW5GaWVsZFdpdGhvdXRUYWJJbmRleCkgeworICAgICAgICAvLyBObyBu ZXh0IGZvY3VzYWJsZSBmaWVsZCB3YXMgZm91bmQsIGJ1dCBhIGZpcnN0IG9uZSB3aXRob3V0IGEg dGFiaW5kZXggd2FzIGZvdW5kLCB1c2UgaXQgYXMgdGhlIG5leHQgZmllbGQuCisgICAgICAgIG1f bmV4dEZvY3VzYWJsZVRleHRFbGVtZW50ID0gZmlyc3RJbkZpZWxkV2l0aG91dFRhYkluZGV4Owor ICAgIH0KKworICAgIGlmICghbV9wcmV2aW91c0ZvY3VzYWJsZVRleHRFbGVtZW50ICYmIGhpZ2hl c3RUYWJJbmRleEVsZW1lbnQpIHsKKyAgICAgICAgLy8gTm8gcHJldiBmb2N1c2FibGUgZmllbGQg d2FzIGZvdW5kLCB1c2UgdGhlIGhpZ2hlc3QgdGFiIGluZGV4IGFzIHByZXZpb3VzIHNpbmNlIHRo aXMgZmllbGQgbXVzdCBub3QgaGF2ZQorICAgICAgICAvLyBhIHRhYmluZGV4LCBvdGhlcml3c2Ug aGlnaGVzdFRhYkluZGV4RWxlbWVudCB3b3VsZCBiZSBudWxsLgorICAgICAgICBtX3ByZXZpb3Vz Rm9jdXNhYmxlVGV4dEVsZW1lbnQgPSBoaWdoZXN0VGFiSW5kZXhFbGVtZW50OworICAgIH0KKwog ICAgIGlmICghbV9uZXh0Rm9jdXNhYmxlVGV4dEVsZW1lbnQgJiYgIW1fcHJldmlvdXNGb2N1c2Fi bGVUZXh0RWxlbWVudCkgewogICAgICAgICBtX2hhc1N1Ym1pdEJ1dHRvbiA9IGZhbHNlOwogICAg ICAgICBJbnB1dExvZyhQbGF0Zm9ybTo6TG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjp1cGRh dGVGb3JtU3RhdGUgbm8gdmFsaWQgZWxlbWVudHMgZm91bmQsIGNsZWFyaW5nIHN0YXRlLiIpOwot LSAKMS43LjEwLjQKCg== 202716 2013-05-23 08:10:07 -0700 2013-05-23 08:54:56 -0700 Updated Patch 0001-2013-05-21-Mike-Fenton-mifenton-rim.com.patch text/plain 2769 mifenton RnJvbSA5NzE5MmM4YTc4NzM1NTIxNWI3ZTNlNzIyNmZmMDZjYTRjYzMxNTBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VHVlLCAyMSBNYXkgMjAxMyAxMzo1MTo0MiAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSAyMDEz LTA1LTIxICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CgogICAgICAgIFBSIDMxNDIw Mi4KCiAgICAgICAgQ2hlY2sgdmFsaWRhdGlvbiBvZiB0aGUgaW5wdXQgZm9ybSBiZWZvcmUgdHJp Z2dlcmluZyBkaXJlY3Qgc3VibWlzc2lvbi4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgogICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6c3VibWl0Rm9ybSk6Ci0tLQogU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgICAx NiArKysrKysrKysrKysrKysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9J bnB1dEhhbmRsZXIuY3BwICAgfCAgIDE1ICsrKysrKysrKy0tLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAyNSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCmluZGV4IGZiMzRmOWIuLjExOGFlMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTIzICBNaWtlIEZlbnRvbiAgPG1pZmVudG9u QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFZhbGlkYXRlIGZvcm0gZGF0YSBiZWZv cmUgZG9pbmcgZGlyZWN0IHN1Ym1pc3Npb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQUiAzMTQyMDIuCisKKyAgICAgICAgQ2hlY2sgdmFsaWRhdGlv biBvZiB0aGUgaW5wdXQgZm9ybSBiZWZvcmUgdHJpZ2dlcmluZyBkaXJlY3Qgc3VibWlzc2lvbi4K KworICAgICAgICBJbnRlcm5hbGx5IFJldmlld2VkIGJ5IE5pbWEgR2hhbmF2YXRpYW4uCisKKyAg ICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6c3VibWl0Rm9ybSk6CisKIDIwMTMtMDUtMjEgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtCbGFj a0JlcnJ5XSBNYWtlIFBhZ2VQb3B1cCBpbXBsZW1lbnRhdGlvbiBpbmRlcGVuZGVudCBmcm9tIFdl YkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDQzYjY5MTAuLjRiZjExZDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNw cApAQCAtMTAwOCwxNSArMTAwOCwxOCBAQCB2b2lkIElucHV0SGFuZGxlcjo6c3VibWl0Rm9ybSgp CiAgICAgICAgIHJldHVybjsKIAogICAgIElucHV0TG9nKFBsYXRmb3JtOjpMb2dMZXZlbEluZm8s ICJJbnB1dEhhbmRsZXI6OnN1Ym1pdEZvcm0gdHJpZ2dlcmVkIik7Ci0gICAgaWYgKGVsZW1lbnRU eXBlKG1fY3VycmVudEZvY3VzRWxlbWVudC5nZXQoKSkgPT0gSW5wdXRUeXBlVGV4dEFyZWEpCi0g ICAgICAgIGZvcm1FbGVtZW50LT5zdWJtaXQoKTsKLSAgICBlbHNlIHsKKworICAgIGlmIChlbGVt ZW50VHlwZShtX2N1cnJlbnRGb2N1c0VsZW1lbnQuZ2V0KCkpICE9IElucHV0VHlwZVRleHRBcmVh KSB7CiAgICAgICAgIGhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZlbnQo S0VZQ09ERV9SRVRVUk4sIFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50OjpLZXlDaGFyLCAwKSwgZmFs c2UgLyogY2hhbmdlSXNQYXJ0T2ZDb21wb3NpdGlvbiAqLyk7CiAKLSAgICAgICAgLy8gQ29uZmly bSB0aGF0IGltcGxpY2l0IHN1Ym1pc3Npb24gd2FzIGFjY2VwdGVkLgotICAgICAgICBpZiAoaXNB Y3RpdmVUZXh0RWRpdCgpKQotICAgICAgICAgICAgZm9ybUVsZW1lbnQtPnN1Ym1pdCgpOworICAg ICAgICAvLyBEaWQgdGhpcyBjbGVhciB0aGUgZm9jdXM/IElmIHNvLCBmb3JtIHdhcyBzdWJtaXR0 ZWQgb3IgaW52YWxpZC4KKyAgICAgICAgaWYgKCFpc0FjdGl2ZVRleHRFZGl0KCkpCisgICAgICAg ICAgICByZXR1cm47CiAgICAgfQorCisgICAgLy8gVmFsaWRhdGUgZm9ybSBkYXRhIGFuZCBpZiB2 YWxpZCwgc3VibWl0LgorICAgIGlmIChmb3JtRWxlbWVudC0+Y2hlY2tWYWxpZGl0eSgpKQorICAg ICAgICBmb3JtRWxlbWVudC0+c3VibWl0KCk7CiB9CiAKIHN0YXRpYyB2b2lkIGFkZElucHV0U3R5 bGVNYXNrRm9yS2V5Ym9hcmRUeXBlKGludDY0X3QmIGlucHV0TWFzaywgVmlydHVhbEtleWJvYXJk VHlwZSBrZXlib2FyZFR5cGUpCi0tIAoxLjcuMTAuNAoK