116673 2013-05-23 07:23:48 -0700 Make default bug links in buildbot clickable 2013-06-04 14:40:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga cdumez commit-queue rniwa oldest_to_newest 892861 0 paroga 2013-05-23 07:23:48 -0700 Make default bug links in buildbot clickable 892864 1 202709 paroga 2013-05-23 07:26:39 -0700 Created attachment 202709 Patch 892934 2 202709 rniwa 2013-05-23 10:09:07 -0700 Comment on attachment 202709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202709&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:47 > + changecommentlink=(r"https://bugs\.webkit\.org/show_bug\.cgi\?id=(\d+)", "https://bugs.webkit.org/show_bug.cgi?id=\1"), We should probably also support the short form: webkit\.org/b/(\d+) 892936 3 paroga 2013-05-23 10:12:06 -0700 (In reply to comment #2) > (From update of attachment 202709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202709&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:47 > > + changecommentlink=(r"https://bugs\.webkit\.org/show_bug\.cgi\?id=(\d+)", "https://bugs.webkit.org/show_bug.cgi?id=\1"), > > We should probably also support the short form: webkit\.org/b/(\d+) But then is the question if we want to support _all_ http[s]:// links in the commit message? Adding more than one link would require that we change the whole commit message by adding the anker tags ourself... It's doable, but I think that this should be ok when people use webkit-patch for creating patches.... 892937 4 202709 rniwa 2013-05-23 10:14:30 -0700 Comment on attachment 202709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202709&action=review >>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:47 >>> + changecommentlink=(r"https://bugs\.webkit\.org/show_bug\.cgi\?id=(\d+)", "https://bugs.webkit.org/show_bug.cgi?id=\1"), >> >> We should probably also support the short form: webkit\.org/b/(\d+) > > But then is the question if we want to support _all_ http[s]:// links in the commit message? Adding more than one link would require that we change the whole commit message by adding the anker tags ourself... > It's doable, but I think that this should be ok when people use webkit-patch for creating patches.... Just do r"(https://bugs\.webkit\.org/show_bug\.cgi\?id=|webkit\.org/b/)(\d+)" and change \1 to \2. 892943 5 202725 paroga 2013-05-23 10:22:51 -0700 Created attachment 202725 Patch for landing 892951 6 202725 commit-queue 2013-05-23 10:49:23 -0700 Comment on attachment 202725 Patch for landing Clearing flags on attachment: 202725 Committed r150592: <http://trac.webkit.org/changeset/150592> 892952 7 commit-queue 2013-05-23 10:49:25 -0700 All reviewed patches have been landed. Closing bug. 896883 8 cdumez 2013-06-04 07:07:56 -0700 FYI, this patch did not work as intended it seems. Link are clickable but they all point to https://bugs.webkit.org/show_bug.cgi?id= (missing bug ID). 897043 9 rniwa 2013-06-04 14:40:02 -0700 Fixed in http://trac.webkit.org/changeset/151185. 202709 2013-05-23 07:26:39 -0700 2013-05-23 10:22:51 -0700 Patch bug-116673.patch text/plain 1329 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDFkMDdjODguLjEyOGQ1MTUgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNDQsNiArNDQsNyBAQCBhdXRoeiA9IEF1dGh6KAogY1snc3RhdHVzJ10gPSBb XQogY1snc3RhdHVzJ10uYXBwZW5kKGh0bWwuV2ViU3RhdHVzKGh0dHBfcG9ydD04NzEwLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldmxpbms9Imh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LyVzIiwgCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2hhbmdlY29tbWVudGxpbms9KHIiaHR0cHM6Ly9idWdzXC53ZWJraXRcLm9yZy9zaG93X2J1Z1wu Y2dpXD9pZD0oXGQrKSIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 XDEiKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhdXRoej1hdXRoeikpCiAK IGNbJ3NsYXZlUG9ydG51bSddID0gMTcwMDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwN2Y2ZTEyLi43MTUxYzVjIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMt MDUtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAg TWFrZSBkZWZhdWx0IGJ1ZyBsaW5rcyBpbiBidWlsZGJvdCBjbGlja2FibGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjY3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBjaGFuZ2Vjb21tZW50bGlu ayBvZiBodG1sLldlYlN0YXR1cyB0byBtYWtlIHRoZSBsaW5rcyBjbGlja2FibGUuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2Zn OgorCiAyMDEzLTA1LTIxICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtBVEtdIFtXZWJLaXQyXSBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50IG9mdGVuIGxl YWtzIGl0cyBBdGtPYmplY3QK 202725 2013-05-23 10:22:51 -0700 2013-05-23 10:49:23 -0700 Patch for landing bug-116673.patch text/plain 1344 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDFkMDdjODguLjEyOGQ1MTUgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNDQsNiArNDQsNyBAQCBhdXRoeiA9IEF1dGh6KAogY1snc3RhdHVzJ10gPSBb XQogY1snc3RhdHVzJ10uYXBwZW5kKGh0bWwuV2ViU3RhdHVzKGh0dHBfcG9ydD04NzEwLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldmxpbms9Imh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LyVzIiwgCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2hhbmdlY29tbWVudGxpbms9KHIiKGh0dHBzOi8vYnVnc1wud2Via2l0XC5vcmcvc2hvd19idWdc LmNnaVw/aWQ9fHdlYmtpdFwub3JnL2IvKShcZCspIiwgImh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD1cMiIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGF1dGh6PWF1dGh6KSkKIAogY1snc2xhdmVQb3J0bnVtJ10gPSAxNzAwMApkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDA3ZjZlMTIuLjcxNTFjNWMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMy0wNS0yMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KKworICAgICAgICBNYWtlIGRlZmF1bHQgYnVnIGxpbmtzIGluIGJ1aWxkYm90IGNsaWNr YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2 NjczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIFVzZSBj aGFuZ2Vjb21tZW50bGluayBvZiBodG1sLldlYlN0YXR1cyB0byBtYWtlIHRoZSBsaW5rcyBjbGlj a2FibGUuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9tYXN0ZXIuY2ZnOgorCiAyMDEzLTA1LTIxICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNo QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtdIFtXZWJLaXQyXSBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50IG9mdGVuIGxlYWtzIGl0cyBBdGtPYmplY3QK