116666 2013-05-23 06:13:48 -0700 [CMake] Add generation of JITStubs for x86_64 MSVC 2013-07-04 02:16:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue gyuyoung.kim rakuco oldest_to_newest 892815 0 paroga 2013-05-23 06:13:48 -0700 [CMake] Add generation of JITStubs for x86_64 MSVC 892837 1 202702 paroga 2013-05-23 06:17:47 -0700 Created attachment 202702 Patch 892844 2 202702 buildbot 2013-05-23 06:52:58 -0700 Comment on attachment 202702 Patch Attachment 202702 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/639092 902233 3 202702 laszlo.gombos 2013-06-20 11:39:29 -0700 Comment on attachment 202702 Patch Lets try to run EWS again.. 902235 4 202702 laszlo.gombos 2013-06-20 11:44:33 -0700 Comment on attachment 202702 Patch This looks good to me. Please make sure the win EWS failure is unrelated before committing. We should continue to discuss the usage of WTF_CPU_XXX CMake variables at bug 116662 . 902243 5 202702 rakuco 2013-06-20 11:50:52 -0700 Comment on attachment 202702 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202702&action=review > Source/JavaScriptCore/ChangeLog:9 > + since it's compiler specific and not dedecated to Windwos CE. nitpick: dedecated -> dedicated, Windwos -> Windows. 906103 6 paroga 2013-07-04 02:16:57 -0700 Committed r152395: <http://trac.webkit.org/changeset/152395> 202702 2013-05-23 06:17:47 -0700 2013-06-20 11:50:52 -0700 Patch bug-116666.patch text/plain 3554 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCAwZDcyOTllLi5kMWY3OTkyIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC01MTksOSArNTE5LDM0IEBAIGlm IChXVEZfQ1BVX0FSTSkKICAgICAgICAgYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmNwcAogICAg ICAgICBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uY3BwCiAgICAgKQorICAgIGlmIChNU1ZD IEFORCBFTkFCTEVfSklUKQorICAgICAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCisgICAgICAgICAg ICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9HZW5lcmF0ZWRKSVRTdHVicy5hc20KKyAg ICAgICAgICAgIE1BSU5fREVQRU5ERU5DWSAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vY3JlYXRlX2pp dF9zdHVicworICAgICAgICAgICAgREVQRU5EUyAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vaml0L0pJ VFN0dWJzLmNwcAorICAgICAgICAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtKQVZB U0NSSVBUQ09SRV9ESVJ9L2NyZWF0ZV9qaXRfc3R1YnMgLS1wcmVmaXg9TVNWQyAke0pBVkFTQ1JJ UFRDT1JFX0RJUn0vaml0L0pJVFN0dWJzLmNwcCA+ICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vR2Vu ZXJhdGVkSklUU3R1YnMuYXNtCisgICAgICAgICAgICBWRVJCQVRJTSkKKworICAgICAgICBhZGRf Y3VzdG9tX2NvbW1hbmQoCisgICAgICAgICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfRElS fS9HZW5lcmF0ZWRKSVRTdHVicy5vYmoKKyAgICAgICAgICAgIE1BSU5fREVQRU5ERU5DWSAke0RF UklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLmFzbQorICAgICAgICAgICAgQ09N TUFORCBhcm1hc20gLW5vbG9nbyAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0 dWJzLmFzbSAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLm9iagorICAg ICAgICAgICAgVkVSQkFUSU0pCisKKyAgICAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVf U09VUkNFUyAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLm9iaikKKyAg ICBlbmRpZiAoKQogZWxzZWlmIChXVEZfQ1BVX01JUFMpCiBlbHNlaWYgKFdURl9DUFVfWDg2KQog ZWxzZWlmIChXVEZfQ1BVX1g4Nl82NCkKKyAgICBpZiAoTVNWQyBBTkQgRU5BQkxFX0pJVCkKKyAg ICAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAorICAgICAgICAgICAgT1VUUFVUICR7REVSSVZFRF9T T1VSQ0VTX0RJUn0vSklUU3R1YnNNU1ZDNjQub2JqCisgICAgICAgICAgICBNQUlOX0RFUEVOREVO Q1kgJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2ppdC9KSVRTdHVic01TVkM2NC5hc20KKyAgICAgICAg ICAgIENPTU1BTkQgbWw2NCAtbm9sb2dvIC1jIC1GbyAke0RFUklWRURfU09VUkNFU19ESVJ9L0pJ VFN0dWJzTVNWQzY0Lm9iaiAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vaml0L0pJVFN0dWJzTVNWQzY0 LmFzbQorICAgICAgICAgICAgVkVSQkFUSU0pCisKKyAgICAgICAgbGlzdChBUFBFTkQgSmF2YVNj cmlwdENvcmVfU09VUkNFUyAke0RFUklWRURfU09VUkNFU19ESVJ9L0pJVFN0dWJzTVNWQzY0Lm9i aikKKyAgICBlbmRpZiAoKQogZWxzZSAoKQogICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIlVua25v d24gQ1BVIikKIGVuZGlmICgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAyYjk1M2FlLi42 YmYzZTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0w NS0yMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBb Q01ha2VdIEFkZCBnZW5lcmF0aW9uIG9mIEpJVFN0dWJzIGZvciB4ODZfNjQgTVNWQworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NjY2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbyBtb3ZlIHRoZSBn ZW5lcmF0aW9uIGZvciBBUk0gQ1BVIGludG8gdGhlIENNYWtlTGlzdHMudHh0LAorICAgICAgICBz aW5jZSBpdCdzIGNvbXBpbGVyIHNwZWNpZmljIGFuZCBub3QgZGVkZWNhdGVkIHRvIFdpbmR3b3Mg Q0UuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBQbGF0Zm9ybVdpbkNF LmNtYWtlOiBSZW1vdmVkLgorCiAyMDEzLTA1LTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVu YmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRGlzYWJsZSBTdXBlclJlZ2lvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtV2luQ0UuY21ha2UgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvUGxhdGZvcm1XaW5DRS5jbWFrZQpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggNWRkMzlkMS4uMDAwMDAwMAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZv cm1XaW5DRS5jbWFrZQorKysgL2Rldi9udWxsCkBAIC0xLDE2ICswLDAgQEAKLWlmIChFTkFCTEVf SklUIEFORCBXVEZfQ1BVX0FSTSkKLSAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCi0gICAgICAgIE9V VFBVVCAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLmFzbQotICAgICAg ICBNQUlOX0RFUEVOREVOQ1kgJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2NyZWF0ZV9qaXRfc3R1YnMK LSAgICAgICAgREVQRU5EUyAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vaml0L0pJVFN0dWJzLmNwcAot ICAgICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAke0pBVkFTQ1JJUFRDT1JFX0RJUn0v Y3JlYXRlX2ppdF9zdHVicyAtLXByZWZpeD1NU1ZDICR7SkFWQVNDUklQVENPUkVfRElSfS9qaXQv SklUU3R1YnMuY3BwID4gJHtERVJJVkVEX1NPVVJDRVNfRElSfS9HZW5lcmF0ZWRKSVRTdHVicy5h c20KLSAgICAgICAgVkVSQkFUSU0pCi0KLSAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCi0gICAgICAg IE9VVFBVVCAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLm9iagotICAg ICAgICBNQUlOX0RFUEVOREVOQ1kgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9HZW5lcmF0ZWRKSVRT dHVicy5hc20KLSAgICAgICAgQ09NTUFORCBhcm1hc20gLW5vbG9nbyAke0RFUklWRURfU09VUkNF U19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLmFzbSAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVy YXRlZEpJVFN0dWJzLm9iagotICAgICAgICBWRVJCQVRJTSkKLQotICAgIGxpc3QoQVBQRU5EIEph dmFTY3JpcHRDb3JlX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9HZW5lcmF0ZWRKSVRT dHVicy5vYmopCi1lbmRpZiAoKQo=