116662 2013-05-23 05:59:09 -0700 [CMake] Fix detection of x86_64 platform with MSVC 2013-09-04 02:39:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue gyuyoung.kim laszlo.gombos rakuco oldest_to_newest 892770 0 paroga 2013-05-23 05:59:09 -0700 [CMake] Fix detection of x86_64 platform with MSVC 892772 1 202671 paroga 2013-05-23 06:05:06 -0700 Created attachment 202671 Patch 902201 2 laszlo.gombos 2013-06-20 10:28:05 -0700 Some ports are delegating build decisions to the C files and do not expose CPU variables to the build system. This logic is mostly already cross-platform. Can we explore that option for CMake as well ? Only CPU variable that seems to be used in CMake is WTF_CPU_ARM. Can the other WTF_CPU_XXX variables removed ? Can we remove WTF_CPU_ARM as well - for example assembler/ARMv7Assembler.cpp is already guarded with CPU(ARM_THUMB2), which seems to be a more specific guard. 902251 3 paroga 2013-06-20 12:07:57 -0700 (In reply to comment #2) > Some ports are delegating build decisions to the C files and do not expose CPU variables to the build system. This logic is mostly already cross-platform. Can we explore that option for CMake as well ? > > Only CPU variable that seems to be used in CMake is WTF_CPU_ARM. Can the other WTF_CPU_XXX variables removed ? > > Can we remove WTF_CPU_ARM as well - for example assembler/ARMv7Assembler.cpp is already guarded with CPU(ARM_THUMB2), which seems to be a more specific guard. I need to add some (different) assembler files depending on the WTF_CPU to the build systems. AFAIK MS assembler has no possibility for a #if CPU(XXX), so I don't see an other chance. :-/ 912800 4 paroga 2013-07-30 05:38:55 -0700 ping? 916692 5 202671 rakuco 2013-08-13 07:26:24 -0700 Comment on attachment 202671 Patch LGTM, but I'd add a comment before the string(TOLOWER ...) with the same explanation you have in the ChangeLog. 917430 6 202671 gyuyoung.kim 2013-08-14 23:07:58 -0700 Comment on attachment 202671 Patch rs=me, but, please land after adjusting kubo's comment. 924332 7 paroga 2013-09-04 02:39:22 -0700 Committed r154978: <http://trac.webkit.org/changeset/154978> 202671 2013-05-23 06:05:06 -0700 2013-08-14 23:07:58 -0700 Patch bug-116662.patch text/plain 1933 paroga ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggMjgxZjk0 YS4uZDhiZDZiOCAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0cy50 eHQKQEAgLTY3LDE3ICs2NywyMSBAQCBmaW5kX3BhY2thZ2UoUnVieSAxLjguNykKICMgLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KICMgRGV0ZXJtaW5lIHRoZSB0YXJnZXQgcHJvY2Vzc29yCiAjIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCi1zdHJpbmcoVE9MT1dFUiAke0NNQUtFX1NZU1RFTV9QUk9DRVNTT1J9 IExPV0VSQ0FTRV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SKQoraWYgKE1TVkNfQ1hYX0FSQ0hJVEVD VFVSRV9JRCkKKyAgICBzdHJpbmcoVE9MT1dFUiAke01TVkNfQ1hYX0FSQ0hJVEVDVFVSRV9JRH0g TE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IpCitlbHNlICgpCisgICAgc3RyaW5nKFRP TE9XRVIgJHtDTUFLRV9TWVNURU1fUFJPQ0VTU09SfSBMT1dFUkNBU0VfQ01BS0VfU1lTVEVNX1BS T0NFU1NPUikKK2VuZGlmICgpCiBpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1Ig TUFUQ0hFUyAiXmFybSIpCiAgICAgc2V0KFdURl9DUFVfQVJNIDEpCiBlbHNlaWYgKExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENIRVMgIl5taXBzIikKICAgICBzZXQoV1RGX0NQ VV9NSVBTIDEpCi1lbHNlaWYgKExPV0VSQ0FTRV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENI RVMgIih4ODZfNjR8YW1kNjQpIikKK2Vsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9D RVNTT1IgTUFUQ0hFUyAiKHg2NHx4ODZfNjR8YW1kNjQpIikKICAgICBzZXQoV1RGX0NQVV9YODZf NjQgMSkKIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAi KGlbMy02XTg2fHg4NikiKQogICAgIHNldChXVEZfQ1BVX1g4NiAxKQogZWxzZSAoKQotICAgIG1l c3NhZ2UoRkFUQUxfRVJST1IgIlVua25vd24gQ1BVICcke0NNQUtFX1NZU1RFTV9QUk9DRVNTT1J9 JyIpCisgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiVW5rbm93biBDUFUgJyR7TE9XRVJDQVNFX0NN QUtFX1NZU1RFTV9QUk9DRVNTT1J9JyIpCiBlbmRpZiAoKQogCiAjIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzlkMTBmZC4uMTk2 ZTE1OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA1LTIzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgor CisgICAgICAgIFtDTWFrZV0gRml4IGRldGVjdGlvbiBvZiB4ODZfNjQgcGxhdGZvcm0gd2l0aCBN U1ZDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2 NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug JHtNU1ZDX0NYWF9BUkNISVRFQ1RVUkVfSUR9IGluc3RlYWQgb2YgJHtDTUFLRV9TWVNURU1fUFJP Q0VTU09SfSwgc2luY2UKKyAgICAgICAgdGhlIGxhdGVyIG9uZSBqdXN0IHJlc29sdmVzIHRvIHRo ZSBob3N0IHByb2Nlc3NvciBvbiBXaW5kb3dzLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6 CisKIDIwMTMtMDUtMTQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgSW50cm9kdWNlIFVTRShXSU5HREkpIGZvciB0aGUgV2luZG93cyBwb3J0Cg==