116657 2013-05-23 03:49:24 -0700 [EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get 2013-05-23 05:29:46 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez commit-queue lucas.de.marchi rakuco oldest_to_newest 892724 0 gyuyoung.kim 2013-05-23 03:49:24 -0700 WKPageGet|SetPaginationMode APIs appear on WK2 C APIs. So, we need to use them for ewk_view_pagination_mode_set|get. 892731 1 202659 gyuyoung.kim 2013-05-23 03:57:23 -0700 Created attachment 202659 Patch 892733 2 202659 cdumez 2013-05-23 04:04:49 -0700 Comment on attachment 202659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202659&action=review > Source/WebKit2/ChangeLog:8 > + WKPageGet|SetPaginationMode APIs appear on WK2 C APIs. So, we need to use them for "appear on" -> "is present in" > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:511 > + WKPageSetPaginationMode(impl->wkPage(), static_cast<WebCore::Pagination::Mode>(mode)); This should really be casted to a WKPaginationMode, not a WebCore::Pagination::Mode. The COMPILE_ASSERT_MATCHING_ENUM() above need to be updated or we need a static inline function to convert one enum into another. Can you check if we can get rid of the "using namespace WebCore;" and maybe a few WebCore includes? 892740 3 202661 gyuyoung.kim 2013-05-23 04:35:53 -0700 Created attachment 202661 Patch 892741 4 gyuyoung.kim 2013-05-23 04:37:40 -0700 (In reply to comment #2) > This should really be casted to a WKPaginationMode, not a WebCore::Pagination::Mode. The COMPILE_ASSERT_MATCHING_ENUM() above need to be updated or we need a static inline function to convert one enum into another. Can you check if we can get rid of the "using namespace WebCore;" and maybe a few WebCore includes? Nice catch !! I missed it. I prefer to update COMPILE_ASSERT_MATCHING_ENUM() using WKPaginationMode. 892743 5 202662 gyuyoung.kim 2013-05-23 04:43:13 -0700 Created attachment 202662 Patch 892746 6 gyuyoung.kim 2013-05-23 04:44:20 -0700 Remove "using namespace WebCore;" as well. Thanks. 892747 7 202663 gyuyoung.kim 2013-05-23 04:45:55 -0700 Created attachment 202663 Patch 892749 8 202663 cdumez 2013-05-23 04:50:06 -0700 Comment on attachment 202663 Patch Nice, r=me. 892763 9 202663 commit-queue 2013-05-23 05:29:43 -0700 Comment on attachment 202663 Patch Clearing flags on attachment: 202663 Committed r150581: <http://trac.webkit.org/changeset/150581> 892764 10 commit-queue 2013-05-23 05:29:46 -0700 All reviewed patches have been landed. Closing bug. 202659 2013-05-23 03:57:23 -0700 2013-05-23 04:35:47 -0700 Patch bug-116657-20130523195608.patch text/plain 2270 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmU2NzdhMTdiNDM4NDQy Y2I4M2UwYTE3MTI3ZDBhNGIwOTQxNzQ4Mi4uZjcwMWVlNmVmZjZjZjdmY2UyMDhhNTRkMGFkNDk4 YWI1MWVlMDA0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTIzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBVc2UgV0syIEMgQVBJIGluIGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXR8Z2V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2NTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXS1BhZ2VHZXR8U2V0 UGFnaW5hdGlvbk1vZGUgQVBJcyBhcHBlYXIgb24gV0syIEMgQVBJcy4gU28sIHdlIG5lZWQgdG8g dXNlIHRoZW0gZm9yCisgICAgICAgIGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXR8Z2V0LiAK KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3 a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXQpOgorICAgICAgICAoZXdrX3ZpZXdfcGFnaW5hdGlv bl9tb2RlX2dldCk6CisKIDIwMTMtMDUtMjMgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzQGluZi51 LXN6ZWdlZC5odT4KIAogICAgICAgICBTdXBwb3J0IGZyYW1lIGluc3RydW1lbnRhdGlvbiBmb3Ig Y29vcmRpbmF0ZWQgZ3JhcGhpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcAppbmRleCBkODAyZTUwOGUzNTY0ODlhZDUwY2I1MGNhNTgyYmJhN2MwZWVh NjUyLi43MzQ4MzJmMmJkNDQ3OWY1NGZjZGRhOWFjMGU5MjZiYmZmYTdmZjI3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC01MDcsOCArNTA3 LDggQEAgQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElPTl9NT0RFX0JP VFRPTV9UT19UT1AsIFdlYkNvcmU6OlBhZ2luYXQKIEVpbmFfQm9vbCBld2tfdmlld19wYWdpbmF0 aW9uX21vZGVfc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfUGFnaW5hdGlvbl9Nb2RlIG1v ZGUpCiB7CiAgICAgRVdLX1ZJRVdfSU1QTF9HRVRfT1JfUkVUVVJOKGV3a1ZpZXcsIGltcGwsIGZh bHNlKTsKLSAgICAvLyBGSVhNRTogbW92ZSB0byBleHBvcnRlZCBDIFdLUGFnZSBBUEkgd2hlbiBp dCBhcHBlYXJzLgotICAgIHRvSW1wbChpbXBsLT53a1BhZ2UoKSktPnNldFBhZ2luYXRpb25Nb2Rl KHN0YXRpY19jYXN0PFdlYkNvcmU6OlBhZ2luYXRpb246Ok1vZGU+KG1vZGUpKTsKKworICAgIFdL UGFnZVNldFBhZ2luYXRpb25Nb2RlKGltcGwtPndrUGFnZSgpLCBzdGF0aWNfY2FzdDxXZWJDb3Jl OjpQYWdpbmF0aW9uOjpNb2RlPihtb2RlKSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTUx Niw4ICs1MTYsOCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFnaW5hdGlvbl9tb2RlX3NldChFdmFz X09iamVjdCogZXdrVmlldywgRXdrX1BhZ2luYXRpb25fTW9kZQogRXdrX1BhZ2luYXRpb25fTW9k ZSBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3 KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCBFV0tf UEFHSU5BVElPTl9NT0RFX0lOVkFMSUQpOwotICAgIC8vIEZJWE1FOiBtb3ZlIHRvIGV4cG9ydGVk IEMgV0tQYWdlIEFQSSB3aGVuIGl0IGFwcGVhcnMuCi0gICAgcmV0dXJuIHN0YXRpY19jYXN0PEV3 a19QYWdpbmF0aW9uX01vZGU+KHRvSW1wbChpbXBsLT53a1BhZ2UoKSktPnBhZ2luYXRpb25Nb2Rl KCkpOworICAgIAorICAgIHJldHVybiBzdGF0aWNfY2FzdDxFd2tfUGFnaW5hdGlvbl9Nb2RlPihX S1BhZ2VHZXRQYWdpbmF0aW9uTW9kZShpbXBsLT53a1BhZ2UoKSkpOwogfQogCiBFaW5hX0Jvb2wg ZXdrX3ZpZXdfZnVsbHNjcmVlbl9leGl0KEV2YXNfT2JqZWN0KiBld2tWaWV3KQo= 202661 2013-05-23 04:35:53 -0700 2013-05-23 04:43:05 -0700 Patch bug-116657-20130523203438.patch text/plain 3429 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmU2NzdhMTdiNDM4NDQy Y2I4M2UwYTE3MTI3ZDBhNGIwOTQxNzQ4Mi4uNzZhNjZhN2M2MjU4ZGRlZmY1MjFkZTIzMzRiNTc2 ZWVhMGQxNmYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTIzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBVc2UgV0syIEMgQVBJIGluIGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXR8Z2V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2NTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXS1BhZ2VHZXR8U2V0 UGFnaW5hdGlvbk1vZGUgQVBJcyBpcyBwcmVzZW50IGluIFdLMiBDIEFQSXMuIFNvLCB3ZSBuZWVk IHRvIHVzZSB0aGVtIGZvcgorICAgICAgICBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfc2V0fGdl dC4gCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAg IChld2tfdmlld19wYWdpbmF0aW9uX21vZGVfc2V0KToKKyAgICAgICAgKGV3a192aWV3X3BhZ2lu YXRpb25fbW9kZV9nZXQpOgorCiAyMDEzLTA1LTIzICBSb2xhbmQgVGFrYWNzICA8cnRha2Fjc0Bp bmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgU3VwcG9ydCBmcmFtZSBpbnN0cnVtZW50YXRpb24g Zm9yIGNvb3JkaW5hdGVkIGdyYXBoaWNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlldy5jcHAKaW5kZXggZDgwMmU1MDhlMzU2NDg5YWQ1MGNiNTBjYTU4MmJiYTdj MGVlYTY1Mi4uMmI1MjRjNzQ1ZjE3NjlhYjc1NTg4ZjgzNjYwOTU5OTdiYzliODYxZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApAQCAtNDk3LDE4 ICs0OTcsMTggQEAgRWluYV9Cb29sIGV3a192aWV3X2luc3BlY3Rvcl9jbG9zZShFdmFzX09iamVj dCogZXdrVmlldykKICNlbmRpZgogfQogCi0vLyBFd2tfUGFnaW5hdGlvbl9Nb2RlIHNob3VsZCBi ZSBtYXRjaGVkIHVwIG9yZGVycyB3aXRoIFdlYkNvcmU6OlBhZ2luYXRpb246Ok1vZGUuCi1DT01Q SUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19QQUdJTkFUSU9OX01PREVfVU5QQUdJTkFURUQs IFdlYkNvcmU6OlBhZ2luYXRpb246OlVucGFnaW5hdGVkKTsKLUNPTVBJTEVfQVNTRVJUX01BVENI SU5HX0VOVU0oRVdLX1BBR0lOQVRJT05fTU9ERV9MRUZUX1RPX1JJR0hULCBXZWJDb3JlOjpQYWdp bmF0aW9uOjpMZWZ0VG9SaWdodFBhZ2luYXRlZCk7Ci1DT01QSUxFX0FTU0VSVF9NQVRDSElOR19F TlVNKEVXS19QQUdJTkFUSU9OX01PREVfUklHSFRfVE9fTEVGVCwgV2ViQ29yZTo6UGFnaW5hdGlv bjo6UmlnaHRUb0xlZnRQYWdpbmF0ZWQpOwotQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShF V0tfUEFHSU5BVElPTl9NT0RFX1RPUF9UT19CT1RUT00sIFdlYkNvcmU6OlBhZ2luYXRpb246OlRv cFRvQm90dG9tUGFnaW5hdGVkKTsKLUNPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX1BB R0lOQVRJT05fTU9ERV9CT1RUT01fVE9fVE9QLCBXZWJDb3JlOjpQYWdpbmF0aW9uOjpCb3R0b21U b1RvcFBhZ2luYXRlZCk7CisvLyBFd2tfUGFnaW5hdGlvbl9Nb2RlIHNob3VsZCBiZSBtYXRjaGVk IHVwIG9yZGVycyB3aXRoIFdLUGFnaW5hdGlvbk1vZGUuCitDT01QSUxFX0FTU0VSVF9NQVRDSElO R19FTlVNKEVXS19QQUdJTkFUSU9OX01PREVfVU5QQUdJTkFURUQsIGtXS1BhZ2luYXRpb25Nb2Rl VW5wYWdpbmF0ZWQpOworQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElP Tl9NT0RFX0xFRlRfVE9fUklHSFQsIGtXS1BhZ2luYXRpb25Nb2RlTGVmdFRvUmlnaHQpOworQ09N UElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElPTl9NT0RFX1JJR0hUX1RPX0xF RlQsIGtXS1BhZ2luYXRpb25Nb2RlUmlnaHRUb0xlZnQpOworQ09NUElMRV9BU1NFUlRfTUFUQ0hJ TkdfRU5VTShFV0tfUEFHSU5BVElPTl9NT0RFX1RPUF9UT19CT1RUT00sIGtXS1BhZ2luYXRpb25N b2RlVG9wVG9Cb3R0b20pOworQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5B VElPTl9NT0RFX0JPVFRPTV9UT19UT1AsIGtXS1BhZ2luYXRpb25Nb2RlQm90dG9tVG9Ub3ApOwog CiBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFnaW5hdGlvbl9tb2RlX3NldChFdmFzX09iamVjdCogZXdr VmlldywgRXdrX1BhZ2luYXRpb25fTW9kZSBtb2RlKQogewogICAgIEVXS19WSUVXX0lNUExfR0VU X09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCBmYWxzZSk7Ci0gICAgLy8gRklYTUU6IG1vdmUgdG8g ZXhwb3J0ZWQgQyBXS1BhZ2UgQVBJIHdoZW4gaXQgYXBwZWFycy4KLSAgICB0b0ltcGwoaW1wbC0+ d2tQYWdlKCkpLT5zZXRQYWdpbmF0aW9uTW9kZShzdGF0aWNfY2FzdDxXZWJDb3JlOjpQYWdpbmF0 aW9uOjpNb2RlPihtb2RlKSk7CisKKyAgICBXS1BhZ2VTZXRQYWdpbmF0aW9uTW9kZShpbXBsLT53 a1BhZ2UoKSwgc3RhdGljX2Nhc3Q8V0tQYWdpbmF0aW9uTW9kZT4obW9kZSkpOwogCiAgICAgcmV0 dXJuIHRydWU7CiB9CkBAIC01MTYsOCArNTE2LDggQEAgRWluYV9Cb29sIGV3a192aWV3X3BhZ2lu YXRpb25fbW9kZV9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV3a19QYWdpbmF0aW9uX01vZGUK IEV3a19QYWdpbmF0aW9uX01vZGUgZXdrX3ZpZXdfcGFnaW5hdGlvbl9tb2RlX2dldChjb25zdCBF dmFzX09iamVjdCogZXdrVmlldykKIHsKICAgICBFV0tfVklFV19JTVBMX0dFVF9PUl9SRVRVUk4o ZXdrVmlldywgaW1wbCwgRVdLX1BBR0lOQVRJT05fTU9ERV9JTlZBTElEKTsKLSAgICAvLyBGSVhN RTogbW92ZSB0byBleHBvcnRlZCBDIFdLUGFnZSBBUEkgd2hlbiBpdCBhcHBlYXJzLgotICAgIHJl dHVybiBzdGF0aWNfY2FzdDxFd2tfUGFnaW5hdGlvbl9Nb2RlPih0b0ltcGwoaW1wbC0+d2tQYWdl KCkpLT5wYWdpbmF0aW9uTW9kZSgpKTsKKyAgICAKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RXdr X1BhZ2luYXRpb25fTW9kZT4oV0tQYWdlR2V0UGFnaW5hdGlvbk1vZGUoaW1wbC0+d2tQYWdlKCkp KTsKIH0KIAogRWluYV9Cb29sIGV3a192aWV3X2Z1bGxzY3JlZW5fZXhpdChFdmFzX09iamVjdCog ZXdrVmlldykK 202662 2013-05-23 04:43:13 -0700 2013-05-23 04:45:49 -0700 Patch bug-116657-20130523204157.patch text/plain 3701 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmU2NzdhMTdiNDM4NDQy Y2I4M2UwYTE3MTI3ZDBhNGIwOTQxNzQ4Mi4uMjg2ZWM0YTIyMDgwZGQxNzlmYWJkODJiOTllODBh MDE0YzBmNzA3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTIzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBVc2UgV0syIEMgQVBJIGluIGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXR8Z2V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2NTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXS1BhZ2VHZXR8U2V0 UGFnaW5hdGlvbk1vZGUgQVBJcyBpcyBwcmVzZW50IGluIFdLMiBDIEFQSXMuIFNvLCB3ZSBuZWVk IHRvIHVzZSB0aGVtIGZvcgorICAgICAgICBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfc2V0fGdl dC4KKworICAgICAgICBCZXNpZGVzIHdlIGRvbid0IG5lZWQgdG8gdXNlIFdlYkNvcmUgbmFtZXNw YWNlIGFueW1vcmUuIFRoaXMgd2FzIGxhc3QgbGF5ZXJpbmcgdmlvbGF0aW9uIGluIGV3a192aWV3 LmNwcC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAg ICAgKGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXQpOgorICAgICAgICAoZXdrX3ZpZXdfcGFn aW5hdGlvbl9tb2RlX2dldCk6CisKIDIwMTMtMDUtMjMgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNz QGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBTdXBwb3J0IGZyYW1lIGluc3RydW1lbnRhdGlv biBmb3IgY29vcmRpbmF0ZWQgZ3JhcGhpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcAppbmRleCBkODAyZTUwOGUzNTY0ODlhZDUwY2I1MGNhNTgyYmJh N2MwZWVhNjUyLi45YzJhZGVkMmI0YTMzOGQxZjQxZDhiYjIxNzQwYWFmOGI5MjI0NDY1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC01Nyw3 ICs1Nyw2IEBACiAjZW5kaWYKIAogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKLXVzaW5nIG5hbWVz cGFjZSBXZWJDb3JlOwogCiBzdGF0aWMgaW5saW5lIEV3a1ZpZXcqIHRvRXdrVmlld0NoZWNrZWQo Y29uc3QgRXZhc19PYmplY3QqIGV2YXNPYmplY3QpCiB7CkBAIC00OTcsMTggKzQ5NiwxOCBAQCBF aW5hX0Jvb2wgZXdrX3ZpZXdfaW5zcGVjdG9yX2Nsb3NlKEV2YXNfT2JqZWN0KiBld2tWaWV3KQog I2VuZGlmCiB9CiAKLS8vIEV3a19QYWdpbmF0aW9uX01vZGUgc2hvdWxkIGJlIG1hdGNoZWQgdXAg b3JkZXJzIHdpdGggV2ViQ29yZTo6UGFnaW5hdGlvbjo6TW9kZS4KLUNPTVBJTEVfQVNTRVJUX01B VENISU5HX0VOVU0oRVdLX1BBR0lOQVRJT05fTU9ERV9VTlBBR0lOQVRFRCwgV2ViQ29yZTo6UGFn aW5hdGlvbjo6VW5wYWdpbmF0ZWQpOwotQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tf UEFHSU5BVElPTl9NT0RFX0xFRlRfVE9fUklHSFQsIFdlYkNvcmU6OlBhZ2luYXRpb246OkxlZnRU b1JpZ2h0UGFnaW5hdGVkKTsKLUNPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX1BBR0lO QVRJT05fTU9ERV9SSUdIVF9UT19MRUZULCBXZWJDb3JlOjpQYWdpbmF0aW9uOjpSaWdodFRvTGVm dFBhZ2luYXRlZCk7Ci1DT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19QQUdJTkFUSU9O X01PREVfVE9QX1RPX0JPVFRPTSwgV2ViQ29yZTo6UGFnaW5hdGlvbjo6VG9wVG9Cb3R0b21QYWdp bmF0ZWQpOwotQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElPTl9NT0RF X0JPVFRPTV9UT19UT1AsIFdlYkNvcmU6OlBhZ2luYXRpb246OkJvdHRvbVRvVG9wUGFnaW5hdGVk KTsKKy8vIEV3a19QYWdpbmF0aW9uX01vZGUgc2hvdWxkIGJlIG1hdGNoZWQgdXAgb3JkZXJzIHdp dGggV0tQYWdpbmF0aW9uTW9kZS4KK0NPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX1BB R0lOQVRJT05fTU9ERV9VTlBBR0lOQVRFRCwga1dLUGFnaW5hdGlvbk1vZGVVbnBhZ2luYXRlZCk7 CitDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19QQUdJTkFUSU9OX01PREVfTEVGVF9U T19SSUdIVCwga1dLUGFnaW5hdGlvbk1vZGVMZWZ0VG9SaWdodCk7CitDT01QSUxFX0FTU0VSVF9N QVRDSElOR19FTlVNKEVXS19QQUdJTkFUSU9OX01PREVfUklHSFRfVE9fTEVGVCwga1dLUGFnaW5h dGlvbk1vZGVSaWdodFRvTGVmdCk7CitDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19Q QUdJTkFUSU9OX01PREVfVE9QX1RPX0JPVFRPTSwga1dLUGFnaW5hdGlvbk1vZGVUb3BUb0JvdHRv bSk7CitDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19QQUdJTkFUSU9OX01PREVfQk9U VE9NX1RPX1RPUCwga1dLUGFnaW5hdGlvbk1vZGVCb3R0b21Ub1RvcCk7CiAKIEVpbmFfQm9vbCBl d2tfdmlld19wYWdpbmF0aW9uX21vZGVfc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfUGFn aW5hdGlvbl9Nb2RlIG1vZGUpCiB7CiAgICAgRVdLX1ZJRVdfSU1QTF9HRVRfT1JfUkVUVVJOKGV3 a1ZpZXcsIGltcGwsIGZhbHNlKTsKLSAgICAvLyBGSVhNRTogbW92ZSB0byBleHBvcnRlZCBDIFdL UGFnZSBBUEkgd2hlbiBpdCBhcHBlYXJzLgotICAgIHRvSW1wbChpbXBsLT53a1BhZ2UoKSktPnNl dFBhZ2luYXRpb25Nb2RlKHN0YXRpY19jYXN0PFdlYkNvcmU6OlBhZ2luYXRpb246Ok1vZGU+KG1v ZGUpKTsKKworICAgIFdLUGFnZVNldFBhZ2luYXRpb25Nb2RlKGltcGwtPndrUGFnZSgpLCBzdGF0 aWNfY2FzdDxXS1BhZ2luYXRpb25Nb2RlPihtb2RlKSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K QEAgLTUxNiw4ICs1MTUsOCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFnaW5hdGlvbl9tb2RlX3Nl dChFdmFzX09iamVjdCogZXdrVmlldywgRXdrX1BhZ2luYXRpb25fTW9kZQogRXdrX1BhZ2luYXRp b25fTW9kZSBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBl d2tWaWV3KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBs LCBFV0tfUEFHSU5BVElPTl9NT0RFX0lOVkFMSUQpOwotICAgIC8vIEZJWE1FOiBtb3ZlIHRvIGV4 cG9ydGVkIEMgV0tQYWdlIEFQSSB3aGVuIGl0IGFwcGVhcnMuCi0gICAgcmV0dXJuIHN0YXRpY19j YXN0PEV3a19QYWdpbmF0aW9uX01vZGU+KHRvSW1wbChpbXBsLT53a1BhZ2UoKSktPnBhZ2luYXRp b25Nb2RlKCkpOworICAgIAorICAgIHJldHVybiBzdGF0aWNfY2FzdDxFd2tfUGFnaW5hdGlvbl9N b2RlPihXS1BhZ2VHZXRQYWdpbmF0aW9uTW9kZShpbXBsLT53a1BhZ2UoKSkpOwogfQogCiBFaW5h X0Jvb2wgZXdrX3ZpZXdfZnVsbHNjcmVlbl9leGl0KEV2YXNfT2JqZWN0KiBld2tWaWV3KQo= 202663 2013-05-23 04:45:55 -0700 2013-05-23 05:29:42 -0700 Patch bug-116657-20130523204440.patch text/plain 3651 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmU2NzdhMTdiNDM4NDQy Y2I4M2UwYTE3MTI3ZDBhNGIwOTQxNzQ4Mi4uZmFkMGE0MmEwNzExMTkzZDEzYjI0Y2FhNWQwYzBl NTcyMzAxNjZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTIzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBVc2UgV0syIEMgQVBJIGluIGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9zZXR8Z2V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2NTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXS1BhZ2VHZXR8U2V0 UGFnaW5hdGlvbk1vZGUgQVBJcyBpcyBwcmVzZW50IGluIFdLMiBDIEFQSXMuIFNvLCB3ZSBuZWVk IHRvIHVzZSB0aGVtIGZvcgorICAgICAgICBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfc2V0fGdl dC4KKworICAgICAgICBCZXNpZGVzIHdlIGRvbid0IG5lZWQgdG8gdXNlIFdlYkNvcmUgbmFtZXNw YWNlIGFueW1vcmUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6 CisgICAgICAgIChld2tfdmlld19wYWdpbmF0aW9uX21vZGVfc2V0KToKKyAgICAgICAgKGV3a192 aWV3X3BhZ2luYXRpb25fbW9kZV9nZXQpOgorCiAyMDEzLTA1LTIzICBSb2xhbmQgVGFrYWNzICA8 cnRha2Fjc0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgU3VwcG9ydCBmcmFtZSBpbnN0cnVt ZW50YXRpb24gZm9yIGNvb3JkaW5hdGVkIGdyYXBoaWNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggZDgwMmU1MDhlMzU2NDg5YWQ1MGNiNTBj YTU4MmJiYTdjMGVlYTY1Mi4uOWMyYWRlZDJiNGEzMzhkMWY0MWQ4YmIyMTc0MGFhZjhiOTIyNDQ2 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApA QCAtNTcsNyArNTcsNiBAQAogI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7Ci11c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogc3RhdGljIGlubGluZSBFd2tWaWV3KiB0b0V3a1ZpZXdD aGVja2VkKGNvbnN0IEV2YXNfT2JqZWN0KiBldmFzT2JqZWN0KQogewpAQCAtNDk3LDE4ICs0OTYs MTggQEAgRWluYV9Cb29sIGV3a192aWV3X2luc3BlY3Rvcl9jbG9zZShFdmFzX09iamVjdCogZXdr VmlldykKICNlbmRpZgogfQogCi0vLyBFd2tfUGFnaW5hdGlvbl9Nb2RlIHNob3VsZCBiZSBtYXRj aGVkIHVwIG9yZGVycyB3aXRoIFdlYkNvcmU6OlBhZ2luYXRpb246Ok1vZGUuCi1DT01QSUxFX0FT U0VSVF9NQVRDSElOR19FTlVNKEVXS19QQUdJTkFUSU9OX01PREVfVU5QQUdJTkFURUQsIFdlYkNv cmU6OlBhZ2luYXRpb246OlVucGFnaW5hdGVkKTsKLUNPTVBJTEVfQVNTRVJUX01BVENISU5HX0VO VU0oRVdLX1BBR0lOQVRJT05fTU9ERV9MRUZUX1RPX1JJR0hULCBXZWJDb3JlOjpQYWdpbmF0aW9u OjpMZWZ0VG9SaWdodFBhZ2luYXRlZCk7Ci1DT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVX S19QQUdJTkFUSU9OX01PREVfUklHSFRfVE9fTEVGVCwgV2ViQ29yZTo6UGFnaW5hdGlvbjo6Umln aHRUb0xlZnRQYWdpbmF0ZWQpOwotQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFH SU5BVElPTl9NT0RFX1RPUF9UT19CT1RUT00sIFdlYkNvcmU6OlBhZ2luYXRpb246OlRvcFRvQm90 dG9tUGFnaW5hdGVkKTsKLUNPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX1BBR0lOQVRJ T05fTU9ERV9CT1RUT01fVE9fVE9QLCBXZWJDb3JlOjpQYWdpbmF0aW9uOjpCb3R0b21Ub1RvcFBh Z2luYXRlZCk7CisvLyBFd2tfUGFnaW5hdGlvbl9Nb2RlIHNob3VsZCBiZSBtYXRjaGVkIHVwIG9y ZGVycyB3aXRoIFdLUGFnaW5hdGlvbk1vZGUuCitDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVN KEVXS19QQUdJTkFUSU9OX01PREVfVU5QQUdJTkFURUQsIGtXS1BhZ2luYXRpb25Nb2RlVW5wYWdp bmF0ZWQpOworQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElPTl9NT0RF X0xFRlRfVE9fUklHSFQsIGtXS1BhZ2luYXRpb25Nb2RlTGVmdFRvUmlnaHQpOworQ09NUElMRV9B U1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElPTl9NT0RFX1JJR0hUX1RPX0xFRlQsIGtX S1BhZ2luYXRpb25Nb2RlUmlnaHRUb0xlZnQpOworQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5V TShFV0tfUEFHSU5BVElPTl9NT0RFX1RPUF9UT19CT1RUT00sIGtXS1BhZ2luYXRpb25Nb2RlVG9w VG9Cb3R0b20pOworQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfUEFHSU5BVElPTl9N T0RFX0JPVFRPTV9UT19UT1AsIGtXS1BhZ2luYXRpb25Nb2RlQm90dG9tVG9Ub3ApOwogCiBFaW5h X0Jvb2wgZXdrX3ZpZXdfcGFnaW5hdGlvbl9tb2RlX3NldChFdmFzX09iamVjdCogZXdrVmlldywg RXdrX1BhZ2luYXRpb25fTW9kZSBtb2RlKQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JF VFVSTihld2tWaWV3LCBpbXBsLCBmYWxzZSk7Ci0gICAgLy8gRklYTUU6IG1vdmUgdG8gZXhwb3J0 ZWQgQyBXS1BhZ2UgQVBJIHdoZW4gaXQgYXBwZWFycy4KLSAgICB0b0ltcGwoaW1wbC0+d2tQYWdl KCkpLT5zZXRQYWdpbmF0aW9uTW9kZShzdGF0aWNfY2FzdDxXZWJDb3JlOjpQYWdpbmF0aW9uOjpN b2RlPihtb2RlKSk7CisKKyAgICBXS1BhZ2VTZXRQYWdpbmF0aW9uTW9kZShpbXBsLT53a1BhZ2Uo KSwgc3RhdGljX2Nhc3Q8V0tQYWdpbmF0aW9uTW9kZT4obW9kZSkpOwogCiAgICAgcmV0dXJuIHRy dWU7CiB9CkBAIC01MTYsOCArNTE1LDggQEAgRWluYV9Cb29sIGV3a192aWV3X3BhZ2luYXRpb25f bW9kZV9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV3a19QYWdpbmF0aW9uX01vZGUKIEV3a19Q YWdpbmF0aW9uX01vZGUgZXdrX3ZpZXdfcGFnaW5hdGlvbl9tb2RlX2dldChjb25zdCBFdmFzX09i amVjdCogZXdrVmlldykKIHsKICAgICBFV0tfVklFV19JTVBMX0dFVF9PUl9SRVRVUk4oZXdrVmll dywgaW1wbCwgRVdLX1BBR0lOQVRJT05fTU9ERV9JTlZBTElEKTsKLSAgICAvLyBGSVhNRTogbW92 ZSB0byBleHBvcnRlZCBDIFdLUGFnZSBBUEkgd2hlbiBpdCBhcHBlYXJzLgotICAgIHJldHVybiBz dGF0aWNfY2FzdDxFd2tfUGFnaW5hdGlvbl9Nb2RlPih0b0ltcGwoaW1wbC0+d2tQYWdlKCkpLT5w YWdpbmF0aW9uTW9kZSgpKTsKKyAgICAKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RXdrX1BhZ2lu YXRpb25fTW9kZT4oV0tQYWdlR2V0UGFnaW5hdGlvbk1vZGUoaW1wbC0+d2tQYWdlKCkpKTsKIH0K IAogRWluYV9Cb29sIGV3a192aWV3X2Z1bGxzY3JlZW5fZXhpdChFdmFzX09iamVjdCogZXdrVmll dykK