116655 2013-05-23 03:43:45 -0700 WebFrameProxy::didFailLoad clears frame title for no apparent reason 2013-05-25 11:35:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 santosh.ma webkit-unassigned andersca ap benjamin cdumez commit-queue gyuyoung.kim sam santosh.mahto vivekg oldest_to_newest 892722 0 santosh.ma 2013-05-23 03:43:45 -0700 void WebFrameProxy::didFailLoad() { ........ ..... m_title = String(); // causing title to empty even though Page(and title) is displayed } When Page loading is stopped before load is finished. we should not set the title to empty string We still have the content to display on screen(we have full Frame & dom tree present). So if page is stopped the UI process always get the empty title even though the page related to that title exists. 892727 1 202657 santosh.ma 2013-05-23 03:53:13 -0700 Created attachment 202657 Patch 892954 2 ap 2013-05-23 10:52:24 -0700 One thing that's very helpful to do in cases like this is svn blame, which may explain rationale behind the code. Here, it points to <http://trac.webkit.org/changeset/74282>. As you can see, the behavior was chosen conscientiously, and even mentioned in ChangeLog . 892958 3 202657 ap 2013-05-23 10:53:30 -0700 Comment on attachment 202657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202657&action=review But I still agree that the behavior is wrong. > Source/WebKit2/ChangeLog:3 > + [WebFrameProxy::didFailLoad] title becomes empty even though Page(and title) is Please update the title in ChangeLog to match Bugzilla. We use brackets in title for a very specific purpose (marking patches that are of limited interest only). 893104 4 202757 santosh.ma 2013-05-23 19:46:27 -0700 Created attachment 202757 Patch 893537 5 santosh.mahto 2013-05-24 18:33:15 -0700 (In reply to comment #3) > (From update of attachment 202657 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202657&action=review > > But I still agree that the behavior is wrong. > > > Source/WebKit2/ChangeLog:3 > > + [WebFrameProxy::didFailLoad] title becomes empty even though Page(and title) is > > Please update the title in ChangeLog to match Bugzilla. > > We use brackets in title for a very specific purpose (marking patches that are of limited interest only). Hi I updated the changLog as requested. please give +1 for this patch 893622 6 vivekg 2013-05-25 11:15:31 -0700 cq+ 893625 7 202757 commit-queue 2013-05-25 11:35:29 -0700 Comment on attachment 202757 Patch Clearing flags on attachment: 202757 Committed r150689: <http://trac.webkit.org/changeset/150689> 893626 8 commit-queue 2013-05-25 11:35:33 -0700 All reviewed patches have been landed. Closing bug. 202657 2013-05-23 03:53:13 -0700 2013-05-23 19:46:21 -0700 Patch bug-116655-20130523195159.patch text/plain 1336 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmU2NzdhMTdiNDM4NDQy Y2I4M2UwYTE3MTI3ZDBhNGIwOTQxNzQ4Mi4uNGRjYjIxNTc2Y2QwMGJiMTYyOGI3MDI5NzA1ZmJm NThhNTUzMDAyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTIzICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV2ViRnJhbWVQ cm94eTo6ZGlkRmFpbExvYWRdIHRpdGxlIGJlY29tZXMgZW1wdHkgZXZlbiB0aG91Z2ggUGFnZShh bmQgdGl0bGUpIGlzCisgICAgICAgIGRpc3BsYXllZCBvbiBzY3JlZW4gb24gc3RvcHBpbmcgbG9h ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NjU1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViRnJhbWVQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6 OmRpZEZhaWxMb2FkKToKKwogMjAxMy0wNS0yMyAgUm9sYW5kIFRha2FjcyAgPHJ0YWthY3NAaW5m LnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFN1cHBvcnQgZnJhbWUgaW5zdHJ1bWVudGF0aW9uIGZv ciBjb29yZGluYXRlZCBncmFwaGljcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkZyYW1lUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZyYW1l UHJveHkuY3BwCmluZGV4IGRlZGI1YzI5YmZmNWZiMGM0ZjhlOTFjY2ZiN2NiNzFkYWYzYThkOTgu LmE1NzA4N2MxZmQ0YzhkYWMyMDIyMzA3YWQ0NWI2YTE1ODllYWQyZjMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAKQEAgLTE2Miw3ICsxNjIsNiBAQCB2b2lk IFdlYkZyYW1lUHJveHk6OmRpZEZhaWxMb2FkKCkKICAgICBBU1NFUlQobV9sb2FkU3RhdGUgPT0g TG9hZFN0YXRlQ29tbWl0dGVkKTsKICAgICBBU1NFUlQobV9wcm92aXNpb25hbFVSTC5pc0VtcHR5 KCkpOwogICAgIG1fbG9hZFN0YXRlID0gTG9hZFN0YXRlRmluaXNoZWQ7Ci0gICAgbV90aXRsZSA9 IFN0cmluZygpOwogfQogCiB2b2lkIFdlYkZyYW1lUHJveHk6OmRpZFNhbWVEb2N1bWVudE5hdmln YXRpb24oY29uc3QgU3RyaW5nJiB1cmwpCg== 202757 2013-05-23 19:46:27 -0700 2013-05-25 11:35:29 -0700 Patch bug-116655-20130524114513.patch text/plain 1268 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTA5NTdiYmVlNjA0YmRm OTU0MWI4ZTVlYzBjOTk2N2E2YzVmM2JjOS4uZWQ4NDI4NjBlYjcwOGMwMTk3NTM1NzY2ZTdmMTRh ZWJkZDM2YTU0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTIzICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBXZWJGcmFtZVBy b3h5OjpkaWRGYWlsTG9hZCBjbGVhcnMgZnJhbWUgdGl0bGUgZm9yIG5vIGFwcGFyZW50IHJlYXNv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NjU1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViRnJhbWVQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6 OmRpZEZhaWxMb2FkKToKKwogMjAxMy0wNS0yMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FA YXBwbGUuY29tPgogCiAgICAgICAgIFNoaW0gRmxhc2ggcGx1Zy1pbiB0byBhbGxvdyBpdHMgdXBk YXRlciB0byBydW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFt ZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcApp bmRleCBkZWRiNWMyOWJmZjVmYjBjNGY4ZTkxY2NmYjdjYjcxZGFmM2E4ZDk4Li5hNTcwODdjMWZk NGM4ZGFjMjAyMjMwN2FkNDViNmExNTg5ZWFkMmYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkZyYW1lUHJveHkuY3BwCkBAIC0xNjIsNyArMTYyLDYgQEAgdm9pZCBXZWJGcmFtZVBy b3h5OjpkaWRGYWlsTG9hZCgpCiAgICAgQVNTRVJUKG1fbG9hZFN0YXRlID09IExvYWRTdGF0ZUNv bW1pdHRlZCk7CiAgICAgQVNTRVJUKG1fcHJvdmlzaW9uYWxVUkwuaXNFbXB0eSgpKTsKICAgICBt X2xvYWRTdGF0ZSA9IExvYWRTdGF0ZUZpbmlzaGVkOwotICAgIG1fdGl0bGUgPSBTdHJpbmcoKTsK IH0KIAogdm9pZCBXZWJGcmFtZVByb3h5OjpkaWRTYW1lRG9jdW1lbnROYXZpZ2F0aW9uKGNvbnN0 IFN0cmluZyYgdXJsKQo=