116639 2013-05-22 15:08:59 -0700 Fix assertion in the getComputedStyle-background-shorthand.html test 2013-05-22 15:19:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn simon.fraser oldest_to_newest 892559 0 simon.fraser 2013-05-22 15:08:59 -0700 Fix assertion in the getComputedStyle-background-shorthand.html test 892561 1 202627 simon.fraser 2013-05-22 15:13:15 -0700 Created attachment 202627 Patch 892563 2 202627 rniwa 2013-05-22 15:16:21 -0700 Comment on attachment 202627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202627&action=review > Source/WebCore/rendering/RenderObject.cpp:2527 > + if (!isText()) { I wish we had a way to assert that this is the only case we have to worry about. 892567 3 simon.fraser 2013-05-22 15:19:20 -0700 https://trac.webkit.org/r150547 202627 2013-05-22 15:13:15 -0700 2013-05-22 15:16:21 -0700 Patch bug-116639-20130522151207.patch text/plain 2567 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjllN2Y5ZjRmZDMxYzk4 NDM4NDdiODA5NTA1OGRiYjhmYzJjMDEyZi4uNDY4N2EyM2Q2NmI3Mzc5ZDQxNTJmZWFiODQ1MzMy NWNlYTllMTM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTA1LTIyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBhc3NlcnRp b24gaW4gdGhlIGdldENvbXB1dGVkU3R5bGUtYmFja2dyb3VuZC1zaG9ydGhhbmQuaHRtbCB0ZXN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2MzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBnZXRDb21w dXRlZFN0eWxlLWJhY2tncm91bmQtc2hvcnRoYW5kLmh0bWwgd2FzIGFzc2VydGluZyB1bmRlciB0 aGUgbmV3bHkgYWRkZWQKKyAgICAgICAgY29kZSBpbiB3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKS4g VGhlIGFzc2VydGlvbiB3YXMgY2F1c2VkIGJ5IHRvbyBtYW55IGNhbGxzIHRvCisgICAgICAgIEZy YW1lVmlldzo6cmVtb3ZlU2xvd1JlcGFpbnRPYmplY3QoKSwgd2hpY2ggaGFwcGVuZWQgYmVjYXVz ZSB3ZSBjYWxsZWQgaXQgZm9yCisgICAgICAgIFJlbmRlclRleHRzLCB3aGljaCBzaGFyZSBzdHls ZSB3aXRoIHRoZWlyIHBhcmVudCByZW5kZXJlci4KKyAgICAgICAgCisgICAgICAgIFJlbmRlclRl eHQgb3ZlcnJpZGVzIHN0eWxlV2lsbENoYW5nZSgpIHRvIGRvIG5vdGhpbmcsIHNvIHdlIG5ldmVy CisgICAgICAgIGNhbGwgYWRkL3JlbW92ZVNsb3dSZXBhaW50T2JqZWN0KCkgZm9yIHRoZW0uIFRo dXMgd2Ugc2hvdWxkIGFsc28gc2tpcCB0aGlzCisgICAgICAgIHdvcmsgaW4gd2lsbEJlUmVtb3Zl ZEZyb21UcmVlKCkgZm9yIFJlbmRlclRleHRzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OndpbGxCZVJlbW92 ZWRGcm9tVHJlZSk6CisKKzIwMTMtMDUtMjIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CisKICAgICAgICAgRml4IGlzc3VlcyB3aXRoIGZvY3VzIHJpbmdzIG9uIHNlYXJj aCBmaWVsZHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjU5MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4 IGY2OGUwZTZhMzU1ZmZjNmZjZTRlYWJlMzM3NjgwZWUxMDQzZThkZWMuLmRjNTdmNGJhMWE1MWZh ZmNmOTc0OTEzZmRkMDc0ZDlmZjljMjFlOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCkBAIC0yNTI0LDEwICsyNTI0LDEyIEBAIHZvaWQgUmVuZGVyT2JqZWN0 Ojp3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKQogewogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgQVNT RVJUKGlzUm9vdGVkKCkpIGJ1dCB3ZSBoYXZlIHNvbWUgb3V0LW9mLW9yZGVyIHJlbW92YWxzIHdo aWNoIHdvdWxkIG5lZWQgdG8gYmUgZml4ZWQgZmlyc3QuCiAKLSAgICBpZiAoRnJhbWVWaWV3KiBm cmFtZVZpZXcgPSB2aWV3KCktPmZyYW1lVmlldygpKSB7Ci0gICAgICAgIGJvb2wgcmVwYWludEZp eGVkQmFja2dyb3VuZHNPblNjcm9sbCA9IHNob3VsZFJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25T Y3JvbGwoZnJhbWVWaWV3KTsKLSAgICAgICAgaWYgKHJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25T Y3JvbGwgJiYgbV9zdHlsZSAmJiBtX3N0eWxlLT5oYXNGaXhlZEJhY2tncm91bmRJbWFnZSgpKQot ICAgICAgICAgICAgZnJhbWVWaWV3LT5yZW1vdmVTbG93UmVwYWludE9iamVjdCgpOworICAgIGlm ICghaXNUZXh0KCkpIHsKKyAgICAgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gdmlldygp LT5mcmFtZVZpZXcoKSkgeworICAgICAgICAgICAgYm9vbCByZXBhaW50Rml4ZWRCYWNrZ3JvdW5k c09uU2Nyb2xsID0gc2hvdWxkUmVwYWludEZpeGVkQmFja2dyb3VuZHNPblNjcm9sbChmcmFtZVZp ZXcpOworICAgICAgICAgICAgaWYgKHJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25TY3JvbGwgJiYg bV9zdHlsZSAmJiBtX3N0eWxlLT5oYXNGaXhlZEJhY2tncm91bmRJbWFnZSgpKQorICAgICAgICAg ICAgICAgIGZyYW1lVmlldy0+cmVtb3ZlU2xvd1JlcGFpbnRPYmplY3QoKTsKKyAgICAgICAgfQog ICAgIH0KIAogICAgIC8vIElmIHdlIHJlbW92ZSBhIHZpc2libGUgY2hpbGQgZnJvbSBhbiBpbnZp c2libGUgcGFyZW50LCB3ZSBkb24ndCBrbm93IHRoZSBsYXllciB2aXNpYmlsaXR5IGFueSBtb3Jl Lgo=