116625 2013-05-22 11:42:14 -0700 [wk2] Should be able to make tiled WKViews clip to the view's exposed rect without using autolayout 2013-05-22 12:48:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue sam simon.fraser webkit-bug-importer oldest_to_newest 892471 0 thorton 2013-05-22 11:42:14 -0700 The two modes are not dependent, we just have had no reason to enable them separately before. 892472 1 webkit-bug-importer 2013-05-22 11:44:04 -0700 <rdar://problem/13962816> 892473 2 202608 thorton 2013-05-22 11:53:02 -0700 Created attachment 202608 patch 892475 3 commit-queue 2013-05-22 11:55:17 -0700 Attachment 202608 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h']" exit_code: 1 Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 892476 4 202608 thorton 2013-05-22 11:56:12 -0700 Comment on attachment 202608 patch View in context: https://bugs.webkit.org/attachment.cgi?id=202608&action=review >> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63 >> +@property (readwrite) BOOL shouldClipToExposedRect; > > Extra space before ( in function call [whitespace/parens] [4] False. 892489 5 202608 andersca 2013-05-22 12:32:03 -0700 Comment on attachment 202608 patch I think we should call the API “shouldClipToVisibleRect”. 892500 6 thorton 2013-05-22 12:48:48 -0700 https://trac.webkit.org/r150532 202608 2013-05-22 11:53:02 -0700 2013-05-22 12:32:02 -0700 patch clips-to-exposed.diff text/plain 5475 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxZDA5YmE3Li5mMjhiYzhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUg QEAKKzIwMTMtMDUtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gU2hvdWxkIGJlIGFibGUgdG8gbWFrZSB0aWxlZCBXS1ZpZXdzIGNsaXAg dG8gdGhlIHZpZXcncyBleHBvc2VkIHJlY3Qgd2l0aG91dCB1c2luZyBhdXRvbGF5b3V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY2MjUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzEzOTYyODE2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0d28gbW9kZXMgYXJlIG5vdCBkZXBlbmRlbnQ7IGl0 IHNob3VsZCBiZSBwb3NzaWJsZSB0byBlbmFibGUKKyAgICAgICAgY2xpcHMtdG8tZXhwb3NlZC1y ZWN0IHdpdGhvdXQgdXNpbmcgYXV0b2xheW91dC4gVGhpcyBlbmFibGVzIGFwcHMgdG8KKyAgICAg ICAgbWFrZSB2ZXJ5IGxhcmdlIHRpbGVkIFdLVmlld3MgdGhhdCBkb24ndCBjcmVhdGUgdGlsZXMg Zm9yIHRoZSB3aG9sZQorICAgICAgICBhcmVhIG9mIHRoZSB2aWV3IChhbmQgYWxzbyBkaXNhYmxl cyBzY3JvbGxpbmcsIHNpbmNlIHRoYXQgaXMgY3VycmVudGx5CisgICAgICAgIGluY29tcGF0aWJs ZSB3aXRoIGNsaXBwaW5nIHRvIHRoZSBleHBvc2VkIHJlY3QpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgc2V0RnJhbWVTaXplOl0p OgorICAgICAgICAoLVtXS1ZpZXcgX3VwZGF0ZVdpbmRvd0FuZFZpZXdGcmFtZXNdKToKKyAgICAg ICAgKC1bV0tWaWV3IGluaXRXaXRoRnJhbWU6Y29udGV4dFJlZjpwYWdlR3JvdXBSZWY6cmVsYXRl ZFRvUGFnZTpdKToKKyAgICAgICAgKC1bV0tWaWV3IGVuYWJsZUZyYW1lU2l6ZVVwZGF0ZXNdKToK KyAgICAgICAgKC1bV0tWaWV3IGZvcmNlQXN5bmNEcmF3aW5nQXJlYVNpemVVcGRhdGU6XSk6Cisg ICAgICAgIFJlbmFtZSBfZXhwYW5kc1RvRml0Q29udGVudFZpYUF1dG9MYXlvdXQgdG8gX2NsaXBz VG9FeHBvc2VkUmVjdCBmb3IgYWNjdXJhY3kuCisKKyAgICAgICAgKC1bV0tWaWV3IHNldE1pbmlt dW1XaWR0aEZvckF1dG9MYXlvdXQ6XSk6CisgICAgICAgIEZhY3RvciBjbGlwcy10by1leHBvc2Vk LXJlY3QgdG9nZ2xlIG91dCBpbnRvIHNldFNob3VsZENsaXBUb0V4cG9zZWRSZWN0LgorCisgICAg ICAgICgtW1dLVmlldyBzaG91bGRDbGlwVG9FeHBvc2VkUmVjdF0pOgorICAgICAgICAoLVtXS1Zp ZXcgc2V0U2hvdWxkQ2xpcFRvRXhwb3NlZFJlY3Q6XSk6CisgICAgICAgIEFsbG93IHNldHRpbmcg Y2xpcHMtdG8tZXhwb3NlZCByZWN0IHdpdGhvdXQgYXV0b2xheW91dC4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvbWFjL1dLVmlld1ByaXZhdGUuaDoKKyAgICAgICAgQWRkIHNob3VsZENsaXBU b0V4cG9zZWRSZWN0IHByb3BlcnR5LgorCiAyMDEzLTA1LTIxICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IGM3NmU2NTkuLjRiMWQ1YzIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KQEAgLTIzNSw3ICsyMzUs NyBAQCBzdHJ1Y3QgV0tWaWV3SW50ZXJwcmV0S2V5RXZlbnRzUGFyYW1ldGVycyB7CiAgICAgV0tD b250ZW50QW5jaG9yIF9jb250ZW50QW5jaG9yOwogICAgIAogICAgIE5TU2l6ZSBfaW50cmluc2lj Q29udGVudFNpemU7Ci0gICAgQk9PTCBfZXhwYW5kc1RvRml0Q29udGVudFZpYUF1dG9MYXlvdXQ7 CisgICAgQk9PTCBfY2xpcHNUb0V4cG9zZWRSZWN0OwogCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9O X01JTl9SRVFVSVJFRCA+PSAxMDkwCiAgICAgQk9PTCBfaXNXaW5kb3dPY2NsdWRlZDsKQEAgLTQy Niw3ICs0MjYsNyBAQCBzdHJ1Y3QgV0tWaWV3SW50ZXJwcmV0S2V5RXZlbnRzUGFyYW1ldGVycyB7 CiAgICAgW3N1cGVyIHNldEZyYW1lU2l6ZTpzaXplXTsKIAogICAgIGlmIChmcmFtZVNpemVVcGRh dGVzRW5hYmxlZCkgewotICAgICAgICBpZiAoX2RhdGEtPl9leHBhbmRzVG9GaXRDb250ZW50Vmlh QXV0b0xheW91dCkKKyAgICAgICAgaWYgKF9kYXRhLT5fY2xpcHNUb0V4cG9zZWRSZWN0KQogICAg ICAgICAgICAgX2RhdGEtPl9wYWdlLT52aWV3RXhwb3NlZFJlY3RDaGFuZ2VkKFtzZWxmIHZpc2li bGVSZWN0XSk7CiAgICAgICAgIFtzZWxmIF9zZXREcmF3aW5nQXJlYVNpemU6c2l6ZV07CiAgICAg fQpAQCAtNDM4LDcgKzQzOCw3IEBAIHN0cnVjdCBXS1ZpZXdJbnRlcnByZXRLZXlFdmVudHNQYXJh bWV0ZXJzIHsKICAgICBOU1BvaW50IGFjY2Vzc2liaWxpdHlQb3NpdGlvbiA9IFtbc2VsZiBhY2Nl c3NpYmlsaXR5QXR0cmlidXRlVmFsdWU6TlNBY2Nlc3NpYmlsaXR5UG9zaXRpb25BdHRyaWJ1dGVd IHBvaW50VmFsdWVdOwogICAgIAogICAgIF9kYXRhLT5fcGFnZS0+d2luZG93QW5kVmlld0ZyYW1l c0NoYW5nZWQodmlld0ZyYW1lSW5XaW5kb3dDb29yZGluYXRlcywgYWNjZXNzaWJpbGl0eVBvc2l0 aW9uKTsKLSAgICBpZiAoX2RhdGEtPl9leHBhbmRzVG9GaXRDb250ZW50VmlhQXV0b0xheW91dCkK KyAgICBpZiAoX2RhdGEtPl9jbGlwc1RvRXhwb3NlZFJlY3QpCiAgICAgICAgIF9kYXRhLT5fcGFn ZS0+dmlld0V4cG9zZWRSZWN0Q2hhbmdlZChbc2VsZiB2aXNpYmxlUmVjdF0pOwogfQogCkBAIC0z MDY2LDcgKzMwNjYsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKnBhdGhXaXRoVW5pcXVlRmlsZW5hbWVG b3JQYXRoKE5TU3RyaW5nICpwYXRoKQogI2VuZGlmCiAgICAgX2RhdGEtPl9tb3VzZURvd25FdmVu dCA9IG5pbDsKICAgICBfZGF0YS0+X2lnbm9yaW5nTW91c2VEcmFnZ2VkRXZlbnRzID0gTk87Ci0g ICAgX2RhdGEtPl9leHBhbmRzVG9GaXRDb250ZW50VmlhQXV0b0xheW91dCA9IE5POworICAgIF9k YXRhLT5fY2xpcHNUb0V4cG9zZWRSZWN0ID0gTk87CiAKICAgICBfZGF0YS0+X2ludHJpbnNpY0Nv bnRlbnRTaXplID0gTlNNYWtlU2l6ZShOU1ZpZXdOb0luc3RyaW5zaWNNZXRyaWMsIE5TVmlld05v SW5zdHJpbnNpY01ldHJpYyk7CiAKQEAgLTMxNzEsNyArMzE3MSw3IEBAIHN0YXRpYyBOU1N0cmlu ZyAqcGF0aFdpdGhVbmlxdWVGaWxlbmFtZUZvclBhdGgoTlNTdHJpbmcgKnBhdGgpCiAgICAgICAg IHJldHVybjsKICAgICAKICAgICBpZiAoISgtLV9kYXRhLT5fZnJhbWVTaXplVXBkYXRlc0Rpc2Fi bGVkQ291bnQpKSB7Ci0gICAgICAgIGlmIChfZGF0YS0+X2V4cGFuZHNUb0ZpdENvbnRlbnRWaWFB dXRvTGF5b3V0KQorICAgICAgICBpZiAoX2RhdGEtPl9jbGlwc1RvRXhwb3NlZFJlY3QpCiAgICAg ICAgICAgICBfZGF0YS0+X3BhZ2UtPnZpZXdFeHBvc2VkUmVjdENoYW5nZWQoW3NlbGYgdmlzaWJs ZVJlY3RdKTsKICAgICAgICAgW3NlbGYgX3NldERyYXdpbmdBcmVhU2l6ZTpbc2VsZiBmcmFtZV0u c2l6ZV07CiAgICAgfQpAQCAtMzIyOSwxMyArMzIyOSwyNCBAQCBzdGF0aWMgTlNTdHJpbmcgKnBh dGhXaXRoVW5pcXVlRmlsZW5hbWVGb3JQYXRoKE5TU3RyaW5nICpwYXRoKQogewogICAgIEJPT0wg ZXhwYW5kc1RvRml0ID0gbWluaW11bUxheW91dFdpZHRoID4gMDsKIAotICAgIF9kYXRhLT5fZXhw YW5kc1RvRml0Q29udGVudFZpYUF1dG9MYXlvdXQgPSBleHBhbmRzVG9GaXQ7CiAgICAgX2RhdGEt Pl9wYWdlLT5zZXRNaW5pbXVtTGF5b3V0V2lkdGgobWluaW11bUxheW91dFdpZHRoKTsKIAotICAg IGlmIChleHBhbmRzVG9GaXQpCisgICAgW3NlbGYgc2V0U2hvdWxkQ2xpcFRvRXhwb3NlZFJlY3Q6 ZXhwYW5kc1RvRml0XTsKK30KKworLSAoQk9PTClzaG91bGRDbGlwVG9FeHBvc2VkUmVjdAorewor ICAgIHJldHVybiBfZGF0YS0+X2NsaXBzVG9FeHBvc2VkUmVjdDsKK30KKworLSAodm9pZClzZXRT aG91bGRDbGlwVG9FeHBvc2VkUmVjdDooQk9PTCljbGlwc1RvRXhwb3NlZFJlY3QKK3sKKyAgICBf ZGF0YS0+X2NsaXBzVG9FeHBvc2VkUmVjdCA9IGNsaXBzVG9FeHBvc2VkUmVjdDsKKworICAgIGlm IChjbGlwc1RvRXhwb3NlZFJlY3QpCiAgICAgICAgIF9kYXRhLT5fcGFnZS0+dmlld0V4cG9zZWRS ZWN0Q2hhbmdlZChbc2VsZiB2aXNpYmxlUmVjdF0pOwogCi0gICAgX2RhdGEtPl9wYWdlLT5zZXRN YWluRnJhbWVJc1Njcm9sbGFibGUoIWV4cGFuZHNUb0ZpdCk7CisgICAgX2RhdGEtPl9wYWdlLT5z ZXRNYWluRnJhbWVJc1Njcm9sbGFibGUoIWNsaXBzVG9FeHBvc2VkUmVjdCk7CiB9CiAKIC0gKE5T Q29sb3IgKil1bmRlcmxheUNvbG9yCkBAIC0zMzUzLDcgKzMzNjQsNyBAQCBzdGF0aWMgTlNTdHJp bmcgKnBhdGhXaXRoVW5pcXVlRmlsZW5hbWVGb3JQYXRoKE5TU3RyaW5nICpwYXRoKQogLy8gZnJh bWUgYWNjb3JkaW5nIHRvIHRoZSBjdXJyZW50IGNvbnRlbnRBbmNob3IuCiAtICh2b2lkKWZvcmNl QXN5bmNEcmF3aW5nQXJlYVNpemVVcGRhdGU6KE5TU2l6ZSlzaXplCiB7Ci0gICAgaWYgKF9kYXRh LT5fZXhwYW5kc1RvRml0Q29udGVudFZpYUF1dG9MYXlvdXQpCisgICAgaWYgKF9kYXRhLT5fY2xp cHNUb0V4cG9zZWRSZWN0KQogICAgICAgICBfZGF0YS0+X3BhZ2UtPnZpZXdFeHBvc2VkUmVjdENo YW5nZWQoW3NlbGYgdmlzaWJsZVJlY3RdKTsKICAgICBbc2VsZiBfc2V0RHJhd2luZ0FyZWFTaXpl OnNpemVdOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdQ cml2YXRlLmgKaW5kZXggMjdkZDVhNy4uZjE1YTdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld1ByaXZhdGUuaApAQCAtNjAsNiArNjAsNyBAQCB0eXBl ZGVmIGVudW0gewogCiBAcHJvcGVydHkgKHJlYWR3cml0ZSkgQ0dGbG9hdCBtaW5pbXVtTGF5b3V0 V2lkdGg7CiBAcHJvcGVydHkgKHJlYWR3cml0ZSkgQ0dGbG9hdCBtaW5pbXVtV2lkdGhGb3JBdXRv TGF5b3V0OworQHByb3BlcnR5IChyZWFkd3JpdGUpIEJPT0wgc2hvdWxkQ2xpcFRvRXhwb3NlZFJl Y3Q7CiAKIEBwcm9wZXJ0eShjb3B5LCBub25hdG9taWMpIE5TQ29sb3IgKnVuZGVybGF5Q29sb3I7 CiAK