116615 2013-05-22 07:04:25 -0700 [EFL] Back, Forward and Stop should be hidden in context menu 2013-05-23 00:06:12 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mpakulavelrutka mpakulavelrutka cdumez commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 892277 0 mpakulavelrutka 2013-05-22 07:04:25 -0700 SSIA 892282 1 202535 mpakulavelrutka 2013-05-22 07:27:16 -0700 Created attachment 202535 proposed patch 892286 2 202535 andersca 2013-05-22 08:03:45 -0700 Comment on attachment 202535 proposed patch Maybe this decision could be made by a call out to the PopupMenuClient? 892290 3 mpakulavelrutka 2013-05-22 08:47:31 -0700 (In reply to comment #2) > (From update of attachment 202535 [details]) > Maybe this decision could be made by a call out to the PopupMenuClient? In case of back/forward it is possible, but I am not sure if I can made check inside UIProcess for reload/stop like DocumentLoader::isLoadingInAPISense. 892687 4 202535 cdumez 2013-05-22 23:34:49 -0700 Comment on attachment 202535 proposed patch One less #ifdef and it makes EFL use more common code which is always good. The items in question were not getting disabled for us anyway so it is best not to show them. r=me but let Gyuyoung have a look before landing as he may be the one who added this #ifdef in the first place. 892688 5 gyuyoung.kim 2013-05-22 23:44:23 -0700 There was no big reason to show those menu items. It just follows GTK port behavior. If the items doesn't work on EFL port now, I'm fine. 892689 6 202535 gyuyoung.kim 2013-05-22 23:46:45 -0700 Comment on attachment 202535 proposed patch I'd like to check API test with patch before landing. 892690 7 202535 gyuyoung.kim 2013-05-22 23:55:28 -0700 Comment on attachment 202535 proposed patch There is no problem on context menu API tests. 892691 8 202535 commit-queue 2013-05-23 00:06:07 -0700 Comment on attachment 202535 proposed patch Clearing flags on attachment: 202535 Committed r150575: <http://trac.webkit.org/changeset/150575> 892692 9 commit-queue 2013-05-23 00:06:12 -0700 All reviewed patches have been landed. Closing bug. 202535 2013-05-22 07:27:16 -0700 2013-05-23 00:06:07 -0700 proposed patch backforward.diff text/plain 1640 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YTNlMTA0Li5jZjk2MTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDUtMjIgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1z dW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCYWNrLCBGb3J3YXJkIGFuZCBTdG9wIHNob3VsZCBi ZSBoaWRkZW4gaW4gY29udGV4dCBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTY2MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDb250ZXh0IG1lbnUgaXRlbXM6IEJhY2ssIEZvcndhcmQsIFN0b3As IFJlbG9hZCwgc2hvdWxkIGJlIHNob3duIG9ubHkgd2hlbgorICAgICAgICB0aGV5IGFyZSBhYmxl IHRvIHBlcmZvcm0gYWN0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIG5vIG5ldyBmdW5j dGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVDb250cm9sbGVyOjpwb3B1bGF0ZSk6CisKIDIw MTMtMDUtMjEgIE1paGFpIFRpY2EgIDxtaXRpY2FAYWRvYmUuY29tPgogICAgICAgICAKICAgICAg ICAgVXBkYXRlIHRoZSBiYWNrZ3JvdW5kIGJsZW5kaW5nIGltcGxlbWVudGF0aW9uIHRvIG1hdGNo IHRoZSBjaGFuZ2VzIGRvbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29udGV4 dE1lbnVDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDb250 cm9sbGVyLmNwcAppbmRleCA2MGYyYzI4Li5lZDgzMTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCkBAIC04OTAsOCArODkwLDggQEAgdm9pZCBD b250ZXh0TWVudUNvbnRyb2xsZXI6OnBvcHVsYXRlKCkKICAgICAgICAgICAgICAgICBpZiAoIShm cmFtZS0+cGFnZSgpICYmIGZyYW1lLT5wYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+aGFz SW5zcGVjdG9yRnJvbnRlbmRDbGllbnQoKSkpIHsKICNlbmRpZgogCi0gICAgICAgICAgICAgICAg Ly8gSW4gR1RLKyBhbmQgRUZMLCB1bmF2YWlsYWJsZSBpdGVtcyBhcmUgbm90IGhpZGRlbiBidXQg aW5zZW5zaXRpdmUuCi0jaWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShFRkwpCisgICAgICAg ICAgICAgICAgLy8gSW4gR1RLKyB1bmF2YWlsYWJsZSBpdGVtcyBhcmUgbm90IGhpZGRlbiBidXQg aW5zZW5zaXRpdmUuCisjaWYgUExBVEZPUk0oR1RLKQogICAgICAgICAgICAgICAgIGFwcGVuZEl0 ZW0oQmFja0l0ZW0sIG1fY29udGV4dE1lbnUuZ2V0KCkpOwogICAgICAgICAgICAgICAgIGFwcGVu ZEl0ZW0oRm9yd2FyZEl0ZW0sIG1fY29udGV4dE1lbnUuZ2V0KCkpOwogICAgICAgICAgICAgICAg IGFwcGVuZEl0ZW0oU3RvcEl0ZW0sIG1fY29udGV4dE1lbnUuZ2V0KCkpOwo=