116612 2013-05-22 06:45:18 -0700 [Qt][Mips] r150484 broke the build 2013-05-30 12:15:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108664 116578 1 zarvai allan.jensen allan.jensen andersca gergely jturcotte kadam kilvadyb ossy oldest_to_newest 892271 0 zarvai 2013-05-22 06:45:18 -0700 After the patch something went wrong on Qt Mips: /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp: In member function 'WebKit::PluginProcessProxy* WebKit::PluginProcessManager::getOrCreatePluginProcess(uint64_t)': /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:126: error: cannot convert 'std::nullptr_t' to 'WebKit::PluginProcessProxy*' in return make[3]: *** [.obj/release-shared/UIProcess/Plugins/PluginProcessManager.o] Error 1 changes in that file: http://trac.webkit.org/changeset/150484/trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp 892919 1 ossy 2013-05-23 09:19:19 -0700 It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in Source/WTF/wtf/Compiler.h , because you use too old compiler. But now c++11 is mandatory for WebKit2, so you probably need newer compiler. 892941 2 kilvadyb 2013-05-23 10:19:46 -0700 (In reply to comment #1) > It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in > Source/WTF/wtf/Compiler.h , because you use too old compiler. > > But now c++11 is mandatory for WebKit2, so you probably need newer compiler. Tamk you for the info. We are working on it. 892942 3 kilvadyb 2013-05-23 10:21:02 -0700 (In reply to comment #2) > (In reply to comment #1) > > It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in > > Source/WTF/wtf/Compiler.h , because you use too old compiler. > > > > But now c++11 is mandatory for WebKit2, so you probably need newer compiler. > > Tamk you for the info. We are working on it. Sorry, I wanted to write: Thank you 893966 4 allan.jensen 2013-05-27 04:26:56 -0700 The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. 893969 5 ossy 2013-05-27 04:29:31 -0700 (In reply to comment #4) > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. C++11 in WebKit2 is mandatory now... ... but feel free to find a WebKit2 owner for this fix. :) 893970 6 202969 allan.jensen 2013-05-27 04:31:01 -0700 Created attachment 202969 Patch 893971 7 allan.jensen 2013-05-27 04:32:46 -0700 (In reply to comment #5) > (In reply to comment #4) > > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. > > C++11 in WebKit2 is mandatory now... > > ... but feel free to find a WebKit2 owner for this fix. :) All of C++11 is hardly mandatory, or we would depend on unreleased compilers. There is has to be an expected subset of featuers. 894138 8 andersca 2013-05-27 13:26:32 -0700 (In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #4) > > > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. > > > > C++11 in WebKit2 is mandatory now... > > > > ... but feel free to find a WebKit2 owner for this fix. :) > > All of C++11 is hardly mandatory, or we would depend on unreleased compilers. There is has to be an expected subset of featuers. I’ve generally only used features that’s available on compilers that have been out for at least two years. That includes MSVC 2010 as well as GCC 4.6. 895533 9 zarvai 2013-05-30 07:37:27 -0700 The bot is green again :) 895626 10 202969 andersca 2013-05-30 12:15:39 -0700 Comment on attachment 202969 Patch Clearing review flag. 202969 2013-05-27 04:31:01 -0700 2013-05-30 12:15:39 -0700 Patch bug-116612-20130527132941.patch text/plain 1336 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzZlNTIzMDFjNzJmNzcy ZTNkYjRjZjFlMzEwOTk0MDY4MWNmZGU2Yi4uY2YxODc2NGRhMzdlMDlhMTUwYTE1ZDdiN2JiNTY0 YzM1NDk5MzM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTI3ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF1bTWlwc10gcjE1MDQ4NCBicm9rZSB0aGUgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjYxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVubmVjZXNzYXJ5IHVzZSBvZiAnbnVsbHB0cicgYnJl YWtzIEdDQyA8IDQuNiBldmVuIGluIEMrKzExIG1vZGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv UGx1Z2lucy9QbHVnaW5Qcm9jZXNzTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdp blByb2Nlc3NNYW5hZ2VyOjpnZXRPckNyZWF0ZVBsdWdpblByb2Nlc3MpOgorCiAyMDEzLTA1LTI2 ICBDaGFuZ2h1biBLYW5nICA8dGVtb29jaGluQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFRo ZSBwdWJsaWMgV0sgaGVhZGVyIGZpbGUgc2hvdWxkIG5vdCBpbmNsdWRlIFdLQVBJQ2FzdC5oCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNz TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9j ZXNzTWFuYWdlci5jcHAKaW5kZXggMjI3OWFhZWNkY2Q5NTYwMTA5ZmE4MWUxMjRmMzZiZWQ3ZTgw MmQ3My4uNmFmNTkzYTU0OWM0ZGVmNWViZTA1MWNkN2I3YTg1MjdjZjAzM2YzNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc01hbmFnZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NN YW5hZ2VyLmNwcApAQCAtMTIzLDcgKzEyMyw3IEBAIFBsdWdpblByb2Nlc3NQcm94eSogUGx1Z2lu UHJvY2Vzc01hbmFnZXI6OmdldE9yQ3JlYXRlUGx1Z2luUHJvY2Vzcyh1aW50NjRfdCBwbHVnCiAg ICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gbnVsbHB0cjsKKyAgICByZXR1cm4gMDsKIH0K IAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==