116609 2013-05-22 05:55:15 -0700 [Qt][Win] r150484 broke the build 2014-01-13 22:04:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 116578 1 zarvai webkit-unassigned allan.jensen andersca hausmann jturcotte kadam kbalazs kling ossy oldest_to_newest 892251 0 zarvai 2013-05-22 05:55:15 -0700 It seems ENABLE_NETSCAPE_PLUGIN_API=1 but ENABLE_PLUGIN_PROCESS is not set (not in Features) on Qt Win. Probably that makes the following error on it: WebPageProxy.cpp C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1426) : error C2065: 'PluginProcessSandboxPolicy' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1426) : error C2146: syntax error : missing ';' before identifier 'pluginProcessSandboxPolicy' C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1426) : error C2065: 'pluginProcessSandboxPolicy' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1429) : error C2065: 'pluginProcessSandboxPolicy' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1429) : error C2065: 'PluginProcessSandboxPolicyNormal' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1432) : error C2065: 'pluginProcessSandboxPolicy' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1432) : error C2065: 'PluginProcessSandboxPolicyUnsandboxed' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1441) : error C2065: 'pluginProcessSandboxPolicy' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1441) : error C2065: 'PluginProcessSandboxPolicyUnsandboxed' : undeclared identifier C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1442) : error C2653: 'PluginProcessManager' : is not a class or namespace name C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1442) : error C2228: left of '.pluginProcessToken' must have class/struct/union type is ''unknown-type'' C:\buildslave\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\WebPageProxy.cpp(1442) : error C2061: syntax error : identifier 'PluginProcessType' 892252 1 zarvai 2013-05-22 05:57:58 -0700 "#if ENABLE(PLUGIN_PROCESS)" guard is removed from WebKit2/Shared/Plugins/PluginProcessAttributes.h https://trac.webkit.org/changeset/150484/trunk/Source/WebKit2/Shared/Plugins/PluginProcessAttributes.h 892254 2 ossy 2013-05-22 06:02:03 -0700 Yes, plugin process is mandatory now, as Anders announced it on webkit-dev. In this case it would be great to fix it in Qt build system too. 892257 3 ossy 2013-05-22 06:11:35 -0700 Hmmm ... PluginProcess is really disabled on Qt Windows: https://trac.webkit.org/browser/trunk/Tools/qmake/mkspecs/features/features.prf#L66 It is enabled if xlib is available. 892260 4 ossy 2013-05-22 06:17:29 -0700 Plugin process was enabled by https://trac.webkit.org/changeset/112889 on unix long long time ago. Is there a reason why wasn't it enabled on Windows too? 892872 5 202713 zarvai 2013-05-23 07:31:41 -0700 Created attachment 202713 plugin_process I played a little bit with the Windows build to see what happens if I turn on plugin_process on Win. Currently I got some error: PluginProcessQt.cpp C:\WebKitBuildSlave\proba\WebKit\Source\WebKit2\PluginProcess\qt\PluginProcessMa inQt.cpp(88) : error C2039: 'scanPlugin' : is not a member of 'WebKit::NetscapeP luginModule' C:\WebKitBuildSlave\proba\WebKit\Source\WebKit2\Shared\Plugins\Netscape\ NetscapePluginModule.h(42) : see declaration of 'WebKit::NetscapePluginModule' C:\WebKitBuildSlave\proba\WebKit\Source\WebKit2\PluginProcess\qt\PluginProcessMa inQt.cpp(88) : error C3861: 'scanPlugin': identifier not found C:\WebKitBuildSlave\proba\WebKit\Source\WebKit2\PluginProcess\qt\PluginProcessMa inQt.cpp(100) : error C2440: '=' : cannot convert from 'int' to 'CoreIPC::Connec tion::Identifier' Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast 892877 6 ossy 2013-05-23 07:42:47 -0700 It seems the problem is that NetscapePluginModule::scanPlugin is implemented in NetscapePluginModuleX11.cpp Maybe disabling scanPlugin commandline option for !PLUGIN_ARCHITECTURE(X11) platform would be a good workaround until the proper fix. But it would be better if a _Qt_ engineer could comment this bug what is their plan with QtWebKit on Windows. Are you interested in making it buildable again? 892880 7 ossy 2013-05-23 07:48:50 -0700 Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.h: ... #if PLUGIN_ARCHITECTURE(X11) static bool scanPlugin(const String& pluginPath); #endif ... So it seems you only need to add similar #if guard. I bet in this case plugins won't work at all ... but at least WebKit2 will be buildable. :) 892889 8 jturcotte 2013-05-23 08:19:11 -0700 (In reply to comment #6) > But it would be better if a _Qt_ engineer could comment this bug what is their > plan with QtWebKit on Windows. Are you interested in making it buildable again? There is no plan for 5.2 to implement the missing pieces to make WK2 plugins work on Windows, we should at least make sure that it doesn't crash before we release. Hopefully we can keep the rest working until then without too much hassle. Ping me on IRC if you find out that this needs a bit more plumbing. 892893 9 kbalazs 2013-05-23 08:20:33 -0700 (In reply to comment #7) > Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.h: > ... > #if PLUGIN_ARCHITECTURE(X11) > static bool scanPlugin(const String& pluginPath); > #endif > ... > > So it seems you only need to add similar #if guard. I bet in this case > plugins won't work at all ... but at least WebKit2 will be buildable. :) The code we have for plugins is only for X11. AFAIK Qt-WK2 has no plugin support on Windows currently, and there is not even a native Windows implementation for WebKit2 that can be simply reused. Fixing the build is a matter of adding guards for these files (rather in the files than in the build system but it's your choice). I believe IRC is a more efficient channel to resolve such not too complex problems :) 892931 10 andersca 2013-05-23 10:04:53 -0700 Maybe Qt/WebKit2 on Windows can just disable netscape plug-ins altogether? 893039 11 kbalazs 2013-05-23 14:02:07 -0700 (In reply to comment #10) > Maybe Qt/WebKit2 on Windows can just disable netscape plug-ins altogether? Indeed. 894932 12 zarvai 2013-05-29 06:49:01 -0700 I turned off WebKit2 on Qt Win bot until we figure out the right solution for the issues. 894934 13 203198 zarvai 2013-05-29 07:04:23 -0700 Created attachment 203198 trying some change With disabled Netscape Plugin Api an #if turns to true in WebCore/plugins/PluginDatabase.cpp that probably should be false on Qt Win. After changing it some methods are turning to unresolved external symbol, so I added some dummy function to try a build. Maybe this is not the right way, 'cause I got errors. WebKit1.lib(qwebplugindatabase.obj) : error LNK2019: unresolved external symbol "public: static class WTF::Vector<class WTF::String,0,class WTF::CrashOnOverflow> __cdecl WebCore::PluginDatabase::defaultPluginDirectories(void)" (?defaultPluginDirectories@PluginDatabase@WebCore@@SA?AV?$Vector@VString@WTF@@$0A@VCrashOnOverflow@2@@WTF@@XZ) referenced in function "public: static class QStringList __cdecl QWebPluginDatabase::defaultSearchPaths(void)" (?defaultSearchPaths@QWebPluginDatabase@@SA?AVQStringList@@XZ) WebCore.lib(PluginDatabase.obj) : error LNK2001: unresolved external symbol "public: static class WTF::Vector<class WTF::String,0,class WTF::CrashOnOverflow> __cdecl WebCore::PluginDatabase::defaultPluginDirectories(void)" (?defaultPluginDirectories@PluginDatabase@WebCore@@SA?AV?$Vector@VString@WTF@@$0A@VCrashOnOverflow@2@@WTF@@XZ) WebCore.lib(PluginDatabase.obj) : error LNK2019: unresolved external symbol "public: unsigned int __thiscall WebCore::PluginPackage::hash(void)const " (?hash@PluginPackage@WebCore@@QBEIXZ) referenced in function "public: static unsigned int __cdecl WebCore::PluginPackageHash::hash(class WTF::RefPtr<class WebCore::PluginPackage> const &)" (?hash@PluginPackageHash@WebCore@@SAIABV?$RefPtr@VPluginPackage@WebCore@@@WTF@@@Z) WebCore.lib(PluginDatabase.obj) : error LNK2019: unresolved external symbol "public: static bool __cdecl WebCore::PluginPackage::equal(class WebCore::PluginPackage const &,class WebCore::PluginPackage const &)" (?equal@PluginPackage@WebCore@@SA_NABV12@0@Z) referenced in function "public: static bool __cdecl WebCore::PluginPackageHash::equal(class WTF::RefPtr<class WebCore::PluginPackage> const &,class WTF::RefPtr<class WebCore::PluginPackage> const &)" (?equal@PluginPackageHash@WebCore@@SA_NABV?$RefPtr@VPluginPackage@WebCore@@@WTF@@0@Z) WebCore.lib(PluginDatabase.obj) : error LNK2019: unresolved external symbol "private: void __thiscall WebCore::PluginDatabase::getPluginPathsInDirectories(class WTF::HashSet<class WTF::String,struct WTF::StringHash,struct WTF::HashTraits<class WTF::String> > &)const " (?getPluginPathsInDirectories@PluginDatabase@WebCore@@ABEXAAV?$HashSet@VString@WTF@@UStringHash@2@U?$HashTraits@VString@WTF@@@2@@WTF@@@Z) referenced in function "public: bool __thiscall WebCore::PluginDatabase::refresh(void)" (?refresh@PluginDatabase@WebCore@@QAE_NXZ) WebCore.lib(PluginPackage.obj) : error LNK2019: unresolved external symbol "public: static bool __cdecl WebCore::PluginDatabase::isPreferredPluginDirectory(class WTF::String const &)" (?isPreferredPluginDirectory@PluginDatabase@WebCore@@SA_NABVString@WTF@@@Z) referenced in function "public: int __thiscall WebCore::PluginPackage::compare(class WebCore::PluginPackage const &)const " (?compare@PluginPackage@WebCore@@QBEHABV12@@Z) WTF.lib(OSRandomSource.obj) : error LNK2019: unresolved external symbol __imp__CryptReleaseContext@8 referenced in function "void __cdecl WTF::cryptographicallyRandomValuesFromOS(unsigned char *,unsigned int)" (?cryptographicallyRandomValuesFromOS@WTF@@YAXPAEI@Z) WTF.lib(OSRandomSource.obj) : error LNK2019: unresolved external symbol __imp__CryptGenRandom@12 referenced in function "void __cdecl WTF::cryptographicallyRandomValuesFromOS(unsigned char *,unsigned int)" (?cryptographicallyRandomValuesFromOS@WTF@@YAXPAEI@Z) WTF.lib(OSRandomSource.obj) : error LNK2019: unresolved external symbol __imp__CryptAcquireContextW@20 referenced in function "void __cdecl WTF::cryptographicallyRandomValuesFromOS(unsigned char *,unsigned int)" (?cryptographicallyRandomValuesFromOS@WTF@@YAXPAEI@Z) ..\lib\Qt5WebKit.dll : fatal error LNK1120: 8 unresolved externals 202713 2013-05-23 07:31:41 -0700 2013-05-29 07:04:23 -0700 plugin_process pluginprocess.patch text/plain 1267 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5l Y3Rpb24uY3BwIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVj dGlvbi5jcHAKaW5kZXggMDQyZTUzYi4uN2I4NjFlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5jcHAKQEAgLTM5LDcgKzM5 LDE0IEBACiAjaW5jbHVkZSAiUGx1Z2luUHJveHlNZXNzYWdlcy5oIgogI2luY2x1ZGUgIldlYlBy b2Nlc3NDb25uZWN0aW9uTWVzc2FnZXMuaCIKICNpbmNsdWRlIDxXZWJDb3JlL1J1bkxvb3AuaD4K KworI2lmIEhBVkVfVU5JU1REX0gKICNpbmNsdWRlIDx1bmlzdGQuaD4KKyNlbHNlIC8qIFdpbmRv d3Mgd2l0aCBNU1ZDICovCisjaW5jbHVkZSA8aW8uaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4KKyNk ZWZpbmUgc2xlZXAobikgX3NsZWVwICgobikgKiAxMDAwKQorI2VuZGlmCiAKIHVzaW5nIG5hbWVz cGFjZSBXZWJDb3JlOwogCmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVz L2ZlYXR1cmVzLnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJm CmluZGV4IDlhMWRiMmQuLjhiYzU3YTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3Mv ZmVhdHVyZXMvZmVhdHVyZXMucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMv ZmVhdHVyZXMucHJmCkBAIC03NSw5ICs3NSwxMCBAQCBkZWZpbmVUZXN0KGRldGVjdEZlYXR1cmVz KSB7CiAgICAgICAgICAgICBwbHVnaW5fcHJvY2VzcwogCiAgICAgfSBlbHNlOiB1bml4fHdpbjMy LSo6IWVtYmVkZGVkOiF3aW5jZSogewotICAgICAgICBXRUJLSVRfQ09ORklHICs9IG5ldHNjYXBl X3BsdWdpbl9hcGkKKyAgICAgICAgV0VCS0lUX0NPTkZJRyArPSBuZXRzY2FwZV9wbHVnaW5fYXBp IFwKKwkJICAgIHBsdWdpbl9wcm9jZXNzCiAgICAgICAgICMgV2ViS2l0MgotICAgICAgICBXRUJL SVRfQ09ORklHICs9IHBsdWdpbl9hcmNoaXRlY3R1cmVfdW5zdXBwb3J0ZWQKKyAgICAgICAgI1dF QktJVF9DT05GSUcgKz0gcGx1Z2luX2FyY2hpdGVjdHVyZV91bnN1cHBvcnRlZAogICAgIH0gZWxz ZSB7CiAgICAgICAgIFdFQktJVF9DT05GSUcgKz0gcGx1Z2luX2FyY2hpdGVjdHVyZV91bnN1cHBv cnRlZAogICAgIH0KCg== 203198 2013-05-29 07:04:23 -0700 2013-05-29 07:04:23 -0700 trying some change winwk2.patch text/plain 1925 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YWJhc2UuY3BwIGIv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHAKaW5kZXggMmQxN2FiYy4u NjliMTQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFz ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHAKQEAg LTM4Myw3ICszODMsOCBAQCBib29sIFBsdWdpbkRhdGFiYXNlOjphZGREaXNhYmxlZFBsdWdpbkZp bGUoY29uc3QgU3RyaW5nJiBmaWxlTmFtZSkKICAgICByZXR1cm4gbV9kaXNhYmxlZFBsdWdpbkZp bGVzLmFkZChmaWxlTmFtZSkuaXNOZXdFbnRyeTsKIH0KIAotI2lmICghT1MoV0lOQ0UpKSAmJiAo IU9TKFdJTkRPV1MpIHx8ICFFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkpCisKKyNpZiAoIU9T KFdJTkNFKSkgJiYgKCFPUyhXSU5ET1dTKSB8fCAoIUVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJ KSAmJiAhUExBVEZPUk0oUVQpKSkKIC8vIEZvciBTYWZhcmkvV2luIHRoZSBmb2xsb3dpbmcgdGhy ZWUgbWV0aG9kcyBhcmUgaW1wbGVtZW50ZWQKIC8vIGluIFBsdWdpbkRhdGFiYXNlV2luLmNwcCwg YnV0IGlmIHdlIGNhbiB1c2UgV2ViQ29yZSBjb25zdHJ1Y3RzCiAvLyBmb3IgdGhlIGxvZ2ljIHdl IHNob3VsZCBwZXJoYXBzIG1vdmUgaXQgaGVyZSB1bmRlciBYUF9XSU4/CkBAIC00NDIsNiArNDQz LDI1IEBAIFZlY3RvcjxTdHJpbmc+IFBsdWdpbkRhdGFiYXNlOjpkZWZhdWx0UGx1Z2luRGlyZWN0 b3JpZXMoKQogICAgIHBhdGhzLmFwcGVuZCh1c2VyUGx1Z2luUGF0aCk7CiAjZW5kaWYKIAorI2lm IFBMQVRGT1JNKFFUKSAmJiBPUyhXSU5ET1dTKSAmJiAoIUVOQUJMRShORVRTQ0FQRV9QTFVHSU5f QVBJKSkKK1ZlY3RvcjxTdHJpbmc+IFBsdWdpbkRhdGFiYXNlOjpkZWZhdWx0UGx1Z2luRGlyZWN0 b3JpZXMoKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIFZlY3RvcjxTdHJp bmc+KCk7Cit9CisKK3ZvaWQgUGx1Z2luRGF0YWJhc2U6OmdldFBsdWdpblBhdGhzSW5EaXJlY3Rv cmllcyhIYXNoU2V0PFN0cmluZz4mIHBhdGhzKSBjb25zdAoreworICAgIG5vdEltcGxlbWVudGVk KCk7Cit9CisKK2Jvb2wgUGx1Z2luRGF0YWJhc2U6OmlzUHJlZmVycmVkUGx1Z2luRGlyZWN0b3J5 KGNvbnN0IFN0cmluZyYgZGlyZWN0b3J5KQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAg cmV0dXJuIGZhbHNlOworfQorCisjZW5kaWYKICAgICAvLyBBZGQgcGF0aHMgc3BlY2lmaWMgdG8g ZWFjaCBwb3J0CiAjaWYgUExBVEZPUk0oUVQpCiAgICAgVmVjdG9yPFN0cmluZz4gcXRQYXRoczsK ZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmIGIv VG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKaW5kZXggOWExZGIyZC4u MGIzZDU0NSAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJl cy5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKQEAg LTc0LDcgKzc0LDcgQEAgZGVmaW5lVGVzdChkZXRlY3RGZWF0dXJlcykgewogICAgICAgICAgICAg cGx1Z2luX2FyY2hpdGVjdHVyZV94MTEgXAogICAgICAgICAgICAgcGx1Z2luX3Byb2Nlc3MKIAot ICAgIH0gZWxzZTogdW5peHx3aW4zMi0qOiFlbWJlZGRlZDohd2luY2UqIHsKKyAgICB9IGVsc2U6 IHVuaXg6IXdpbjMyLSo6IWVtYmVkZGVkOiF3aW5jZSogewogICAgICAgICBXRUJLSVRfQ09ORklH ICs9IG5ldHNjYXBlX3BsdWdpbl9hcGkKICAgICAgICAgIyBXZWJLaXQyCiAgICAgICAgIFdFQktJ VF9DT05GSUcgKz0gcGx1Z2luX2FyY2hpdGVjdHVyZV91bnN1cHBvcnRlZAo=