116602 2013-05-22 02:43:04 -0700 [BlackBerry] Fix subframe target added to new requests 2013-05-27 11:03:50 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 1 cgarcia webkit-unassigned commit-queue rwlbuis oldest_to_newest 892199 0 cgarcia 2013-05-22 02:43:04 -0700 In some cases we might be adding TargetIsMainFrame to a subframe request causing an isMainFrame assert. 892200 1 202512 cgarcia 2013-05-22 02:45:49 -0700 Created attachment 202512 Patch 894085 2 202512 rwlbuis 2013-05-27 10:42:36 -0700 Comment on attachment 202512 Patch Looks good. 894091 3 202512 commit-queue 2013-05-27 11:03:47 -0700 Comment on attachment 202512 Patch Clearing flags on attachment: 202512 Committed r150766: <http://trac.webkit.org/changeset/150766> 894092 4 commit-queue 2013-05-27 11:03:50 -0700 All reviewed patches have been landed. Closing bug. 202512 2013-05-22 02:45:49 -0700 2013-05-27 11:03:45 -0700 Patch bb-target-frame.diff text/plain 2131 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDliYjEzN2UuLjk0OGM5MWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTIyICBF bGkgRmlkbGVyICA8ZWZpZGxlckByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGaXgg c3ViZnJhbWUgdGFyZ2V0IGFkZGVkIHRvIG5ldyByZXF1ZXN0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NjAyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gc29tZSBjYXNlcyB3ZSBtaWdodCBiZSBh ZGRpbmcgVGFyZ2V0SXNNYWluRnJhbWUgdG8gYSBzdWJmcmFtZQorICAgICAgICByZXF1ZXN0IGNh dXNpbmcgYW4gaXNNYWluRnJhbWUgYXNzZXJ0LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQv RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QpOgorICAgICAg ICBDaGVjayB3ZSBhcmUgYWN0dWFsbHkgbG9hZGluZyB0aGUgbWFpbiBmcmFtZSBiZWZvcmUgc2V0 dGluZworICAgICAgICBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzTWFpbkZyYW1lIHRhcmdldC4K KwogMjAxMy0wNS0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0JsYWNrQmVycnldIERvIG5vdCB1c2Ugc2tpYSBpbiBGcmFtZUxvYWRlckNs aWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGlkUmVjZWl2ZUljb24oKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCAwOTBkNWEwLi4yMjVlZDU2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtOTcyLDggKzk3 Miw4IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNwYXRjaFdpbGxTZW5k UmVxdWVzdChEb2N1bWVudExvYWRlciogZG9jTG9hCiAgICAgYm9vbCBpc01haW5SZXNvdXJjZUxv YWQgPSBkb2NMb2FkZXIgJiYgZG9jTG9hZGVyID09IGRvY0xvYWRlci0+ZnJhbWVMb2FkZXIoKS0+ cHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcigpOwogCiAgICAgLy8gVGFyZ2V0VHlwZSBmb3Igc3Vi cmVzb3VyY2UgbG9hZHMgc2hvdWxkIGhhdmUgYmVlbiBzZXQgaW4gQ2FjaGVkUmVzb3VyY2U6Omxv YWQoKS4KLSAgICBpZiAoaXNNYWluUmVzb3VyY2VMb2FkICYmIHJlcXVlc3QudGFyZ2V0VHlwZSgp ID09IFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNVbnNwZWNpZmllZCkKLSAgICAgICAgcmVxdWVz dC5zZXRUYXJnZXRUeXBlKGlzTWFpbkZyYW1lKCkgPyBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElz TWFpbkZyYW1lIDogUmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJc1N1YmZyYW1lKTsKKyAgICBpZiAo aXNNYWluUmVzb3VyY2VMb2FkKQorICAgICAgICByZXF1ZXN0LnNldFRhcmdldFR5cGUoZG9jTG9h ZGVyLT5mcmFtZUxvYWRlcigpLT5pc0xvYWRpbmdNYWluRnJhbWUoKSA/IFJlc291cmNlUmVxdWVz dDo6VGFyZ2V0SXNNYWluRnJhbWUgOiBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzU3ViZnJhbWUp OwogCiAgICAgLy8gQW55IHByb2Nlc3Npbmcgd2hpY2ggaXMgZG9uZSBmb3IgYWxsIGxvYWRzIChi b3RoIG1haW4gYW5kIHN1YnJlc291cmNlKSBzaG91bGQgZ28gaGVyZS4KICAgICBOZXR3b3JrUmVx dWVzdCBwbGF0Zm9ybVJlcXVlc3Q7Cg==