116598 2013-05-22 02:27:54 -0700 [BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData() 2013-05-27 08:37:02 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 1 cgarcia webkit-unassigned commit-queue rwlbuis oldest_to_newest 892186 0 cgarcia 2013-05-22 02:27:54 -0700 It's no longer needed since the encoder now checks the override encoding. 892188 1 202509 cgarcia 2013-05-22 02:30:24 -0700 Created attachment 202509 Patch 894043 2 202509 rwlbuis 2013-05-27 08:30:46 -0700 Comment on attachment 202509 Patch Looks good. 894047 3 202509 commit-queue 2013-05-27 08:37:00 -0700 Comment on attachment 202509 Patch Clearing flags on attachment: 202509 Committed r150757: <http://trac.webkit.org/changeset/150757> 894048 4 commit-queue 2013-05-27 08:37:02 -0700 All reviewed patches have been landed. Closing bug. 202509 2013-05-22 02:30:24 -0700 2013-05-27 08:36:59 -0700 Patch bb-text-encoding.diff text/plain 3858 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDliYjEzN2UuLjliYWE5MGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTIyICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gUmVtb3ZlIGVuY29kaW5nIHBhcmFtZXRlciBmcm9tIEZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeTo6cmVjZWl2ZWREYXRhKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNjU5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEl0J3Mgbm8gbG9uZ2VyIG5lZWRlZCBzaW5jZSB0aGUgZW5jb2Rl ciBub3cgY2hlY2tzIHRoZSBvdmVycmlkZSBlbmNvZGluZy4KKworICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNvbW1pdHRlZExvYWQpOiBDYWxsCisgICAg ICAgIHJlY2VpdmVkRGF0YSgpIHBhc3NpbmcgdGhlIERvY3VtZW50TG9hZGVyIGluc3RlYWQgb2Yg dGhlIHRleHQKKyAgICAgICAgZW5jb2RpbmcuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRl ckNsaWVudEJsYWNrQmVycnk6OnJlY2VpdmVkRGF0YSk6IENhbGwKKyAgICAgICAgRG9jdW1lbnRM b2FkZXI6OmNvbW1pdERhdGEoKSBkaXJlY3RseS4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9G cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuaDoKKyAgICAgICAgKEZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeSk6CisKIDIwMTMtMDUtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3QgdXNlIHNraWEgaW4g RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNwYXRjaERpZFJlY2VpdmVJY29uKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggMDkwZDVhMC4u NTUxN2QyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAK QEAgLTI4OSwxMCArMjg5LDggQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNv bW1pdHRlZExvYWQoRG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgY29uc3QgY2gKICAgICAvLyBUaGVy ZWFmdGVyLCBhbGwgZGF0YSB3aWxsIGJlIHJlLWRpcmVjdGVkIHRvIHRoZSBQbHVnaW5WaWV3OyBp LmUuLCBubyBhZGRpdGlvbmFsIGRhdGEgd2lsbCBnbwogICAgIC8vIHRvIHJlY2VpdmVkRGF0YS4K IAotICAgIGlmICghbV9wbHVnaW5WaWV3KSB7Ci0gICAgICAgIGNvbnN0IFN0cmluZyYgdGV4dEVu Y29kaW5nID0gbG9hZGVyLT5yZXNwb25zZSgpLnRleHRFbmNvZGluZ05hbWUoKTsKLSAgICAgICAg cmVjZWl2ZWREYXRhKGRhdGEsIGxlbmd0aCwgdGV4dEVuY29kaW5nKTsKLSAgICB9CisgICAgaWYg KCFtX3BsdWdpblZpZXcpCisgICAgICAgIHJlY2VpdmVkRGF0YShsb2FkZXIsIGRhdGEsIGxlbmd0 aCk7CiAKICAgICBpZiAobV9wbHVnaW5WaWV3KSB7CiAgICAgICAgIGlmICghbV9oYXNTZW50UmVz cG9uc2VUb1BsdWdpbikgewpAQCAtMzQ3LDcgKzM0NSw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGll bnRCbGFja0JlcnJ5OjpyZWRpcmVjdERhdGFUb1BsdWdpbihXaWRnZXQqIHBsdWdpbldpZGdldCkK ICAgICAgICAgbV9oYXNTZW50UmVzcG9uc2VUb1BsdWdpbiA9IGZhbHNlOwogfQogCi12b2lkIEZy YW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6cmVjZWl2ZWREYXRhKGNvbnN0IGNoYXIqIGRhdGEs IGludCBsZW5ndGgsIGNvbnN0IFN0cmluZyYgdGV4dEVuY29kaW5nKQordm9pZCBGcmFtZUxvYWRl ckNsaWVudEJsYWNrQmVycnk6OnJlY2VpdmVkRGF0YShEb2N1bWVudExvYWRlciogbG9hZGVyLCBj b25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQogewogICAgIGlmICghbV9mcmFtZSkKICAgICAg ICAgcmV0dXJuOwpAQCAtMzU5LDEzICszNTcsOCBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeTo6cmVjZWl2ZWREYXRhKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgsIGNvbgog ICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgLy8gU2V0IHRoZSBlbmNvZGluZy4gVGhpcyBv bmx5IG5lZWRzIHRvIGJlIGRvbmUgb25jZSwgYnV0IGl0J3MgaGFybWxlc3MgdG8gZG8gaXQgYWdh aW4gbGF0ZXIuCi0gICAgU3RyaW5nIGVuY29kaW5nID0gbV9mcmFtZS0+bG9hZGVyKCktPmRvY3Vt ZW50TG9hZGVyKCktPm92ZXJyaWRlRW5jb2RpbmcoKTsKLSAgICBib29sIHVzZXJDaG9zZW4gPSAh ZW5jb2RpbmcuaXNOdWxsKCk7Ci0gICAgaWYgKGVuY29kaW5nLmlzTnVsbCgpKQotICAgICAgICBl bmNvZGluZyA9IHRleHRFbmNvZGluZzsKLSAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRM b2FkZXIoKS0+d3JpdGVyKCktPnNldEVuY29kaW5nKGVuY29kaW5nLCB1c2VyQ2hvc2VuKTsKLSAg ICBtX2ZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+d3JpdGVyKCktPmFkZERhdGEo ZGF0YSwgbGVuZ3RoKTsKKyAgICAvLyBUaGUgZW5jb2RlciBub3cgY2hlY2tzIHRoZSBvdmVycmlk ZSBlbmNvZGluZyBhbmQgc2V0cyBldmVyeXRoaW5nIG9uIG91ciBiZWhhbGYuCisgICAgbG9hZGVy LT5jb21taXREYXRhKGRhdGEsIGxlbmd0aCk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRC bGFja0JlcnJ5OjpmaW5pc2hlZExvYWRpbmcoRG9jdW1lbnRMb2FkZXIqKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oCmluZGV4IGUyNzdlNjcuLjNlYWFhYjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudEJsYWNrQmVycnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmgKQEAgLTE4MSw3ICsxODEsNyBA QCBwdWJsaWM6CiAgICAgdm9pZCBzdXBwcmVzc0NoaWxkRnJhbWVDcmVhdGlvbigpIHsgbV9jaGls ZEZyYW1lQ3JlYXRpb25TdXBwcmVzc2VkID0gdHJ1ZTsgfQogCiBwcml2YXRlOgotICAgIHZvaWQg cmVjZWl2ZWREYXRhKGNvbnN0IGNoYXIqLCBpbnQsIGNvbnN0IFN0cmluZyYpOworICAgIHZvaWQg cmVjZWl2ZWREYXRhKERvY3VtZW50TG9hZGVyKiwgY29uc3QgY2hhciosIGludCwgY29uc3QgU3Ry aW5nJik7CiAgICAgdm9pZCBkaWRGaW5pc2hPckZhaWxMb2FkaW5nKGNvbnN0IFJlc291cmNlRXJy b3ImKTsKICAgICBib29sIGlzTWFpbkZyYW1lKCkgY29uc3Q7CiAK