116597 2013-05-22 02:07:56 -0700 [Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode 2013-05-30 07:28:14 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam allan.jensen andersca cmarcelo commit-queue jamesr jturcotte kadam luiz ossy tonikitoo zarvai zeno oldest_to_newest 892179 0 noam 2013-05-22 02:07:56 -0700 Scrolling now doesn't work at all in MiniBrowser --desktop 893720 1 202908 noam 2013-05-26 01:54:36 -0700 Created attachment 202908 Patch 893721 2 noam 2013-05-26 01:56:55 -0700 this fixes the regression, however since the Qt-WK2-desktop mode is a configuration that is not covered at all by tests, I can't guarantee regressions like this won't come back. 894307 3 203043 noam 2013-05-28 05:24:33 -0700 Created attachment 203043 Patch 894311 4 203043 allan.jensen 2013-05-28 05:38:15 -0700 Comment on attachment 203043 Patch LGTM 894326 5 203043 commit-queue 2013-05-28 06:07:24 -0700 Comment on attachment 203043 Patch Clearing flags on attachment: 203043 Committed r150798: <http://trac.webkit.org/changeset/150798> 894327 6 commit-queue 2013-05-28 06:07:27 -0700 All reviewed patches have been landed. Closing bug. 894363 7 ossy 2013-05-28 07:55:17 -0700 FYI: It broke ~500 pixel tests on the pixel bot. 894364 8 zarvai 2013-05-28 08:01:24 -0700 (In reply to comment #7) > FYI: It broke ~500 pixel tests on the pixel bot. The scrollbar is missing on actual results http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/r150800%20%284395%29/results.html 894974 9 zarvai 2013-05-29 09:06:35 -0700 (In reply to comment #8) > (In reply to comment #7) > > FYI: It broke ~500 pixel tests on the pixel bot. > > The scrollbar is missing on actual results > http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/r150800%20%284395%29/results.html No scrollbar appears in "MiniBrowser --desktop". But there is also no scrollbar with r149291. If the new results without scrollbars are acceptable I will rebaseline them. Is it ok? 895531 10 zarvai 2013-05-30 07:28:14 -0700 PNG rebaseline for QT WK2 landed in http://trac.webkit.org/changeset/150961. 202908 2013-05-26 01:54:36 -0700 2013-05-28 05:24:28 -0700 Patch bug-116597-20130526105311.patch text/plain 4478 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDY1M2E1MDMzMDZkZDlk ZTMxNjcwOWMxNjg3ZjEwODRmMGYxOGE4Mi4uMmU5MTA5MTAzNDY3YjlmZGRjZjM2ZDNiZWI3Njlk MWY0NjgxY2U0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA1LTI2ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04o cjE0OTI5Mik6IGJyb2tlIHNjcm9sbGluZyBpbiBRdCBXSzIgZGVza3RvcCBtb2RlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY1OTcKKworICAgICAg ICBRdCBXZWJLaXQyIGRlc2t0b3AgbW9kZSB1c2VzIHRoZSB0cmFkaXRpb25hbCBzY3JvbGxpbmcg Zm9yIHRoZSBGcmFtZVZpZXcuCisgICAgICAgIHIxNDkyOTIgYnJva2UgdGhpcyBiZWhhdmlvciBz aW5jZSBub3cgdGhlIEZyYW1lVmlldyB1c2VzIGNvbXBvc2l0aW5nLCB3aGljaAorICAgICAgICBo YXMgbWFkZSBTY3JvbGxpbmdDb29yZGluYXRvcjo6Y29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFt ZVZpZXcgcmV0dXJuIHRydWUsCisgICAgICAgIG1ha2luZyBpdCBzbyB0aGF0IFdlYkNvcmUgZXhw ZWN0cyB0aGUgc2Nyb2xsaW5nIGNvb3JkaW5hdG9yIHRvIGhhbmRsZSBzY3JvbGxpbmcsCisgICAg ICAgIHdoaWNoIGl0IGRvZXNuJ3QgZm9yIHRoZSBGcmFtZVZpZXcgaW4gY29vcmRpbmF0ZWQgZ3Jh cGhpY3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLgorICAgICAgICBUaGVyZSBhcmUgbm8gdGVzdGluZyBmYWNpbGl0aWVzIHRv IHRlc3QgUXQgV2ViS2l0MiBpbiBkZXNrdG9wIG1vZGUuIElmIHRob3NlCisgICAgICAgIGFyZSBh ZGRlZCBpbiBhIHNlcGFyYXRlIHBhdGNoLCB0ZXN0aW5nIGZvciB0aGlzIGNhbiBiZSBhZGRlZCBh cyB3ZWxsLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3Iu aDoKKyAgICAgICAgICAgIE1hZGUgY29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFtZVZpZXcgdmly dHVhbC4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL2Nvb3JkaW5hdGVkZ3JhcGhpY3MvU2Ny b2xsaW5nQ29vcmRpbmF0b3JDb29yZGluYXRlZEdyYXBoaWNzLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yQ29vcmRpbmF0ZWRHcmFwaGljczo6Y29vcmRpbmF0ZXNT Y3JvbGxpbmdGb3JGcmFtZVZpZXcpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGFn ZS9zY3JvbGxpbmcvY29vcmRpbmF0ZWRncmFwaGljcy9TY3JvbGxpbmdDb29yZGluYXRvckNvb3Jk aW5hdGVkR3JhcGhpY3MuaDoKKyAgICAgICAgICAgIFJldHVybiBmYWxzZSB3aGVuIHVzZUZpeGVk TGF5b3V0IGlzIGZhbHNlICgiZGVza3RvcCBtb2RlIikuCisKIDIwMTMtMDUtMjQgIE5vYW0gUm9z ZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIERpcmVjdCBwYXR0 ZXJuIGNvbXBvc2l0aW5nIGJyZWFrcyB3aGVuIG5vLXJlcGVhdCBpcyBzZXQgb24gYSBsYXJnZSBs YXllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n Q29vcmRpbmF0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nv b3JkaW5hdG9yLmgKaW5kZXggYjM5YWVlNDNmZmRjOWZmYjUyODYyNWYyNWM1NTZhZmIzYzcwNGE5 OS4uZWI3MjdhMDUzNTkzOGVhZDY3YTc2YmQ4MjRjZDFlZGE4MDQ4NTFiNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oCkBA IC04MSw3ICs4MSw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAgLy8gUmV0dXJuIHdoZXRoZXIg dGhpcyBzY3JvbGxpbmcgY29vcmRpbmF0b3IgaGFuZGxlcyBzY3JvbGxpbmcgZm9yIHRoZSBnaXZl biBmcmFtZSB2aWV3LgotICAgIGJvb2wgY29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFtZVZpZXco RnJhbWVWaWV3KikgY29uc3Q7CisgICAgdmlydHVhbCBib29sIGNvb3JkaW5hdGVzU2Nyb2xsaW5n Rm9yRnJhbWVWaWV3KEZyYW1lVmlldyopIGNvbnN0OwogCiAgICAgLy8gU2hvdWxkIGJlIGNhbGxl ZCB3aGVuZXZlciB0aGUgZ2l2ZW4gZnJhbWUgdmlldyBoYXMgYmVlbiBsYWlkIG91dC4KICAgICB2 aXJ0dWFsIHZvaWQgZnJhbWVWaWV3TGF5b3V0VXBkYXRlZChGcmFtZVZpZXcqKSB7IH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL2Nvb3JkaW5hdGVkZ3JhcGhpY3Mv U2Nyb2xsaW5nQ29vcmRpbmF0b3JDb29yZGluYXRlZEdyYXBoaWNzLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL2Nvb3JkaW5hdGVkZ3JhcGhpY3MvU2Nyb2xsaW5nQ29vcmRpbmF0 b3JDb29yZGluYXRlZEdyYXBoaWNzLmNwcAppbmRleCA0MGIzNDkyZGFiZmY2OGU0ZjEyNjMxNzhm MTIyOWE5OTVhNWUyMmQ3Li42OTMwN2M2OTc2MzEzZWY0MzNjYzUyYTk3YTFkMzU2NjhjM2RmZjll IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9jb29yZGluYXRlZGdy YXBoaWNzL1Njcm9sbGluZ0Nvb3JkaW5hdG9yQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvY29vcmRpbmF0ZWRncmFwaGljcy9TY3JvbGxp bmdDb29yZGluYXRvckNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwCkBAIC0xMDMsNiArMTAzLDE0IEBA IHZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3JDb29yZGluYXRlZEdyYXBoaWNzOjpzY3JvbGxhYmxl QXJlYVNjcm9sbExheWVyRGlkQ2hhbmdlCiAgICAgbGF5ZXItPnNldFNjcm9sbGFibGVBcmVhKHNj cm9sbGFibGVBcmVhKTsKIH0KIAorYm9vbCBTY3JvbGxpbmdDb29yZGluYXRvckNvb3JkaW5hdGVk R3JhcGhpY3M6OmNvb3JkaW5hdGVzU2Nyb2xsaW5nRm9yRnJhbWVWaWV3KEZyYW1lVmlldyogdmll dykgY29uc3QKK3sKKyAgICBpZiAoIXZpZXctPnVzZUZpeGVkTGF5b3V0KCkpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKworICAgIHJldHVybiBTY3JvbGxpbmdDb29yZGluYXRvcjo6Y29vcmRpbmF0 ZXNTY3JvbGxpbmdGb3JGcmFtZVZpZXcodmlldyk7Cit9CisKIHZvaWQgU2Nyb2xsaW5nQ29vcmRp bmF0b3JDb29yZGluYXRlZEdyYXBoaWNzOjp3aWxsRGVzdHJveVNjcm9sbGFibGVBcmVhKFNjcm9s bGFibGVBcmVhKiBzY3JvbGxhYmxlQXJlYSkKIHsKICAgICBDb29yZGluYXRlZEdyYXBoaWNzTGF5 ZXIqIGxheWVyID0gdG9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIoc2Nyb2xsTGF5ZXJGb3JTY3Jv bGxhYmxlQXJlYShzY3JvbGxhYmxlQXJlYSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9zY3JvbGxpbmcvY29vcmRpbmF0ZWRncmFwaGljcy9TY3JvbGxpbmdDb29yZGluYXRvckNv b3JkaW5hdGVkR3JhcGhpY3MuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL2Nvb3Jk aW5hdGVkZ3JhcGhpY3MvU2Nyb2xsaW5nQ29vcmRpbmF0b3JDb29yZGluYXRlZEdyYXBoaWNzLmgK aW5kZXggNmU4NGJjMGJjNDhhNTJiOTQ1MWNmNGI3NjUyMGJmMzU1ODhmNjEzNS4uYzY2MDQ5Nzk5 YzFkMTdkNjQ2NjQzMjYwMDVhMjA5ZjkyNzc5Y2I4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvY29vcmRpbmF0ZWRncmFwaGljcy9TY3JvbGxpbmdDb29yZGluYXRv ckNvb3JkaW5hdGVkR3JhcGhpY3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9jb29yZGluYXRlZGdyYXBoaWNzL1Njcm9sbGluZ0Nvb3JkaW5hdG9yQ29vcmRpbmF0ZWRHcmFw aGljcy5oCkBAIC00Niw2ICs0Niw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJT dGF0ZVRyZWUoKSBPVkVSUklERTsKIAogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVWaWV3cG9ydENv bnN0cmFpbmVkTm9kZShTY3JvbGxpbmdOb2RlSUQsIGNvbnN0IFZpZXdwb3J0Q29uc3RyYWludHMm LCBHcmFwaGljc0xheWVyKikgT1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIGNvb3JkaW5hdGVz U2Nyb2xsaW5nRm9yRnJhbWVWaWV3KEZyYW1lVmlldyopIGNvbnN0IE9WRVJSSURFOwogCiAgICAg dmlydHVhbCB2b2lkIHNjcm9sbGFibGVBcmVhU2Nyb2xsTGF5ZXJEaWRDaGFuZ2UoU2Nyb2xsYWJs ZUFyZWEqKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbERlc3Ryb3lTY3JvbGxhYmxl QXJlYShTY3JvbGxhYmxlQXJlYSopIE9WRVJSSURFOwo= 203043 2013-05-28 05:24:33 -0700 2013-05-28 06:07:24 -0700 Patch bug-116597-20130528142312.patch text/plain 1838 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWRmZTViNzg2MWRkYTc4 Yzg4NWE2Zjc1MzkzODkxMTFmNjJmOTQ3ZC4uNjI2MzdiOWM3ODNhNWZiZTI3N2QwYWZjMDM4ODlm M2I5YjQxOWQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTI4ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04o cjE0OTI5Mik6IGJyb2tlIHNjcm9sbGluZyBpbiBRdCBXSzIgZGVza3RvcCBtb2RlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY1OTcKKworICAgICAg ICBTY3JvbGxpbmdDb29yZGluYXRvckNvb3JkaW5hdGVkR3JhcGhpY3MgaXMgdGFpbG9yZWQgc3Bl Y2lmaWNhbGx5IGZvcgorICAgICAgICBmaXhlZExheW91dCBtb2RlLiBXaGVuIGZpeGVkTGF5b3V0 IGlzIG5vdCBzZXQsIGl0IHNob3VsZCBiZSB0dXJuZWQgb2ZmLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdl YktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpDb29yZGluYXRlZExheWVyVHJlZUhvc3Qp OgorCiAyMDEzLTA1LTI0ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAg ICAgICBUeXBpbmcgaW4gU2FmYXJpJ3MgdW5pZmllZCBmaWVsZCBjYXVzZXMgdW5uZWNlc3Nhcnkg d2ViIGNvbnRlbnQgcmVwYWludHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3Qu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAppbmRleCA1NzIwNDZkNmIwMjQ3MzhlMDgw NTM4MTUxMmVhYjU2OTY5OTU4MmUyLi40MjJhZTVkMDA3MjJkOGY1OTcwNWM5OTgzZTk1ZDViZGU0 MjkwMDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5h dGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTk5LDcgKzk5LDggQEAgQ29vcmRpbmF0ZWRMYXllclRy ZWVIb3N0OjpDb29yZGluYXRlZExheWVyVHJlZUhvc3QoV2ViUGFnZSogd2ViUGFnZSkKICAgICAs IG1fbGFzdEFuaW1hdGlvblNlcnZpY2VUaW1lKDApCiAjZW5kaWYKIHsKLSAgICBtX3dlYlBhZ2Ut PmNvcmVQYWdlKCktPnNldHRpbmdzKCktPnNldFNjcm9sbGluZ0Nvb3JkaW5hdG9yRW5hYmxlZCh0 cnVlKTsKKyAgICBpZiAobV93ZWJQYWdlLT51c2VGaXhlZExheW91dCgpKQorICAgICAgICBtX3dl YlBhZ2UtPmNvcmVQYWdlKCktPnNldHRpbmdzKCktPnNldFNjcm9sbGluZ0Nvb3JkaW5hdG9yRW5h YmxlZCh0cnVlKTsKICAgICBtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPnNldHRpbmdzKCktPnNldEFw cGx5RGV2aWNlU2NhbGVGYWN0b3JJbkNvbXBvc2l0b3IodHJ1ZSk7CiAKICAgICAvLyBDcmVhdGUg YSByb290IGxheWVyLgo=