116595 2013-05-22 00:52:18 -0700 REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails 2013-05-25 10:46:30 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 rniwa webkit-unassigned aestes andersca dino jberlin kling sam oldest_to_newest 892166 0 rniwa 2013-05-22 00:52:18 -0700 WebKit2.DOMWindowExtensionNoCache started failing after this revision: http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29/builds/10020 Note: Google Test filter = WebKit2.DOMWindowExtensionNoCache [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebKit2 [ RUN ] WebKit2.DOMWindowExtensionNoCache LEAK: 29 WebCoreNode LEAK: 5 CachedResource Timeout 892470 1 rniwa 2013-05-22 11:41:29 -0700 Confirmed. It passes on r150490 but times out on r150491. 892658 2 rniwa 2013-05-22 21:24:54 -0700 I've tried to add add a call to WKTerminate but that broke the test. Now we wouldn't get the last 3 messages: Extension states: First page, main frame, standard world - Destroyed First page, main frame, non-standard world - Destroyed First page, subframe, standard world - Destroyed First page, subframe, non-standard world - Destroyed Second page, main frame, standard world - Destroyed Second page, main frame, non-standard world - Destroyed First page, main frame, standard world - Connected First page, main frame, non-standard world - Connected First page, subframe, standard world - Connected First page, subframe, non-standard world - Connected Extension states: First page, main frame, standard world - Destroyed First page, main frame, non-standard world - Destroyed First page, subframe, standard world - Destroyed First page, subframe, non-standard world - Destroyed Second page, main frame, standard world - Destroyed Second page, main frame, non-standard world - Destroyed First page, main frame, standard world - Removed First page, main frame, non-standard world - Removed First page, subframe, standard world - Removed First page, subframe, non-standard world - Removed TestComplete 892659 3 rniwa 2013-05-22 21:26:32 -0700 Committed r150564: <http://trac.webkit.org/changeset/150564> 893386 4 202838 kling 2013-05-24 11:16:48 -0700 Created attachment 202838 Tweak the test for new WKPageClose semantics 893395 5 202838 rniwa 2013-05-24 11:35:49 -0700 Comment on attachment 202838 Tweak the test for new WKPageClose semantics View in context: https://bugs.webkit.org/attachment.cgi?id=202838&action=review > Tools/ChangeLog:10 > + Since WKPageClose() will now disconnect from the web process if it's the last page > + being disconnected, stop expecting bundle messages after that point. > + Don't we still need to wait for WebProcess to terminate? 893492 6 kling 2013-05-24 16:12:50 -0700 I'd like some advice on what to do here. Now that WebPageProxy::close() may disconnect from the web process, we've removed the ability for an injected bundle to reliably communicate with the UI process in its willDestroyPage() callback. Is this functionality important? I suggested to Anders that we could switch the test to using WKPageTryClose() instead of WKPageClose(), and then let WebPage::tryClose() call out to the injected bundle's willDestroyPage() if it plans to indeed kill the page. Anders was not impressed. 893620 7 sam 2013-05-25 10:46:30 -0700 (In reply to comment #6) > I'd like some advice on what to do here. > > Now that WebPageProxy::close() may disconnect from the web process, we've removed the ability for an injected bundle to reliably communicate with the UI process in its willDestroyPage() callback. > > Is this functionality important? > > I suggested to Anders that we could switch the test to using WKPageTryClose() instead of WKPageClose(), and then let WebPage::tryClose() call out to the injected bundle's willDestroyPage() if it plans to indeed kill the page. Anders was not impressed. It seems valuable to preserve the ability for willDestroyPage() to always run, but I can also see arguments against it, since being able to shoot a process in the head when closing its last page could certainly be more efficient. Perhaps we need new SPI to allow choosing which behavior is desirable, or maybe we can piggyback on existing sudden termination API. 202838 2013-05-24 11:16:48 -0700 2013-05-24 11:35:49 -0700 Tweak the test for new WKPageClose semantics bug-116595.diff text/plain 3627 kling ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YjY1 ZjllLi4xZWUyYmYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDUtMjQgIEFuZHJlYXMgS2xpbmcgIDxha2xp bmdAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1MDQ5MSk6IFdlYktpdDIuRE9N V2luZG93RXh0ZW5zaW9uTm9DYWNoZSBmYWlscy4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3Jn L2IvMTE2NTk1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNpbmNlIFdLUGFnZUNsb3NlKCkgd2lsbCBub3cgZGlzY29ubmVjdCBmcm9tIHRoZSB3ZWIg cHJvY2VzcyBpZiBpdCdzIHRoZSBsYXN0IHBhZ2UKKyAgICAgICAgYmVpbmcgZGlzY29ubmVjdGVk LCBzdG9wIGV4cGVjdGluZyBidW5kbGUgbWVzc2FnZXMgYWZ0ZXIgdGhhdCBwb2ludC4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9ET01XaW5kb3dFeHRlbnNpb25Ob0Nh Y2hlLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEkpOgorICAgICAgICAoVGVzdFdlYktpdEFQ STo6VEVTVCk6CisKIDIwMTMtMDUtMjQgIFNpbW9uIFBlbmEgIDxzaW1vbi5wZW5hQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFVwZGF0ZSBXVEY6OlZlY3RvciBwcmV0dHkgcHJpbnRlcnMKZGlmZiAt LWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9ET01XaW5kb3dFeHRlbnNp b25Ob0NhY2hlLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9ET01XaW5k b3dFeHRlbnNpb25Ob0NhY2hlLmNwcAppbmRleCBhYzA0MDEyLi5lYjRhNzIzIDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvRE9NV2luZG93RXh0ZW5zaW9uTm9D YWNoZS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL0RPTVdpbmRv d0V4dGVuc2lvbk5vQ2FjaGUuY3BwCkBAIC01OCwxMCArNTgsNyBAQCBzdGF0aWMgY29uc3QgY2hh ciogZXhwZWN0ZWRNZXNzYWdlc1tdID0gewogIkdsb2JhbE9iamVjdElzQXZhaWxhYmxlRm9yRnJh bWUgY2FsbGVkIiwKICJTdWJmcmFtZSBmaW5pc2hlZCBsb2FkaW5nIiwKICJFeHRlbnNpb24gc3Rh dGVzOlxuRmlyc3QgcGFnZSwgbWFpbiBmcmFtZSwgc3RhbmRhcmQgd29ybGQgLSBEZXN0cm95ZWRc bkZpcnN0IHBhZ2UsIG1haW4gZnJhbWUsIG5vbi1zdGFuZGFyZCB3b3JsZCAtIERlc3Ryb3llZFxu Rmlyc3QgcGFnZSwgc3ViZnJhbWUsIHN0YW5kYXJkIHdvcmxkIC0gRGVzdHJveWVkXG5GaXJzdCBw YWdlLCBzdWJmcmFtZSwgbm9uLXN0YW5kYXJkIHdvcmxkIC0gRGVzdHJveWVkXG5TZWNvbmQgcGFn ZSwgbWFpbiBmcmFtZSwgc3RhbmRhcmQgd29ybGQgLSBEZXN0cm95ZWRcblNlY29uZCBwYWdlLCBt YWluIGZyYW1lLCBub24tc3RhbmRhcmQgd29ybGQgLSBEZXN0cm95ZWRcbkZpcnN0IHBhZ2UsIG1h aW4gZnJhbWUsIHN0YW5kYXJkIHdvcmxkIC0gQ29ubmVjdGVkXG5GaXJzdCBwYWdlLCBtYWluIGZy YW1lLCBub24tc3RhbmRhcmQgd29ybGQgLSBDb25uZWN0ZWRcbkZpcnN0IHBhZ2UsIHN1YmZyYW1l LCBzdGFuZGFyZCB3b3JsZCAtIENvbm5lY3RlZFxuRmlyc3QgcGFnZSwgc3ViZnJhbWUsIG5vbi1z dGFuZGFyZCB3b3JsZCAtIENvbm5lY3RlZCIsCi0iTWFpbiBmcmFtZSBmaW5pc2hlZCBsb2FkaW5n IiwKLSJFeHRlbnNpb24gc3RhdGVzOlxuRmlyc3QgcGFnZSwgbWFpbiBmcmFtZSwgc3RhbmRhcmQg d29ybGQgLSBEZXN0cm95ZWRcbkZpcnN0IHBhZ2UsIG1haW4gZnJhbWUsIG5vbi1zdGFuZGFyZCB3 b3JsZCAtIERlc3Ryb3llZFxuRmlyc3QgcGFnZSwgc3ViZnJhbWUsIHN0YW5kYXJkIHdvcmxkIC0g RGVzdHJveWVkXG5GaXJzdCBwYWdlLCBzdWJmcmFtZSwgbm9uLXN0YW5kYXJkIHdvcmxkIC0gRGVz dHJveWVkXG5TZWNvbmQgcGFnZSwgbWFpbiBmcmFtZSwgc3RhbmRhcmQgd29ybGQgLSBEZXN0cm95 ZWRcblNlY29uZCBwYWdlLCBtYWluIGZyYW1lLCBub24tc3RhbmRhcmQgd29ybGQgLSBEZXN0cm95 ZWRcbkZpcnN0IHBhZ2UsIG1haW4gZnJhbWUsIHN0YW5kYXJkIHdvcmxkIC0gQ29ubmVjdGVkXG5G aXJzdCBwYWdlLCBtYWluIGZyYW1lLCBub24tc3RhbmRhcmQgd29ybGQgLSBDb25uZWN0ZWRcbkZp cnN0IHBhZ2UsIHN1YmZyYW1lLCBzdGFuZGFyZCB3b3JsZCAtIENvbm5lY3RlZFxuRmlyc3QgcGFn ZSwgc3ViZnJhbWUsIG5vbi1zdGFuZGFyZCB3b3JsZCAtIENvbm5lY3RlZCIsCi0iRXh0ZW5zaW9u IHN0YXRlczpcbkZpcnN0IHBhZ2UsIG1haW4gZnJhbWUsIHN0YW5kYXJkIHdvcmxkIC0gRGVzdHJv eWVkXG5GaXJzdCBwYWdlLCBtYWluIGZyYW1lLCBub24tc3RhbmRhcmQgd29ybGQgLSBEZXN0cm95 ZWRcbkZpcnN0IHBhZ2UsIHN1YmZyYW1lLCBzdGFuZGFyZCB3b3JsZCAtIERlc3Ryb3llZFxuRmly c3QgcGFnZSwgc3ViZnJhbWUsIG5vbi1zdGFuZGFyZCB3b3JsZCAtIERlc3Ryb3llZFxuU2Vjb25k IHBhZ2UsIG1haW4gZnJhbWUsIHN0YW5kYXJkIHdvcmxkIC0gRGVzdHJveWVkXG5TZWNvbmQgcGFn ZSwgbWFpbiBmcmFtZSwgbm9uLXN0YW5kYXJkIHdvcmxkIC0gRGVzdHJveWVkXG5GaXJzdCBwYWdl LCBtYWluIGZyYW1lLCBzdGFuZGFyZCB3b3JsZCAtIFJlbW92ZWRcbkZpcnN0IHBhZ2UsIG1haW4g ZnJhbWUsIG5vbi1zdGFuZGFyZCB3b3JsZCAtIFJlbW92ZWRcbkZpcnN0IHBhZ2UsIHN1YmZyYW1l LCBzdGFuZGFyZCB3b3JsZCAtIFJlbW92ZWRcbkZpcnN0IHBhZ2UsIHN1YmZyYW1lLCBub24tc3Rh bmRhcmQgd29ybGQgLSBSZW1vdmVkIiwKLSJUZXN0Q29tcGxldGUiCisiTWFpbiBmcmFtZSBmaW5p c2hlZCBsb2FkaW5nIgogfTsKIAogc3RhdGljIFZlY3RvcjxXS1JldGFpblB0cjxXS1N0cmluZ1Jl Zj4gPiBtZXNzYWdlczsKQEAgLTc4LDcgKzc1LDcgQEAgc3RhdGljIHZvaWQgZGlkUmVjZWl2ZU1l c3NhZ2VGcm9tSW5qZWN0ZWRCdW5kbGUoV0tDb250ZXh0UmVmLCBXS1N0cmluZ1JlZiBtZXNzYWcK ICAgICAgIGZpbmlzaGVkID0gdHJ1ZTsKIH0KIAotVEVTVChXZWJLaXQyLCBESVNBQkxFRF9ET01X aW5kb3dFeHRlbnNpb25Ob0NhY2hlKQorVEVTVChXZWJLaXQyLCBET01XaW5kb3dFeHRlbnNpb25O b0NhY2hlKQogewogICAgIFdLUmV0YWluUHRyPFdLUGFnZUdyb3VwUmVmPiBwYWdlR3JvdXAoQWRv cHRXSywgV0tQYWdlR3JvdXBDcmVhdGVXaXRoSWRlbnRpZmllcihXS1N0cmluZ0NyZWF0ZVdpdGhV VEY4Q1N0cmluZygiRE9NV2luZG93RXh0ZW5zaW9uTm9DYWNoZVBhZ2VHcm91cCIpKSk7CiAKQEAg LTExOCw4ICsxMTUsNiBAQCBURVNUKFdlYktpdDIsIERJU0FCTEVEX0RPTVdpbmRvd0V4dGVuc2lv bk5vQ2FjaGUpCiAKICAgICBXS1BhZ2VDbG9zZSh3ZWJWaWV3LnBhZ2UoKSk7CiAKLSAgICBVdGls OjpydW4oJmZpbmlzaGVkKTsKLQogICAgIGNvbnN0IHNpemVfdCBleHBlY3RlZFNpemUgPSBzaXpl b2YoZXhwZWN0ZWRNZXNzYWdlcykgLyBzaXplb2YoY29uc3QgY2hhciopOwogICAgIEVYUEVDVF9F UShleHBlY3RlZFNpemUsIG1lc3NhZ2VzLnNpemUoKSk7CiAK