116591 2013-05-21 22:30:48 -0700 Fix issues with focus rings on search fields 2013-05-22 12:06:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin simon.fraser thorton oldest_to_newest 892118 0 simon.fraser 2013-05-21 22:30:48 -0700 Fix issues with focus rings on search fields 892119 1 202498 simon.fraser 2013-05-21 22:35:49 -0700 Created attachment 202498 Patch 892283 2 202498 darin 2013-05-22 07:46:04 -0700 Comment on attachment 202498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202498&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:4953 > + // Required to fix search field focus rings <rdar://problem/13780122>. The use of "fix" here is not clear enough. It would be better if this comment was more specific about what exactly AppKit does when we return YES here that helps us. I tried to read your comment in the change log, but I couldn’t understand it. 892480 3 simon.fraser 2013-05-22 12:06:45 -0700 https://trac.webkit.org/r150530 202498 2013-05-21 22:35:49 -0700 2013-05-22 07:46:04 -0700 Patch bug-116591-20130521223436.patch text/plain 4232 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGY2NzQyYTI1OTRjMzRh MTMzYzJmYjFlMWVjODY1YWEzNWEyNGY3Yi4uYjA1OWYzZmRjZGY5MjE2Y2EzNTRhODZiMzBhZmY5 MTI0MWM5NzQ1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA1LTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBpc3N1ZXMg d2l0aCBmb2N1cyByaW5ncyBvbiBzZWFyY2ggZmllbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY1OTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIE9uIGEgZnV0dXJlIE9TLCB0aGUgcmVj dCByZXR1cm5lZCBieSBfZm9jdXNSaW5nVmlzaWJsZVJlY3Qgc2hvdWxkCisgICAgICAgIGJlIGlu IHRoZSBjb29yZGluYXRlIHN5c3RlbSBvZiB0aGUgdGhhdCBOU1ZpZXcsIG5vdCB0aGUgYmFzZQor ICAgICAgICBjb29yZGluYXRlIHN5c3RlbSwgc28gZml4IHRoZSBjb2RlIHRoYXQgc2V0cyBhbmQg cmVhZHMgdGhlIGdsb2JhbAorICAgICAgICBmb2N1c1JpbmdDbGlwUmVjdCB2YXJpYWJsZSBhY2Nv cmRpbmdseS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9XZWJMYXllci5tbToK KyAgICAgICAgKGRyYXdMYXllckNvbnRlbnRzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGhl bWVNYWMubW06CisgICAgICAgICgtW1dlYkNvcmVGbGlwcGVkVmlldyBfZm9jdXNSaW5nVmlzaWJs ZVJlY3RdKToKKwogMjAxMy0wNC0zMCAgQmFsYXpzIEtlbGVtZW4gIDxiLmtlbGVtZW5Ac2lzYS5z YW1zdW5nLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBjYW5ub3Qgc2VlayBhZnRlciB2aWRl byBmaW5pc2hlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4IDM2NzUzZGM2MDRlZDI1NzBkODQ0ZGU2Yjhl ZDIzNzA5YjI1NzM4MmYuLjhlNjE0MWI5ODZhNzlmYThkYWJiMzA3OGUxNTI3MmYyNzQyZGE4ZDgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wNS0yMSAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaXNzdWVzIHdpdGgg Zm9jdXMgcmluZ3Mgb24gc2VhcmNoIGZpZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJbiBXZWJLaXQxLCBmb2N1cyByaW5ncyBkaWRu J3QgcmVuZGVyIGNvcnJlY3RseSBvbiBzb21lIE9TZXMgdW50aWwKKyAgICAgICAgc29tZSBvdGhl ciBjb250cm9sIGRyZXcgYSBmb2N1cyByaW5nLCB3aGljaCBjaGFuZ2VzIGludGVybmFsIEFwcEtp dCBzdGF0ZQorICAgICAgICBvbiB0aGUgZm9jdXNlZCB2aWV3LiBGaXggYnkgb3ZlcnJpZGluZyBh biBpbnRlcm5hbCBBcHBLaXQgbWV0aG9kIHRvIGFsd2F5cworICAgICAgICBkaXNhYmxlIEFwcEtp dCdzICJhdXRvbWF0aWMiIGZvY3VzIHJpbmcgZHJhd2luZy4KKworICAgICAgICAqIFdlYlZpZXcv V2ViSFRNTFZpZXcubW06CisgICAgICAgICgtW1dlYkhUTUxWaWV3IF9hdXRvbWF0aWNGb2N1c1Jp bmdEaXNhYmxlZF0pOgorCiAyMDEzLTA1LTEzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViUHJvY2VzcyBjb25zdW1pbmcgdmVyeSBoaWdoIENQVSBvbiBsaW5r ZWRpbi5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9XZWJMYXllci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9XZWJM YXllci5tbQppbmRleCBiNzFlYWQ4NTk4N2NhZDg3ZTQwMzU5MjNiMjQ0NTAyMzQ4MWZiMGI4Li41 ODU1NmMxNDVhMjIxNmFlNjYxY2E4YWUyZDZmM2QwZGFkN2ZmZWFkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViTGF5ZXIubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dlYkxheWVyLm1tCkBAIC03OSw5ICs3OSwx MyBAQCB2b2lkIGRyYXdMYXllckNvbnRlbnRzKENHQ29udGV4dFJlZiBjb250ZXh0LCBDQUxheWVy ICpsYXllciwgV2ViQ29yZTo6UGxhdGZvcm1DQQogICAgIC8vIHNtYWxsZXIgdGhhbiB0aGUgbGF5 ZXIgYm91bmRzIChlLmcuIHRpbGVkIGxheWVycykKICAgICBGbG9hdFJlY3QgY2xpcEJvdW5kcyA9 IENHQ29udGV4dEdldENsaXBCb3VuZGluZ0JveChjb250ZXh0KTsKIAorICAgIEZsb2F0UmVjdCBm b2N1c1JpbmdDbGlwUmVjdCA9IGNsaXBCb3VuZHM7CisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA8IDEwOTAKICAgICAvLyBTZXQgdGhlIGZvY3VzIHJpbmcgY2xpcCByZWN0IHdo aWNoIG5lZWRzIHRvIGJlIGluIGJhc2UgY29vcmRpbmF0ZXMuCiAgICAgQWZmaW5lVHJhbnNmb3Jt IHRyYW5zZm9ybSA9IENHQ29udGV4dEdldENUTShjb250ZXh0KTsKLSAgICBUaGVtZU1hYzo6c2V0 Rm9jdXNSaW5nQ2xpcFJlY3QodHJhbnNmb3JtLm1hcFJlY3QoY2xpcEJvdW5kcykpOworICAgIGZv Y3VzUmluZ0NsaXBSZWN0ID0gdHJhbnNmb3JtLm1hcFJlY3QoY2xpcEJvdW5kcyk7CisjZW5kaWYK KyAgICBUaGVtZU1hYzo6c2V0Rm9jdXNSaW5nQ2xpcFJlY3QoZm9jdXNSaW5nQ2xpcFJlY3QpOwog CiAjaWYgUExBVEZPUk0oSU9TKSB8fCBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwNzAKICAgICBjb25zdCBmbG9hdCB3YXN0ZWRTcGFjZVRocmVzaG9sZCA9IDAuNzVmOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCmluZGV4IGJlNjYxZDAyODA5MjE4NmMz YzUyMTBhNGM1ZmU0MjNiYmYyNzIwNmMuLmFmMmVjY2NkNWMyNmUzMTUyYWQ2ZjljMDk3ZGYzYmI4 N2JmNmU2NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1h Yy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0KQEAgLTY2 LDcgKzY2LDkgQEAgTlNSZWN0IGZvY3VzUmluZ0NsaXBSZWN0OwogICAgICAgICByZXR1cm4gW3Nl bGYgdmlzaWJsZVJlY3RdOwogCiAgICAgTlNSZWN0IHJlY3QgPSBmb2N1c1JpbmdDbGlwUmVjdDsK KyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTA5MAogICAgIHJlY3Qub3Jp Z2luLnkgPSBbc2VsZiBib3VuZHNdLnNpemUuaGVpZ2h0IC0gTlNNYXhZKHJlY3QpOworI2VuZGlm CiAKICAgICByZXR1cm4gcmVjdDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViSFRNTFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxW aWV3Lm1tCmluZGV4IDhmZjY1YWIwMDNlNzUzNDFhMjcwNWI5ZTgxMTlkMzRiMjc1NGNmOWUuLjhi MmJjMzQ5MDg3OGI4Y2U0M2NmOGJhZmMyZDE0YTVlOTFjZjQxYTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQpAQCAtNDk0Nyw2ICs0OTQ3LDEzIEBAIHN0YXRpYyBC T09MIHdyaXRpbmdEaXJlY3Rpb25LZXlCaW5kaW5nc0VuYWJsZWQoKQogICAgIHJldHVybiBoYXZl V2ViQ29yZUZyYW1lOwogfQogCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSAxMDkwCistIChCT09MKV9hdXRvbWF0aWNGb2N1c1JpbmdEaXNhYmxlZAoreworICAgIC8vIFJl cXVpcmVkIHRvIGZpeCBzZWFyY2ggZmllbGQgZm9jdXMgcmluZ3MgPHJkYXI6Ly9wcm9ibGVtLzEz NzgwMTIyPi4KKyAgICByZXR1cm4gWUVTOworfQorI2VuZGlmCiAKIC0gKHZvaWQpX3VwZGF0ZUNv bnRyb2xUaW50cwogewo=