116583 2013-05-21 16:54:59 -0700 [WinCE,WinCairo] RenderThemeWin.cpp need to include FrameSelection.h 2013-06-05 14:33:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mark.salisbury webkit-unassigned commit-queue esprehn+autocc glenn oldest_to_newest 892050 0 mark.salisbury 2013-05-21 16:54:59 -0700 Not sure how recently this was introduced - I think WinCairo does not generally build RenderThemeWin.cpp anymore. Anyway, FrameSelection is undefined, probably because it was removed from an upstream include file recently. 892051 1 202478 mark.salisbury 2013-05-21 16:58:22 -0700 Created attachment 202478 Proposed fix Simple build fix 892052 2 commit-queue 2013-05-21 17:00:53 -0700 Attachment 202478 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderThemeWin.cpp']" exit_code: 1 Source/WebCore/rendering/RenderThemeWin.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 892062 3 202480 mark.salisbury 2013-05-21 17:16:25 -0700 Created attachment 202480 Proposed fix Added header file in proper alphabetical order. 896062 4 202480 bfulgham 2013-05-31 22:47:37 -0700 Comment on attachment 202480 Proposed fix r=me 896891 5 203695 mark.salisbury 2013-06-04 07:33:34 -0700 Created attachment 203695 Proposed fix Added Brent Fulgham as reviewer. Thanks Brent. 897558 6 203695 bfulgham 2013-06-05 14:28:37 -0700 Comment on attachment 203695 Proposed fix r=me 897561 7 203695 commit-queue 2013-06-05 14:33:29 -0700 Comment on attachment 203695 Proposed fix Clearing flags on attachment: 203695 Committed r151239: <http://trac.webkit.org/changeset/151239> 897562 8 commit-queue 2013-06-05 14:33:31 -0700 All reviewed patches have been landed. Closing bug. 202478 2013-05-21 16:58:22 -0700 2013-05-21 17:16:25 -0700 Proposed fix bug-116583.patch text/plain 992 mark.salisbury ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjczZmIwLi41YjA2MWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMDUtMjEgIE1hcmsgU2FsaXNidXJ5ICA8bWFyay5zYWxpc2J1cnlAaHAuY29tPgor CisgICAgICAgIFtXaW5DRSxXaW5DYWlyb10gUmVuZGVyVGhlbWVXaW4uY3BwIG5lZWRzIHRvIGlu Y2x1ZGUgRnJhbWVTZWxlY3Rpb24uaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNjU4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcDoKKwogMjAxMy0w NS0yMSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBC dWlsZCBmaXggZm9yICFVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpIGFmdGVyIHIxNTAzMDcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAppbmRleCBiNTAx ZmZmLi41ODc3MGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdp bi5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJTb2Z0TGlua2luZy5oIgogI2luY2x1 ZGUgIlN5c3RlbUluZm8uaCIKICNpbmNsdWRlICJVc2VyQWdlbnRTdHlsZVNoZWV0cy5oIgorI2lu Y2x1ZGUgIkZyYW1lU2VsZWN0aW9uLmgiCiAKICNpZiBFTkFCTEUoVklERU8pCiAjaW5jbHVkZSAi UmVuZGVyTWVkaWFDb250cm9scy5oIgo= 202480 2013-05-21 17:16:25 -0700 2013-06-04 07:33:34 -0700 Proposed fix bug-116583.patch text/plain 1007 mark.salisbury ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjczZmIwLi41YjA2MWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMDUtMjEgIE1hcmsgU2FsaXNidXJ5ICA8bWFyay5zYWxpc2J1cnlAaHAuY29tPgor CisgICAgICAgIFtXaW5DRSxXaW5DYWlyb10gUmVuZGVyVGhlbWVXaW4uY3BwIG5lZWRzIHRvIGlu Y2x1ZGUgRnJhbWVTZWxlY3Rpb24uaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNjU4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcDoKKwogMjAxMy0w NS0yMSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBC dWlsZCBmaXggZm9yICFVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpIGFmdGVyIHIxNTAzMDcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAppbmRleCBiNTAx ZmZmLi44Yjg2OGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdp bi5jcHAKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJFbGVtZW50LmgiCiAjaW5jbHVkZSAi Rm9udE1ldHJpY3MuaCIKICNpbmNsdWRlICJGcmFtZS5oIgorI2luY2x1ZGUgIkZyYW1lU2VsZWN0 aW9uLmgiCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiTG9jYWxXaW5k b3dzQ29udGV4dC5oIgogI2luY2x1ZGUgIlBhaW50SW5mby5oIgo= 203695 2013-06-04 07:33:34 -0700 2013-06-05 14:33:29 -0700 Proposed fix bug-116583.patch text/plain 1006 mark.salisbury ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjczZmIwLi41YjA2MWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMDUtMjEgIE1hcmsgU2FsaXNidXJ5ICA8bWFyay5zYWxpc2J1cnlAaHAuY29tPgor CisgICAgICAgIFtXaW5DRSxXaW5DYWlyb10gUmVuZGVyVGhlbWVXaW4uY3BwIG5lZWRzIHRvIGlu Y2x1ZGUgRnJhbWVTZWxlY3Rpb24uaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNjU4MworCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdo YW0uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwOgorCiAyMDEzLTA1 LTIxICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1 aWxkIGZpeCBmb3IgIVVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykgYWZ0ZXIgcjE1MDMwNy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCmluZGV4IGI1MDFm ZmYuLjhiODY4YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU aGVtZVdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2lu LmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkVsZW1lbnQuaCIKICNpbmNsdWRlICJG b250TWV0cmljcy5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCisjaW5jbHVkZSAiRnJhbWVTZWxlY3Rp b24uaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJMb2NhbFdpbmRv d3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiUGFpbnRJbmZvLmgiCg==