116566 2013-05-21 12:10:26 -0700 [BlackBerry] Need to forward the opener frame url to client when creating a new window 2013-05-23 23:23:04 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned commit-queue mifenton rwlbuis oldest_to_newest 891936 0 andchen 2013-05-21 12:10:26 -0700 The opener frame url is useful to determine whether the popup should be blocked. 892392 1 202574 andchen 2013-05-22 11:03:51 -0700 Created attachment 202574 Patch 893106 2 202574 rwlbuis 2013-05-23 20:36:34 -0700 Comment on attachment 202574 Patch Ok 893161 3 202574 commit-queue 2013-05-23 23:23:01 -0700 Comment on attachment 202574 Patch Clearing flags on attachment: 202574 Committed r150628: <http://trac.webkit.org/changeset/150628> 893162 4 commit-queue 2013-05-23 23:23:04 -0700 All reviewed patches have been landed. Closing bug. 202574 2013-05-22 11:03:51 -0700 2013-05-23 23:23:01 -0700 Patch bug-116566-20130522140237.patch text/plain 4544 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmYjM0ZjliZjhiZjNjODFiYTcwZThlYzJkODExZDNkOTk3MTUwZWIxLi4zOTJlODY2Mzdl MTU4NGM4Y2IxYTQwYjJmN2E0MmNhODRmY2MxZTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMy0wNS0yMiAgQW5keSBDaGVuICA8YW5kY2hlbkBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gTmVlZCB0byBmb3J3YXJkIHRo ZSBvcGVuZXIgZnJhbWUgdXJsIHRvIGNsaWVudCB3aGVuIGNyZWF0aW5nIGEgbmV3IHdpbmRvdwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NTY2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIgMzM3OTM1 CisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgQXJ2aWQgTmlsc3Nvbi4KKyAgICAgICAg V2hlbiBjcmVhdGluZyBhIG5ldyB3aW5kb3csIGZvcndhcmQgdGhlIG9wZW5lciBmcmFtZSB1cmwg dG8gY2xpZW50LgorCisgICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNocm9tZUNsaWVudEJsYWNrQmVycnk6OmNyZWF0ZVdpbmRvdyk6CisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hDcmVhdGVQYWdlKToK KwogMjAxMy0wNS0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0JsYWNrQmVycnldIE1ha2UgUGFnZVBvcHVwIGltcGxlbWVudGF0aW9uIGlu ZGVwZW5kZW50IGZyb20gV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2VDbGllbnQuaAppbmRleCBjMmZmM2JlMjRhMWM0YWFmYTQ4NzJlZjY4NDI3MzJjZGE5ZWVj NjI4Li41YTY4NDczZWFiYjBjMTcxNGJmMjM1YjM3ZDI1MTlhMjRkNDI4OWFhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMTcxLDcgKzE3MSw3 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgb3BlblBvcHVwTGlzdChib29sIG11bHRpcGxl LCBpbnQgc2l6ZSwgY29uc3QgU2NvcGVBcnJheTxCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5n PiYgbGFiZWxzLCBjb25zdCBib29sKiBlbmFibGVkcywgY29uc3QgaW50KiBpdGVtVHlwZSwgY29u c3QgYm9vbCogc2VsZWN0ZWRzKSA9IDA7CiAgICAgdmlydHVhbCBib29sIGNob29zZUZpbGVuYW1l cyhib29sIGFsbG93TXVsdGlwbGUsIGNvbnN0IFNoYXJlZEFycmF5PEJsYWNrQmVycnk6OlBsYXRm b3JtOjpTdHJpbmc+JiBhY2NlcHRUeXBlcywgY29uc3QgU2hhcmVkQXJyYXk8QmxhY2tCZXJyeTo6 UGxhdGZvcm06OlN0cmluZz4mIGluaXRpYWxGaWxlcywgY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZv cm06OlN0cmluZyYgY2FwdHVyZSwgU2hhcmVkQXJyYXk8QmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0 cmluZz4mIGNob3NlbkZpbGVzKSA9IDA7CiAKLSAgICB2aXJ0dWFsIFdlYlBhZ2UqIGNyZWF0ZVdp bmRvdyhpbnQgeCwgaW50IHksIGludCB3aWR0aCwgaW50IGhlaWdodCwgdW5zaWduZWQgZmxhZ3Ms IGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIHVybCwgY29uc3QgQmxhY2tCZXJy eTo6UGxhdGZvcm06OlN0cmluZyYgd2luZG93TmFtZSwgYm9vbCB1c2VyR2VzdHVyZSkgPSAwOwor ICAgIHZpcnR1YWwgV2ViUGFnZSogY3JlYXRlV2luZG93KGludCB4LCBpbnQgeSwgaW50IHdpZHRo LCBpbnQgaGVpZ2h0LCB1bnNpZ25lZCBmbGFncywgY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06 OlN0cmluZyYgdXJsLCBjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiB3aW5kb3dO YW1lLCBjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBvcGVuZXJGcmFtZVVybCwg Ym9vbCB1c2VyR2VzdHVyZSkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIHNjaGVkdWxlQ2xvc2VX aW5kb3coKSA9IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCBj OTc3N2EzNGJlNThjZjdlODczOWU1MWYzOGUzYzUzNGU4NTNlZDhjLi4xZGU5MTI3MzQyMGMyOGM0 YTE5Mzk2NWNlODNmY2NlZmZkNTQxMjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVy cnkuY3BwCkBAIC0yNTYsNyArMjU2LDcgQEAgUGFnZSogQ2hyb21lQ2xpZW50QmxhY2tCZXJyeTo6 Y3JlYXRlV2luZG93KEZyYW1lKiBmcmFtZSwgY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYKICAgICBp ZiAoZmVhdHVyZXMuZGlhbG9nKQogICAgICAgICBmbGFncyB8PSBXZWJQYWdlQ2xpZW50OjpGbGFn V2luZG93SXNEaWFsb2c7CiAKLSAgICBXZWJQYWdlKiB3ZWJQYWdlID0gbV93ZWJQYWdlUHJpdmF0 ZS0+bV9jbGllbnQtPmNyZWF0ZVdpbmRvdyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBmbGFncywgdXJs LnN0cmluZygpLCByZXF1ZXN0LmZyYW1lTmFtZSgpLCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNz aW5nVXNlckdlc3R1cmUoKSk7CisgICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fd2ViUGFnZVByaXZh dGUtPm1fY2xpZW50LT5jcmVhdGVXaW5kb3coeCwgeSwgd2lkdGgsIGhlaWdodCwgZmxhZ3MsIHVy bC5zdHJpbmcoKSwgcmVxdWVzdC5mcmFtZU5hbWUoKSwgZnJhbWUtPmRvY3VtZW50KCktPnVybCgp LnN0cmluZygpLCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKSk7CiAg ICAgaWYgKCF3ZWJQYWdlKQogICAgICAgICByZXR1cm4gMDsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVM b2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCAwOTBkNWEwMTE3Yzg2NGY1ZjY0NmFiMmQ0 YjE3Mzg3MTk5YWZiY2E4Li4zYTZjMjQ4Y2EwYTAwMzdjOGNjZDRlNGVmMjg2MjYyOWVkOTAzZmJl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtOTQy LDcgKzk0Miw3IEBAIGJvb2wgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpzaG91bGRTdG9w TG9hZGluZ0Zvckhpc3RvcnlJdGVtKEhpc3RvcnlJdGVtKikKIAogRnJhbWUqIEZyYW1lTG9hZGVy Q2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hDcmVhdGVQYWdlKGNvbnN0IE5hdmlnYXRpb25BY3Rp b24mIG5hdmlnYXRpb24pCiB7Ci0gICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fd2ViUGFnZVByaXZh dGUtPm1fY2xpZW50LT5jcmVhdGVXaW5kb3coMCwgMCwgLTEsIC0xLCBXZWJQYWdlQ2xpZW50OjpG bGFnV2luZG93RGVmYXVsdCwgbmF2aWdhdGlvbi51cmwoKS5zdHJpbmcoKSwgQmxhY2tCZXJyeTo6 UGxhdGZvcm06OlN0cmluZzo6ZW1wdHlTdHJpbmcoKSwgU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vz c2luZ1VzZXJHZXN0dXJlKCkpOworICAgIFdlYlBhZ2UqIHdlYlBhZ2UgPSBtX3dlYlBhZ2VQcml2 YXRlLT5tX2NsaWVudC0+Y3JlYXRlV2luZG93KDAsIDAsIC0xLCAtMSwgV2ViUGFnZUNsaWVudDo6 RmxhZ1dpbmRvd0RlZmF1bHQsIG5hdmlnYXRpb24udXJsKCkuc3RyaW5nKCksIEJsYWNrQmVycnk6 OlBsYXRmb3JtOjpTdHJpbmc6OmVtcHR5U3RyaW5nKCksIG1fZnJhbWUtPmRvY3VtZW50KCktPnVy bCgpLnN0cmluZygpLCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKSk7 CiAgICAgaWYgKCF3ZWJQYWdlKQogICAgICAgICByZXR1cm4gMDsKIAo=