116543 2013-05-21 08:54:28 -0700 [BlackBerry] Reveal HTTP error code for XHR even if there is no response body 2013-05-27 08:44:59 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leoyang leoyang commit-queue joenotcharles rwlbuis oldest_to_newest 891804 0 leoyang 2013-05-21 08:54:28 -0700 BlackBerry is doing friendly http error handling: if there is no response body for an http error it will display an error message made by the port. But for XHR request, which is not usually displaying error messages to the end user, we should reveal http error code to let the JS know what is the actual server error. 891827 1 202440 leoyang 2013-05-21 09:17:01 -0700 Created attachment 202440 Patch 891849 2 202440 ap 2013-05-21 09:49:15 -0700 Comment on attachment 202440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202440&action=review > Source/WebCore/ChangeLog:14 > + BlackBerry is doing friendly HTTP error handling: if there is no response body > + for an HTTP error it will display an error message made by the port. But for a > + XHR request, which usually does not result in displaying error messages to the > + end user, HTTP error code should be revealed to let the JavaScript know what > + the actual server error code is. Shouldn't the difference be "main resource vs. any subresource"? There is no user visible error reporting for any subresources, not just XHR. 891878 3 202440 leoyang 2013-05-21 10:28:15 -0700 Comment on attachment 202440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202440&action=review >> Source/WebCore/ChangeLog:14 >> + the actual server error code is. > > Shouldn't the difference be "main resource vs. any subresource"? There is no user visible error reporting for any subresources, not just XHR. As far as I know only XHR may care about the actual status code in this case. Extends to the subresource might be a good idea but I need to evaluate the potential negative impact. 892284 4 202440 leoyang 2013-05-22 08:00:36 -0700 Comment on attachment 202440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202440&action=review >>> Source/WebCore/ChangeLog:14 >>> + the actual server error code is. >> >> Shouldn't the difference be "main resource vs. any subresource"? There is no user visible error reporting for any subresources, not just XHR. > > As far as I know only XHR may care about the actual status code in this case. Extends to the subresource might be a good idea but I need to evaluate the potential negative impact. Based on no-unnecessary-change, I'd like to keep current error handling for subresource `AS IS`. 894033 5 202440 rwlbuis 2013-05-27 08:11:45 -0700 Comment on attachment 202440 Patch Okay. 894052 6 202440 leoyang 2013-05-27 08:41:06 -0700 Comment on attachment 202440 Patch Sending to cq. 894056 7 202440 commit-queue 2013-05-27 08:44:57 -0700 Comment on attachment 202440 Patch Clearing flags on attachment: 202440 Committed r150759: <http://trac.webkit.org/changeset/150759> 894057 8 commit-queue 2013-05-27 08:44:59 -0700 All reviewed patches have been landed. Closing bug. 202440 2013-05-21 09:17:01 -0700 2013-05-27 08:44:57 -0700 Patch 0001-BlackBerry-Reveal-HTTP-error-code-for-XHR-even-if-th.patch text/plain 3482 leoyang RnJvbSAzMmE4MTExZjU0ZjA3YjY2NDJmYTQ2Y2U0NTI1NmM5ZmM5N2Q1NmY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBUdWUs IDIxIE1heSAyMDEzIDEyOjE0OjQ2IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IFJldmVhbCBIVFRQIGVycm9yIGNvZGUgZm9yIFhIUiBldmVuIGlmIHRoZXJlIGlzCiBubyByZXNw b25zZSBib2R5CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NTQz CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBKb2Ug TWFzb24uCgpJdCdzIGEgcmVncmVzc2lvbiBpbnRyb2R1Y2VkIGJ5IHIxMzI1NTYuCkJsYWNrQmVy cnkgaXMgZG9pbmcgZnJpZW5kbHkgSFRUUCBlcnJvciBoYW5kbGluZzogaWYgdGhlcmUgaXMgbm8g cmVzcG9uc2UgYm9keQpmb3IgYW4gSFRUUCBlcnJvciBpdCB3aWxsIGRpc3BsYXkgYW4gZXJyb3Ig bWVzc2FnZSBtYWRlIGJ5IHRoZSBwb3J0LiBCdXQgZm9yIGEKWEhSIHJlcXVlc3QsIHdoaWNoIHVz dWFsbHkgZG9lcyBub3QgcmVzdWx0IGluIGRpc3BsYXlpbmcgZXJyb3IgbWVzc2FnZXMgdG8gdGhl CmVuZCB1c2VyLCBIVFRQIGVycm9yIGNvZGUgc2hvdWxkIGJlIHJldmVhbGVkIHRvIGxldCB0aGUg SmF2YVNjcmlwdCBrbm93IHdoYXQKdGhlIGFjdHVhbCBzZXJ2ZXIgZXJyb3IgY29kZSBpcy4KCkNv dmVyZWQgYnkgZXhpc3RpbmcgdGVzdHM6Ck1hbnVhbFRlc3RzL2JsYWNrYmVycnkvaGVhZC14aHIt bm9uZXhpc3RhbnQtZmlsZS5odG1sCkxheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QveG1saHR0cHJlcXVlc3QtY2hlY2staGVhZC1yZWFkeXN0YXRlLWZvci00MDQuaHRtbApMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LWNoZWNrLWdl dC1yZWFkeXN0YXRlLWZvci00MDQtd2l0aG91dC1ib2R5Lmh0bWwKCiogcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgooV2ViQ29yZTo6TmV0d29ya0pvYjo6c2hvdWxk Tm90aWZ5Q2xpZW50RmFpbGVkKToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMjMgKysrKysrKysrKysrKysrKysrKysKIC4uLi9wbGF0 Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgICAgIHwgICAgMiArLQogMiBm aWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCAzYzU3MDc2Li5jYTI4N2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTMt MDUtMjEgIExlbyBZYW5nICA8bGVveWFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5 XSBSZXZlYWwgSFRUUCBlcnJvciBjb2RlIGZvciBYSFIgZXZlbiBpZiB0aGVyZSBpcyBubyByZXNw b25zZSBib2R5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTY1NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg UmV2aWV3ZWQgaW50ZXJuYWxseSBieSBKb2UgTWFzb24uCisKKyAgICAgICAgSXQncyBhIHJlZ3Jl c3Npb24gaW50cm9kdWNlZCBieSByMTMyNTU2LgorICAgICAgICBCbGFja0JlcnJ5IGlzIGRvaW5n IGZyaWVuZGx5IEhUVFAgZXJyb3IgaGFuZGxpbmc6IGlmIHRoZXJlIGlzIG5vIHJlc3BvbnNlIGJv ZHkKKyAgICAgICAgZm9yIGFuIEhUVFAgZXJyb3IgaXQgd2lsbCBkaXNwbGF5IGFuIGVycm9yIG1l c3NhZ2UgbWFkZSBieSB0aGUgcG9ydC4gQnV0IGZvciBhCisgICAgICAgIFhIUiByZXF1ZXN0LCB3 aGljaCB1c3VhbGx5IGRvZXMgbm90IHJlc3VsdCBpbiBkaXNwbGF5aW5nIGVycm9yIG1lc3NhZ2Vz IHRvIHRoZQorICAgICAgICBlbmQgdXNlciwgSFRUUCBlcnJvciBjb2RlIHNob3VsZCBiZSByZXZl YWxlZCB0byBsZXQgdGhlIEphdmFTY3JpcHQga25vdyB3aGF0CisgICAgICAgIHRoZSBhY3R1YWwg c2VydmVyIGVycm9yIGNvZGUgaXMuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0 czoKKyAgICAgICAgTWFudWFsVGVzdHMvYmxhY2tiZXJyeS9oZWFkLXhoci1ub25leGlzdGFudC1m aWxlLmh0bWwKKyAgICAgICAgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC94 bWxodHRwcmVxdWVzdC1jaGVjay1oZWFkLXJlYWR5c3RhdGUtZm9yLTQwNC5odG1sCisgICAgICAg IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3QtY2hl Y2stZ2V0LXJlYWR5c3RhdGUtZm9yLTQwNC13aXRob3V0LWJvZHkuaHRtbAorCisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TmV0d29ya0pvYjo6c2hvdWxkTm90aWZ5Q2xpZW50RmFpbGVkKToKKwogMjAxMy0wNS0y MSAgQWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgQWRkIEJs YWNrQmVycnkgZGVmaW5pdGlvbiBvZiBOYXRpdmVJbWFnZVB0cgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmlu ZGV4IDhlOTQzMzkuLmMwZDVhMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTYwMSw3ICs2MDEs NyBAQCBib29sIE5ldHdvcmtKb2I6OnNob3VsZFJlbGVhc2VDbGllbnRSZXNvdXJjZSgpCiAKIGJv b2wgTmV0d29ya0pvYjo6c2hvdWxkTm90aWZ5Q2xpZW50RmFpbGVkKCkgY29uc3QKIHsKLSAgICBy ZXR1cm4gbV9leHRlbmRlZFN0YXR1c0NvZGUgPCAwIHx8IChpc0Vycm9yKG1fZXh0ZW5kZWRTdGF0 dXNDb2RlKSAmJiAhbV9kYXRhUmVjZWl2ZWQgJiYgIW1faXNIZWFkTWV0aG9kKTsKKyAgICByZXR1 cm4gbV9leHRlbmRlZFN0YXR1c0NvZGUgPCAwIHx8IChpc0Vycm9yKG1fZXh0ZW5kZWRTdGF0dXND b2RlKSAmJiAhbV9kYXRhUmVjZWl2ZWQgJiYgIW1faXNIZWFkTWV0aG9kICYmIG1faGFuZGxlLT5m aXJzdFJlcXVlc3QoKS50YXJnZXRUeXBlKCkgIT0gUmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJc1hI Uik7CiB9CiAKIGJvb2wgTmV0d29ya0pvYjo6cmV0cnlBc0ZUUERpcmVjdG9yeSgpCi0tIAoxLjcu NS40Cgo=