116534 2013-05-21 06:12:41 -0700 [GStreamer] Adjust internal size on http source element when receiving data if necessary 2013-06-19 06:23:25 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115354 0 andrunko webkit-unassigned cgarcia commit-queue gustavo menard mrobinson pnormand oldest_to_newest 891735 0 andrunko 2013-05-21 06:12:41 -0700 Follow up on bug #115354. 891738 1 202423 andrunko 2013-05-21 06:15:44 -0700 Created attachment 202423 Adjust internal size when receiving data if needed This patch replaces https://bugs.webkit.org/attachment.cgi?id=202290 from bug #115354 891744 2 commit-queue 2013-05-21 06:18:09 -0700 Attachment 202423 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp']" exit_code: 1 Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:917: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 891745 3 202424 andrunko 2013-05-21 06:19:05 -0700 Created attachment 202424 Adjust internal size when receiving data if needed Updated Changelog to use proper bug number. 891747 4 commit-queue 2013-05-21 06:21:12 -0700 Attachment 202424 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp']" exit_code: 1 Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:917: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 897736 5 202424 cgarcia 2013-06-06 06:07:23 -0700 Comment on attachment 202424 Adjust internal size when receiving data if needed View in context: https://bugs.webkit.org/attachment.cgi?id=202424&action=review Please, fix coding style issues before landing. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1019 > + // priv->size == 0 if received length on didReceiveResponse < 0 Nit: According to the coding style comments should finish with a period. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020 > + if (priv->size != 0 && priv->offset > priv->size) { This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be if (priv->offset > priv->size) > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1021 > + GST_DEBUG_OBJECT(m_src, "Updating internal size from %ld to %ld", priv->size, priv->offset); size and offset are guint64, you should probably use G_GUINT64_FORMAT instead of %ld. 897830 6 203946 andrunko 2013-06-06 09:58:43 -0700 Created attachment 203946 Adjust internal size when receiving data if needed (In reply to comment #5) > (From update of attachment 202424 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202424&action=review > > Please, fix coding style issues before landing. > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1019 > > + // priv->size == 0 if received length on didReceiveResponse < 0 > > Nit: According to the coding style comments should finish with a period. > Done > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020 > > + if (priv->size != 0 && priv->offset > priv->size) { > > This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be > > if (priv->offset > priv->size) > But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need to update the internal size as didReceiveResponse will disable seek, etc on the gst appsrc. No change here > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1021 > > + GST_DEBUG_OBJECT(m_src, "Updating internal size from %ld to %ld", priv->size, priv->offset); > > size and offset are guint64, you should probably use G_GUINT64_FORMAT instead of %ld. Done 897831 7 commit-queue 2013-06-06 10:00:06 -0700 Attachment 203946 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp']" exit_code: 1 Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1015: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 897835 8 cgarcia 2013-06-06 10:05:42 -0700 (In reply to comment #6) > Created an attachment (id=203946) [details] > Adjust internal size when receiving data if needed > > (In reply to comment #5) > > (From update of attachment 202424 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=202424&action=review > > > > Please, fix coding style issues before landing. > > > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1019 > > > + // priv->size == 0 if received length on didReceiveResponse < 0 > > > > Nit: According to the coding style comments should finish with a period. > > > Done > > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020 > > > + if (priv->size != 0 && priv->offset > priv->size) { > > > > This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be > > > > if (priv->offset > priv->size) > > > But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need to update the internal size as didReceiveResponse will disable seek, etc on the gst appsrc. No change here You are right, I read the comparison wrongly. But still, you should do: if (priv->size && priv->offset > priv->size) or if (priv->size > 0 && priv->offset > priv->size) to make the style bot happy. 897841 9 203947 andrunko 2013-06-06 10:16:07 -0700 Created attachment 203947 Adjust internal size when receiving data if needed (In reply to comment #8) > > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020 > > > > + if (priv->size != 0 && priv->offset > priv->size) { > > > > > > This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be > > > > > > if (priv->offset > priv->size) > > > > > But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need to update the internal size as didReceiveResponse will disable seek, etc on the gst appsrc. No change here > > You are right, I read the comparison wrongly. But still, you should do: > > if (priv->size && priv->offset > priv->size) > > or > > if (priv->size > 0 && priv->offset > priv->size) > > to make the style bot happy. hehe, done :). 901768 10 203947 commit-queue 2013-06-19 06:23:22 -0700 Comment on attachment 203947 Adjust internal size when receiving data if needed Clearing flags on attachment: 203947 Committed r151731: <http://trac.webkit.org/changeset/151731> 901769 11 commit-queue 2013-06-19 06:23:25 -0700 All reviewed patches have been landed. Closing bug. 202423 2013-05-21 06:15:44 -0700 2013-05-21 06:19:05 -0700 Adjust internal size when receiving data if needed patch_115354_3.diff text/plain 2495 andrunko RnJvbSBiMDhkOTZjYTMzNmI1ZDM5Mzc1MWQ4ODYxMTM1NWY2ODlmY2I2ZGEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgKGFuZHJ1bmtvKSIg PGFuZHJlLm1hZ2FsaGFlc0Bjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMyBNYXkgMjAxMyAx MjoyNzozMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkanVzdCBpbnRlcm5hbCBzaXplIG9uIGdz dHJlYW1lciBzb3VyY2UgZWxlbWVudCB3aGVuCiByZWNlaXZpbmcgZGF0YSBpZiBuZWNlc3Nhcnku CgpJZiB0aGUgc2l6ZSByZWNlaXZlZCBpbiBkaWRSZWNlaXZlUmVzcG9uc2UgaXMgc21hbGxlciB0 aGFuIHRoZSBhY3R1YWwgc2l6ZSBvZiB0aGUgcmVjZWl2ZWQgZGF0YQp1cGRhdGUgdGhlIGludGVy bmFsIHNpemUgYW5kIHRoZSBhcHBzcmMgc2l6ZSB0byB0aGUgcHJvcGVyIHZhbHVlLgotLS0KIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAx NyArKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwICAgICB8ICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNlNTA5ODcuLjdjYjdmNmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wNS0wMyAgQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgICA8YW5k cmUubWFnYWxoYWVzQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBBZGp1c3QgaW50ZXJuYWwg c2l6ZSBvbiBnc3RyZWFtZXIgc291cmNlIGVsZW1lbnQgd2hlbiByZWNlaXZpbmcgZGF0YSBpZiBu ZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNTM1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZSBzaXplIHJlY2VpdmVkIGluIGRpZFJlY2VpdmVSZXNwb25zZSBpcyBzbWFsbGVyIHRo YW4gdGhlIGFjdHVhbCBzaXplIG9mIHRoZSByZWNlaXZlZCBkYXRhCisgICAgICAgIHVwZGF0ZSB0 aGUgaW50ZXJuYWwgc2l6ZSBhbmQgdGhlIGFwcHNyYyBzaXplIHRvIHRoZSBwcm9wZXIgdmFsdWUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6ZGlkUmVjZWl2ZURhdGEp OgorCiAyMDEzLTA0LTE4ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBUb29sYmFyIGljb25zIGFyZSBkaXNwbGF5ZWQgaW5jb3Jy ZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXgg ODlmMDNjOS4uZTk5MWUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKQEAgLTEwMTYsNiArMTAxNiwxMiBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6ZGlk UmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29uc3QgY2hhciogZGF0YSwgaQog ICAgIGlmIChwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgPT0gcHJpdi0+b2Zmc2V0KQogICAgICAgICBw cml2LT5yZXF1ZXN0ZWRPZmZzZXQgKz0gbGVuZ3RoOwogICAgIHByaXYtPm9mZnNldCArPSBsZW5n dGg7CisgICAgLy8gcHJpdi0+c2l6ZSA9PSAwIGlmIHJlY2VpdmVkIGxlbmd0aCBvbiBkaWRSZWNl aXZlUmVzcG9uc2UgPCAwCisgICAgaWYgKHByaXYtPnNpemUgIT0gMCAmJiBwcml2LT5vZmZzZXQg PiBwcml2LT5zaXplKSB7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QobV9zcmMsICJVcGRhdGlu ZyBpbnRlcm5hbCBzaXplIGZyb20gJWxkIHRvICVsZCIsIHByaXYtPnNpemUsIHByaXYtPm9mZnNl dCk7CisgICAgICAgIGdzdF9hcHBfc3JjX3NldF9zaXplKHByaXYtPmFwcHNyYywgcHJpdi0+b2Zm c2V0KTsKKyAgICAgICAgcHJpdi0+c2l6ZSA9IHByaXYtPm9mZnNldDsKKyAgICB9CiAgICAgR1NU X0JVRkZFUl9PRkZTRVRfRU5EKHByaXYtPmJ1ZmZlci5nZXQoKSkgPSBwcml2LT5vZmZzZXQ7CiAK ICAgICBHU1RfT0JKRUNUX1VOTE9DSyhtX3NyYyk7Ci0tIAoxLjguMS4yCgo= 202424 2013-05-21 06:19:05 -0700 2013-06-06 09:58:43 -0700 Adjust internal size when receiving data if needed patch_115354_3.diff text/plain 2495 andrunko RnJvbSBiMDhkOTZjYTMzNmI1ZDM5Mzc1MWQ4ODYxMTM1NWY2ODlmY2I2ZGEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgKGFuZHJ1bmtvKSIg PGFuZHJlLm1hZ2FsaGFlc0Bjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMyBNYXkgMjAxMyAx MjoyNzozMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkanVzdCBpbnRlcm5hbCBzaXplIG9uIGdz dHJlYW1lciBzb3VyY2UgZWxlbWVudCB3aGVuCiByZWNlaXZpbmcgZGF0YSBpZiBuZWNlc3Nhcnku CgpJZiB0aGUgc2l6ZSByZWNlaXZlZCBpbiBkaWRSZWNlaXZlUmVzcG9uc2UgaXMgc21hbGxlciB0 aGFuIHRoZSBhY3R1YWwgc2l6ZSBvZiB0aGUgcmVjZWl2ZWQgZGF0YQp1cGRhdGUgdGhlIGludGVy bmFsIHNpemUgYW5kIHRoZSBhcHBzcmMgc2l6ZSB0byB0aGUgcHJvcGVyIHZhbHVlLgotLS0KIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAx NyArKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwICAgICB8ICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNlNTA5ODcuLjdjYjdmNmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wNS0wMyAgQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgICA8YW5k cmUubWFnYWxoYWVzQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBBZGp1c3QgaW50ZXJuYWwg c2l6ZSBvbiBnc3RyZWFtZXIgc291cmNlIGVsZW1lbnQgd2hlbiByZWNlaXZpbmcgZGF0YSBpZiBu ZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZSBzaXplIHJlY2VpdmVkIGluIGRpZFJlY2VpdmVSZXNwb25zZSBpcyBzbWFsbGVyIHRo YW4gdGhlIGFjdHVhbCBzaXplIG9mIHRoZSByZWNlaXZlZCBkYXRhCisgICAgICAgIHVwZGF0ZSB0 aGUgaW50ZXJuYWwgc2l6ZSBhbmQgdGhlIGFwcHNyYyBzaXplIHRvIHRoZSBwcm9wZXIgdmFsdWUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6ZGlkUmVjZWl2ZURhdGEp OgorCiAyMDEzLTA0LTE4ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBUb29sYmFyIGljb25zIGFyZSBkaXNwbGF5ZWQgaW5jb3Jy ZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXgg ODlmMDNjOS4uZTk5MWUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKQEAgLTEwMTYsNiArMTAxNiwxMiBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6ZGlk UmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29uc3QgY2hhciogZGF0YSwgaQog ICAgIGlmIChwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgPT0gcHJpdi0+b2Zmc2V0KQogICAgICAgICBw cml2LT5yZXF1ZXN0ZWRPZmZzZXQgKz0gbGVuZ3RoOwogICAgIHByaXYtPm9mZnNldCArPSBsZW5n dGg7CisgICAgLy8gcHJpdi0+c2l6ZSA9PSAwIGlmIHJlY2VpdmVkIGxlbmd0aCBvbiBkaWRSZWNl aXZlUmVzcG9uc2UgPCAwCisgICAgaWYgKHByaXYtPnNpemUgIT0gMCAmJiBwcml2LT5vZmZzZXQg PiBwcml2LT5zaXplKSB7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QobV9zcmMsICJVcGRhdGlu ZyBpbnRlcm5hbCBzaXplIGZyb20gJWxkIHRvICVsZCIsIHByaXYtPnNpemUsIHByaXYtPm9mZnNl dCk7CisgICAgICAgIGdzdF9hcHBfc3JjX3NldF9zaXplKHByaXYtPmFwcHNyYywgcHJpdi0+b2Zm c2V0KTsKKyAgICAgICAgcHJpdi0+c2l6ZSA9IHByaXYtPm9mZnNldDsKKyAgICB9CiAgICAgR1NU X0JVRkZFUl9PRkZTRVRfRU5EKHByaXYtPmJ1ZmZlci5nZXQoKSkgPSBwcml2LT5vZmZzZXQ7CiAK ICAgICBHU1RfT0JKRUNUX1VOTE9DSyhtX3NyYyk7Ci0tIAoxLjguMS4yCgo= 203946 2013-06-06 09:58:43 -0700 2013-06-06 10:16:07 -0700 Adjust internal size when receiving data if needed patch_115354_3.diff text/plain 2529 andrunko RnJvbSBiMDhkOTZjYTMzNmI1ZDM5Mzc1MWQ4ODYxMTM1NWY2ODlmY2I2ZGEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgKGFuZHJ1bmtvKSIg PGFuZHJlLm1hZ2FsaGFlc0Bjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMyBNYXkgMjAxMyAx MjoyNzozMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkanVzdCBpbnRlcm5hbCBzaXplIG9uIGdz dHJlYW1lciBzb3VyY2UgZWxlbWVudCB3aGVuCiByZWNlaXZpbmcgZGF0YSBpZiBuZWNlc3Nhcnku CgpJZiB0aGUgc2l6ZSByZWNlaXZlZCBpbiBkaWRSZWNlaXZlUmVzcG9uc2UgaXMgc21hbGxlciB0 aGFuIHRoZSBhY3R1YWwgc2l6ZSBvZiB0aGUgcmVjZWl2ZWQgZGF0YQp1cGRhdGUgdGhlIGludGVy bmFsIHNpemUgYW5kIHRoZSBhcHBzcmMgc2l6ZSB0byB0aGUgcHJvcGVyIHZhbHVlLgotLS0KIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAx NyArKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwICAgICB8ICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNlNTA5ODcuLjdjYjdmNmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wNS0wMyAgQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgICA8YW5k cmUubWFnYWxoYWVzQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBBZGp1c3QgaW50ZXJuYWwg c2l6ZSBvbiBnc3RyZWFtZXIgc291cmNlIGVsZW1lbnQgd2hlbiByZWNlaXZpbmcgZGF0YSBpZiBu ZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZSBzaXplIHJlY2VpdmVkIGluIGRpZFJlY2VpdmVSZXNwb25zZSBpcyBzbWFsbGVyIHRo YW4gdGhlIGFjdHVhbCBzaXplIG9mIHRoZSByZWNlaXZlZCBkYXRhCisgICAgICAgIHVwZGF0ZSB0 aGUgaW50ZXJuYWwgc2l6ZSBhbmQgdGhlIGFwcHNyYyBzaXplIHRvIHRoZSBwcm9wZXIgdmFsdWUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6ZGlkUmVjZWl2ZURhdGEp OgorCiAyMDEzLTA0LTE4ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBUb29sYmFyIGljb25zIGFyZSBkaXNwbGF5ZWQgaW5jb3Jy ZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXgg ODlmMDNjOS4uZTk5MWUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKQEAgLTEwMTYsNiArMTAxNiwxMiBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6ZGlk UmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29uc3QgY2hhciogZGF0YSwgaQog ICAgIGlmIChwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgPT0gcHJpdi0+b2Zmc2V0KQogICAgICAgICBw cml2LT5yZXF1ZXN0ZWRPZmZzZXQgKz0gbGVuZ3RoOwogICAgIHByaXYtPm9mZnNldCArPSBsZW5n dGg7CisgICAgLy8gcHJpdi0+c2l6ZSA9PSAwIGlmIHJlY2VpdmVkIGxlbmd0aCBvbiBkaWRSZWNl aXZlUmVzcG9uc2UgPCAwLgorICAgIGlmIChwcml2LT5zaXplICE9IDAgJiYgcHJpdi0+b2Zmc2V0 ID4gcHJpdi0+c2l6ZSkgeworICAgICAgICBHU1RfREVCVUdfT0JKRUNUKG1fc3JjLCAiVXBkYXRp bmcgaW50ZXJuYWwgc2l6ZSBmcm9tICUiIEdfR1VJTlQ2NF9GT1JNQVQgIiB0byAlIiBHX0dVSU5U NjRfRk9STUFULCBwcml2LT5zaXplLCBwcml2LT5vZmZzZXQpOworICAgICAgICBnc3RfYXBwX3Ny Y19zZXRfc2l6ZShwcml2LT5hcHBzcmMsIHByaXYtPm9mZnNldCk7CisgICAgICAgIHByaXYtPnNp emUgPSBwcml2LT5vZmZzZXQ7CisgICAgfQogICAgIEdTVF9CVUZGRVJfT0ZGU0VUX0VORChwcml2 LT5idWZmZXIuZ2V0KCkpID0gcHJpdi0+b2Zmc2V0OwogCiAgICAgR1NUX09CSkVDVF9VTkxPQ0so bV9zcmMpOwotLSAKMS44LjEuMgoK 203947 2013-06-06 10:16:07 -0700 2013-06-19 06:23:22 -0700 Adjust internal size when receiving data if needed patch_115354_3.diff text/plain 2528 andrunko RnJvbSBiMDhkOTZjYTMzNmI1ZDM5Mzc1MWQ4ODYxMTM1NWY2ODlmY2I2ZGEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgKGFuZHJ1bmtvKSIg PGFuZHJlLm1hZ2FsaGFlc0Bjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMyBNYXkgMjAxMyAx MjoyNzozMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkanVzdCBpbnRlcm5hbCBzaXplIG9uIGdz dHJlYW1lciBzb3VyY2UgZWxlbWVudCB3aGVuCiByZWNlaXZpbmcgZGF0YSBpZiBuZWNlc3Nhcnku CgpJZiB0aGUgc2l6ZSByZWNlaXZlZCBpbiBkaWRSZWNlaXZlUmVzcG9uc2UgaXMgc21hbGxlciB0 aGFuIHRoZSBhY3R1YWwgc2l6ZSBvZiB0aGUgcmVjZWl2ZWQgZGF0YQp1cGRhdGUgdGhlIGludGVy bmFsIHNpemUgYW5kIHRoZSBhcHBzcmMgc2l6ZSB0byB0aGUgcHJvcGVyIHZhbHVlLgotLS0KIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAx NyArKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwICAgICB8ICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNlNTA5ODcuLjdjYjdmNmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wNS0wMyAgQW5kcmUgTW9yZWlyYSBNYWdhbGhhZXMgICA8YW5k cmUubWFnYWxoYWVzQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBBZGp1c3QgaW50ZXJuYWwg c2l6ZSBvbiBnc3RyZWFtZXIgc291cmNlIGVsZW1lbnQgd2hlbiByZWNlaXZpbmcgZGF0YSBpZiBu ZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZSBzaXplIHJlY2VpdmVkIGluIGRpZFJlY2VpdmVSZXNwb25zZSBpcyBzbWFsbGVyIHRo YW4gdGhlIGFjdHVhbCBzaXplIG9mIHRoZSByZWNlaXZlZCBkYXRhCisgICAgICAgIHVwZGF0ZSB0 aGUgaW50ZXJuYWwgc2l6ZSBhbmQgdGhlIGFwcHNyYyBzaXplIHRvIHRoZSBwcm9wZXIgdmFsdWUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6ZGlkUmVjZWl2ZURhdGEp OgorCiAyMDEzLTA0LTE4ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBUb29sYmFyIGljb25zIGFyZSBkaXNwbGF5ZWQgaW5jb3Jy ZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXgg ODlmMDNjOS4uZTk5MWUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKQEAgLTEwMTYsNiArMTAxNiwxMiBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6ZGlk UmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29uc3QgY2hhciogZGF0YSwgaQog ICAgIGlmIChwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgPT0gcHJpdi0+b2Zmc2V0KQogICAgICAgICBw cml2LT5yZXF1ZXN0ZWRPZmZzZXQgKz0gbGVuZ3RoOwogICAgIHByaXYtPm9mZnNldCArPSBsZW5n dGg7CisgICAgLy8gcHJpdi0+c2l6ZSA9PSAwIGlmIHJlY2VpdmVkIGxlbmd0aCBvbiBkaWRSZWNl aXZlUmVzcG9uc2UgPCAwLgorICAgIGlmIChwcml2LT5zaXplID4gMCAmJiBwcml2LT5vZmZzZXQg PiBwcml2LT5zaXplKSB7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QobV9zcmMsICJVcGRhdGlu ZyBpbnRlcm5hbCBzaXplIGZyb20gJSIgR19HVUlOVDY0X0ZPUk1BVCAiIHRvICUiIEdfR1VJTlQ2 NF9GT1JNQVQsIHByaXYtPnNpemUsIHByaXYtPm9mZnNldCk7CisgICAgICAgIGdzdF9hcHBfc3Jj X3NldF9zaXplKHByaXYtPmFwcHNyYywgcHJpdi0+b2Zmc2V0KTsKKyAgICAgICAgcHJpdi0+c2l6 ZSA9IHByaXYtPm9mZnNldDsKKyAgICB9CiAgICAgR1NUX0JVRkZFUl9PRkZTRVRfRU5EKHByaXYt PmJ1ZmZlci5nZXQoKSkgPSBwcml2LT5vZmZzZXQ7CiAKICAgICBHU1RfT0JKRUNUX1VOTE9DSyht X3NyYyk7Ci0tIAoxLjguMS4yCgo=